rubocop-airbnb 3.0.2 → 5.0.0

data/spec/rubocop/cop/airbnb/default_scope_spec.rb

@@ -1,38 +1,31 @@
-describe RuboCop::Cop::Airbnb::DefaultScope do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::DefaultScope, :config do
   it 'rejects with default_scopes' do
-    source = [
-      '# encoding: UTF-8',
-      'module SurveyQuestion',
-      '  class Host < PhraseBundle',
-      '    db_magic :connection => AIRMISC_MASTER,',
-      '             :slaves => AIRMISC_DB_SLAVES,',
-      '             :force_slave_reads => FORCE_SLAVE_READS',
-      '',
-      '    default_scope where(active: true)',
-      '',
-      '  end',
-      'end',
-    ].join("\n")
-    inspect_source(source)
+    expect_offense(<<~RUBY)
+      # encoding: UTF-8
+      module SurveyQuestion
+        class Host < PhraseBundle
+          db_magic :connection => AIRMISC_MASTER,
+                   :slaves => AIRMISC_DB_SLAVES,
+                   :force_slave_reads => FORCE_SLAVE_READS
+
+          default_scope where(active: true)
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid `default_scope`. [...]
 
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([8])
+        end
+      end
+    RUBY
   end
 
   it 'passes when there is no default_scope' do
-    source = [
-      '# encoding: UTF-8',
-      'module SurveyQuestion',
-      '  class Host < PhraseBundle',
-      '    db_magic :connection => AIRMISC_MASTER,',
-      '             :slaves => AIRMISC_DB_SLAVES,',
-      '             :force_slave_reads => FORCE_SLAVE_READS',
-      '  end',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      # encoding: UTF-8
+      module SurveyQuestion
+        class Host < PhraseBundle
+          db_magic :connection => AIRMISC_MASTER,
+                   :slaves => AIRMISC_DB_SLAVES,
+                   :force_slave_reads => FORCE_SLAVE_READS
+        end
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/factory_attr_references_class_spec.rb

@@ -1,160 +1,120 @@
-describe RuboCop::Cop::Airbnb::FactoryAttrReferencesClass do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::FactoryAttrReferencesClass, :config do
   it 'rejects with `attr_name CONST_NAME` in a factory' do
-    source = [
-      'factory :reservation2 do',
-      '  status Reservation2::STATUS_NEW',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([2])
+    expect_offense(<<~RUBY)
+      factory :reservation2 do
+        status Reservation2::STATUS_NEW
+               ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+      end
+    RUBY
   end
 
   it 'passes with `attr_name { CONST_NAME }` in a factory' do
-    source = [
-      'factory :reservation2 do',
-      '  status { Reservation2::STATUS_NEW }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :reservation2 do
+        status { Reservation2::STATUS_NEW }
+      end
+    RUBY
   end
 
   it 'rejects with `attr_name [CONST_NAME]`' do
-    source = [
-      'factory :reservation2 do',
-      '  statuses [Reservation2::STATUS_NEW]',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([2])
+    expect_offense(<<~RUBY)
+      factory :reservation2 do
+        statuses [Reservation2::STATUS_NEW]
+                  ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+      end
+    RUBY
   end
 
   it 'passes with `attr_name { [CONST_NAME] }`' do
-    source = [
-      'factory :reservation2 do',
-      '  statuses { [Reservation2::STATUS_NEW] }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :reservation2 do
+        statuses { [Reservation2::STATUS_NEW] }
+      end
+    RUBY
   end
 
   it 'rejects with `attr_name [[CONST_NAME]]`' do
-    source = [
-      'factory :reservation2 do',
-      '  statuses [[Reservation2::STATUS_NEW]]',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([2])
+    expect_offense(<<~RUBY)
+      factory :reservation2 do
+        statuses [[Reservation2::STATUS_NEW]]
+                   ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+      end
+    RUBY
   end
 
   it 'passes with `attr_name { [[CONST_NAME]] }`' do
-    source = [
-      'factory :reservation2 do',
-      '  statuses { [[Reservation2::STATUS_NEW]] }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :reservation2 do
+        statuses { [[Reservation2::STATUS_NEW]] }
+      end
+    RUBY
   end
 
   it 'rejects with `attr_name({ ConstName => something })' do
-    source = [
-      'factory :reservation2 do',
-      '  status_names({ Reservation2::STATUS_NEW => "new" })',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([2])
+    expect_offense(<<~RUBY)
+      factory :reservation2 do
+        status_names({ Reservation2::STATUS_NEW => "new" })
+                       ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+      end
+    RUBY
   end
 
   it 'passes with `attr_name { { ConstName => something } }`' do
-    source = [
-      'factory :reservation2 do',
-      '  status_names { { Reservation2::STATUS_NEW => "new" } }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :reservation2 do
+        status_names { { Reservation2::STATUS_NEW => "new" } }
+      end
+    RUBY
   end
 
   it 'rejects with `attr_name ConstName[:symbol]`' do
-    source = [
-      'factory :airlock_rule do',
-      '  stickiness Airlock::STICKINESS[:user]',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([2])
+    expect_offense(<<~RUBY)
+      factory :airlock_rule do
+        stickiness Airlock::STICKINESS[:user]
+                   ^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+      end
+    RUBY
   end
 
   it 'passes with `attr_name { ConstName[:symbol] }`' do
-    source = [
-      'factory :airlock_rule do',
-      '  stickiness { Airlock::STICKINESS[:user] }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :airlock_rule do
+        stickiness { Airlock::STICKINESS[:user] }
+      end
+    RUBY
   end
 
   it 'rejects even if the const is not the first attr' do
-    source = [
-      'factory :reservation2 do',
-      '  trait :accepted do',
-      '    cancel_policy Hosting::CANCEL_FLEXIBLE',
-      '    status Reservation2::STATUS_NEW',
-      '  end',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(2)
-    expect(cop.offenses.map(&:line)).to eq([3, 4])
+    expect_offense(<<~RUBY)
+      factory :reservation2 do
+        trait :accepted do
+          cancel_policy Hosting::CANCEL_FLEXIBLE
+                        ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+          status Reservation2::STATUS_NEW
+                 ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+        end
+      end
+    RUBY
   end
 
   it 'rejects with `attr_name CONST_NAME` in a trait' do
-    source = [
-      'factory :reservation2 do',
-      '  trait :accepted do',
-      '    status Reservation2::STATUS_NEW',
-      '  end',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([3])
+    expect_offense(<<~RUBY)
+      factory :reservation2 do
+        trait :accepted do
+          status Reservation2::STATUS_NEW
+                 ^^^^^^^^^^^^^^^^^^^^^^^^ Instead of attr_name MyClass::MY_CONST, use attr_name { MyClass::MY_CONST }. [...]
+        end
+      end
+    RUBY
   end
 
   it 'passes with `attr_name { CONST_NAME }` in a trait' do
-    source = [
-      'factory :reservation2 do',
-      '  trait :accepted do',
-      '    status { Reservation2::STATUS_NEW }',
-      '  end',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :reservation2 do
+        trait :accepted do
+          status { Reservation2::STATUS_NEW }
+        end
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/factory_class_use_string_spec.rb

@@ -1,26 +1,18 @@
-describe RuboCop::Cop::Airbnb::FactoryClassUseString do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::FactoryClassUseString, :config do
   it 'rejects with :class => Model' do
-    source = [
-      'factory :help_answer, :class => Help::Answer do',
-      '  text { Faker::Company.name }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line)).to eq([1])
+    expect_offense(<<~RUBY)
+      factory :help_answer, :class => Help::Answer do
+                            ^^^^^^^^^^^^^^^^^^^^^^ Instead of :class => MyClass, use :class => "MyClass". [...]
+        text { Faker::Company.name }
+      end
+    RUBY
   end
 
   it 'passes with :class => "Model"' do
-    source = [
-      'factory :help_answer, :class => "Help::Answer" do',
-      '  text { Faker::Company.name }',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      factory :help_answer, :class => "Help::Answer" do
+        text { Faker::Company.name }
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/mass_assignment_accessible_modifier_spec.rb

@@ -1,28 +1,23 @@
-describe RuboCop::Cop::Airbnb::MassAssignmentAccessibleModifier do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::MassAssignmentAccessibleModifier, :config do
   it 'rejects when accessible= is called' do
-    source = [
-      'def some_method',
-      '  user = User.new',
-      '  user.accessible = [:first_name, :last_name]',
-      '  user.update_attributes(:first_name => "Walter", :last_name => "Udoing")',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+    expect_offense(<<~RUBY)
+      def some_method
+        user = User.new
+        user.accessible = [:first_name, :last_name]
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do no override and objects mass assignment restrictions.
+        user.update_attributes(:first_name => "Walter", :last_name => "Udoing")
+      end
+    RUBY
   end
 
   it 'accepts when accessible= is not called' do
-    source = [
-      'def some_method',
-      '  user = User.new',
-      '  user.first_name = "Walter"',
-      '  user.last_name = "Udoing"',
-      '  user.save!',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      def some_method
+        user = User.new
+        user.first_name = "Walter"
+        user.last_name = "Udoing"
+        user.save!
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/module_method_in_wrong_file_spec.rb

@@ -1,6 +1,4 @@
-describe RuboCop::Cop::Airbnb::ModuleMethodInWrongFile do
-  subject(:cop) { described_class.new(config) }
-
+describe RuboCop::Cop::Airbnb::ModuleMethodInWrongFile, :config do
   let(:config) do
     RuboCop::Config.new(
       {
@@ -25,157 +23,120 @@ describe RuboCop::Cop::Airbnb::ModuleMethodInWrongFile do
   end
 
   it 'rejects if module method is in file with non-matching name' do
-    source = [
-      'module Hello',
-      '  module Foo',
-      '    def baz', # error is here if this file is named bar.rb
-      '      42',
-      '    end',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/bar.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_offense(<<~RUBY, file)
+        module Hello
+          module Foo
+            def baz
+            ^^^^^^^ In order for Rails autoloading to be able to find and load this file when someone calls this method, move the method definition to a file that defines the module. This file just uses the module as a namespace for another class or module. Method baz should be defined in hello/foo.rb.
+              42
+            end
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([3])
-    expect(cop.offenses.first.message).to include("Method baz should be defined in hello/foo.rb.")
   end
 
   it 'accepts if module method is in file with matching name' do
-    source = [
-      'module Foo',
-      '  def baz',
-      '    42',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/foo.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_no_offenses(<<~RUBY, file)
+        module Foo
+          def baz
+            42
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses).to be_empty
   end
 
   it 'rejects with "self." static methods and a non-matching name' do
-    source = [
-      'module Foo',
-      '  def self.baz',
-      '    42',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/bar.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_offense(<<~RUBY, file)
+        module Foo
+          def self.baz
+          ^^^^^^^^^^^^ In order for Rails autoloading to be able to find and load this file when someone calls this method, move the method definition to a file that defines the module. This file just uses the module as a namespace for another class or module. Method (self) should be defined in foo.rb.
+            42
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([2])
   end
 
   it 'accepts with "self." static methods and a matching name' do
-    source = [
-      'module Foo',
-      '  def self.baz',
-      '    42',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/foo.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_no_offenses(<<~RUBY, file)
+        module Foo
+          def self.baz
+            42
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses).to be_empty
   end
 
-  it 'rejects with "<<" static methods and a non-matching name' do
-    source = [
-      'module Foo',
-      '  class << self',
-      '    def baz',
-      '      42',
-      '    end',
-      '  end',
-      'end',
-    ].join("\n")
-
+  xit 'rejects with "<<" static methods and a non-matching name' do
     File.open "#{models_dir}/bar.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_offense(<<~RUBY, file)
+        module Foo
+          class << self
+            def baz
+            ^^^^^^^ In order for Rails autoloading to be able to find and load this file when someone calls this method, move the method definition to a file that defines the module. This file just uses the module as a namespace for another class or module. Method baz should be defined in foo.rb.
+              42
+            end
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([3])
   end
 
   it 'accepts with "<<" static methods and a matching name' do
-    source = [
-      'module Foo',
-      '  class << self',
-      '    def baz',
-      '      42',
-      '    end',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/foo.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_no_offenses(<<~RUBY, file)
+        module Foo
+          class << self
+            def baz
+              42
+            end
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses).to be_empty
   end
 
   it 'accepts methods defined in a nested class' do
-    source = [
-      'module Foo',
-      '  class Bar',
-      '    def qux',
-      '    end',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/foo.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_no_offenses(<<~RUBY, file)
+        module Foo
+          class Bar
+            def qux
+            end
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses).to be_empty
   end
 
   it 'accepts methods where the containing class uses an acronym' do
-    source = [
-      'module CSVFoo',
-      '  def baz',
-      '    42',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/csv_foo.rb", "w" do |file|
-      inspect_source(source, file)
+      expect_no_offenses(<<~RUBY, file)
+        module CSVFoo
+          def baz
+            42
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses).to be_empty
   end
 
   it 'ignores rake tasks' do
-    source = [
-      'module Hello',
-      '  def baz', # error is here if this file is named bar.rb
-      '    42',
-      '  end',
-      'end',
-    ].join("\n")
-
     File.open "#{models_dir}/bar.rake", "w" do |file|
-      inspect_source(source, file)
+      expect_no_offenses(<<~RUBY, file)
+        module Hello
+          def baz
+            42
+          end
+        end
+      RUBY
     end
-
-    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/airbnb/no_timeout_spec.rb

@@ -1,30 +1,24 @@
-describe RuboCop::Cop::Airbnb::NoTimeout do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::NoTimeout, :config do
   context 'send' do
     it 'rejects Timeout.timeout' do
-      source = [
-        'def some_method(a)',
-        '  Timeout.timeout(5) do',
-        '    some_other_method(a)',
-        '  end',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-      expect(cop.offenses.size).to eql(1)
-      expect(cop.offenses.first.message).to start_with('Do not use Timeout.timeout')
+      expect_offense(<<~RUBY)
+        def some_method(a)
+          Timeout.timeout(5) do
+          ^^^^^^^^^^^^^^^^^^ Do not use Timeout.timeout. [...]
+            some_other_method(a)
+          end
+        end
+      RUBY
     end
 
     it 'accepts foo.timeout' do
-      source = [
-        'def some_method(a)',
-        '  foo.timeout do',
-        '    some_other_method(a)',
-        '  end',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-      expect(cop.offenses).to be_empty
+      expect_no_offenses(<<~RUBY)
+        def some_method(a)
+          foo.timeout do
+            some_other_method(a)
+          end
+        end
+      RUBY
     end
   end
 end