rubocop-airbnb 2.0.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8e5601cd8ff7b14b19b4bf38c802b4e1d687c322
-  data.tar.gz: fb2fca2fe9589451f8f7a1f35ba79372b0ee5b9a
+SHA256:
+  metadata.gz: 9d15fbaae4390350367ffaf63eb8983bfd6b3f5b20b204a84396b1e52f7f6509
+  data.tar.gz: eb4b2cb7e6b3fb6a347c8c8aa1d3c189a5787d14b0d59db5a5993d4fe400a299
 SHA512:
-  metadata.gz: 2862c58fce4d1f1048df2b58e28978fcb01a943d67339dd93e4175f019cc40757deb378b86e1c2a1c241844652e6d3fff8f75876246e4153bea1da77a1f018cd
-  data.tar.gz: 252c1280c4b61671975ff387b2b3ded22e55747b8125860ff3b37728ac6192716eb0c118db22cb34fc9ae046e5aec3d56ea74174339f1ea521f983b4f13cde0b
+  metadata.gz: bc207a5af59c1eecfeaba405a3a216fae0afa3b54288b35249de115b9f6c1d5036f9ae3f692823ee0a5a3af64718cd7aef072f0e6402c6c4b305b7f6f13bdd5f
+  data.tar.gz: e99bd2c461379d8a13f20a880b2963b0d0241d8affa7028d67cff807573ffe9fe8053bd7d8bbe65174bf0d3021dd9c7a75c4456f9dd1c58e5fe340280554d5d0

data/CHANGELOG.md

@@ -1,3 +1,28 @@
+# 4.0.0
+* Add support for Ruby 3.0
+* Run CI against Ruby 2.7
+* Drop support for Ruby 2.3
+* Update rubocop to 0.93.1
+* Update rubocop-performance to 1.10.2
+* Update rubocop-rails to 2.9.1
+* Update rubocop-rspec to 1.44.1
+* Disable Style/BracesAroundHashParameters
+* Set `DisabledByDefault: true` to disable any new rubocop cops that have not yet been evaluated for this style guide
+
+# 3.0.2
+* Moves `require`s for `rubocop-performance` and `rubocop-rails` to library code for better transitivity.
+
+# 3.0.1
+* Update supported ruby versions in gemspec
+
+# 3.0.0
+* Update to rubocop 0.76
+* Enable Rails/IgnoredSkipActionFilterOption
+* Enable Rails/ReflectionClassName
+* Disable and delete Airbnb/ClassName
+* Enable Layout/IndentFirstParameter
+* Drop support for Ruby 2.2
+
 # 2.0.0
 * Upgrade to rubocop-rspec 1.30.0, use ~> to allow for PATCH version flexibility
 * Upgrade to rubocop 0.58.0, use ~> to allow for PATCH version flexibility

data/README.md

@@ -15,6 +15,11 @@ Just put this in your `Gemfile` it depends on the appropriate version of rubocop
 gem 'rubocop-airbnb'
 ```
 
+Note: If you want to run with Ruby 2.2 you will need to set your version to 2
+```
+gem 'rubocop-airbnb', '~> 2'
+```
+
 ## Usage
 
 You need to tell RuboCop to load the Airbnb extension. There are three
@@ -29,7 +34,7 @@ require:
 ```
 
 Next add the following to `.rubocop.yml`
-or add before `.rubocop_todo.yml` in your existin `inherit_from`
+or add before `.rubocop_todo.yml` in your existing `inherit_from`
 
 ```
 inherit_from:

data/config/default.yml

@@ -24,6 +24,15 @@ AllCops:
     - spec/factories/**/*.rb
     - features/support/factories/**/*.rb
 
+  # While Rubocop has released a bunch of new cops, not all of these cops have been evaluated as
+  # part of this styleguide. To prevent new, unevaluated cops from imposing on this styleguide, we
+  # are marking these new cops as disabled. Note that as a consumer of this styleguide, you can
+  # always override any choices here by setting `Enabled: true` on any cops that you would like to
+  # have be enabled, even if we have explicitly disabled them (or if they are new and we have yet
+  # to evaluate them). For more on this configuration parameter, see
+  # https://github.com/rubocop/rubocop/blob/1e55b1aa5e4c5eaeccad5d61f08b7930ed6bc341/config/default.yml#L89-L101
+  DisabledByDefault: true
+
 inherit_from:
   - './rubocop-airbnb.yml'
   - './rubocop-bundler.yml'

data/config/rubocop-airbnb.yml

@@ -2,11 +2,6 @@
 # They are custom built for use inside Airbnb and address issues that we have experienced in
 # testing and production.
 
-Airbnb/ClassName:
-  Description: Use :class_name => "Model" instead of :class_name => Model.name
-    to avoid a long cascade of autoloading.
-  Enabled: true
-
 Airbnb/ClassOrModuleDeclaredInWrongFile:
   Description: Declare a class or module in the file that matches its namespace and name.
   Enabled: true

data/config/rubocop-gemspec.yml

@@ -7,3 +7,6 @@ Gemspec/RequiredRubyVersion:
   Enabled: false
   Include:
     - '**/*.gemspec'
+
+Gemspec/RubyVersionGlobalsUsage:
+  Enabled: true

data/config/rubocop-layout.yml

@@ -11,13 +11,13 @@ Layout/AccessModifierIndentation:
   - indent
 
 # Supports --auto-correct
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: Align the elements of an array literal if they span more than one line.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#align-multiline-arrays
   Enabled: true
 
 # Supports --auto-correct
-Layout/AlignHash:
+Layout/HashAlignment:
   Description: Align the elements of a hash literal if they span more than one line.
   Enabled: true
   EnforcedHashRocketStyle: key
@@ -30,7 +30,7 @@ Layout/AlignHash:
   - ignore_explicit
 
 # Supports --auto-correct
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: Align the parameters of a method call if they span more than one line.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-double-indent
   Enabled: true
@@ -227,7 +227,7 @@ Layout/FirstMethodParameterLineBreak:
   Enabled: false
 
 # Supports --auto-correct
-Layout/FirstParameterIndentation:
+Layout/FirstArgumentIndentation:
   Description: Checks the indentation of the first parameter in a method call.
   Enabled: true
   EnforcedStyle: consistent
@@ -238,20 +238,19 @@ Layout/FirstParameterIndentation:
   - special_for_inner_method_call_in_parentheses
 
 # Supports --auto-correct
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   Description: Checks the indentation of the first element in an array literal.
   Enabled: true
   EnforcedStyle: consistent
 
 # Supports --auto-correct
-Layout/IndentAssignment:
+Layout/AssignmentIndentation:
   Description: Checks the indentation of the first line of the right-hand-side of a
     multi-line assignment.
   Enabled: true
-  IndentationWidth:
 
 # Supports --auto-correct
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Description: Checks the indentation of the first key in a hash literal.
   Enabled: true
   EnforcedStyle: consistent
@@ -259,7 +258,7 @@ Layout/IndentHash:
   - special_inside_parentheses
   - consistent
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 # Supports --auto-correct
@@ -269,7 +268,7 @@ Layout/IndentationConsistency:
   EnforcedStyle: normal
   SupportedStyles:
   - normal
-  - rails
+  - indented_internal_methods
 
 # Supports --auto-correct
 Layout/IndentationWidth:
@@ -283,7 +282,7 @@ Layout/InitialIndentation:
   Description: Checks the indentation of the first non-blank non-comment line in a file.
   Enabled: true
 
-Layout/LeadingBlankLines:
+Layout/LeadingEmptyLines:
   Enabled: true
 
 # Supports --auto-correct
@@ -344,7 +343,6 @@ Layout/MultilineMethodCallIndentation:
   SupportedStyles:
   - aligned
   - indented
-  IndentationWidth:
 
 Layout/MultilineMethodDefinitionBraceLayout:
   Description: >-
@@ -474,11 +472,6 @@ Layout/SpaceInsideBlockBraces:
   EnforcedStyleForEmptyBraces: no_space
   SpaceBeforeBlockParameters: true
 
-Layout/SpaceInsideParens:
-  Description: 'No spaces after ( or before ).'
-  StyleGuide: '#spaces-braces'
-  Enabled: true
-
 Layout/SpaceInsideArrayLiteralBrackets:
   EnforcedStyle: no_space
   SupportedStyles:
@@ -538,13 +531,13 @@ Layout/SpaceInsideStringInterpolation:
   - no_space
 
 # Supports --auto-correct
-Layout/Tab:
+Layout/IndentationStyle:
   Description: No hard tabs.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation
   Enabled: true
 
 # Supports --auto-correct
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Description: Checks trailing blank lines and final newline.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#newline-eof
   Enabled: true
@@ -558,3 +551,11 @@ Layout/TrailingWhitespace:
   Description: Avoid trailing whitespace.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-trailing-whitespace
   Enabled: true
+
+Layout/FirstParameterIndentation:
+  Enabled: true
+
+# Supports --auto-correct
+Layout/LineLength:
+  Max: 100
+  AllowURI: true

data/config/rubocop-lint.yml

@@ -45,7 +45,7 @@ Lint/DuplicateMethods:
   Description: Check for duplicate methods calls.
   Enabled: true
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Description: Check for duplicate keys in hash literals.
   Enabled: true
 
@@ -68,10 +68,6 @@ Lint/EmptyInterpolation:
 Lint/EmptyWhen:
   Enabled: false
 
-Lint/EndInMethod:
-  Description: END blocks should not be placed inside method definitions.
-  Enabled: false
-
 Lint/EnsureReturn:
   Description: Do not use return in an ensure block.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-return-ensure
@@ -80,6 +76,11 @@ Lint/EnsureReturn:
 Lint/ErbNewArguments:
   Enabled: false
 
+Lint/FlipFlop:
+  Description: Checks for flip flops
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-flip-flops
+  Enabled: false
+
 Lint/FloatOutOfRange:
   Description: Catches floating-point literals too large or small for Ruby to represent.
   Enabled: false
@@ -88,7 +89,7 @@ Lint/FormatParameterMismatch:
   Description: The number of parameters to format/sprint must match the fields.
   Enabled: true
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#dont-hide-exceptions
   Enabled: false
@@ -139,7 +140,10 @@ Lint/MissingCopEnableDirective:
   Description: 'Checks for a `# rubocop:enable` after `# rubocop:disable`'
   Enabled: true
 
-Lint/MultipleCompare:
+Lint/MissingSuper:
+  Enabled: false
+
+Lint/MultipleComparison:
   Enabled: false
 
 Lint/NestedMethodDefinition:
@@ -225,7 +229,7 @@ Lint/ShadowingOuterLocalVariable:
   Enabled: true
 
 # Supports --auto-correct
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Description: Checks for Object#to_s usage in string interpolation.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-to-s
   Enabled: true
@@ -237,20 +241,20 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Enabled: false
 
-Lint/UnneededCopDisableDirective:
+Lint/RedundantCopDisableDirective:
   Description: >-
     Checks for rubocop:disable comments that can be removed.
     Note: this cop is not disabled when disabling all cops. It must be explicitly disabled.
   Enabled: true
 
-Lint/UnneededCopEnableDirective:
+Lint/RedundantCopEnableDirective:
   Description: Checks for rubocop:enable comments that can be removed.
   Enabled: true
 
-Lint/UnneededRequireStatement:
+Lint/RedundantRequireStatement:
   Enabled: false
 
-Lint/UnneededSplatExpansion:
+Lint/RedundantSplatExpansion:
   Enabled: false
 
 Lint/UnreachableCode:
@@ -284,7 +288,7 @@ Lint/UselessAssignment:
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#underscore-unused-vars
   Enabled: true
 
-Lint/UselessComparison:
+Lint/BinaryOperatorWithIdenticalOperands:
   Description: Checks for comparison of something with itself.
   Enabled: true
 

data/config/rubocop-metrics.yml

@@ -21,10 +21,6 @@ Metrics/CyclomaticComplexity:
   Enabled: false
   Max: 6
 
-Metrics/LineLength:
-  Max: 100
-  AllowURI: true
-
 Metrics/MethodLength:
   Enabled: false
 

data/config/rubocop-naming.yml

@@ -55,18 +55,18 @@ Naming/PredicateName:
   - is_
   - has_
   - have_
-  NamePrefixBlacklist:
+  ForbiddenPrefixes:
   - is_
   - has_
   - have_
 
-Naming/UncommunicativeBlockParamName:
+Naming/BlockParameterName:
   Description: >-
               Checks for block parameter names that contain capital letters,
               end in numbers, or do not meet a minimal length.
   Enabled: false
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Description: >-
               Checks for method parameter names that contain capital letters,
               end in numbers, or do not meet a minimal length.
@@ -83,3 +83,6 @@ Naming/VariableName:
 
 Naming/VariableNumber:
   Enabled: false
+
+Naming/RescuedExceptionsVariableName:
+  Enabled: false

data/config/rubocop-performance.yml

@@ -56,11 +56,6 @@ Performance/FlatMap:
 Performance/InefficientHashSearch:
   Enabled: false
 
-# Supports --auto-correct
-Performance/LstripRstrip:
-  Description: Use `strip` instead of `lstrip.rstrip`.
-  Enabled: false
-
 # Supports --auto-correct
 Performance/RangeInclude:
   Description: Use `Range#cover?` instead of `Range#include?`.
@@ -85,11 +80,6 @@ Performance/RedundantMerge:
   Reference: https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code
   Enabled: false
 
-# Supports --auto-correct
-Performance/RedundantSortBy:
-  Description: Use `sort` instead of `sort_by { |x| x }`.
-  Enabled: false
-
 Performance/RegexpMatch:
   Enabled: false
 
@@ -99,12 +89,6 @@ Performance/ReverseEach:
   Reference: https://github.com/JuanitoFatas/fast-ruby#enumerablereverseeach-vs-enumerablereverse_each-code
   Enabled: false
 
-# Supports --auto-correct
-Performance/Sample:
-  Description: Use `sample` instead of `shuffle.first`, `shuffle.last`, and `shuffle[Fixnum]`.
-  Reference: https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code
-  Enabled: false
-
 # Supports --auto-correct
 Performance/Size:
   Description: Use `size` instead of `count` for counting the number of elements in
@@ -133,9 +117,6 @@ Performance/TimesMap:
 Performance/UnfreezeString:
   Enabled: false
 
-Performance/UnneededSort:
-  Enabled: false
-
 Performance/UriDefaultParser:
   Enabled: false
 

data/config/rubocop-rails.yml

@@ -206,3 +206,13 @@ Rails/Validation:
   Enabled: false
   Include:
   - app/models/**/*.rb
+
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: true
+
+Rails/ReflectionClassName:
+  Enabled: true
+
+Rails/RakeEnvironment:
+  Description: Ensures that rake tasks depend on :environment
+  Enabled: false

data/config/rubocop-style.yml

@@ -134,16 +134,6 @@ Style/BlockDelimiters:
     - proc
     - it
 
-# Supports --auto-correct
-Style/BracesAroundHashParameters:
-  Description: Enforce braces style around hash parameters.
-  Enabled: false
-  EnforcedStyle: no_braces
-  SupportedStyles:
-  - braces
-  - no_braces
-  - context_dependent
-
 Style/CaseEquality:
   Description: Avoid explicit use of the case equality operator(===).
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-case-equality
@@ -328,11 +318,6 @@ Style/ExpandPathArguments:
   Description: "Use `expand_path(__dir__)` instead of `expand_path('..', __FILE__)`."
   Enabled: false
 
-Style/FlipFlop:
-  Description: Checks for flip flops
-  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-flip-flops
-  Enabled: false
-
 Style/For:
   Description: Checks use of for or each in multiline loops.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-for-loops
@@ -360,10 +345,11 @@ Style/FrozenStringLiteralComment:
   Description: Add the frozen_string_literal comment to the top of files to help transition
     from Ruby 2.3.0 to Ruby 3.0.
   Enabled: false
-  EnforcedStyle: when_needed
   SupportedStyles:
-  - when_needed
   - always
+  - always_true
+  - never
+  EnforcedStyle: always_true
 
 Style/GlobalVars:
   Description: Do not introduce global variables.
@@ -463,9 +449,6 @@ Style/MethodDefParentheses:
   - require_parentheses
   - require_no_parentheses
 
-Style/MethodMissingSuper:
-  Enabled: false
-
 Style/MissingRespondToMissing:
   Enabled: false
 
@@ -735,6 +718,11 @@ Style/RedundantSelf:
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-self-unless-required
   Enabled: true
 
+# Supports --auto-correct
+Style/RedundantSortBy:
+  Description: Use `sort` instead of `sort_by { |x| x }`.
+  Enabled: false
+
 # Supports --auto-correct
 Style/RegexpLiteral:
   Description: Use / or %r around regular expressions.
@@ -763,6 +751,12 @@ Style/ReturnNil:
 Style/SafeNavigation:
   Enabled: false
 
+# Supports --auto-correct
+Style/Sample:
+  Description: Use `sample` instead of `shuffle.first`, `shuffle.last`, and `shuffle[Fixnum]`.
+  Reference: https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code
+  Enabled: false
+
 # Supports --auto-correct
 Style/SelfAssignment:
   Description: Checks for places where self-assignment shorthand should have been used.
@@ -818,6 +812,21 @@ Style/SpecialGlobalVars:
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-cryptic-perlisms
   Enabled: true
 
+Style/HashEachMethods:
+  Description: Enforce use of each_key and each_value Hash methods.
+  StyleGuide: https://docs.rubocop.org/en/latest/cops_style/#stylehasheachmethods
+  Enabled: false
+
+Style/HashTransformKeys:
+  Description: Enforce use of transform_keys Hash methods. Not suggested for use below ruby 2.5
+  StyleGuide: https://docs.rubocop.org/en/latest/cops_style/#stylehashtransformkeys
+  Enabled: false
+
+Style/HashTransformValues:
+  Description: Enforce use of transform_values Hash methods. Not suggested for use below ruby 2.5
+  StyleGuide: https://docs.rubocop.org/en/latest/cops_style/#stylehashtransformvalues
+  Enabled: false
+
 Style/StabbyLambdaParentheses:
   Description: Check for the usage of parentheses around stabby lambda arguments.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#stabby-lambda-with-args
@@ -856,6 +865,11 @@ Style/StringMethods:
   PreferredMethods:
     intern: to_sym
 
+# Supports --auto-correct
+Style/Strip:
+  Description: Use `strip` instead of `lstrip.rstrip`.
+  Enabled: false
+
 Style/StructInheritance:
   Description: Checks for inheritance from Struct.new.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-extend-struct-new
@@ -922,24 +936,27 @@ Style/UnlessElse:
   Enabled: true
 
 # Supports --auto-correct
-Style/UnneededCapitalW:
+Style/RedundantCapitalW:
   Description: Checks for %W when interpolation is not needed.
   Enabled: false
 
-Style/UnneededCondition:
+Style/RedundantCondition:
   Enabled: false
 
 # Supports --auto-correct
-Style/UnneededInterpolation:
+Style/RedundantInterpolation:
   Description: Checks for strings that are just an interpolated expression.
   Enabled: false
 
 # Supports --auto-correct
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Description: Checks for %q/%Q when single quotes or double quotes would do.
   StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#percent-q
   Enabled: false
 
+Style/RedundantSort:
+  Enabled: false
+
 Style/UnpackFirst:
   Enabled: false
 

data/lib/rubocop/airbnb/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Airbnb
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = '2.0.0'.freeze
+    VERSION = '4.0.0'
   end
 end

data/lib/rubocop/cop/airbnb/continuation_slash.rb

@@ -14,7 +14,7 @@ module RuboCop
         alias on_send enforce_violation
         alias on_if enforce_violation
 
-        Util::ASGN_NODES.each do |type|
+        ::RuboCop::AST::Node::ASSIGNMENTS.each do |type|
           define_method("on_#{type}") do |node|
             enforce_violation(node)
           end

data/lib/rubocop-airbnb.rb

@@ -4,6 +4,9 @@ require 'yaml'
 # Load original rubocop gem
 require 'rubocop'
 
+require 'rubocop-performance'
+require 'rubocop-rails'
+
 require 'rubocop/airbnb'
 require 'rubocop/airbnb/inject'
 require 'rubocop/airbnb/version'

data/rubocop-airbnb.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.license = 'MIT'
   spec.version = RuboCop::Airbnb::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.1'
+  spec.required_ruby_version = '>= 2.4'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
@@ -25,7 +25,9 @@ Gem::Specification.new do |spec|
     'Gemfile',
   ]
 
-  spec.add_dependency('rubocop', '~> 0.58.0')
-  spec.add_dependency('rubocop-rspec', '~> 1.30.0')
+  spec.add_dependency('rubocop', '~> 0.93.1')
+  spec.add_dependency('rubocop-performance', '~> 1.10.2')
+  spec.add_dependency('rubocop-rails', '~> 2.9.1')
+  spec.add_dependency('rubocop-rspec', '~> 1.44.1')
   spec.add_development_dependency('rspec', '~> 3.5')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-airbnb
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Airbnb Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-31 00:00:00.000000000 Z
+date: 2021-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.0
+        version: 0.93.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.0
+        version: 0.93.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.10.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.10.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.9.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.44.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.44.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -85,7 +113,6 @@ files:
 - lib/rubocop/airbnb/inject.rb
 - lib/rubocop/airbnb/rails_autoloading.rb
 - lib/rubocop/airbnb/version.rb
-- lib/rubocop/cop/airbnb/class_name.rb
 - lib/rubocop/cop/airbnb/class_or_module_declared_in_wrong_file.rb
 - lib/rubocop/cop/airbnb/const_assigned_in_wrong_file.rb
 - lib/rubocop/cop/airbnb/continuation_slash.rb
@@ -105,7 +132,6 @@ files:
 - lib/rubocop/cop/airbnb/spec_constant_assignment.rb
 - lib/rubocop/cop/airbnb/unsafe_yaml_marshal.rb
 - rubocop-airbnb.gemspec
-- spec/rubocop/cop/airbnb/class_name_spec.rb
 - spec/rubocop/cop/airbnb/class_or_module_declared_in_wrong_file_spec.rb
 - spec/rubocop/cop/airbnb/const_assigned_in_wrong_file_spec.rb
 - spec/rubocop/cop/airbnb/continuation_slash_spec.rb
@@ -137,15 +163,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Custom code style checking for Airbnb.

data/lib/rubocop/cop/airbnb/class_name.rb

@@ -1,47 +0,0 @@
-module RuboCop
-  module Cop
-    module Airbnb
-      # Cop to prevent cross-model references, which result in a cascade of autoloads. E.g.,
-      # belongs_to :user, :class_name => User.name
-      class ClassName < Cop
-        MSG = 'Use "Model" instead of Model.name at class scope to avoid cross-model references. ' \
-          'They cause a long cascade of autoloading, slowing down app startup and slowing down ' \
-          'reloading of zeus after changing a model.'.freeze
-
-        # Is this a has_many, has_one, or belongs_to with a :class_name arg? Make sure the
-        # class name is a hardcoded string. If not, add an offense and return true.
-        def on_send(node)
-          association_statement =
-            node.command?(:has_many) ||
-            node.command?(:has_one) ||
-            node.command?(:belongs_to)
-
-          return unless association_statement
-
-          class_pair = class_name_node(node)
-
-          if class_pair && !string_class_name?(class_pair)
-            add_offense(class_pair)
-          end
-        end
-
-        private
-
-        # Return the descendant node that is a hash pair (:key => value) whose key
-        # is :class_name.
-        def class_name_node(node)
-          node.descendants.detect do |e|
-            e.is_a?(Parser::AST::Node) &&
-              e.pair_type? &&
-              e.children[0].children[0] == :class_name
-          end
-        end
-
-        # Given a hash pair :class_name => value, is the value a hardcoded string?
-        def string_class_name?(class_pair)
-          class_pair.children[1].str_type?
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/cop/airbnb/class_name_spec.rb

@@ -1,78 +0,0 @@
-describe RuboCop::Cop::Airbnb::ClassName do
-  subject(:cop) { described_class.new }
-
-  describe "belongs_to" do
-    it 'rejects with Model.name' do
-      source = [
-        'class Coupon',
-        '  belongs_to :user, :class_name => User.name',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([2])
-    end
-
-    it 'passes with "Model"' do
-      source = [
-        'class Coupon',
-        '  belongs_to :user, :class_name => "User"',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  describe "has_many" do
-    it 'rejects with Model.name' do
-      source = [
-        'class Coupon',
-        '  has_many :reservations, :class_name => Reservation2.name',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line)).to eq([2])
-    end
-
-    it 'passes with "Model"' do
-      source = [
-        'class Coupon',
-        '  has_many :reservations, :class_name => "Reservation2"',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  describe "has_one" do
-    it 'rejects with Model.name' do
-      source = [
-        'class Coupon',
-        '  has_one :loss, :class_name => Payments::Loss.name',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line)).to eq([2])
-    end
-
-    it 'passes with "Model"' do
-      source = [
-        'class Coupon',
-        '  has_one :loss, :class_name => "Payments::Loss"',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-
-      expect(cop.offenses).to be_empty
-    end
-  end
-end