rubion 0.3.12 → 0.3.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7dc1bfbae3334e5454a9cc24e15284f6ea266e6ae39c0d897e834cdbd4a060b2
-  data.tar.gz: 99397bc977a084f856a850dbc32401a72d302ce3f55243b4a09f9660224168fd
+  metadata.gz: 7e44746a0b8ff53ccdc236e43a182d060ace64e38790450f10c04fb4d09550ed
+  data.tar.gz: 9c05871fdf57aef1e1e2ff82bc2c58015eb18865c999afc3ae13b46ccb0c2341
 SHA512:
-  metadata.gz: 78c7ccc9ac63d82a38d704d47f626e3ec1ba08976d10e3efbfe6ef35f5fb15d5424c61219d00034d11cee5e25f77b5a7b971406400e6744e5e005e9e9e9cf87a
-  data.tar.gz: ebda62b7ec502a9e834a41b45953996363289b5c63f3ce3b6da380beaf96dfd47f5476e56f65babca314c3cd01624a5601cf607c4e1bd4884ef704d1be270e99
+  metadata.gz: 3bee4acf0c1d91670bd811eb2c01c1e4d2192616ba3ce49a7b27f1e1577b8daed57fb35bb0c9a7f77dce0afe6f0698cadcc64ce2145e1ca38bc583afbadfa5ba
+  data.tar.gz: f9092694ecd11f85b03fecd7e3021ae6d0e3904022c7384d0c161f35aaf703887b4162a35162fd39c2af45f912221e981c1c0d91538d979b7cceaf08543794cc

data/lib/rubion/scanner.rb

@@ -102,30 +102,37 @@ module Rubion
       stdout, stderr, status = Open3.capture3('bundle-audit check 2>&1', chdir: @project_path)
 
       # bundle-audit returns exit code 1 when vulnerabilities are found, 0 when none found
-      # Always parse if there's output (vulnerabilities found) or if it succeeded (no vulnerabilities)
-      if stdout.include?('vulnerabilities found') || stdout.include?('Name:') || status.success?
+      # Exit code 1 is expected when vulnerabilities exist, so we still parse the output
+      # Exit code 0 means no vulnerabilities found
+      # Any other exit code or error means the command failed
+      if status.exitstatus == 1 || status.success?
+        # Exit code 1 (vulnerabilities found) or 0 (no vulnerabilities) - parse output
         parse_bundler_audit_output(stdout)
+      elsif !stdout.empty? && (stdout.include?('vulnerabilities found') || stdout.include?('Name:'))
+        # Try to parse if output looks valid even if exit code is unexpected
+        parse_bundler_audit_output(stdout)
+      elsif status.exitstatus.nil?
+        # Command not found or failed to execute
+        raise "bundle-audit command failed or is not installed. Error: #{stderr}"
       else
-        # No vulnerabilities found or bundler-audit not available
-        @result.gem_vulnerabilities = []
+        # Unexpected exit code
+        raise "bundle-audit failed with exit code #{status.exitstatus}. Output: #{stdout}#{stderr.empty? ? '' : "\nError: #{stderr}"}"
       end
-    rescue StandardError => e
-      puts "  ⚠️  Could not run bundle-audit (#{e.message}). Skipping gem vulnerability check."
-      @result.gem_vulnerabilities = []
     end
 
     def check_gem_versions
       stdout, stderr, status = Open3.capture3('bundle outdated --parseable', chdir: @project_path)
 
-      if status.success? || !stdout.empty?
+      if status.success?
+        # Command succeeded - parse output (may be empty if all gems are up to date)
         parse_bundle_outdated_output(stdout)
+      elsif status.exitstatus.nil?
+        # Command not found or failed to execute
+        raise "bundle outdated command failed or is not available. Error: #{stderr}"
       else
-        # No outdated gems found
-        @result.gem_versions = []
+        # Command failed with non-zero exit code
+        raise "bundle outdated failed with exit code #{status.exitstatus}. Output: #{stdout}#{stderr.empty? ? '' : "\nError: #{stderr}"}"
       end
-    rescue StandardError => e
-      puts "  ⚠️  Could not run bundle outdated (#{e.message}). Skipping gem version check."
-      @result.gem_versions = []
     end
 
     def check_npm_vulnerabilities
@@ -134,15 +141,20 @@ module Rubion
       command = "#{@package_manager} audit --json 2>&1"
       stdout, stderr, status = Open3.capture3(command, chdir: @project_path)
 
+      if status.exitstatus.nil?
+        # Command not found or failed to execute
+        raise "#{@package_manager} audit command failed or is not available. Error: #{stderr}"
+      elsif !status.success? && status.exitstatus != 1
+        # Exit code 1 is expected when vulnerabilities are found, other non-zero codes are errors
+        raise "#{@package_manager} audit failed with exit code #{status.exitstatus}. Output: #{stdout}#{stderr.empty? ? '' : "\nError: #{stderr}"}"
+      end
+
       begin
         data = JSON.parse(stdout)
         parse_npm_audit_output(data)
-      rescue JSON::ParserError
-        @result.package_vulnerabilities = []
+      rescue JSON::ParserError => e
+        raise "Failed to parse #{@package_manager} audit JSON output: #{e.message}. Raw output: #{stdout}"
       end
-    rescue StandardError => e
-      puts "  ⚠️  Could not run #{@package_manager} audit (#{e.message}). Skipping package vulnerability check."
-      @result.package_vulnerabilities = []
     end
 
     def check_npm_versions
@@ -160,16 +172,20 @@ module Rubion
       command = 'npm outdated --json 2>&1'
       stdout, stderr, status = Open3.capture3(command, chdir: @project_path)
 
+      if status.exitstatus.nil?
+        # Command not found or failed to execute
+        raise "npm outdated command failed or is not available. Error: #{stderr}"
+      elsif !status.success? && status.exitstatus != 1
+        # Exit code 1 is expected when packages are outdated, other non-zero codes are errors
+        raise "npm outdated failed with exit code #{status.exitstatus}. Output: #{stdout}#{stderr.empty? ? '' : "\nError: #{stderr}"}"
+      end
+
       begin
         data = JSON.parse(stdout) unless stdout.empty?
         parse_npm_outdated_output(data || {})
       rescue JSON::ParserError => e
-        puts "  ⚠️  Error parsing npm outdated JSON output: #{e.message}"
-        @result.package_versions = []
+        raise "Failed to parse npm outdated JSON output: #{e.message}. Raw output: #{stdout}"
       end
-    rescue StandardError => e
-      puts "  ⚠️  Could not run npm outdated (#{e.message}). Skipping package version check."
-      @result.package_versions = []
     end
 
     def check_yarn_outdated
@@ -177,15 +193,19 @@ module Rubion
       command = 'yarn outdated 2>&1'
       stdout, stderr, status = Open3.capture3(command, chdir: @project_path)
 
+      if status.exitstatus.nil?
+        # Command not found or failed to execute
+        raise "yarn outdated command failed or is not available. Error: #{stderr}"
+      elsif !status.success? && status.exitstatus != 1
+        # Exit code 1 is expected when packages are outdated, other non-zero codes are errors
+        raise "yarn outdated failed with exit code #{status.exitstatus}. Output: #{stdout}#{stderr.empty? ? '' : "\nError: #{stderr}"}"
+      end
+
       begin
         parse_yarn_outdated_output(stdout)
       rescue StandardError => e
-        puts "  ⚠️  Could not parse yarn outdated output (#{e.message}). Skipping package version check."
-        @result.package_versions = []
+        raise "Failed to parse yarn outdated output: #{e.message}. Raw output: #{stdout}"
       end
-    rescue StandardError => e
-      puts "  ⚠️  Could not run yarn outdated (#{e.message}). Skipping package version check."
-      @result.package_versions = []
     end
 
     # Parsers
@@ -332,9 +352,6 @@ module Rubion
       end
 
       @result.package_vulnerabilities = vulnerabilities
-    rescue StandardError => e
-      puts "  ⚠️  Error parsing npm audit data: #{e.message}"
-      @result.package_vulnerabilities = []
     end
 
     def parse_npm_outdated_output(data)
@@ -416,9 +433,6 @@ module Rubion
       end
 
       @result.package_versions = versions
-    rescue StandardError => e
-      puts "  ⚠️  Error parsing npm outdated data: #{e.message}"
-      @result.package_versions = []
     end
 
     def parse_yarn_outdated_output(output)

data/lib/rubion/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Rubion
-  VERSION = "0.3.12"
+  VERSION = "0.3.13"
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubion
 version: !ruby/object:Gem::Version
-  version: 0.3.12
+  version: 0.3.13
 platform: ruby
 authors:
 - bipashant
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-11-15 00:00:00.000000000 Z
+date: 2025-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: terminal-table