ruber 0.0.9 → 0.0.10

data/plugins/syntax_checker/ui/config_widget.rb

@@ -0,0 +1,61 @@
+=begin
+** Form generated from reading ui file 'config_widget.ui'
+**
+** Created: ven lug 1 15:40:38 2011
+**      by: Qt User Interface Compiler version 4.7.3
+**
+** WARNING! All changes made in this file will be lost when recompiling ui file!
+=end
+
+class Ui_SyntaxCheckerConfigWidget
+    attr_reader :horizontalLayout
+    attr_reader :label
+    attr_reader :_syntax_checker__time_interval
+
+    def setupUi(syntaxCheckerConfigWidget)
+    if syntaxCheckerConfigWidget.objectName.nil?
+        syntaxCheckerConfigWidget.objectName = "syntaxCheckerConfigWidget"
+    end
+    syntaxCheckerConfigWidget.resize(400, 40)
+    @horizontalLayout = Qt::HBoxLayout.new(syntaxCheckerConfigWidget)
+    @horizontalLayout.objectName = "horizontalLayout"
+    @label = Qt::Label.new(syntaxCheckerConfigWidget)
+    @label.objectName = "label"
+
+    @horizontalLayout.addWidget(@label)
+
+    @_syntax_checker__time_interval = Qt::SpinBox.new(syntaxCheckerConfigWidget)
+    @_syntax_checker__time_interval.objectName = "_syntax_checker__time_interval"
+    @_syntax_checker__time_interval.maximum = 999
+    @_syntax_checker__time_interval.value = 1
+
+    @horizontalLayout.addWidget(@_syntax_checker__time_interval)
+
+    @label.buddy = @_syntax_checker__time_interval
+
+    retranslateUi(syntaxCheckerConfigWidget)
+
+    Qt::MetaObject.connectSlotsByName(syntaxCheckerConfigWidget)
+    end # setupUi
+
+    def setup_ui(syntaxCheckerConfigWidget)
+        setupUi(syntaxCheckerConfigWidget)
+    end
+
+    def retranslateUi(syntaxCheckerConfigWidget)
+    syntaxCheckerConfigWidget.windowTitle = Qt::Application.translate("SyntaxCheckerConfigWidget", "Syntax Checker", nil, Qt::Application::UnicodeUTF8)
+    @label.text = Qt::Application.translate("SyntaxCheckerConfigWidget", "&Inactivity time before checking syntax (s)", nil, Qt::Application::UnicodeUTF8)
+    @_syntax_checker__time_interval.specialValueText = Qt::Application.translate("SyntaxCheckerConfigWidget", "Disable timed syntax check", nil, Qt::Application::UnicodeUTF8)
+    end # retranslateUi
+
+    def retranslate_ui(syntaxCheckerConfigWidget)
+        retranslateUi(syntaxCheckerConfigWidget)
+    end
+
+end
+
+module Ui
+    class SyntaxCheckerConfigWidget < Ui_SyntaxCheckerConfigWidget
+    end
+end  # module Ui
+

data/plugins/syntax_checker/ui/config_widget.ui

@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>SyntaxCheckerConfigWidget</class>
+ <widget class="QWidget" name="SyntaxCheckerConfigWidget">
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>400</width>
+    <height>40</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>Syntax Checker</string>
+  </property>
+  <layout class="QHBoxLayout" name="horizontalLayout">
+   <item>
+    <widget class="QLabel" name="label">
+     <property name="text">
+      <string>&amp;Inactivity time before checking syntax (s)</string>
+     </property>
+     <property name="buddy">
+      <cstring>_syntax_checker__time_interval</cstring>
+     </property>
+    </widget>
+   </item>
+   <item>
+    <widget class="QSpinBox" name="_syntax_checker__time_interval">
+     <property name="specialValueText">
+      <string>Disable timed syntax check</string>
+     </property>
+     <property name="maximum">
+      <number>999</number>
+     </property>
+     <property name="value">
+      <number>1</number>
+     </property>
+    </widget>
+   </item>
+  </layout>
+ </widget>
+ <resources/>
+ <connections/>
+</ui>

data/plugins/yaml_syntax_checker/plugin.yaml

@@ -0,0 +1,11 @@
+name: yaml_syntax_checker
+version: 0.0.1
+about:
+ authors: [Stefano Crocco, stefano.crocco@alice.it]
+ license: :gpl
+ description: Syntax checker for YAML documents. Requires the syntax checker plugin
+ icon: tools-check-spelling
+ bug_address: http://github.com/stcrocco/ruber/issues
+class: Ruber::YAMLSyntaxChecker::Plugin
+require: yaml_syntax_checker
+deps: syntax_checker

data/plugins/yaml_syntax_checker/yaml_syntax_checker.rb

@@ -0,0 +1,62 @@
+=begin 
+    Copyright (C) 2010, 2011 by Stefano Crocco   
+    stefano.crocco@alice.it   
+  
+    This program is free software; you can redistribute it andor modify  
+    it under the terms of the GNU General Public License as published by  
+    the Free Software Foundation; either version 2 of the License, or     
+    (at your option) any later version.                                   
+  
+    This program is distributed in the hope that it will be useful,       
+    but WITHOUT ANY WARRANTY; without even the implied warranty of        
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         
+    GNU General Public License for more details.                          
+  
+    You should have received a copy of the GNU General Public License     
+    along with this program; if not, write to the                         
+    Free Software Foundation, Inc.,                                       
+    59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             
+=end
+
+require 'yaml'
+
+module Ruber
+  
+  module YAMLSyntaxChecker
+    
+    SyntaxError = Struct.new :line, :column, :message, :formatted_message
+    
+    class Plugin < Ruber::Plugin
+      
+      def initialize psf
+        super
+        Ruber[:syntax_checker].register_syntax_checker YAMLSyntaxChecker::Checker,
+            [], ['*.yaml']
+      end
+      
+      def unload
+        Ruber[:syntax_checker].remove_syntax_checker YAMLSyntaxChecker::Checker
+      end
+      
+    end
+    
+    class Checker
+      
+      def check_syntax str, format
+        begin 
+          YAML.parse str
+          nil
+        rescue ArgumentError => e
+          match = e.message.match %r{syntax error on line\s+(-?\d+),\s+col\s+(-?\d+)}i
+          return [] unless match
+          line = [match[1].to_i, 0].max
+          col = [match[2].to_i, 0].max
+          [SyntaxError.new(line, col, 'Syntax error', 'Syntax error')]
+        end
+      end
+      
+    end
+    
+  end
+  
+end

data/spec/auto_end_spec.rb

@@ -5,7 +5,114 @@ require 'tempfile'
 
 module InsertionChecker
   
-  def it_should_insert_end cond, text, initial_text, exp_text, cursor_pos = [2, 0]
+  def it_checks_for_syntax_errors_when cond, inserted_text, existing_text = ''
+    lines = existing_text.split "\n"
+    insert_pos = lines.find_and_map do |l|
+      if l.include? '%'
+        [lines.index(l), l.index('%')]
+      end
+    end
+    insert_pos ||= [existing_text.each_line.count, 0]
+    insert_pos = KTextEditor::Cursor.new *insert_pos
+
+    context "when #{cond}" do
+      
+      context 'and the document is active' do
+        
+        before do
+          @doc.activate
+          @view = @doc.create_view
+          @doc.text = ''
+          flexmock(@doc).should_receive(:active_view).and_return @view
+          @doc.block_signals true
+          @doc.text= existing_text.sub '%', ''
+          @doc.block_signals false
+          #avoid messing up the text with indentation
+          flexmock(@view).should_receive(:execute_action).with('tools_align').by_default
+        end
+        
+        it 'checks the syntax of the document' do
+          flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).with(:format => false, :update => false).once.and_return :errors => []
+          @doc.insert_text insert_pos, inserted_text
+        end
+        
+      end
+      
+      context 'and the active view is not associated with the document' do
+        
+        before do
+          @doc.deactivate
+          flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).never
+        end
+        
+        it 'does nothing' do
+          flexmock(@doc).should_receive(:active_view).and_return nil
+          old_text = @doc.text
+          @doc.insert_text insert_pos, inserted_text
+        end
+        
+      end
+      
+    end
+    
+  end
+  
+  def it_doesnt_check_for_syntax_errors_when cond, line, existing_text = ''
+    
+    lines = existing_text.split "\n"
+    insert_pos = lines.find_and_map do |l|
+      if l.include? '%'
+        [lines.index(l), l.index('%')]
+      end
+    end
+    insert_pos ||= [existing_text.each_line.count, 0]
+    insert_pos = KTextEditor::Cursor.new *insert_pos
+    
+    context "when #{cond}" do
+      
+      context "and the view is active" do
+        
+        before do
+          @doc.activate
+          @view = @doc.create_view
+          @doc.text = ''
+          flexmock(@doc).should_receive(:active_view).and_return @view
+          @doc.block_signals true
+          @doc.text= existing_text.sub '%', ''
+          @doc.block_signals false
+          #avoid messing up the text with indentation
+          flexmock(@view).should_receive(:execute_action).with('tools_align').by_default
+        end
+        
+        it 'doesn\'t check the syntax of the document' do
+          flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).never
+          @doc.insert_text insert_pos, line
+        end
+        
+      end
+      
+      context 'and the active view is not associated with the document' do
+        
+        before do
+          @doc.deactivate
+          flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).never
+        end
+        
+        it 'does nothing' do
+          flexmock(@doc).should_receive(:active_view).and_return nil
+          old_text = @doc.text
+          @doc.insert_text insert_pos, line
+        end
+        
+      end
+
+      
+    end
+
+    
+  end
+  
+  def it_should_insert_end cond, text, initial_text, exp_text, error_type, cursor_pos = [2, 0],  error_message = ''
     lines = initial_text.split "\n"
     insert_pos = lines.find_and_map do |l|
       if l.include? '%'
@@ -21,12 +128,15 @@ module InsertionChecker
         
         before do
           @view = @doc.create_view
+          @doc.text = ''
           flexmock(@doc).should_receive(:active_view).and_return @view
           @doc.block_signals true
           @doc.text= initial_text.sub '%', ''
           @doc.block_signals false
           #avoid messing up the text with indentation
           flexmock(@view).should_receive(:execute_action).with('tools_align').by_default
+          error = {:errors => [OpenStruct.new(:error_type => error_type, :error_message => error_message)]}
+          flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).with(:format => false, :update => false).once.and_return error
         end
         
         it "inserts an an empty line followed by and end keyword" do
@@ -49,6 +159,10 @@ module InsertionChecker
     
       context 'and the active view is not associated with the document' do
         
+        before do
+          flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).never
+        end
+        
         it 'does nothing' do
           flexmock(@doc).should_receive(:active_view).and_return nil
           old_text = @doc.text
@@ -68,6 +182,14 @@ describe Ruber::AutoEnd::Extension do
   
   extend InsertionChecker
   
+  before :all do
+    Ruber[:components].load_plugin 'plugins/autosave'
+    Ruber[:components].load_plugin 'plugins/ruby_runner'
+    Ruber[:components].load_plugin 'plugins/ruby_development'
+    Ruber[:components].load_plugin 'plugins/syntax_checker'
+    Ruber[:components].load_plugin 'plugins/ruby_syntax_checker'
+  end
+  
   before do
     Ruber[:components].load_plugin 'plugins/auto_end/'
     @file = Tempfile.new ['auto_end_test', '.rb']
@@ -80,6 +202,14 @@ describe Ruber::AutoEnd::Extension do
     @file.close true
   end
   
+  after :all do
+    Ruber[:components].unload_plugin :ruby_syntax_checker
+    Ruber[:components].unload_plugin :syntax_checker
+    Ruber[:components].unload_plugin :ruby_development
+    Ruber[:components].unload_plugin :autosave
+    Ruber[:components].unload_plugin :ruby_runner
+  end
+  
   it 'includes the Extension module' do
     Ruber::AutoEnd::Extension.should include(Ruber::Extension)
   end
@@ -110,195 +240,114 @@ describe Ruber::AutoEnd::Extension do
   
   context 'when a piece of text ending with a newline is inserted' do
     
-    context 'and the last line contains a module' do
-      
-      it_should_insert_end "if the module is at the beginning of the line and followed by spaces, an identifier, possible spaces and end of line", "module xY_12a\n", "module X\n%\nend", "module X\nmodule xY_12a\n\nend\nend"
-      
-      it_should_insert_end "if the module is at the beginning of the line, preceded only by spaces and followed by spaces, an identifier, possible spaces and end of line", "  module xY_12a \n", "module X\n%\nend", "module X\n  module xY_12a \n\nend\nend"
-      
-      it 'does not insert an end keyword if the identifier is followed by anything but spaces or other identifers separated by ::' do
-        @doc.block_signals true
-        @doc.text = "module X\n\nend"
-        @doc.block_signals false
-        @doc.insert_text KTextEditor::Cursor.new(1,0), 'module Y a.b'
-        @doc.text.should == "module X\nmodule Y a.b\nend"
-      end
-      
-      it_should_insert_end "if the module is at the beginning of the line and followed by spaces, a sequence of identifiers separated by ::, possible spaces and end of line", "module xY_12a::Ac::By\n", "module X\n%\nend", "module X\nmodule xY_12a::Ac::By\n\nend\nend"
-
-    end
+    it_checks_for_syntax_errors_when 'the line contains the word "module"', "abc module xyz\n"
     
-    context 'and the last line contains a class' do
-      
-      it_should_insert_end "if the class is at the beginning of the line and followed by spaces, an identifier, possible spaces and end of line", "class xY_12a\n", "module X\n%\nend", "module X\nclass xY_12a\n\nend\nend"
-      
-      it_should_insert_end "if the class is at the beginning of the line and followed by spaces, an identifier, a <, another identifier, possible spaces and end of line", "class xY_12a < Ba6_1\n", "module X\n%\nend", "module X\nclass xY_12a < Ba6_1\n\nend\nend"
-      
-      it_should_insert_end "if the class is at the beginning of the line and followed by spaces, an identifier, a <<, another identifier, possible spaces and end of line", "class xY_12a << Ba6_1\n", "module X\n%\nend", "module X\nclass xY_12a << Ba6_1\n\nend\nend"
-      
-      it_should_insert_end "in all the previous cases if there are more than one identifier separated by :: instead of a single identifier", "class A::B < C::D\n", "module X\n%\nend", "module X\nclass A::B < C::D\n\nend\nend"
-      
-    end
+    it_checks_for_syntax_errors_when 'the line contains the word "class"', "abc class xyz\n"
     
-    context "and the last line contains a def" do
-      
-      it_should_insert_end "if the def is at the beginning of the line", "def xyz a, b\n", "class X\n%\nend", "class X\ndef xyz a, b\n\nend\nend"
-      
-      it_should_insert_end 'if the def is preceded only by spaces', "  def xyz a, b\n", "class X\n%\nend", "class X\n  def xyz a, b\n\nend\nend"
-
-    end
+    it_checks_for_syntax_errors_when 'the line contains the word "if" preceded only by whitespaces', "   if abc\n"
     
-    context "and the last line contains an if" do
-      
-      it_should_insert_end "if the if is at the beginning of the line", "if kkk\n", "class X\n%\nend", "class X\nif kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the if is preceded only by whitespaces", "  if kkk\n", "class X\n%\nend", "class X\n  if kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end 'if the if is preceded by an =', "x =if kkk\n",
-          "class X\n%\nend", "class X\nx =if kkk\n\nend\nend"
-      
-      it_should_insert_end 'if the if is preceded by an = followed by spaces', "x = if kkk\n", "class X\n%\nend", "class X\nx = if kkk\n\nend\nend"
-      
-    end
+    it_checks_for_syntax_errors_when 'the line contains the word "if" preceded by an equal sign whitespaces', "a = if abc\n"
     
-    context "and the last line contains a for followed by an identifier, and in and some other characters" do
-      
-      it_should_insert_end "if the for is at the beginning of the line", "for kkk in abc\n", "class X\n%\nend", "class X\nfor kkk in abc\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the for is preceded only by whitespaces", "  for kkk in abc\n", "class X\n%\nend", "class X\n  for kkk in abc\n\nend\nend", [2, 0]
-      
-      it_should_insert_end 'if the for is preceded by an =', "x =for kkk in abc\n",
-          "class X\n%\nend", "class X\nx =for kkk in abc\n\nend\nend"
-      
-      it_should_insert_end 'if the for is preceded by an = followed by spaces', "x = for kkk in abc\n", "class X\n%\nend", "class X\nx = for kkk in abc\n\nend\nend"
-      
-    end
-
-    context "and the last line contains an unless" do
-      
-      it_should_insert_end "if the unless is at the beginning of the line", "unless kkk\n", "class X\n%\nend", "class X\nunless kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the unless is preceded only by whitespaces", "  unless kkk\n", "class X\n%\nend", "class X\n  unless kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end 'if the unless is preceded by an =', "x =unless kkk\n",
-          "class X\n%\nend", "class X\nx =unless kkk\n\nend\nend"
-      
-      it_should_insert_end 'if the unless is preceded by an = followed by spaces', "x = unless kkk\n", "class X\n%\nend", "class X\nx = unless kkk\n\nend\nend"
-      
-    end
+    it_doesnt_check_for_syntax_errors_when 'the line contains the word "if" preceded by anything other than an equal sign and/or spaces', "abc if xyz\n"
     
-    context "and the last line contains a while" do
-      
-      it_should_insert_end "if the while is at the beginning of the line", "while kkk\n", "class X\n%\nend", "class X\nwhile kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the while is preceded only by whitespaces", "  while kkk\n", "class X\n%\nend", "class X\n  while kkk\n\nend\nend", [2, 0]
-      
-    end
+    it_checks_for_syntax_errors_when 'the line contains the word "unless" at the beginning of the line, maybe preceded only by spaces', "   unless xyz\n"
     
-    context "and the last line contains a until" do
-      
-      it_should_insert_end "if the until is at the beginning of the line", "until kkk\n", "class X\n%\nend", "class X\nuntil kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the until is preceded only by whitespaces", "  until kkk\n", "class X\n%\nend", "class X\n  until kkk\n\nend\nend", [2, 0]
-      
-    end
+    it_checks_for_syntax_errors_when 'the line contains the word "unless" preceded by an equal sign and maybe by spaces', " abc =  unless xyz\n"
     
-    context "and the line contains a do" do
-      
-      it_should_insert_end "if the do is at the end of the line", "x.each do\n", "def y x\n%\nend", "def y x\nx.each do\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the do is only followed by whitespaces", "  x.each do\n", "def y x\n%\nend", "def y x\n  x.each do\n\nend\nend", [2, 0]
-      
-      it_should_insert_end "if the do is followed by spaces and a pipe char", "  x.each do |a|\n", "def y x\n%\nend", "def y x\n  x.each do |a|\n\nend\nend", [2, 0]
-      
-      it 'does nothing if the first character of the line is a #' do
-        @doc.block_signals true
-        @doc.text = "def x\n\nend"
-        @doc.block_signals false
-        @doc.insert_text KTextEditor::Cursor.new(1,0), "# a.each do\n"
-        @doc.text.should == "def x\n# a.each do\n\nend"
-      end
-      
-      it 'does nothing if the line starts with spaces followed by a #' do
-        @doc.block_signals true
-        @doc.text = "def x\n\nend"
-        @doc.block_signals false
-        @doc.insert_text KTextEditor::Cursor.new(1,0), " # a.each do\n"
-        @doc.text.should == "def x\n # a.each do\n\nend"
-      end
-      
-    end
+    it_doesnt_check_for_syntax_errors_when 'the line contains the "unless" word, but not at the beginning of line or preceded by an equal sign', "  abc unless xyz"
     
-    context "and the last line contains a begin" do
+    it_checks_for_syntax_errors_when 'the line contains the word "do" followed by optional spaces the end of line', "abc do\n"
+        
+    it_checks_for_syntax_errors_when 'the line contains the word "do" followed by optional spaces and the pipe character', "abc do |xyz| \n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains "do" but not as a standalone word', "abcdo\n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the word do but it is followed by something other than the end of line or a pipe character', "abc do xyz"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "def" at the begining of line (optionally preceded by spaces) and followed by a space', "  def \n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the word "def" but not at the beginning of the line (optionally preceded by spaces)', "abc def \n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the string "def" but not followed by spaces', " defx \n"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "case" at the beginning of the line, maybe preceded only by spaces', "   case xyz\n"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "case" preceded by an equal sign and maybe by spaces', " abc =  case xyz\n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the "case" word, but not at the beginning of line or preceded by an equal sign', "  abc case xyz"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "while" at the beginning of the line, maybe preceded only by spaces', "   while xyz\n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the "while" word, but not at the beginning of line or preceded by an equal sign', "  abc while xyz"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "until" at the beginning of the line, maybe preceded only by spaces', "   until xyz\n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the "until" word, but not at the beginning of line or preceded by an equal sign', "  abc until xyz"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "for" at the beginning of the line, maybe preceded only by spaces', "   for xyz\n"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "for" preceded by an equal sign and maybe by spaces', " abc =  for xyz\n"
+    
+    it_doesnt_check_for_syntax_errors_when 'the line contains the "for" word, but not at the beginning of line or preceded by an equal sign', "  abc for xyz"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "begin" at the beginning of the line, maybe preceded by spaces', "   begin xyz\n"
+    
+    it_checks_for_syntax_errors_when 'the line contains the word "begin" preceded by an equal sign and optionally by space', "  a = begin xyz\n"
+    
+    context ', the syntax check returns errors' do
+      
+      before do
+        @view = @doc.create_view
+        @doc.text = ''
+        flexmock(@doc).should_receive(:active_view).and_return @view
+        #avoid messing up the text with indentation
+        flexmock(@view).should_receive(:execute_action).with('tools_align').by_default
+        @doc.activate
+      end
       
-      it_should_insert_end "if the begin is at the beginning of the line", "begin kkk\n", "class X\n%\nend", "class X\nbegin kkk\n\nend\nend", [2, 0]
+      context 'and the last error is of type :missing_end' do
+        
+        before do
+          errors = {:errors => [OpenStruct.new(:error_type => :xyz, :error_message => ''), OpenStruct.new(:error_type => :missing_end, :error_message => 'missing kEND')]}
+        flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).with(:format => false, :update => false).once.and_return errors
 
-      it_should_insert_end "if the begin is preceded only by whitespaces", "  begin kkk\n", "class X\n%\nend", "class X\n  begin kkk\n\nend\nend", [2, 0]
-      
-      it_should_insert_end 'if the begin is preceded by an =', "x =begin kkk\n",
-      "class X\n%\nend", "class X\nx =begin kkk\n\nend\nend"
-      
-      it_should_insert_end 'if the begin is preceded by an = followed by spaces', "x = begin kkk\n", "class X\n%\nend", "class X\nx = begin kkk\n\nend\nend"
+        end
+        
+        it "inserts an an empty line followed by an =end if the line starts with =begin" do
+          @doc.insert_text KTextEditor::Cursor.new, "abc\n=begin xyz\n"
+          @doc.text.should == "abc\n=begin xyz\n\n=end"
+        end
+        
+        it 'inserts an empty line followed by an end keyword if the line starts with something other than =begin' do
+          @doc.insert_text KTextEditor::Cursor.new, "abc\ndef xyz\n"
+          @doc.text.should == "abc\ndef xyz\n\nend"
+        end
+        
+        it 'indents the text' do
+          flexmock(@view).should_receive(:execute_action).with('tools_align').once
+          @doc.insert_text KTextEditor::Cursor.new, "def xyz\n"
+        end
+        
+        it 'moves the cursor to the line before the end' do
+          @doc.insert_text KTextEditor::Cursor.new, "def xyz\n"
+          @view.cursor_position.should == KTextEditor::Cursor.new(1,0)
+        end
+                
+      end
       
-      it 'does nothing if the line starts with =begin ' do
-        @doc.block_signals true
-        @doc.text = "def x\n\nend"
-        @doc.block_signals false
-        @doc.insert_text KTextEditor::Cursor.new(1,0), "=begin \n"
-        @doc.text.should == "def x\n=begin \n\nend"
+      context 'and the last error is not of type :missing_end' do
+        
+        it 'doesn\'t alter the text' do
+        errors = {:errors => [OpenStruct.new(:error_type => :xyz, :error_message => ''), OpenStruct.new(:error_type => :abc, :error_message => '')]}
+        flexmock(@doc.extension(:syntax_checker)).should_receive(:check_syntax).with(:format => false, :update => false).once.and_return errors
+        @doc.insert_text KTextEditor::Cursor.new, "def a\nxyz)"
+        @doc.text.should == "def a\nxyz)"
+        end
+        
       end
-
       
     end
     
-    context "and the last line starts with =begin" do
-      pending
-#       context "and the active view is associated with the document" do
-#         
-#         before do
-#           @view = @doc.create_view
-#           flexmock(@doc).should_receive(:active_view).and_return @view
-#           @doc.block_signals true
-#           @doc.text= "abc\n"
-#           @doc.block_signals false
-#           @insert_pos = KTextEditor::Cursor.new(1,0)
-#           #avoid messing up the text with indentation
-#           flexmock(@view).should_receive(:execute_action).with('tools_align').by_default
-#         end
-#         
-#         it "inserts an an empty line followed by a =end" do
-#           @doc.insert_text @insert_pos, "=begin xyz\n"
-#           @doc.text.should == "abc\n=begin xyz\n\n=end"
-#         end
-#         
-#         it 'indents the text' do
-#           flexmock(@view).should_receive(:execute_action).with('tools_align').once
-#           @doc.insert_text @insert_pos, "=begin xyz\n"
-#         end
-#         
-#         it 'moves the cursor to the line before the end' do
-#           @doc.insert_text @insert_pos, "=begin xyz\n"
-#           @view.cursor_position.should == KTextEditor::Cursor.new(2,0)
-#         end
-#         
-#       end
-#       
-#       context 'and the active view is not associated with the document' do
-#         
-#         it 'does nothing' do
-#           flexmock(@doc).should_receive(:active_view).and_return nil
-#           @doc.block_signals true
-#           old_text = "abc\n"
-#           @doc.text = old_text
-#           @doc.block_signals false
-#           @doc.insert_text KTextEditor::Cursor.new(1,0), "=begin xyz\n"
-#           @doc.text.should == "abc\n=begin xyz\n"
-#         end
-#         
-#       end
-#         
-    end
-    
   end
   
   it 'doesn\'t insert end keywords in the middle of a multi-line text' do
@@ -309,15 +358,4 @@ describe Ruber::AutoEnd::Extension do
     @doc.text.should == text
   end
   
-  it 'doesn\'t insert an end keyword if the following line is more indented than the current one' do
-    view = @doc.create_view
-    flexmock(@doc).should_receive(:active_view).and_return view
-    text = "class X\n  def y\n   abc"
-    @doc.block_signals true
-    @doc.insert_text KTextEditor::Cursor.new(0,0), text
-    @doc.block_signals false
-    @doc.insert_text KTextEditor::Cursor.new(1,8), "\nY"
-    @doc.text.should == "class X\n  def y\nY\n   abc"
-  end    
-  
 end