ruber 0.0.8 → 0.0.9

data/spec/hint_solver_spec.rb

@@ -1,9 +1,9 @@
 require './spec/common'
-require 'ruber/main_window/hint_solver'
+require 'ruber/world/hint_solver'
 require 'ruber/editor/document'
 require 'ruber/pane'
 
-describe Ruber::MainWindow::HintSolver do
+describe Ruber::World::HintSolver do
   
   class HintSolverSpecComponentManager < Qt::Object
     extend Forwardable
@@ -29,7 +29,7 @@ describe Ruber::MainWindow::HintSolver do
     
     it 'takes the tab widget as argument' do
       tabs = KDE::TabWidget.new
-      lambda{Ruber::MainWindow::HintSolver.new tabs, KParts::PartManager.new(@main_window), []}.should_not raise_error
+      lambda{Ruber::World::HintSolver.new tabs, KParts::PartManager.new(@main_window), []}.should_not raise_error
     end
     
   end
@@ -38,7 +38,7 @@ describe Ruber::MainWindow::HintSolver do
     
     before do
       @tabs = KDE::TabWidget.new
-      @solver = Ruber::MainWindow::HintSolver.new @tabs, KParts::PartManager.new(@main_window), []
+      @solver = Ruber::World::HintSolver.new @tabs, KParts::PartManager.new(@main_window), []
       @doc = Ruber::Document.new nil
     end
     
@@ -332,7 +332,7 @@ describe Ruber::MainWindow::HintSolver do
     
     before do
       @tabs = KDE::TabWidget.new
-      @solver = Ruber::MainWindow::HintSolver.new @tabs, KParts::PartManager.new(@main_window), []
+      @solver = Ruber::World::HintSolver.new @tabs, KParts::PartManager.new(@main_window), []
       @doc = Ruber::Document.new nil
     end
     

data/spec/kde_sugar_spec.rb

@@ -93,6 +93,22 @@ describe 'KDE::Url' do
     
   end
   
+  describe '#eql?' do
+    it 'returns true if the two URLs are equal according to ==' do
+      u1, u2 = 2.times.map{KDE::Url.new 'file:///xyz'}
+      u1.should eql(u2)
+    end
+  end
+  
+  describe '#hash' do
+    
+    it 'returns the hash value of the path' do
+      u = KDE::Url.new 'file://xyz'
+      u.hash.should == u.path.hash
+    end
+    
+  end
+  
 end
 
 describe 'KDE::MimeType#=~' do

data/spec/output_widget_spec.rb

@@ -1089,36 +1089,165 @@ describe Ruber::OutputWidget do
       @mod.append_row Qt::StandardItem.new('')
     end
     
-    it 'calls the find_filename_in_string method, passing it the text of the index, if the argument is a Qt::ModelIndex' do
-      @mod.item(0,0).text = __FILE__
-      flexmock(@ow).should_receive(:find_filename_in_string).once.with __FILE__
-      @ow.send :find_filename_in_index, @mod.index(0,0)
+    context 'when the argument is a Qt::ModelIndex' do
+      
+      it 'calls #find_filename_in_string passing the text associated with the index as argument' do
+        @mod.item(0,0).text = __FILE__
+        flexmock(@ow).should_receive(:find_filename_in_string).with __FILE__
+        @ow.send :find_filename_in_index, @mod.index(0,0)
+      end
+      
+    end
+    
+    context 'when the argument is a string' do
+      
+      it 'calls #find_filename_in_string passing the string as argument' do
+        @mod.item(0,0).text = __FILE__
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with __FILE__
+        @ow.send :find_filename_in_index, __FILE__
+      end
+      
     end
     
-    it 'calls the find_filename_in_string method, passing it the argument, if the argument is a string' do
-      @mod.item(0,0).text = __FILE__
-      flexmock(@ow).should_receive(:find_filename_in_string).once.with __FILE__
-      @ow.send :find_filename_in_index, __FILE__
+    context 'when #find_filename_in_string returns nil' do
+      
+      it 'returns nil' do
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return nil
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should be_nil
+      end
+      
+    end
+    
+    context 'when #find_filename_in_string returns a string' do
+      
+      it 'returns an array with the string as first argument and 0 as second argument' do
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return __FILE__
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+      end
+      
+    end
+    
+    context 'when #find_filename_in_string returns an array with one element' do
+      
+      it 'returns the array after appending a 0 to it' do
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [__FILE__]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+      end
+      
+    end
+    
+    context 'when #find_filename_in_string returns an array with two elements' do
+      
+      it 'returns the array' do
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [__FILE__, 6]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 6]
+      end
+      
     end
 
-    it 'returns nil if find_filename_in_string returns nil' do
-      flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return nil
-      @ow.send(:find_filename_in_index, @mod.index(0,0)).should be_nil
+    context 'when the string or first element of the array returned by #find_filename_in_string is an absolute path' do
+      
+      it 'transforms it in a canonical path' do
+        path_parts = __FILE__.split('/')
+        orig_path = path_parts[0..-2].join('/') + '/../' + path_parts[-2..-1].join('/')
+        flexmock(@ow).should_receive(:find_filename_in_string).once.and_return [orig_path, 0]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.and_return orig_path
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+      end
+      
     end
     
-    it 'returns an array having the value returned by find_filename_in_string as first element and 0 as second if find_filename_in_string returns a string' do
-      flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return __FILE__
-      @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+    context 'when the string or first element of the array returned by #find_filename_in_string is a relative path' do
+      
+      it 'transforms it into an absolute filename relative to the working directory' do
+        @ow.working_dir = File.dirname __FILE__
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [File.basename(__FILE__), 6]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [File.basename(__FILE__)]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return File.basename(__FILE__)
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 6]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+      end
+      
+      it 'transforms it in a canonical path' do
+        @ow.working_dir = File.dirname File.dirname(__FILE__)
+        path_parts = __FILE__.split('/')
+        orig_path = "spec/../spec/#{File.basename(__FILE__)}"
+        
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [orig_path, 6]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [orig_path]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return orig_path
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 6]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+      end
+
     end
     
-    it 'returns an array having the value returned by find_filename_in_string as first element and 0 as second if find_filename_in_string returns an array with one element' do
-      flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [__FILE__]
-      @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+    context 'when the string or first element of the array returned by #find_filename_in_string is an URL with the file scheme' do
+      
+      context 'if the name of the file is an absolute path' do
+        
+        it 'returns the path corresponding to the URL as first element of the array' do
+          url = 'file://' + __FILE__
+          flexmock(@ow).should_receive(:find_filename_in_string).once.and_return [url, 0]
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+          flexmock(@ow).should_receive(:find_filename_in_string).once.and_return url
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        end
+        
+        it 'transforms it in a canonical path' do
+          path_parts = __FILE__.split('/')
+          url = 'file://' + path_parts[0..-2].join('/') + '/../' + path_parts[-2..-1].join('/')
+          flexmock(@ow).should_receive(:find_filename_in_string).once.and_return [url, 0]
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+          flexmock(@ow).should_receive(:find_filename_in_string).once.and_return url
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        end
+      
+      end
+      
+      context 'if the name of the file is a relative path' do
+        
+        it 'transforms it into an absolute filename relative to the working directory' do
+          @ow.working_dir = File.dirname __FILE__
+          url = 'file://' + File.basename(__FILE__)
+          flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [url, 6]
+          flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [url]
+          flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return url
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 6]
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        end
+        
+        it 'transforms it in a canonical path' do
+          @ow.working_dir = File.dirname File.dirname(__FILE__)
+          url = "file://spec/../spec/#{File.basename(__FILE__)}"
+          flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [url, 6]
+          flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [url]
+          flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return url
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 6]
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+          @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 0]
+        end
+        
+      end
+      
     end
     
-    it 'returns the value returned by find_filename_in_string if it is an array with two elements' do
-      flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [__FILE__, 6]
-      @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [__FILE__, 6]
+    context 'when the string or first element of the array returned by #find_filename_in_string is an URL with a scheme different from file' do
+    
+      it 'returns the URL as it is as the first element of the array' do
+        url = 'http://xyz/abc.it'
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [url, 6]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return [url]
+        flexmock(@ow).should_receive(:find_filename_in_string).once.with('').and_return url
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [url, 6]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [url, 0]
+        @ow.send(:find_filename_in_index, @mod.index(0,0)).should == [url, 0]
+      end
+      
     end
     
     it 'removes the first filename from the index text before passing it to find_filename_in_string if the index corresponds to the title and the @skip_first_file_in_title instance variable is true' do
@@ -1425,37 +1554,6 @@ describe Ruber::OutputWidget::Model do
     
   end
   
-  describe '#flags' do
-    
-    before do
-      @mod = @ow.model
-    end
-    
-    it 'returns the value specified in the @flags variable if the index is valid and the global_flags attribute is not nil' do
-      flags = Qt::ItemIsEnabled | Qt::ItemIsUserCheckable
-      @mod.global_flags = flags
-      @mod.append_row Qt::StandardItem.new('x')
-      @mod.flags(@mod.index(0,0)).should == flags.to_i
-    end
-    
-    it 'returns Qt::NoItemFlags if the inxed is not valid and the global_flags attribute is not nil' do
-      flags = Qt::ItemIsEnabled | Qt::ItemIsUserCheckable
-      @mod.global_flags = flags
-      @mod.append_row Qt::StandardItem.new('x')
-      @mod.flags(Qt::ModelIndex.new).should == Qt::NoItemFlags.to_i
-    end
-    
-    it 'calls super if the global_flags attribute is nil' do
-      @mod.global_flags = nil
-      it = Qt::StandardItem.new('x')
-      flags = Qt::ItemIsEnabled|Qt::ItemIsEditable|Qt::ItemIsDragEnabled
-      it.flags = flags
-      @mod.append_row it
-      @mod.flags(it.index).to_i.should == flags.to_i
-      @mod.flags(Qt::ModelIndex.new).to_i.should == Qt::ItemIsDropEnabled.to_i
-    end
-    
-  end
   
   describe '#set' do
     
@@ -1495,6 +1593,19 @@ describe Ruber::OutputWidget::Model do
       @mod.set 'Test', :message, 2, :col => 4, :parent => @mod.item(0,0)
     end
     
+    it 'sets the flags of the new item to the value returned by #global_flags' do
+      flags = Qt::ItemIsEnabled | Qt::ItemIsUserCheckable
+      @mod.global_flags = flags
+      it = @mod.set 'test', :message, 0
+      it.flags.should == flags
+    end
+    
+    it 'leaves the default flags for the item if #global_flags returns nil' do
+      @mod.global_flags = nil
+      it = @mod.set 'test', :message, 0
+      it.flags.should == Qt::ItemIsEnabled|Qt::ItemIsSelectable|Qt::ItemIsEditable|Qt::ItemIsDropEnabled|Qt::ItemIsDragEnabled
+    end
+    
     it 'calls the set_output_type method of the output widget passing it the index of the item and the type argument' do
       5.times{|i| @mod.append_row Qt::StandardItem.new(i.to_s)}
       flexmock(@ow).should_receive(:set_output_type).once.with(FlexMock.on{|i| i.is_a?(Qt::ModelIndex) and i.row == 3 and i.column == 5}, :message)
@@ -1665,6 +1776,21 @@ describe '#insert' do
       lambda{@mod.insert 'x', :message, -15}.should raise_error(IndexError, "Row index -10 is out of range. The allowed values are from 0 to 5")
     end
     
+    it 'sets the flags of the new item to the value returned by #global_flags' do
+      flags = Qt::ItemIsEnabled | Qt::ItemIsUserCheckable
+      @mod.global_flags = flags
+      row = @mod.insert ['x', 'y'], :message, 0
+      row.each{|it| it.flags.should == flags}
+    end
+    
+    it 'leaves the default flags for the item if #global_flags returns nil' do
+      @mod.global_flags = nil
+      flags = Qt::ItemIsEnabled|Qt::ItemIsSelectable|Qt::ItemIsEditable|Qt::ItemIsDropEnabled|Qt::ItemIsDragEnabled
+      row = @mod.insert ['x', 'y'], :message, 0
+      row.each{|it| it.flags.should == flags}
+    end
+
+    
   end
   
   describe '#insert_lines' do

data/spec/pane_spec.rb

@@ -114,18 +114,35 @@ describe Ruber::Pane do
   
   describe '#view' do
     
-    it 'returns the view if the pane contains a single view' do
-      view = @doc.create_view(nil)
-      pane = Ruber::Pane.new view
-      pane.view.should == view
+    context 'if the pane is in single view' do
+      
+      before do
+        @view = @doc.create_view(nil)
+        @pane = Ruber::Pane.new @view
+      end
+      
+      it 'returns the view if the pane contains a single view' do
+        @pane.view.should == @view
+      end
+      
+      it 'returns nil if the view has been closed' do
+        @view.close
+        @pane.view.should be_nil
+      end
+    
     end
     
+    
     it 'returns nil if the pane contains multiple panes' do
       views = 2.times.map{@doc.create_view(nil)}
       pane = Ruber::Pane.new Qt::Vertical, views[0], views[1]
       pane.view.should be_nil
     end
     
+    it 'returns nil if the only view has been removed' do
+      
+    end
+    
   end
   
   describe '#split' do
@@ -690,6 +707,13 @@ describe Ruber::Pane do
       res.should == [@views[0]]
     end
     
+    it 'does nothing if the pane is in single view and the only view has been closed' do
+      res = []
+      @views[0].close
+      @pane.each_view{|v| res << v}
+      res.should == []
+    end
+    
     it 'returns self' do
       @pane.each_view{}.should == @pane
       @pane.split @views[0], @views[1], Qt::Vertical
@@ -713,7 +737,7 @@ describe Ruber::Pane do
       res_single.should == [@views[0]]
       res_multi.should == [@views[0], @views[1], @views[3], @views[2]]
     end
-    
+        
   end
   
   describe '#parent_pane' do

data/spec/plugin_spec.rb

@@ -1071,7 +1071,7 @@ describe 'Ruber::Plugin#update_project' do
     @plug = Ruber::Plugin.new Ruber::PluginSpecification.full(@data)
     @prj = Ruber::Project.new 'test.ruprj', 'Test'
     @plug.register_with_project @prj
-    @doc = Ruber::Document.new nil, __FILE__
+    @doc = Ruber::Document.new __FILE__
   end
   
   it 'calls remove_options_from_project passing false as second argument' do

data/spec/project_factory_spec.rb

@@ -0,0 +1,104 @@
+require 'spec/framework'
+require './spec/common'
+require 'ruber/world/project_factory'
+
+require 'tempfile'
+require 'tmpdir'
+
+describe Ruber::World::ProjectFactory do
+  
+  before do
+    @factory = Ruber::World::ProjectFactory.new
+  end
+  
+  describe '#project' do
+    
+    context 'when called with a file name as argument' do
+      
+      before do
+        @file = Tempfile.new ['project_factory_test', '.ruprj']
+        @file.write YAML.dump({:general => {:project_name => 'project_factory_test'}})
+        @file.flush
+      end
+      
+      after do
+        @file.close!
+      end
+      
+      it 'returns a new project associated with the file if no other project is associated with it' do
+        prj = @factory.project @file.path
+        prj.should be_a(Ruber::Project)
+        prj.project_file.should == @file.path
+      end
+      
+      it 'returns an existing project associated with the same file, if that project exists' do
+        old = @factory.project @file.path
+        new = @factory.project @file.path
+        new.should == old
+      end
+      
+      it 'emits the project_created signal passing the project as argument if a new project was created' do
+        prj = Ruber::Project.new @file.path
+        flexmock(Ruber::Project).should_receive(:new).with(@file.path, nil).once.and_return prj
+        mk = flexmock{|m| m.should_receive(:test).once.with(prj)}
+        @factory.connect(SIGNAL('project_created(QObject*)')){|pr| mk.test pr}
+        @factory.project @file.path
+      end
+      
+      it 'doesn\'t return an existing project which has been closed' do
+        old = @factory.project @file.path
+        old.close
+        new = @factory.project @file.path
+        new.should_not == old
+      end
+      
+    end
+    
+  end
+  
+  context 'when called with a file name and a project name as arguments' do
+    
+    it 'returns a new project associated with the file if no other project is associated with it' do
+      file = File.join Dir.tmpdir, 'project_factory_test.ruprj'
+      prj = @factory.project file, 'project_factory_test'
+      prj.should be_a(Ruber::Project)
+      prj.project_file.should == file
+    end
+    
+    it 'returns the existing project associated with the file if there is such a project and the name of the project is equal to the second argument' do
+      file = File.join Dir.tmpdir, 'project_factory_test.ruprj'
+      old = @factory.project file, 'project_factory_test'
+      prj = @factory.project file, 'project_factory_test'
+      prj.should == old
+    end
+    
+    it 'emits the project_created signal passing the project as argument if a new project was created' do
+      name = 'project_factory_test'
+      file = File.join Dir.tmpdir, 'project_factory_test.ruprj'
+      prj = Ruber::Project.new file, name
+      flexmock(Ruber::Project).should_receive(:new).once.with(file, name).and_return prj
+      mk = flexmock{|m| m.should_receive(:test).once.with(prj)}
+      @factory.connect(SIGNAL('project_created(QObject*)')){|pr| mk.test pr}
+      @factory.project file, name
+    end
+    
+    it 'raises ProjectFactory::MismatchingNameError if there\'s a project associated with the same file but the project name is different from the second argument' do
+      file = File.join Dir.tmpdir, 'project_factory_test.ruprj'
+      old_name = 'project_factory_test'
+      old = @factory.project file, old_name
+      new_name = 'project_factory_test_other_name'
+      lambda{@factory.project file, new_name}.should raise_error(Ruber::World::ProjectFactory::MismatchingNameError, "A project associated with #{file} exists, but the corresponding project name is #{old_name} instead of #{new_name}")
+    end
+    
+    it 'doesn\'t return an existing project which has been closed' do
+      file = File.join Dir.tmpdir, 'project_factory_test.ruprj'
+      old = @factory.project file, 'project_factory_test'
+      old.close false
+      new = @factory.project file, 'project_factory_test'
+      new.should_not == old
+    end
+
+    
+  end
+  
+end