ruber 0.0.7 → 0.0.8

data/spec/common.rb

@@ -21,6 +21,7 @@ end
 
 require 'ruber/qt_sugar'
 require 'ruber/kde_sugar'
+require 'ruber/ktexteditor_sugar'
 require 'ruber/utils'
 
 #Distinguish between rspec 1.* and 2.*

data/spec/document_spec.rb

@@ -802,4 +802,87 @@ describe Ruber::Document do
     
   end
   
+  describe '#text' do
+    
+    before do
+      @doc = Ruber::Document.new
+    end
+    
+    context 'when called with no arguments' do
+    
+      it 'returns an empty string if the document is empty' do
+        @doc.text.should == ''
+      end
+      
+      it 'returns the text of the document if the document is not empty' do
+        @doc.text = 'xyz'
+        @doc.text.should == 'xyz'
+      end
+      
+    end
+    
+    context 'when called with a KTextEditor::Range argument' do
+      
+      it 'returns an empty string if the document is empty' do
+        @doc.text(KTextEditor::Range.new(2,3, 4, 5)).should == ''
+      end
+      
+      it 'returns the text contained in the given range if the document is not empty' do
+        @doc.text = "abc\ndef\nghi"
+        @doc.text(KTextEditor::Range.new(0,1,1,2)).should == "bc\nde"
+      end
+      
+      it 'returns an empty string if the range is invalid' do
+        @doc.text = "abc\ndef\nghi"
+        @doc.text(KTextEditor::Range.new(-5,0,0,2)).should == ''
+      end
+      
+    end
+    
+    context 'when the second argument is true' do
+
+      it 'returns an empty string if the document is empty' do
+        @doc.text(KTextEditor::Range.new(2,3, 4, 5), true).should == ''
+      end
+      
+      it 'returns the text contained in the given range, considered as a block selection, if the document is not empty' do
+        @doc.text = "abc\ndef\nghi"
+        @doc.text(KTextEditor::Range.new(0,1,1,2), true).should == "b\ne"
+      end
+      
+      it 'returns an empty string if the range is invalid' do
+        @doc.text = "abc\ndef\nghi"
+        @doc.text(KTextEditor::Range.new(-5,0,0,2), true).should == ''
+      end
+
+    end
+    
+  end
+  
+  describe '#line' do
+    
+    before do
+      @doc = Ruber::Document.new
+    end
+    
+    it 'returns the text in the line given as argument' do
+      @doc.text = "abc\ndef\nghi"
+      lines = %w[abc def ghi]
+      lines.each_with_index do |str, i|
+        @doc.line(i).should == str
+      end
+    end
+    
+    it 'returns an empty string if the line is empty' do
+      @doc.text = "abc\n\nxyz"
+      @doc.line(1).should == ''
+    end
+    
+    it 'returns an empty string if the line number corresponds to a nonexisting line' do
+      @doc.text = "abc\ndef\nghi"
+      @doc.line(10).should == ''
+    end
+    
+  end
+  
 end

data/spec/editor_view_spec.rb

@@ -148,6 +148,47 @@ describe Ruber::EditorView do
     end
     
   end
+  
+  describe '#move_cursor_by' do
+    
+    before do
+      @doc.text = 20.times.map{'x'*20}.join("\n")
+      @view.go_to 10, 8
+    end
+    
+    it 'moves the cursor by the specified amount from the current position' do
+      exp = KTextEditor::Cursor.new 14, 9
+      @view.move_cursor_by 4, 1
+      res = @view.cursor_position
+      res.line.should == exp.line
+      res.column.should == exp.column
+    end
+    
+    it 'moves the cursor upwards if the row argument is negative' do
+      exp = KTextEditor::Cursor.new 6, 9
+      @view.move_cursor_by -4, 1
+      res = @view.cursor_position
+      res.line.should == exp.line
+      res.column.should == exp.column
+    end
+    
+    it 'moves the cursor to the left if the column argument is negative' do
+      exp = KTextEditor::Cursor.new 14, 5
+      @view.move_cursor_by 4, -3
+      res = @view.cursor_position
+      res.line.should == exp.line
+      res.column.should == exp.column
+    end
+    
+    it 'doesn\'t move the cursor and returns false if the new cursor position is out of range' do
+      exp = KTextEditor::Cursor.new 10, 8
+      @view.move_cursor_by(100, -300).should be_false
+      res = @view.cursor_position
+      res.line.should == exp.line
+      res.column.should == exp.column
+    end
+
+  end
 
 end
 

data/spec/filtered_output_widget_spec.rb

@@ -60,13 +60,13 @@ describe Ruber::FilteredOutputWidget do
       flexmock(editor).should_receive(:hide).once
       flexmock(KDE::LineEdit).should_receive(:new).once.with(Ruber::FilteredOutputWidget).and_return editor
       ow = Ruber::FilteredOutputWidget.new
-      ow.layout.item_at_position(1,0).widget.should be_the_same_as(editor)
+      ow.layout.item_at_position(2,0).widget.should be_the_same_as(editor)
     end
     
     it 'overrides the editor\'s keyReleasedEvent method so that it hides the editor itself if the ESC key (without modifiers) is pressed' do
       ow = Ruber::FilteredOutputWidget.new
       ed = ow.instance_variable_get(:@editor)
-      flexmock(ed).should_receive(:hide).once
+      flexmock(ed).should_receive(:hide) #.once
       ev = Qt::KeyEvent.new Qt::KeyEvent::KeyRelease, Qt::Key_Escape, 0
       ed.send :keyReleaseEvent, ev
       ev = Qt::KeyEvent.new Qt::KeyEvent::KeyRelease, Qt::Key_A, 0, 'A'

data/spec/ktexteditor_sugar_spec.rb

@@ -0,0 +1,190 @@
+require './spec/common'
+require 'ruber/ktexteditor_sugar'
+
+describe KTextEditor::Cursor do
+  
+  describe '#inspect' do
+    
+    it 'returns a string containing the class, the object id and the line and column associated with the cursor' do
+      line = 12
+      col = 38
+      cur = KTextEditor::Cursor.new line, col
+      exp = "<KTextEditor::Cursor:#{cur.object_id} line=#{line} column=#{col}>"
+      cur.inspect.should == exp
+    end
+    
+    it 'returns a string containing the class, the object id and the string DISPOSED if the Cursor has been disposed' do
+      range = KTextEditor::Cursor.new 1,2
+      range.dispose
+      range.inspect.should == "<KTextEditor::Cursor:#{range.object_id} DISPOSED>"
+    end
+    
+    
+  end
+  
+  describe '#==' do
+    
+    it 'returns true if the argument is a Cursor with the same line and column' do
+      line = 10
+      col = 24
+      c1, c2 = 2.times.map{KTextEditor::Cursor.new line, col}
+      c1.should == c2
+    end
+    
+    it 'returns false if the argument is a Cursor with a different line or column number' do
+      cursor = KTextEditor::Cursor.new 10, 34
+      cursors = 
+        [
+          KTextEditor::Cursor.new(10, 21),
+          KTextEditor::Cursor.new(2, 34),
+          KTextEditor::Cursor.new(1, 9)
+        ]
+      cursors.each{|c| cursor.should_not == c}
+    end
+    
+    it 'returns false if the other object is not a Cursor' do
+      cursor = KTextEditor::Cursor.new(10, 34).should_not == "x"
+    end
+    
+  end
+  
+  describe '#dup' do
+    
+    before do
+      @cur = KTextEditor::Cursor.new 23, 57
+    end
+    
+    it 'returns a copy of self' do
+      res = @cur.dup
+      res.should == @cur
+      res.should_not equal(@cur)
+    end
+    
+    it 'doesn\'t copy the frozen state of self' do
+      res = @cur.dup
+      res.should_not be_frozen
+      @cur.freeze
+      res = @cur.dup
+      res.should_not be_frozen
+    end
+    
+  end
+  
+  describe '#clone' do
+    
+    before do
+      @cur = KTextEditor::Cursor.new 23, 57
+    end
+    
+    it 'returns a copy of self' do
+      res = @cur.clone
+      res.should == @cur
+      res.should_not equal(@cur)
+    end
+    
+    it 'copies the frozen state of self' do
+      res = @cur.clone
+      res.should_not be_frozen
+      @cur.freeze
+      res = @cur.clone
+      res.should be_frozen
+    end
+    
+  end
+  
+end
+
+describe KTextEditor::Range do
+  
+  describe '#inspect' do
+    
+    it 'returns a string containing the class, the object id and the starting and ending line and column' do
+      start_line = 12
+      start_col = 38
+      end_line = 15
+      end_col = 20
+      range = KTextEditor::Range.new start_line, start_col, end_line, end_col
+      exp = "<KTextEditor::Range:#{range.object_id} start=(#{start_line};#{start_col}) end=(#{end_line};#{end_col})>"
+      range.inspect.should == exp
+    end
+    
+    it 'returns a string containing the class, the object id and the string DISPOSED if the Range has been disposed' do
+      range = KTextEditor::Range.new 1,2,3,4
+      range.dispose
+      range.inspect.should == "<KTextEditor::Range:#{range.object_id} DISPOSED>"
+    end
+    
+  end
+  
+  describe '==' do
+    
+    it 'returns true if the argument is a Range with the same start and end' do
+      r1 = KTextEditor::Range.new 12, 4, 13, 5
+      r2 = KTextEditor::Range.new 12, 4, 13, 5
+      r1.should == r2
+    end
+    
+    it 'returns false if the argument is not a Range' do
+      r = KTextEditor::Range.new 12, 4, 13, 5
+      r.should_not == 'x'
+    end
+    
+    it 'returns false if the argument is a range with different start or end' do
+      range = KTextEditor::Range.new 12, 4, 13, 5
+      ranges = [
+        KTextEditor::Range.new(11,4,13,5),
+        KTextEditor::Range.new(12,4,13,9),
+        KTextEditor::Range.new(13,2,15,6)
+      ]
+      ranges.each{|r| r.should_not == range}
+    end
+    
+  end
+  
+  describe '#dup' do
+    
+    before do
+      @range = KTextEditor::Range.new 23, 57, 46, 23
+    end
+    
+    it 'returns a copy of self' do
+      res = @range.dup
+      res.should == @range
+      res.should_not equal(@range)
+    end
+    
+    it 'doesn\'t copy the frozen state of self' do
+      res = @range.dup
+      res.should_not be_frozen
+      @range.freeze
+      res = @range.dup
+      res.should_not be_frozen
+    end
+    
+  end
+  
+  describe '#clone' do
+    
+    before do
+      @range = KTextEditor::Range.new 23, 57, 46, 23
+    end
+    
+    it 'returns a copy of self' do
+      res = @range.clone
+      res.should == @range
+      res.should_not equal(@range)
+    end
+    
+    it 'copies the frozen state of self' do
+      res = @range.clone
+      res.should_not be_frozen
+      @range.freeze
+      res = @range.clone
+      res.should be_frozen
+    end
+    
+  end
+
+  
+  
+end

data/spec/output_widget_spec.rb

@@ -152,9 +152,17 @@ describe Ruber::OutputWidget do
       w.view.parent.should equal(w)
     end
     
-    it 'inserts the view in the layout at position (0,0)' do
+    it 'inserts the view in the layout at position (1,0)' do
       w = Ruber::OutputWidget.new
-      w.layout.item_at_position(0,0).widget.should be_a(Ruber::OutputWidget::ListView)
+      w.layout.item_at_position(1,0).widget.should be_a(Ruber::OutputWidget::ListView)
+    end
+    
+    it 'has a checkable Qt::ToolButton in the first line, aligned to the right' do
+      w = Ruber::OutputWidget.new
+      it = w.layout.item_at_position(0,0)
+      it.widget.should be_a(Qt::ToolButton)
+      it.alignment.should == Qt::AlignRight | Qt::AlignVCenter
+      it.widget.should be_checkable
     end
     
     it 'sets the selection mode to Extended' do
@@ -587,6 +595,14 @@ describe Ruber::OutputWidget do
       @ow.send :do_auto_scroll, Qt::ModelIndex.new, 1, 3      
     end
     
+    it 'does nothing if the slider is not at the maximum value' do
+      flexmock(@ow).should_receive(:scroll_to).never
+      scroll = @ow.view.vertical_scroll_bar
+      scroll.maximum = 100
+      scroll.value = 30
+      @ow.send :do_auto_scroll, Qt::ModelIndex.new, 1, 3
+    end
+    
   end
   
   describe '#with_auto_scrolling' do
@@ -885,6 +901,25 @@ describe Ruber::OutputWidget do
     
   end
   
+  describe '#pinned_down?' do
+    
+    before do
+      @ow = Ruber::OutputWidget.new
+    end
+    
+    it 'returns true if the pinned tool button is on' do
+      @ow.instance_variable_get(:@pin_button).checked = true
+      @ow.should be_pinned_down
+    end
+    
+    it 'returns false if the pinned tool button is off' do
+      @ow.instance_variable_get(:@pin_button).checked = false
+      @ow.should_not be_pinned_down
+    end
+      
+  end
+
+  
   describe '#maybe_open_file' do
     
     before do
@@ -897,7 +932,9 @@ describe Ruber::OutputWidget do
       @mod = @ow.model
       @mod.append_row Qt::StandardItem.new ''
       @mw = flexmock{|m| m.should_ignore_missing}
+      @cfg = flexmock{|m| m.should_receive(:[]).with(:general, :tool_open_files).and_return(:new_tab).by_default}
       flexmock(Ruber).should_receive(:[]).with(:main_window).and_return(@mw).by_default
+      flexmock(Ruber).should_receive(:[]).with(:config).and_return(@cfg).by_default
     end
     
     after do
@@ -908,31 +945,56 @@ describe Ruber::OutputWidget do
       flexmock(@ow).should_receive(:find_filename_in_index).once.with @mod.index(0,0)
       @ow.send :maybe_open_file, @mod.index(0,0)
     end
-
+    
     describe ', when the find_filename_in_index methods returns an array' do
       
       before do
         flexmock(@ow).should_receive(:find_filename_in_index).with(@mod.index(0,0)).and_return([__FILE__, 10]).by_default
       end
       
-      it 'opens displays the file corresponding to the first entry of the array in the editor, scrolling to the line corresponding to the second entry minus 1' do
-        @mw.should_receive(:display_document).once.with(__FILE__, 9)
+      context 'when the Meta key is not pressed' do
+        
+        it 'calls the display_document method of the main window using the hints returned by hints but with the :existing key set to always' do
+          hints = {:existing => :never, :new => :current, :split => :horizontal}
+          flexmock(@ow).should_receive(:hints).and_return(hints)
+          exp = hints.merge :existing => :always, :line => 9
+          @mw.should_receive(:display_document).once.with(__FILE__, exp)
+          @ow.send :maybe_open_file, @mod.index(0,0)
+        end
+        
+      end
+      
+      context 'when the Meta key is pressed' do
+        it 'calls the display_document method of the main window using the hints returned by hints but with the :existing key set to :never' do
+          flexmock(Ruber::Application).should_receive(:keyboard_modifiers).and_return(Qt::MetaModifier)
+          hints = {:existing => :always, :new => :current, :split => :horizontal}
+          flexmock(@ow).should_receive(:hints).and_return(hints)
+          exp = hints.merge :existing => :never, :line => 9
+          @mw.should_receive(:display_document).once.with(__FILE__, exp)
+          @ow.send :maybe_open_file, @mod.index(0,0)
+        end
+
+      end
+      
+      it 'decreases line numbers by one' do
+        @mw.should_receive(:display_document).once.with(__FILE__, FlexMock.on{|h| h[:line].should == 9})
         @ow.send :maybe_open_file, @mod.index(0,0)
       end
       
-      it 'doesn\'t subtract 1 from the line number if it is 0' do
-        @mw.should_receive(:display_document).once.with(__FILE__, 0)
-        @ow.should_receive(:find_filename_in_index).once.and_return [__FILE__, 0]
+      it 'doesn\'t decrease the line number if it\'s 0' do
+        flexmock(@ow).should_receive(:find_filename_in_index).with(@mod.index(0,0)).and_return([__FILE__, 0])
+        @mw.should_receive(:display_document).once.with(__FILE__, FlexMock.on{|h| h[:line].should == 0})
         @ow.send :maybe_open_file, @mod.index(0,0)
       end
       
-      it 'hides the tool widget if the Meta key is not pressed' do
+      it 'hides the tool widget if #pinned_down? returns false' do
+        flexmock(@ow).should_receive(:pinned_down?).and_return false
         @mw.should_receive(:hide_tool).with(@ow).once
         @ow.send :maybe_open_file, @mod.index(0,0)
       end
       
-      it 'doesn\'t hide the tool widget if the Meta key is pressed' do
-        flexmock(Ruber::Application).should_receive(:keyboard_modifiers).once.and_return(Qt::MetaModifier.to_i)
+      it 'doesn\'t hide the tool widget if #pinned_down? returns true' do
+        flexmock(@ow).should_receive(:pinned_down?).and_return true
         @mw.should_receive(:hide_tool).with(@ow).never
         @ow.send :maybe_open_file, @mod.index(0,0)
       end
@@ -972,6 +1034,53 @@ describe Ruber::OutputWidget do
     
   end
   
+  describe '#hints' do
+    
+    before do
+      @ow = Ruber::OutputWidget.new
+      @cfg = flexmock{|m| m.should_ignore_missing}
+      flexmock(Ruber).should_receive(:[]).with(:config).and_return(@cfg).by_default
+    end
+    
+    context 'when the general/tool_open_files setting is :split_horizontally' do
+      
+      it 'returns {:new => :current_tab, :split => :horizontal}' do
+        @cfg.should_receive(:[]).with(:general, :tool_open_files).and_return(:split_horizontally)
+        @ow.send(:hints).should == {:new => :current_tab, :split => :horizontal}
+      end
+      
+    end
+    
+    context 'when the general/tool_open_files setting is :split_vertically' do
+      
+      it 'returns {:new => :current_tab, :split => :vertical}' do
+        @cfg.should_receive(:[]).with(:general, :tool_open_files).and_return(:split_vertically)
+        @ow.send(:hints).should == {:new => :current_tab, :split => :vertical}
+      end
+      
+    end
+    
+    context 'when the general/tool_open_files setting is :new_tab' do
+      
+      it 'returns {:new => :new_tab}' do
+        @cfg.should_receive(:[]).with(:general, :tool_open_files).and_return(:new_tab)
+        @ow.send(:hints).should == {:new => :new_tab}
+      end
+      
+    end
+    
+    context 'when the general/tool_open_files setting contains an invalid value' do
+
+      it 'returns {:new => :new_tab}' do
+        @cfg.should_receive(:[]).with(:general, :tool_open_files).and_return(:xyz)
+        @ow.send(:hints).should == {:new => :new_tab}
+      end
+      
+    end
+    
+  end
+    
+  
   describe '#find_filename_in_index' do
     
     before do