rubbycop 0.49.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +7 -0
- data/LICENSE.txt +21 -0
- data/README.md +211 -0
- data/assets/logo.png +0 -0
- data/assets/output.html.erb +261 -0
- data/bin/rubbycop +17 -0
- data/config/default.yml +1548 -0
- data/config/disabled.yml +119 -0
- data/config/enabled.yml +1734 -0
- data/lib/rubbycop.rb +510 -0
- data/lib/rubbycop/ast/builder.rb +64 -0
- data/lib/rubbycop/ast/node.rb +610 -0
- data/lib/rubbycop/ast/node/and_node.rb +37 -0
- data/lib/rubbycop/ast/node/array_node.rb +48 -0
- data/lib/rubbycop/ast/node/case_node.rb +64 -0
- data/lib/rubbycop/ast/node/ensure_node.rb +25 -0
- data/lib/rubbycop/ast/node/for_node.rb +53 -0
- data/lib/rubbycop/ast/node/hash_node.rb +109 -0
- data/lib/rubbycop/ast/node/if_node.rb +138 -0
- data/lib/rubbycop/ast/node/keyword_splat_node.rb +45 -0
- data/lib/rubbycop/ast/node/mixin/binary_operator_node.rb +23 -0
- data/lib/rubbycop/ast/node/mixin/conditional_node.rb +45 -0
- data/lib/rubbycop/ast/node/mixin/hash_element_node.rb +125 -0
- data/lib/rubbycop/ast/node/mixin/modifier_node.rb +17 -0
- data/lib/rubbycop/ast/node/mixin/predicate_operator_node.rb +35 -0
- data/lib/rubbycop/ast/node/or_node.rb +37 -0
- data/lib/rubbycop/ast/node/pair_node.rb +64 -0
- data/lib/rubbycop/ast/node/resbody_node.rb +25 -0
- data/lib/rubbycop/ast/node/send_node.rb +209 -0
- data/lib/rubbycop/ast/node/until_node.rb +43 -0
- data/lib/rubbycop/ast/node/when_node.rb +61 -0
- data/lib/rubbycop/ast/node/while_node.rb +43 -0
- data/lib/rubbycop/ast/sexp.rb +16 -0
- data/lib/rubbycop/ast/traversal.rb +171 -0
- data/lib/rubbycop/cached_data.rb +63 -0
- data/lib/rubbycop/cli.rb +199 -0
- data/lib/rubbycop/comment_config.rb +155 -0
- data/lib/rubbycop/config.rb +444 -0
- data/lib/rubbycop/config_loader.rb +244 -0
- data/lib/rubbycop/config_loader_resolver.rb +43 -0
- data/lib/rubbycop/config_store.rb +48 -0
- data/lib/rubbycop/cop/autocorrect_logic.rb +26 -0
- data/lib/rubbycop/cop/badge.rb +73 -0
- data/lib/rubbycop/cop/bundler/duplicated_gem.rb +69 -0
- data/lib/rubbycop/cop/bundler/ordered_gems.rb +113 -0
- data/lib/rubbycop/cop/commissioner.rb +118 -0
- data/lib/rubbycop/cop/cop.rb +222 -0
- data/lib/rubbycop/cop/corrector.rb +135 -0
- data/lib/rubbycop/cop/force.rb +41 -0
- data/lib/rubbycop/cop/ignored_node.rb +38 -0
- data/lib/rubbycop/cop/layout/access_modifier_indentation.rb +109 -0
- data/lib/rubbycop/cop/layout/align_array.rb +35 -0
- data/lib/rubbycop/cop/layout/align_hash.rb +235 -0
- data/lib/rubbycop/cop/layout/align_parameters.rb +97 -0
- data/lib/rubbycop/cop/layout/block_end_newline.rb +56 -0
- data/lib/rubbycop/cop/layout/case_indentation.rb +163 -0
- data/lib/rubbycop/cop/layout/closing_parenthesis_indentation.rb +88 -0
- data/lib/rubbycop/cop/layout/comment_indentation.rb +71 -0
- data/lib/rubbycop/cop/layout/dot_position.rb +84 -0
- data/lib/rubbycop/cop/layout/else_alignment.rb +105 -0
- data/lib/rubbycop/cop/layout/empty_line_after_magic_comment.rb +63 -0
- data/lib/rubbycop/cop/layout/empty_line_between_defs.rb +143 -0
- data/lib/rubbycop/cop/layout/empty_lines.rb +60 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_access_modifier.rb +90 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_begin_body.rb +42 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_block_body.rb +41 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_class_body.rb +39 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_exception_handling_keywords.rb +127 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_method_body.rb +41 -0
- data/lib/rubbycop/cop/layout/empty_lines_around_module_body.rb +44 -0
- data/lib/rubbycop/cop/layout/end_of_line.rb +52 -0
- data/lib/rubbycop/cop/layout/extra_spacing.rb +237 -0
- data/lib/rubbycop/cop/layout/first_array_element_line_break.rb +41 -0
- data/lib/rubbycop/cop/layout/first_hash_element_line_break.rb +33 -0
- data/lib/rubbycop/cop/layout/first_method_argument_line_break.rb +49 -0
- data/lib/rubbycop/cop/layout/first_method_parameter_line_break.rb +42 -0
- data/lib/rubbycop/cop/layout/first_parameter_indentation.rb +109 -0
- data/lib/rubbycop/cop/layout/indent_array.rb +114 -0
- data/lib/rubbycop/cop/layout/indent_assignment.rb +42 -0
- data/lib/rubbycop/cop/layout/indent_hash.rb +134 -0
- data/lib/rubbycop/cop/layout/indent_heredoc.rb +173 -0
- data/lib/rubbycop/cop/layout/indentation_consistency.rb +51 -0
- data/lib/rubbycop/cop/layout/indentation_width.rb +303 -0
- data/lib/rubbycop/cop/layout/initial_indentation.rb +42 -0
- data/lib/rubbycop/cop/layout/leading_comment_space.rb +43 -0
- data/lib/rubbycop/cop/layout/multiline_array_brace_layout.rb +81 -0
- data/lib/rubbycop/cop/layout/multiline_assignment_layout.rb +88 -0
- data/lib/rubbycop/cop/layout/multiline_block_layout.rb +134 -0
- data/lib/rubbycop/cop/layout/multiline_hash_brace_layout.rb +81 -0
- data/lib/rubbycop/cop/layout/multiline_method_call_brace_layout.rb +97 -0
- data/lib/rubbycop/cop/layout/multiline_method_call_indentation.rb +215 -0
- data/lib/rubbycop/cop/layout/multiline_method_definition_brace_layout.rb +82 -0
- data/lib/rubbycop/cop/layout/multiline_operation_indentation.rb +89 -0
- data/lib/rubbycop/cop/layout/rescue_ensure_alignment.rb +86 -0
- data/lib/rubbycop/cop/layout/space_after_colon.rb +40 -0
- data/lib/rubbycop/cop/layout/space_after_comma.rb +21 -0
- data/lib/rubbycop/cop/layout/space_after_method_name.rb +37 -0
- data/lib/rubbycop/cop/layout/space_after_not.rb +38 -0
- data/lib/rubbycop/cop/layout/space_after_semicolon.rb +21 -0
- data/lib/rubbycop/cop/layout/space_around_block_parameters.rb +109 -0
- data/lib/rubbycop/cop/layout/space_around_equals_in_parameter_default.rb +68 -0
- data/lib/rubbycop/cop/layout/space_around_keyword.rb +224 -0
- data/lib/rubbycop/cop/layout/space_around_operators.rb +142 -0
- data/lib/rubbycop/cop/layout/space_before_block_braces.rb +54 -0
- data/lib/rubbycop/cop/layout/space_before_comma.rb +16 -0
- data/lib/rubbycop/cop/layout/space_before_comment.rb +27 -0
- data/lib/rubbycop/cop/layout/space_before_first_arg.rb +64 -0
- data/lib/rubbycop/cop/layout/space_before_semicolon.rb +16 -0
- data/lib/rubbycop/cop/layout/space_in_lambda_literal.rb +87 -0
- data/lib/rubbycop/cop/layout/space_inside_array_percent_literal.rb +53 -0
- data/lib/rubbycop/cop/layout/space_inside_block_braces.rb +158 -0
- data/lib/rubbycop/cop/layout/space_inside_brackets.rb +20 -0
- data/lib/rubbycop/cop/layout/space_inside_hash_literal_braces.rb +150 -0
- data/lib/rubbycop/cop/layout/space_inside_parens.rb +16 -0
- data/lib/rubbycop/cop/layout/space_inside_percent_literal_delimiters.rb +64 -0
- data/lib/rubbycop/cop/layout/space_inside_range_literal.rb +63 -0
- data/lib/rubbycop/cop/layout/space_inside_string_interpolation.rb +65 -0
- data/lib/rubbycop/cop/layout/tab.rb +57 -0
- data/lib/rubbycop/cop/layout/trailing_blank_lines.rb +78 -0
- data/lib/rubbycop/cop/layout/trailing_whitespace.rb +28 -0
- data/lib/rubbycop/cop/lint/ambiguous_block_association.rb +66 -0
- data/lib/rubbycop/cop/lint/ambiguous_operator.rb +55 -0
- data/lib/rubbycop/cop/lint/ambiguous_regexp_literal.rb +43 -0
- data/lib/rubbycop/cop/lint/assignment_in_condition.rb +80 -0
- data/lib/rubbycop/cop/lint/block_alignment.rb +229 -0
- data/lib/rubbycop/cop/lint/circular_argument_reference.rb +83 -0
- data/lib/rubbycop/cop/lint/condition_position.rb +52 -0
- data/lib/rubbycop/cop/lint/debugger.rb +72 -0
- data/lib/rubbycop/cop/lint/def_end_alignment.rb +78 -0
- data/lib/rubbycop/cop/lint/deprecated_class_methods.rb +90 -0
- data/lib/rubbycop/cop/lint/duplicate_case_condition.rb +53 -0
- data/lib/rubbycop/cop/lint/duplicate_methods.rb +151 -0
- data/lib/rubbycop/cop/lint/duplicated_key.rb +38 -0
- data/lib/rubbycop/cop/lint/each_with_object_argument.rb +39 -0
- data/lib/rubbycop/cop/lint/else_layout.rb +65 -0
- data/lib/rubbycop/cop/lint/empty_ensure.rb +60 -0
- data/lib/rubbycop/cop/lint/empty_expression.rb +42 -0
- data/lib/rubbycop/cop/lint/empty_interpolation.rb +36 -0
- data/lib/rubbycop/cop/lint/empty_when.rb +38 -0
- data/lib/rubbycop/cop/lint/end_alignment.rb +157 -0
- data/lib/rubbycop/cop/lint/end_in_method.rb +40 -0
- data/lib/rubbycop/cop/lint/ensure_return.rb +43 -0
- data/lib/rubbycop/cop/lint/float_out_of_range.rb +35 -0
- data/lib/rubbycop/cop/lint/format_parameter_mismatch.rb +182 -0
- data/lib/rubbycop/cop/lint/handle_exceptions.rb +56 -0
- data/lib/rubbycop/cop/lint/implicit_string_concatenation.rb +95 -0
- data/lib/rubbycop/cop/lint/ineffective_access_modifier.rb +143 -0
- data/lib/rubbycop/cop/lint/inherit_exception.rb +83 -0
- data/lib/rubbycop/cop/lint/invalid_character_literal.rb +41 -0
- data/lib/rubbycop/cop/lint/literal_in_condition.rb +127 -0
- data/lib/rubbycop/cop/lint/literal_in_interpolation.rb +76 -0
- data/lib/rubbycop/cop/lint/loop.rb +63 -0
- data/lib/rubbycop/cop/lint/multiple_compare.rb +48 -0
- data/lib/rubbycop/cop/lint/nested_method_definition.rb +105 -0
- data/lib/rubbycop/cop/lint/next_without_accumulator.rb +50 -0
- data/lib/rubbycop/cop/lint/non_local_exit_from_iterator.rb +85 -0
- data/lib/rubbycop/cop/lint/parentheses_as_grouped_expression.rb +60 -0
- data/lib/rubbycop/cop/lint/percent_string_array.rb +84 -0
- data/lib/rubbycop/cop/lint/percent_symbol_array.rb +66 -0
- data/lib/rubbycop/cop/lint/rand_one.rb +39 -0
- data/lib/rubbycop/cop/lint/require_parentheses.rb +61 -0
- data/lib/rubbycop/cop/lint/rescue_exception.rb +45 -0
- data/lib/rubbycop/cop/lint/safe_navigation_chain.rb +70 -0
- data/lib/rubbycop/cop/lint/shadowed_exception.rb +132 -0
- data/lib/rubbycop/cop/lint/shadowing_outer_local_variable.rb +53 -0
- data/lib/rubbycop/cop/lint/string_conversion_in_interpolation.rb +58 -0
- data/lib/rubbycop/cop/lint/syntax.rb +55 -0
- data/lib/rubbycop/cop/lint/underscore_prefixed_variable_name.rb +62 -0
- data/lib/rubbycop/cop/lint/unified_integer.rb +42 -0
- data/lib/rubbycop/cop/lint/unneeded_disable.rb +231 -0
- data/lib/rubbycop/cop/lint/unneeded_splat_expansion.rb +141 -0
- data/lib/rubbycop/cop/lint/unreachable_code.rb +52 -0
- data/lib/rubbycop/cop/lint/unused_block_argument.rb +145 -0
- data/lib/rubbycop/cop/lint/unused_method_argument.rb +61 -0
- data/lib/rubbycop/cop/lint/useless_access_modifier.rb +229 -0
- data/lib/rubbycop/cop/lint/useless_assignment.rb +132 -0
- data/lib/rubbycop/cop/lint/useless_comparison.rb +28 -0
- data/lib/rubbycop/cop/lint/useless_else_without_rescue.rb +46 -0
- data/lib/rubbycop/cop/lint/useless_setter_call.rb +162 -0
- data/lib/rubbycop/cop/lint/void.rb +108 -0
- data/lib/rubbycop/cop/message_annotator.rb +116 -0
- data/lib/rubbycop/cop/metrics/abc_size.rb +39 -0
- data/lib/rubbycop/cop/metrics/block_length.rb +32 -0
- data/lib/rubbycop/cop/metrics/block_nesting.rb +64 -0
- data/lib/rubbycop/cop/metrics/class_length.rb +24 -0
- data/lib/rubbycop/cop/metrics/cyclomatic_complexity.rb +31 -0
- data/lib/rubbycop/cop/metrics/line_length.rb +168 -0
- data/lib/rubbycop/cop/metrics/method_length.rb +27 -0
- data/lib/rubbycop/cop/metrics/module_length.rb +24 -0
- data/lib/rubbycop/cop/metrics/parameter_lists.rb +45 -0
- data/lib/rubbycop/cop/metrics/perceived_complexity.rb +61 -0
- data/lib/rubbycop/cop/mixin/access_modifier_node.rb +41 -0
- data/lib/rubbycop/cop/mixin/annotation_comment.rb +36 -0
- data/lib/rubbycop/cop/mixin/array_hash_indentation.rb +82 -0
- data/lib/rubbycop/cop/mixin/array_min_size.rb +59 -0
- data/lib/rubbycop/cop/mixin/array_syntax.rb +15 -0
- data/lib/rubbycop/cop/mixin/autocorrect_alignment.rb +149 -0
- data/lib/rubbycop/cop/mixin/check_assignment.rb +40 -0
- data/lib/rubbycop/cop/mixin/classish_length.rb +36 -0
- data/lib/rubbycop/cop/mixin/code_length.rb +32 -0
- data/lib/rubbycop/cop/mixin/configurable_enforced_style.rb +97 -0
- data/lib/rubbycop/cop/mixin/configurable_formatting.rb +48 -0
- data/lib/rubbycop/cop/mixin/configurable_max.rb +19 -0
- data/lib/rubbycop/cop/mixin/configurable_naming.rb +16 -0
- data/lib/rubbycop/cop/mixin/configurable_numbering.rb +17 -0
- data/lib/rubbycop/cop/mixin/def_node.rb +27 -0
- data/lib/rubbycop/cop/mixin/documentation_comment.rb +46 -0
- data/lib/rubbycop/cop/mixin/duplication.rb +46 -0
- data/lib/rubbycop/cop/mixin/empty_lines_around_body.rb +161 -0
- data/lib/rubbycop/cop/mixin/end_keyword_alignment.rb +85 -0
- data/lib/rubbycop/cop/mixin/enforce_superclass.rb +36 -0
- data/lib/rubbycop/cop/mixin/first_element_line_break.rb +41 -0
- data/lib/rubbycop/cop/mixin/frozen_string_literal.rb +37 -0
- data/lib/rubbycop/cop/mixin/hash_alignment.rb +116 -0
- data/lib/rubbycop/cop/mixin/ignored_pattern.rb +27 -0
- data/lib/rubbycop/cop/mixin/integer_node.rb +12 -0
- data/lib/rubbycop/cop/mixin/match_range.rb +22 -0
- data/lib/rubbycop/cop/mixin/method_complexity.rb +30 -0
- data/lib/rubbycop/cop/mixin/method_preference.rb +30 -0
- data/lib/rubbycop/cop/mixin/min_body_length.rb +19 -0
- data/lib/rubbycop/cop/mixin/multiline_expression_indentation.rb +183 -0
- data/lib/rubbycop/cop/mixin/multiline_literal_brace_layout.rb +152 -0
- data/lib/rubbycop/cop/mixin/negative_conditional.rb +43 -0
- data/lib/rubbycop/cop/mixin/on_method_def.rb +44 -0
- data/lib/rubbycop/cop/mixin/on_normal_if_unless.rb +14 -0
- data/lib/rubbycop/cop/mixin/parentheses.rb +22 -0
- data/lib/rubbycop/cop/mixin/parser_diagnostic.rb +34 -0
- data/lib/rubbycop/cop/mixin/percent_literal.rb +100 -0
- data/lib/rubbycop/cop/mixin/preceding_following_alignment.rb +89 -0
- data/lib/rubbycop/cop/mixin/rescue_node.rb +21 -0
- data/lib/rubbycop/cop/mixin/safe_assignment.rb +20 -0
- data/lib/rubbycop/cop/mixin/safe_mode.rb +22 -0
- data/lib/rubbycop/cop/mixin/space_after_punctuation.rb +55 -0
- data/lib/rubbycop/cop/mixin/space_before_punctuation.rb +48 -0
- data/lib/rubbycop/cop/mixin/space_inside.rb +76 -0
- data/lib/rubbycop/cop/mixin/statement_modifier.rb +69 -0
- data/lib/rubbycop/cop/mixin/string_help.rb +33 -0
- data/lib/rubbycop/cop/mixin/string_literals_help.rb +33 -0
- data/lib/rubbycop/cop/mixin/surrounding_space.rb +40 -0
- data/lib/rubbycop/cop/mixin/target_rails_version.rb +16 -0
- data/lib/rubbycop/cop/mixin/target_ruby_version.rb +16 -0
- data/lib/rubbycop/cop/mixin/too_many_lines.rb +39 -0
- data/lib/rubbycop/cop/mixin/trailing_comma.rb +161 -0
- data/lib/rubbycop/cop/mixin/unused_argument.rb +42 -0
- data/lib/rubbycop/cop/offense.rb +188 -0
- data/lib/rubbycop/cop/performance/caller.rb +41 -0
- data/lib/rubbycop/cop/performance/case_when_splat.rb +176 -0
- data/lib/rubbycop/cop/performance/casecmp.rb +107 -0
- data/lib/rubbycop/cop/performance/compare_with_block.rb +107 -0
- data/lib/rubbycop/cop/performance/count.rb +98 -0
- data/lib/rubbycop/cop/performance/detect.rb +107 -0
- data/lib/rubbycop/cop/performance/double_start_end_with.rb +102 -0
- data/lib/rubbycop/cop/performance/end_with.rb +55 -0
- data/lib/rubbycop/cop/performance/fixed_size.rb +56 -0
- data/lib/rubbycop/cop/performance/flat_map.rb +73 -0
- data/lib/rubbycop/cop/performance/hash_each_methods.rb +84 -0
- data/lib/rubbycop/cop/performance/lstrip_rstrip.rb +41 -0
- data/lib/rubbycop/cop/performance/range_include.rb +41 -0
- data/lib/rubbycop/cop/performance/redundant_block_call.rb +93 -0
- data/lib/rubbycop/cop/performance/redundant_match.rb +55 -0
- data/lib/rubbycop/cop/performance/redundant_merge.rb +149 -0
- data/lib/rubbycop/cop/performance/redundant_sort_by.rb +45 -0
- data/lib/rubbycop/cop/performance/regexp_match.rb +215 -0
- data/lib/rubbycop/cop/performance/reverse_each.rb +40 -0
- data/lib/rubbycop/cop/performance/sample.rb +140 -0
- data/lib/rubbycop/cop/performance/size.rb +71 -0
- data/lib/rubbycop/cop/performance/start_with.rb +58 -0
- data/lib/rubbycop/cop/performance/string_replacement.rb +170 -0
- data/lib/rubbycop/cop/performance/times_map.rb +61 -0
- data/lib/rubbycop/cop/rails/action_filter.rb +96 -0
- data/lib/rubbycop/cop/rails/active_support_aliases.rb +68 -0
- data/lib/rubbycop/cop/rails/application_job.rb +32 -0
- data/lib/rubbycop/cop/rails/application_record.rb +32 -0
- data/lib/rubbycop/cop/rails/blank.rb +138 -0
- data/lib/rubbycop/cop/rails/date.rb +127 -0
- data/lib/rubbycop/cop/rails/delegate.rb +106 -0
- data/lib/rubbycop/cop/rails/delegate_allow_blank.rb +51 -0
- data/lib/rubbycop/cop/rails/dynamic_find_by.rb +81 -0
- data/lib/rubbycop/cop/rails/enum_uniqueness.rb +43 -0
- data/lib/rubbycop/cop/rails/exit.rb +61 -0
- data/lib/rubbycop/cop/rails/file_path.rb +75 -0
- data/lib/rubbycop/cop/rails/find_by.rb +51 -0
- data/lib/rubbycop/cop/rails/find_each.rb +47 -0
- data/lib/rubbycop/cop/rails/has_and_belongs_to_many.rb +18 -0
- data/lib/rubbycop/cop/rails/http_positional_arguments.rb +106 -0
- data/lib/rubbycop/cop/rails/not_null_column.rb +67 -0
- data/lib/rubbycop/cop/rails/output.rb +23 -0
- data/lib/rubbycop/cop/rails/output_safety.rb +58 -0
- data/lib/rubbycop/cop/rails/pluralization_grammar.rb +106 -0
- data/lib/rubbycop/cop/rails/present.rb +143 -0
- data/lib/rubbycop/cop/rails/read_write_attribute.rb +65 -0
- data/lib/rubbycop/cop/rails/relative_date_constant.rb +88 -0
- data/lib/rubbycop/cop/rails/request_referer.rb +56 -0
- data/lib/rubbycop/cop/rails/reversible_migration.rb +216 -0
- data/lib/rubbycop/cop/rails/safe_navigation.rb +91 -0
- data/lib/rubbycop/cop/rails/save_bang.rb +160 -0
- data/lib/rubbycop/cop/rails/scope_args.rb +29 -0
- data/lib/rubbycop/cop/rails/skips_model_validations.rb +63 -0
- data/lib/rubbycop/cop/rails/time_zone.rb +197 -0
- data/lib/rubbycop/cop/rails/uniq_before_pluck.rb +93 -0
- data/lib/rubbycop/cop/rails/validation.rb +64 -0
- data/lib/rubbycop/cop/registry.rb +171 -0
- data/lib/rubbycop/cop/security/eval.rb +30 -0
- data/lib/rubbycop/cop/security/json_load.rb +44 -0
- data/lib/rubbycop/cop/security/marshal_load.rb +37 -0
- data/lib/rubbycop/cop/security/yaml_load.rb +37 -0
- data/lib/rubbycop/cop/severity.rb +76 -0
- data/lib/rubbycop/cop/style/accessor_method_name.rb +45 -0
- data/lib/rubbycop/cop/style/alias.rb +119 -0
- data/lib/rubbycop/cop/style/and_or.rb +125 -0
- data/lib/rubbycop/cop/style/array_join.rb +30 -0
- data/lib/rubbycop/cop/style/ascii_comments.rb +38 -0
- data/lib/rubbycop/cop/style/ascii_identifiers.rb +36 -0
- data/lib/rubbycop/cop/style/attr.rb +50 -0
- data/lib/rubbycop/cop/style/auto_resource_cleanup.rb +42 -0
- data/lib/rubbycop/cop/style/bare_percent_literals.rb +57 -0
- data/lib/rubbycop/cop/style/begin_block.rb +16 -0
- data/lib/rubbycop/cop/style/block_comments.rb +46 -0
- data/lib/rubbycop/cop/style/block_delimiters.rb +228 -0
- data/lib/rubbycop/cop/style/braces_around_hash_parameters.rb +138 -0
- data/lib/rubbycop/cop/style/case_equality.rb +18 -0
- data/lib/rubbycop/cop/style/character_literal.rb +43 -0
- data/lib/rubbycop/cop/style/class_and_module_camel_case.rb +29 -0
- data/lib/rubbycop/cop/style/class_and_module_children.rb +69 -0
- data/lib/rubbycop/cop/style/class_check.rb +40 -0
- data/lib/rubbycop/cop/style/class_methods.rb +67 -0
- data/lib/rubbycop/cop/style/class_vars.rb +23 -0
- data/lib/rubbycop/cop/style/collection_methods.rb +51 -0
- data/lib/rubbycop/cop/style/colon_method_call.rb +33 -0
- data/lib/rubbycop/cop/style/command_literal.rb +119 -0
- data/lib/rubbycop/cop/style/comment_annotation.rb +62 -0
- data/lib/rubbycop/cop/style/conditional_assignment.rb +691 -0
- data/lib/rubbycop/cop/style/constant_name.rb +29 -0
- data/lib/rubbycop/cop/style/copyright.rb +89 -0
- data/lib/rubbycop/cop/style/def_with_parentheses.rb +31 -0
- data/lib/rubbycop/cop/style/documentation.rb +79 -0
- data/lib/rubbycop/cop/style/documentation_method.rb +80 -0
- data/lib/rubbycop/cop/style/double_negation.rb +35 -0
- data/lib/rubbycop/cop/style/each_for_simple_loop.rb +57 -0
- data/lib/rubbycop/cop/style/each_with_object.rb +91 -0
- data/lib/rubbycop/cop/style/empty_case_condition.rb +84 -0
- data/lib/rubbycop/cop/style/empty_else.rb +138 -0
- data/lib/rubbycop/cop/style/empty_literal.rb +108 -0
- data/lib/rubbycop/cop/style/empty_method.rb +102 -0
- data/lib/rubbycop/cop/style/encoding.rb +92 -0
- data/lib/rubbycop/cop/style/end_block.rb +17 -0
- data/lib/rubbycop/cop/style/even_odd.rb +56 -0
- data/lib/rubbycop/cop/style/file_name.rb +183 -0
- data/lib/rubbycop/cop/style/flip_flop.rb +20 -0
- data/lib/rubbycop/cop/style/for.rb +50 -0
- data/lib/rubbycop/cop/style/format_string.rb +46 -0
- data/lib/rubbycop/cop/style/format_string_token.rb +141 -0
- data/lib/rubbycop/cop/style/frozen_string_literal_comment.rb +96 -0
- data/lib/rubbycop/cop/style/global_vars.rb +70 -0
- data/lib/rubbycop/cop/style/guard_clause.rb +90 -0
- data/lib/rubbycop/cop/style/hash_syntax.rb +214 -0
- data/lib/rubbycop/cop/style/identical_conditional_branches.rb +130 -0
- data/lib/rubbycop/cop/style/if_inside_else.rb +45 -0
- data/lib/rubbycop/cop/style/if_unless_modifier.rb +80 -0
- data/lib/rubbycop/cop/style/if_unless_modifier_of_if_unless.rb +38 -0
- data/lib/rubbycop/cop/style/if_with_semicolon.rb +20 -0
- data/lib/rubbycop/cop/style/implicit_runtime_error.rb +31 -0
- data/lib/rubbycop/cop/style/infinite_loop.rb +91 -0
- data/lib/rubbycop/cop/style/inline_comment.rb +32 -0
- data/lib/rubbycop/cop/style/inverse_methods.rb +130 -0
- data/lib/rubbycop/cop/style/lambda.rb +209 -0
- data/lib/rubbycop/cop/style/lambda_call.rb +66 -0
- data/lib/rubbycop/cop/style/line_end_concatenation.rb +115 -0
- data/lib/rubbycop/cop/style/method_call_with_args_parentheses.rb +107 -0
- data/lib/rubbycop/cop/style/method_call_without_args_parentheses.rb +75 -0
- data/lib/rubbycop/cop/style/method_called_on_do_end_block.rb +44 -0
- data/lib/rubbycop/cop/style/method_def_parentheses.rb +83 -0
- data/lib/rubbycop/cop/style/method_missing.rb +81 -0
- data/lib/rubbycop/cop/style/method_name.rb +28 -0
- data/lib/rubbycop/cop/style/missing_else.rb +100 -0
- data/lib/rubbycop/cop/style/mixin_grouping.rb +135 -0
- data/lib/rubbycop/cop/style/module_function.rb +64 -0
- data/lib/rubbycop/cop/style/multiline_block_chain.rb +42 -0
- data/lib/rubbycop/cop/style/multiline_if_modifier.rb +63 -0
- data/lib/rubbycop/cop/style/multiline_if_then.rb +47 -0
- data/lib/rubbycop/cop/style/multiline_memoization.rb +77 -0
- data/lib/rubbycop/cop/style/multiline_ternary_operator.rb +19 -0
- data/lib/rubbycop/cop/style/mutable_constant.rb +68 -0
- data/lib/rubbycop/cop/style/negated_if.rb +103 -0
- data/lib/rubbycop/cop/style/negated_while.rb +32 -0
- data/lib/rubbycop/cop/style/nested_modifier.rb +87 -0
- data/lib/rubbycop/cop/style/nested_parenthesized_calls.rb +61 -0
- data/lib/rubbycop/cop/style/nested_ternary_operator.rb +21 -0
- data/lib/rubbycop/cop/style/next.rb +225 -0
- data/lib/rubbycop/cop/style/nil_comparison.rb +35 -0
- data/lib/rubbycop/cop/style/non_nil_check.rb +121 -0
- data/lib/rubbycop/cop/style/not.rb +69 -0
- data/lib/rubbycop/cop/style/numeric_literal_prefix.rb +97 -0
- data/lib/rubbycop/cop/style/numeric_literals.rb +101 -0
- data/lib/rubbycop/cop/style/numeric_predicate.rb +140 -0
- data/lib/rubbycop/cop/style/one_line_conditional.rb +75 -0
- data/lib/rubbycop/cop/style/op_method.rb +41 -0
- data/lib/rubbycop/cop/style/option_hash.rb +58 -0
- data/lib/rubbycop/cop/style/optional_arguments.rb +62 -0
- data/lib/rubbycop/cop/style/parallel_assignment.rb +287 -0
- data/lib/rubbycop/cop/style/parentheses_around_condition.rb +56 -0
- data/lib/rubbycop/cop/style/percent_literal_delimiters.rb +100 -0
- data/lib/rubbycop/cop/style/percent_q_literals.rb +52 -0
- data/lib/rubbycop/cop/style/perl_backrefs.rb +31 -0
- data/lib/rubbycop/cop/style/predicate_name.rb +67 -0
- data/lib/rubbycop/cop/style/preferred_hash_methods.rb +78 -0
- data/lib/rubbycop/cop/style/proc.rb +26 -0
- data/lib/rubbycop/cop/style/raise_args.rb +140 -0
- data/lib/rubbycop/cop/style/redundant_begin.rb +47 -0
- data/lib/rubbycop/cop/style/redundant_exception.rb +55 -0
- data/lib/rubbycop/cop/style/redundant_freeze.rb +45 -0
- data/lib/rubbycop/cop/style/redundant_parentheses.rb +199 -0
- data/lib/rubbycop/cop/style/redundant_return.rb +121 -0
- data/lib/rubbycop/cop/style/redundant_self.rb +144 -0
- data/lib/rubbycop/cop/style/regexp_literal.rb +114 -0
- data/lib/rubbycop/cop/style/rescue_modifier.rb +37 -0
- data/lib/rubbycop/cop/style/safe_navigation.rb +145 -0
- data/lib/rubbycop/cop/style/self_assignment.rb +93 -0
- data/lib/rubbycop/cop/style/semicolon.rb +70 -0
- data/lib/rubbycop/cop/style/send.rb +21 -0
- data/lib/rubbycop/cop/style/signal_exception.rb +109 -0
- data/lib/rubbycop/cop/style/single_line_block_params.rb +68 -0
- data/lib/rubbycop/cop/style/single_line_methods.rb +77 -0
- data/lib/rubbycop/cop/style/special_global_vars.rb +156 -0
- data/lib/rubbycop/cop/style/stabby_lambda_parentheses.rb +113 -0
- data/lib/rubbycop/cop/style/string_literals.rb +102 -0
- data/lib/rubbycop/cop/style/string_literals_in_interpolation.rb +30 -0
- data/lib/rubbycop/cop/style/string_methods.rb +34 -0
- data/lib/rubbycop/cop/style/struct_inheritance.rb +32 -0
- data/lib/rubbycop/cop/style/symbol_array.rb +109 -0
- data/lib/rubbycop/cop/style/symbol_literal.rb +32 -0
- data/lib/rubbycop/cop/style/symbol_proc.rb +143 -0
- data/lib/rubbycop/cop/style/ternary_parentheses.rb +200 -0
- data/lib/rubbycop/cop/style/trailing_comma_in_arguments.rb +64 -0
- data/lib/rubbycop/cop/style/trailing_comma_in_literal.rb +56 -0
- data/lib/rubbycop/cop/style/trailing_underscore_variable.rb +113 -0
- data/lib/rubbycop/cop/style/trivial_accessors.rb +176 -0
- data/lib/rubbycop/cop/style/unless_else.rb +39 -0
- data/lib/rubbycop/cop/style/unneeded_capital_w.rb +41 -0
- data/lib/rubbycop/cop/style/unneeded_interpolation.rb +98 -0
- data/lib/rubbycop/cop/style/unneeded_percent_q.rb +96 -0
- data/lib/rubbycop/cop/style/variable_interpolation.rb +44 -0
- data/lib/rubbycop/cop/style/variable_name.rb +39 -0
- data/lib/rubbycop/cop/style/variable_number.rb +78 -0
- data/lib/rubbycop/cop/style/when_then.rb +24 -0
- data/lib/rubbycop/cop/style/while_until_do.rb +36 -0
- data/lib/rubbycop/cop/style/while_until_modifier.rb +41 -0
- data/lib/rubbycop/cop/style/word_array.rb +114 -0
- data/lib/rubbycop/cop/style/zero_length_predicate.rb +90 -0
- data/lib/rubbycop/cop/team.rb +193 -0
- data/lib/rubbycop/cop/util.rb +309 -0
- data/lib/rubbycop/cop/variable_force.rb +458 -0
- data/lib/rubbycop/cop/variable_force/assignment.rb +90 -0
- data/lib/rubbycop/cop/variable_force/branch.rb +318 -0
- data/lib/rubbycop/cop/variable_force/branchable.rb +21 -0
- data/lib/rubbycop/cop/variable_force/reference.rb +49 -0
- data/lib/rubbycop/cop/variable_force/scope.rb +107 -0
- data/lib/rubbycop/cop/variable_force/variable.rb +103 -0
- data/lib/rubbycop/cop/variable_force/variable_table.rb +128 -0
- data/lib/rubbycop/error.rb +11 -0
- data/lib/rubbycop/formatter/base_formatter.rb +123 -0
- data/lib/rubbycop/formatter/clang_style_formatter.rb +54 -0
- data/lib/rubbycop/formatter/colorizable.rb +41 -0
- data/lib/rubbycop/formatter/disabled_config_formatter.rb +181 -0
- data/lib/rubbycop/formatter/disabled_lines_formatter.rb +57 -0
- data/lib/rubbycop/formatter/emacs_style_formatter.rb +24 -0
- data/lib/rubbycop/formatter/file_list_formatter.rb +19 -0
- data/lib/rubbycop/formatter/formatter_set.rb +102 -0
- data/lib/rubbycop/formatter/fuubar_style_formatter.rb +80 -0
- data/lib/rubbycop/formatter/html_formatter.rb +134 -0
- data/lib/rubbycop/formatter/json_formatter.rb +74 -0
- data/lib/rubbycop/formatter/offense_count_formatter.rb +55 -0
- data/lib/rubbycop/formatter/progress_formatter.rb +63 -0
- data/lib/rubbycop/formatter/simple_text_formatter.rb +136 -0
- data/lib/rubbycop/formatter/text_util.rb +20 -0
- data/lib/rubbycop/formatter/worst_offenders_formatter.rb +60 -0
- data/lib/rubbycop/magic_comment.rb +210 -0
- data/lib/rubbycop/name_similarity.rb +21 -0
- data/lib/rubbycop/node_pattern.rb +543 -0
- data/lib/rubbycop/options.rb +355 -0
- data/lib/rubbycop/path_util.rb +36 -0
- data/lib/rubbycop/platform.rb +11 -0
- data/lib/rubbycop/processed_source.rb +151 -0
- data/lib/rubbycop/rake_task.rb +86 -0
- data/lib/rubbycop/remote_config.rb +78 -0
- data/lib/rubbycop/result_cache.rb +176 -0
- data/lib/rubbycop/rspec/cop_helper.rb +98 -0
- data/lib/rubbycop/rspec/host_environment_simulation_helper.rb +32 -0
- data/lib/rubbycop/rspec/shared_contexts.rb +98 -0
- data/lib/rubbycop/rspec/shared_examples.rb +92 -0
- data/lib/rubbycop/rspec/support.rb +8 -0
- data/lib/rubbycop/runner.rb +338 -0
- data/lib/rubbycop/string_interpreter.rb +57 -0
- data/lib/rubbycop/string_util.rb +156 -0
- data/lib/rubbycop/target_finder.rb +201 -0
- data/lib/rubbycop/token.rb +25 -0
- data/lib/rubbycop/version.rb +19 -0
- data/lib/rubbycop/warning.rb +11 -0
- metadata +663 -0
@@ -0,0 +1,27 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
module Metrics
|
6
|
+
# This cop checks if the length of a method exceeds some maximum value.
|
7
|
+
# Comment lines can optionally be ignored.
|
8
|
+
# The maximum allowed length is configurable.
|
9
|
+
class MethodLength < Cop
|
10
|
+
include OnMethodDef
|
11
|
+
include TooManyLines
|
12
|
+
|
13
|
+
LABEL = 'Method'.freeze
|
14
|
+
|
15
|
+
private
|
16
|
+
|
17
|
+
def on_method_def(node, _method_name, _args, _body)
|
18
|
+
check_code_length(node)
|
19
|
+
end
|
20
|
+
|
21
|
+
def cop_label
|
22
|
+
LABEL
|
23
|
+
end
|
24
|
+
end
|
25
|
+
end
|
26
|
+
end
|
27
|
+
end
|
@@ -0,0 +1,24 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
module Metrics
|
6
|
+
# This cop checks if the length a module exceeds some maximum value.
|
7
|
+
# Comment lines can optionally be ignored.
|
8
|
+
# The maximum allowed length is configurable.
|
9
|
+
class ModuleLength < Cop
|
10
|
+
include ClassishLength
|
11
|
+
|
12
|
+
def on_module(node)
|
13
|
+
check_code_length(node)
|
14
|
+
end
|
15
|
+
|
16
|
+
private
|
17
|
+
|
18
|
+
def message(length, max_length)
|
19
|
+
format('Module has too many lines. [%d/%d]', length, max_length)
|
20
|
+
end
|
21
|
+
end
|
22
|
+
end
|
23
|
+
end
|
24
|
+
end
|
@@ -0,0 +1,45 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
module Metrics
|
6
|
+
# This cop checks for methods with too many parameters.
|
7
|
+
# The maximum number of parameters is configurable.
|
8
|
+
# On Ruby 2.0+ keyword arguments can optionally
|
9
|
+
# be excluded from the total count.
|
10
|
+
class ParameterLists < Cop
|
11
|
+
include ConfigurableMax
|
12
|
+
|
13
|
+
MSG = 'Avoid parameter lists longer than %d parameters. [%d/%d]'.freeze
|
14
|
+
|
15
|
+
def on_args(node)
|
16
|
+
count = args_count(node)
|
17
|
+
return unless count > max_params
|
18
|
+
|
19
|
+
message = format(MSG, max_params, count, max_params)
|
20
|
+
add_offense(node, :expression, message) do
|
21
|
+
self.max = count
|
22
|
+
end
|
23
|
+
end
|
24
|
+
|
25
|
+
private
|
26
|
+
|
27
|
+
def args_count(node)
|
28
|
+
if count_keyword_args?
|
29
|
+
node.children.size
|
30
|
+
else
|
31
|
+
node.children.count { |a| !%i[kwoptarg kwarg].include?(a.type) }
|
32
|
+
end
|
33
|
+
end
|
34
|
+
|
35
|
+
def max_params
|
36
|
+
cop_config['Max']
|
37
|
+
end
|
38
|
+
|
39
|
+
def count_keyword_args?
|
40
|
+
cop_config['CountKeywordArgs']
|
41
|
+
end
|
42
|
+
end
|
43
|
+
end
|
44
|
+
end
|
45
|
+
end
|
@@ -0,0 +1,61 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
module Metrics
|
6
|
+
# This cop tries to produce a complexity score that's a measure of the
|
7
|
+
# complexity the reader experiences when looking at a method. For that
|
8
|
+
# reason it considers `when` nodes as something that doesn't add as much
|
9
|
+
# complexity as an `if` or a `&&`. Except if it's one of those special
|
10
|
+
# `case`/`when` constructs where there's no expression after `case`. Then
|
11
|
+
# the cop treats it as an `if`/`elsif`/`elsif`... and lets all the `when`
|
12
|
+
# nodes count. In contrast to the CyclomaticComplexity cop, this cop
|
13
|
+
# considers `else` nodes as adding complexity.
|
14
|
+
#
|
15
|
+
# @example
|
16
|
+
#
|
17
|
+
# def my_method # 1
|
18
|
+
# if cond # 1
|
19
|
+
# case var # 2 (0.8 + 4 * 0.2, rounded)
|
20
|
+
# when 1 then func_one
|
21
|
+
# when 2 then func_two
|
22
|
+
# when 3 then func_three
|
23
|
+
# when 4..10 then func_other
|
24
|
+
# end
|
25
|
+
# else # 1
|
26
|
+
# do_something until a && b # 2
|
27
|
+
# end # ===
|
28
|
+
# end # 7 complexity points
|
29
|
+
class PerceivedComplexity < Cop
|
30
|
+
include MethodComplexity
|
31
|
+
|
32
|
+
MSG = 'Perceived complexity for %s is too high. [%d/%d]'.freeze
|
33
|
+
COUNTED_NODES = %i[if case while until
|
34
|
+
for rescue and or].freeze
|
35
|
+
|
36
|
+
private
|
37
|
+
|
38
|
+
def complexity_score_for(node)
|
39
|
+
case node.type
|
40
|
+
when :case
|
41
|
+
expression, *whens, _else = *node
|
42
|
+
# If cond is nil, that means each when has an expression that
|
43
|
+
# evaluates to true or false. It's just an alternative to
|
44
|
+
# if/elsif/elsif... so the when nodes count.
|
45
|
+
if expression.nil?
|
46
|
+
whens.length
|
47
|
+
else
|
48
|
+
# Otherwise, the case node gets 0.8 complexity points and each
|
49
|
+
# when gets 0.2.
|
50
|
+
(0.8 + 0.2 * whens.length).round
|
51
|
+
end
|
52
|
+
when :if
|
53
|
+
node.else? && !node.elsif? ? 2 : 1
|
54
|
+
else
|
55
|
+
1
|
56
|
+
end
|
57
|
+
end
|
58
|
+
end
|
59
|
+
end
|
60
|
+
end
|
61
|
+
end
|
@@ -0,0 +1,41 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
# Common functionality for checking modifier nodes.
|
6
|
+
module AccessModifierNode
|
7
|
+
extend NodePattern::Macros
|
8
|
+
|
9
|
+
def_node_matcher :private_node?, '(send nil :private)'
|
10
|
+
def_node_matcher :protected_node?, '(send nil :protected)'
|
11
|
+
def_node_matcher :public_node?, '(send nil :public)'
|
12
|
+
def_node_matcher :module_function_node?, '(send nil :module_function)'
|
13
|
+
|
14
|
+
# Returns true when the node is an access modifier.
|
15
|
+
def modifier_node?(node)
|
16
|
+
modifier_structure?(node) && class_or_module_parent?(node)
|
17
|
+
end
|
18
|
+
|
19
|
+
# Returns true when the node looks like an access modifier.
|
20
|
+
def modifier_structure?(node)
|
21
|
+
private_node?(node) ||
|
22
|
+
protected_node?(node) ||
|
23
|
+
public_node?(node) ||
|
24
|
+
module_function_node?(node)
|
25
|
+
end
|
26
|
+
|
27
|
+
# Returns true when the parent of what looks like an access modifier
|
28
|
+
# is a Class or Module. Filters out simple method calls to similarly
|
29
|
+
# named private, protected or public.
|
30
|
+
def class_or_module_parent?(node)
|
31
|
+
node.each_ancestor do |ancestor|
|
32
|
+
if ancestor.block_type?
|
33
|
+
return true if ancestor.class_constructor?
|
34
|
+
elsif !ancestor.begin_type?
|
35
|
+
return %i[casgn sclass class module].include?(ancestor.type)
|
36
|
+
end
|
37
|
+
end
|
38
|
+
end
|
39
|
+
end
|
40
|
+
end
|
41
|
+
end
|
@@ -0,0 +1,36 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
module Style
|
6
|
+
# Common functionality related to annotation comments.
|
7
|
+
module AnnotationComment
|
8
|
+
private
|
9
|
+
|
10
|
+
def annotation?(comment)
|
11
|
+
_margin, first_word, colon, space, note = split_comment(comment)
|
12
|
+
keyword_appearance?(first_word, colon, space) &&
|
13
|
+
!just_first_word_of_sentence?(first_word, colon, space, note)
|
14
|
+
end
|
15
|
+
|
16
|
+
def split_comment(comment)
|
17
|
+
match = comment.text.match(/^(# ?)([A-Za-z]+)(\s*:)?(\s+)?(\S+)?/)
|
18
|
+
return false unless match
|
19
|
+
match.captures
|
20
|
+
end
|
21
|
+
|
22
|
+
def keyword_appearance?(first_word, colon, space)
|
23
|
+
first_word && keyword?(first_word.upcase) && (colon || space)
|
24
|
+
end
|
25
|
+
|
26
|
+
def just_first_word_of_sentence?(first_word, colon, space, note)
|
27
|
+
first_word == first_word.capitalize && !colon && space && note
|
28
|
+
end
|
29
|
+
|
30
|
+
def keyword?(word)
|
31
|
+
config.for_cop('Style/CommentAnnotation')['Keywords'].include?(word)
|
32
|
+
end
|
33
|
+
end
|
34
|
+
end
|
35
|
+
end
|
36
|
+
end
|
@@ -0,0 +1,82 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
# Common code for indenting literal arrays and hashes.
|
6
|
+
module ArrayHashIndentation
|
7
|
+
def each_argument_node(node, type)
|
8
|
+
left_parenthesis = node.loc.begin
|
9
|
+
|
10
|
+
return unless left_parenthesis
|
11
|
+
|
12
|
+
node.arguments.each do |arg|
|
13
|
+
on_node(type, arg, :send) do |type_node|
|
14
|
+
left_brace = type_node.loc.begin
|
15
|
+
if left_brace && left_brace.line == left_parenthesis.line
|
16
|
+
yield type_node, left_parenthesis
|
17
|
+
ignore_node(type_node)
|
18
|
+
end
|
19
|
+
end
|
20
|
+
end
|
21
|
+
end
|
22
|
+
|
23
|
+
def check_first(first, left_brace, left_parenthesis, offset)
|
24
|
+
actual_column = first.source_range.column
|
25
|
+
expected_column = base_column(left_brace, left_parenthesis) +
|
26
|
+
configured_indentation_width + offset
|
27
|
+
@column_delta = expected_column - actual_column
|
28
|
+
styles =
|
29
|
+
detected_styles(actual_column, offset, left_parenthesis, left_brace)
|
30
|
+
|
31
|
+
if @column_delta.zero?
|
32
|
+
check_expected_style(styles)
|
33
|
+
else
|
34
|
+
incorrect_style_detected(styles, first, left_parenthesis)
|
35
|
+
end
|
36
|
+
end
|
37
|
+
|
38
|
+
def check_expected_style(styles)
|
39
|
+
if styles.size > 1
|
40
|
+
ambiguous_style_detected(*styles)
|
41
|
+
else
|
42
|
+
correct_style_detected
|
43
|
+
end
|
44
|
+
end
|
45
|
+
|
46
|
+
def base_column(left_brace, left_parenthesis)
|
47
|
+
if style == brace_alignment_style
|
48
|
+
left_brace.column
|
49
|
+
elsif left_parenthesis && style == :special_inside_parentheses
|
50
|
+
left_parenthesis.column + 1
|
51
|
+
else
|
52
|
+
left_brace.source_line =~ /\S/
|
53
|
+
end
|
54
|
+
end
|
55
|
+
|
56
|
+
def detected_styles(actual_column, offset, left_parenthesis, left_brace)
|
57
|
+
base_column = actual_column - configured_indentation_width - offset
|
58
|
+
detected_styles_for_column(base_column, left_parenthesis, left_brace)
|
59
|
+
end
|
60
|
+
|
61
|
+
def detected_styles_for_column(column, left_parenthesis, left_brace)
|
62
|
+
styles = []
|
63
|
+
if column == (left_brace.source_line =~ /\S/)
|
64
|
+
styles << :consistent
|
65
|
+
styles << :special_inside_parentheses unless left_parenthesis
|
66
|
+
end
|
67
|
+
if left_parenthesis && column == left_parenthesis.column + 1
|
68
|
+
styles << :special_inside_parentheses
|
69
|
+
end
|
70
|
+
styles << brace_alignment_style if column == left_brace.column
|
71
|
+
styles
|
72
|
+
end
|
73
|
+
|
74
|
+
def incorrect_style_detected(styles, first, left_parenthesis)
|
75
|
+
add_offense(first, :expression,
|
76
|
+
message(base_description(left_parenthesis))) do
|
77
|
+
ambiguous_style_detected(*styles)
|
78
|
+
end
|
79
|
+
end
|
80
|
+
end
|
81
|
+
end
|
82
|
+
end
|
@@ -0,0 +1,59 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
# Handles the `MinSize` configuration option for array-based cops
|
6
|
+
# `Style/SymbolArray` and `Style/WordArray`, which check for use of the
|
7
|
+
# relevant percent literal syntax such as `%i[...]` and `%w[...]`
|
8
|
+
module ArrayMinSize
|
9
|
+
private
|
10
|
+
|
11
|
+
def below_array_length?(node)
|
12
|
+
node.values.length < min_size_config
|
13
|
+
end
|
14
|
+
|
15
|
+
def min_size_config
|
16
|
+
cop_config['MinSize']
|
17
|
+
end
|
18
|
+
|
19
|
+
def array_style_detected(style, ary_size)
|
20
|
+
cfg = config_to_allow_offenses
|
21
|
+
return if cfg['Enabled'] == false
|
22
|
+
|
23
|
+
largest_brackets = largest_brackets_size(style, ary_size)
|
24
|
+
smallest_percent = smallest_percent_size(style, ary_size)
|
25
|
+
|
26
|
+
if cfg['EnforcedStyle'] == style.to_s
|
27
|
+
# do nothing
|
28
|
+
elsif cfg['EnforcedStyle'].nil?
|
29
|
+
cfg['EnforcedStyle'] = style.to_s
|
30
|
+
elsif smallest_percent <= largest_brackets
|
31
|
+
self.config_to_allow_offenses = { 'Enabled' => false }
|
32
|
+
else
|
33
|
+
cfg['EnforcedStyle'] = 'percent'
|
34
|
+
cfg['MinSize'] = largest_brackets + 1
|
35
|
+
end
|
36
|
+
end
|
37
|
+
|
38
|
+
def largest_brackets_size(style, ary_size)
|
39
|
+
self.class.largest_brackets ||= -Float::INFINITY
|
40
|
+
|
41
|
+
if style == :brackets && ary_size > self.class.largest_brackets
|
42
|
+
self.class.largest_brackets = ary_size
|
43
|
+
end
|
44
|
+
|
45
|
+
self.class.largest_brackets
|
46
|
+
end
|
47
|
+
|
48
|
+
def smallest_percent_size(style, ary_size)
|
49
|
+
@smallest_percent ||= Float::INFINITY
|
50
|
+
|
51
|
+
if style == :percent && ary_size < @smallest_percent
|
52
|
+
@smallest_percent = ary_size
|
53
|
+
end
|
54
|
+
|
55
|
+
@smallest_percent
|
56
|
+
end
|
57
|
+
end
|
58
|
+
end
|
59
|
+
end
|
@@ -0,0 +1,15 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
# Common code for ordinary arrays with [] that can be written with %
|
6
|
+
# syntax.
|
7
|
+
module ArraySyntax
|
8
|
+
def bracketed_array_of?(element_type, node)
|
9
|
+
return false unless node.square_brackets? && node.values.size > 1
|
10
|
+
|
11
|
+
node.values.all? { |value| value.type == element_type }
|
12
|
+
end
|
13
|
+
end
|
14
|
+
end
|
15
|
+
end
|
@@ -0,0 +1,149 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RubbyCop
|
4
|
+
module Cop
|
5
|
+
# This module does auto-correction of nodes that should just be moved to
|
6
|
+
# the left or to the right, amount being determined by the instance
|
7
|
+
# variable @column_delta.
|
8
|
+
module AutocorrectAlignment
|
9
|
+
SPACE = ' '.freeze
|
10
|
+
|
11
|
+
def configured_indentation_width
|
12
|
+
cop_config['IndentationWidth'] ||
|
13
|
+
config.for_cop('IndentationWidth')['Width']
|
14
|
+
end
|
15
|
+
|
16
|
+
def indentation(node)
|
17
|
+
offset(node) + (SPACE * configured_indentation_width)
|
18
|
+
end
|
19
|
+
|
20
|
+
def offset(node)
|
21
|
+
SPACE * node.loc.column
|
22
|
+
end
|
23
|
+
|
24
|
+
def display_column(range)
|
25
|
+
line = processed_source.lines[range.line - 1]
|
26
|
+
Unicode::DisplayWidth.of(line[0, range.column])
|
27
|
+
end
|
28
|
+
|
29
|
+
def check_alignment(items, base_column = nil)
|
30
|
+
unless items.empty?
|
31
|
+
base_column ||= display_column(items.first.source_range)
|
32
|
+
end
|
33
|
+
|
34
|
+
each_bad_alignment(items, base_column) do |current|
|
35
|
+
expr = current.source_range
|
36
|
+
if offenses.any? { |o| within?(expr, o.location) }
|
37
|
+
# If this offense is within a line range that is already being
|
38
|
+
# realigned by autocorrect, we report the offense without
|
39
|
+
# autocorrecting it. Two rewrites in the same area by the same
|
40
|
+
# cop can not be handled. The next iteration will find the
|
41
|
+
# offense again and correct it.
|
42
|
+
add_offense(nil, expr)
|
43
|
+
else
|
44
|
+
add_offense(current, :expression)
|
45
|
+
end
|
46
|
+
end
|
47
|
+
end
|
48
|
+
|
49
|
+
def autocorrect(arg)
|
50
|
+
return unless arg
|
51
|
+
|
52
|
+
heredoc_ranges = heredoc_ranges(arg)
|
53
|
+
expr = arg.respond_to?(:loc) ? arg.loc.expression : arg
|
54
|
+
|
55
|
+
# We can't use the instance variable inside the lambda. That would just
|
56
|
+
# give each lambda the same reference and they would all get the last
|
57
|
+
# value of @column_delta. A local variable fixes the problem.
|
58
|
+
column_delta = @column_delta
|
59
|
+
|
60
|
+
return if block_comment_within?(expr)
|
61
|
+
|
62
|
+
lambda do |corrector|
|
63
|
+
each_line(expr) do |line_begin_pos|
|
64
|
+
autocorrect_line(corrector, line_begin_pos, expr, column_delta,
|
65
|
+
heredoc_ranges)
|
66
|
+
end
|
67
|
+
end
|
68
|
+
end
|
69
|
+
|
70
|
+
private
|
71
|
+
|
72
|
+
def each_bad_alignment(items, base_column)
|
73
|
+
prev_line = -1
|
74
|
+
items.each do |current|
|
75
|
+
if current.loc.line > prev_line &&
|
76
|
+
begins_its_line?(current.source_range)
|
77
|
+
@column_delta = base_column - display_column(current.source_range)
|
78
|
+
|
79
|
+
yield current if @column_delta.nonzero?
|
80
|
+
end
|
81
|
+
prev_line = current.loc.line
|
82
|
+
end
|
83
|
+
end
|
84
|
+
|
85
|
+
def autocorrect_line(corrector, line_begin_pos, expr, column_delta,
|
86
|
+
heredoc_ranges)
|
87
|
+
range = calculate_range(expr, line_begin_pos, column_delta)
|
88
|
+
# We must not change indentation of heredoc strings.
|
89
|
+
return if heredoc_ranges.any? { |h| within?(range, h) }
|
90
|
+
|
91
|
+
if column_delta > 0
|
92
|
+
unless range.source == "\n"
|
93
|
+
corrector.insert_before(range, ' ' * column_delta)
|
94
|
+
end
|
95
|
+
elsif range.source =~ /\A[ \t]+\z/
|
96
|
+
remove(range, corrector)
|
97
|
+
end
|
98
|
+
end
|
99
|
+
|
100
|
+
def heredoc_ranges(arg)
|
101
|
+
return [] unless arg.is_a?(Parser::AST::Node)
|
102
|
+
|
103
|
+
arg.each_node(:dstr)
|
104
|
+
.select { |n| n.loc.respond_to?(:heredoc_body) }
|
105
|
+
.map { |n| n.loc.heredoc_body.join(n.loc.heredoc_end) }
|
106
|
+
end
|
107
|
+
|
108
|
+
def block_comment_within?(expr)
|
109
|
+
processed_source.comments.select(&:document?).any? do |c|
|
110
|
+
within?(c.loc.expression, expr)
|
111
|
+
end
|
112
|
+
end
|
113
|
+
|
114
|
+
def within?(inner, outer)
|
115
|
+
inner.begin_pos >= outer.begin_pos && inner.end_pos <= outer.end_pos
|
116
|
+
end
|
117
|
+
|
118
|
+
def calculate_range(expr, line_begin_pos, column_delta)
|
119
|
+
starts_with_space = expr.source_buffer.source[line_begin_pos] =~ / /
|
120
|
+
pos_to_remove = if column_delta > 0 || starts_with_space
|
121
|
+
line_begin_pos
|
122
|
+
else
|
123
|
+
line_begin_pos - column_delta.abs
|
124
|
+
end
|
125
|
+
|
126
|
+
range_between(pos_to_remove, pos_to_remove + column_delta.abs)
|
127
|
+
end
|
128
|
+
|
129
|
+
def remove(range, corrector)
|
130
|
+
original_stderr = $stderr
|
131
|
+
$stderr = StringIO.new # Avoid error messages on console
|
132
|
+
corrector.remove(range)
|
133
|
+
rescue RuntimeError
|
134
|
+
range = range_between(range.begin_pos + 1, range.end_pos + 1)
|
135
|
+
retry if range.source =~ /^ +$/
|
136
|
+
ensure
|
137
|
+
$stderr = original_stderr
|
138
|
+
end
|
139
|
+
|
140
|
+
def each_line(expr)
|
141
|
+
line_begin_pos = expr.begin_pos
|
142
|
+
expr.source.each_line do |line|
|
143
|
+
yield line_begin_pos
|
144
|
+
line_begin_pos += line.length
|
145
|
+
end
|
146
|
+
end
|
147
|
+
end
|
148
|
+
end
|
149
|
+
end
|