ruact 0.0.5 → 0.0.7

data/spec/ruact/server_bucket_request_spec.rb

@@ -23,10 +23,25 @@ require "rack/test"
 
 require "ruact/controller"
 require "ruact/server"
+require "active_model"
 
 require_relative "controller_request_spec" unless defined?(ControllerRequestSpecSupport)
 
 module ServerBucketSpecSupport
+  # Story 13.3 (FR98) — an ActiveModel record with a presence validation, so a
+  # host action can exercise the non-exception `if record.valid? … else …`
+  # happy-failure path that `ruact_errors` round-trips.
+  class ValidatedPost
+    include ActiveModel::Model
+    include ActiveModel::Attributes
+
+    attribute :title, :string
+
+    validates :title, presence: true
+
+    def self.name = "ValidatedPost"
+  end
+
   # Serializable model — only :id/:title exposed; :secret must never leak.
   class BucketPost
     include Ruact::Serializable
@@ -96,6 +111,33 @@ module ServerBucketSpecSupport
     def unserializable
       @rec = UnserializableRecord.new
     end
+
+    # Story 13.3 (FR98) — opted-in FAILED validation: `ruact_errors(post)` after
+    # an invalid save attempt registers the canonical errors; Bucket-2 injects
+    # them under the reserved `errors` key alongside the serialized ivars.
+    def validated_create_invalid
+      post = ServerBucketSpecSupport::ValidatedPost.new(title: nil)
+      @created = post.valid? # false → populates post.errors
+      ruact_errors(post)
+    end
+
+    # Story 13.3 (FR98) — opted-in SUCCESS: the SAME call path yields
+    # `errors: {}` (success symmetry), so the client reads `result.errors`
+    # uniformly on both branches.
+    def validated_create_valid
+      post = ServerBucketSpecSupport::ValidatedPost.new(title: "Hi")
+      @created = post.valid? # true → post.errors empty
+      ruact_errors(post)
+    end
+
+    # Story 13.3 (FR98) — a stray dev ivar literally named `@errors` must NOT
+    # clobber the reserved round-trip key: the collector is the source of truth.
+    def stray_errors_ivar
+      @errors = "a dev string that must not win"
+      post = ServerBucketSpecSupport::ValidatedPost.new(title: nil)
+      post.valid?
+      ruact_errors(post)
+    end
   end
 
   # Review round 2 — an auth-style before_action that redirects on a Bucket-2
@@ -144,8 +186,31 @@ module ServerBucketSpecSupport
       render json: { token: form_authenticity_token }
     end
   end
+
+  # Story 10.0 (AC5) — the scaffold's resource-controller shape: includes BOTH
+  # Ruact::Controller and Ruact::Server (ApplicationController contributes
+  # Controller; the resource controller adds Server). An ivar-only GET page
+  # action (implicit `default_render`) backed by a conventional template must
+  # flow Server#default_render → super (GET is never a function call) → the
+  # now-fixed Controller#default_render → HTML shell, NOT a 500.
+  class ServerImplicitController < ActionController::Base
+    include Ruact::Controller
+    include Ruact::Server
+
+    def show; end
+  end
 end
 
+# Story 10.0 (AC5) — conventional template under the shared app root so the
+# Server-including controller's implicit GET reaches Controller#default_render.
+ControllerRequestSpecSupport.write_view(
+  "server_bucket_spec_support/server_implicit", "show", <<~ERB
+    <div>
+      <DemoButton label={"hi"} />
+    </div>
+  ERB
+)
+
 if defined?(ControllerRequestSpecSupport) &&
    !ControllerRequestSpecSupport.instance_variable_get(:@__ruact_server_bucket_routes_appended)
   ControllerRequestSpecSupport.instance_variable_set(:@__ruact_server_bucket_routes_appended, true)
@@ -159,9 +224,14 @@ if defined?(ControllerRequestSpecSupport) &&
     post "/bucket/vary_wildcard",   to: "server_bucket_spec_support/bucket_server#vary_wildcard"
     post "/bucket/before_redirect", to: "server_bucket_spec_support/bucket_before_redirect#never_runs"
     post "/bucket/unserializable",  to: "server_bucket_spec_support/bucket_server#unserializable"
+    post "/bucket/validated_create_invalid", to: "server_bucket_spec_support/bucket_server#validated_create_invalid"
+    post "/bucket/validated_create_valid",   to: "server_bucket_spec_support/bucket_server#validated_create_valid"
+    post "/bucket/stray_errors_ivar", to: "server_bucket_spec_support/bucket_server#stray_errors_ivar"
     post "/bucket/dual_redirecting", to: "server_bucket_spec_support/bucket_dual#redirecting"
     post "/bucket/protected", to: "server_bucket_spec_support/bucket_forgery#create_protected"
     get  "/bucket/csrf_token", to: "server_bucket_spec_support/bucket_forgery#csrf_token"
+    # Story 10.0 (AC5) — Server-including controller's implicit GET page action.
+    get  "/server-implicit/show", to: "server_bucket_spec_support/server_implicit#show"
   end
 end
 
@@ -177,6 +247,10 @@ RSpec.describe "Story 9.2: Ruact::Server dual-bucket response negotiation", :sto
   before do
     Rails.logger = Logger.new(IO::NULL)
     ControllerRequestSpecSupport.boot!
+    # Story 10.0 (AC5) — pin Rails.root so the Server-path implicit-render
+    # template (`Rails.root/app/views`) is found regardless of full-suite
+    # ordering leftovers (see controller_request_spec.rb for the rationale).
+    Rails.root = ControllerRequestSpecSupport.app_root
   end
 
   def reset_config
@@ -349,4 +423,72 @@ RSpec.describe "Story 9.2: Ruact::Server dual-bucket response negotiation", :sto
       end
     end
   end
+
+  # Story 13.3 (FR98) — the Bucket-2 (imperative `await`) half of the
+  # Inertia-style validation `errors` round-trip (AC3).
+  describe "Story 13.3: Bucket-2 errors round-trip (FR98)", :story_13_3 do
+    it "FAILED validation injects the canonical errors under the reserved `errors` key" do
+      post "/bucket/validated_create_invalid", "{}", json_headers
+      expect(last_response.status).to eq(200)
+      body = JSON.parse(last_response.body)
+      expect(body).to eq("created" => false, "errors" => { "title" => ["Title can't be blank"] })
+    end
+
+    it "SUCCESS yields `errors: {}` through the same call path (success symmetry)" do
+      post "/bucket/validated_create_valid", "{}", json_headers
+      expect(last_response.status).to eq(200)
+      body = JSON.parse(last_response.body)
+      expect(body).to eq("created" => true, "errors" => {})
+    end
+
+    it "is set with Vary: Accept like every other non-GET shape" do
+      post "/bucket/validated_create_valid", "{}", json_headers
+      expect(last_response.headers["Vary"]).to match(/\bAccept\b/)
+    end
+
+    it "the collector wins over a stray dev ivar literally named @errors" do
+      post "/bucket/stray_errors_ivar", "{}", json_headers
+      expect(last_response.status).to eq(200)
+      body = JSON.parse(last_response.body)
+      expect(body.fetch("errors")).to eq("title" => ["Title can't be blank"])
+    end
+
+    it "preserves the 9.2 untouched-collector contract: an empty opted-out action still 204s" do
+      # `empty_action` never calls `ruact_errors` → no `errors` key, 204 No Content.
+      post "/bucket/empty", "{}", json_headers
+      expect(last_response.status).to eq(204)
+      expect(last_response.body).to eq("")
+    end
+
+    it "preserves the 9.2 untouched-collector contract: a populated action carries NO errors key" do
+      # `with_ivars` sets ivars but never opts in → body has no `errors` key.
+      post "/bucket/with_ivars", "{}", json_headers
+      expect(JSON.parse(last_response.body)).not_to have_key("errors")
+    end
+
+    # AC5(e) coexistence: the RAISED `ActiveRecord::RecordInvalid` path still
+    # renders the structured 422 error payload — proven (unchanged) by
+    # server_rescue_request_spec.rb's `record_invalid` example. 13.3 is the
+    # NON-raised 200 path above; the two contracts stay distinct.
+  end
+
+  # Story 10.0 (AC5) — the Server-path inherits the default_render graceful
+  # degradation fix. A GET is never a function call, so Server#default_render
+  # delegates to super → the fixed Controller#default_render.
+  describe "Story 10.0: Server path inherits non-HTML Accept graceful degradation (AC5)", :story_10_0 do
+    it "GET with Accept: */* returns the HTML shell, not a 500" do
+      get "/server-implicit/show", {}, { "HTTP_ACCEPT" => "*/*" }
+      expect(last_response.status).to(eq(200),
+                                      "expected 200, got #{last_response.status} body=#{last_response.body[0, 400]}")
+      expect(last_response.headers["Content-Type"]).to include("text/html")
+      expect(last_response.body).to include("DemoButton")
+      expect(last_response.body).not_to include("__ruact_component__ called outside a ruact_render flow")
+    end
+
+    it "GET with Accept: text/x-component returns a Flight payload (function-call path untouched)" do
+      get "/server-implicit/show", {}, { "HTTP_ACCEPT" => "text/x-component" }
+      expect(last_response.status).to eq(200)
+      expect(last_response.headers["Content-Type"]).to include("text/x-component")
+    end
+  end
 end

data/spec/ruact/server_function_name_spec.rb

@@ -39,7 +39,7 @@ RSpec.describe "Ruact::Server.ruact_function_name", :story_9_3 do
     end.to raise_error(Ruact::ConfigurationError, /reserved/)
   end
 
-  it "rejects a runtime-bound name (revalidate / _makeRef)" do
+  it "rejects a runtime-bound name (revalidate)" do
     expect do
       host.ruact_function_name(:create, as: "revalidate")
     end.to raise_error(Ruact::ConfigurationError, /reserved|ruact runtime/)