ruact 0.0.2 → 0.0.3

data/spec/ruact/html_converter_spec.rb

@@ -62,10 +62,10 @@ module Ruact
     end
 
     describe "client component via registry" do
-      it "replaces RSC comment placeholder with the registered ReactElement" do
+      it "replaces Ruact comment placeholder with the registered ReactElement" do
         ref      = Flight::ClientReference.new(module_id: "./LikeButton", export_name: "LikeButton")
-        registry = [{ token: "__RSC_0__", name: "LikeButton", ref: ref, props: { "postId" => 1 } }]
-        result   = convert.call("<!-- __RSC_0__ -->", registry)
+        registry = [{ token: "__RUACT_0__", name: "LikeButton", ref: ref, props: { "postId" => 1 } }]
+        result   = convert.call("<!-- __RUACT_0__ -->", registry)
 
         expect(result).to be_a(Flight::ReactElement)
         expect(result.type).to eq(ref)
@@ -74,8 +74,8 @@ module Ruact
 
       it "wraps a client component inside a parent DOM element" do
         ref      = Flight::ClientReference.new(module_id: "./Button", export_name: "Button")
-        registry = [{ token: "__RSC_0__", name: "Button", ref: ref, props: {} }]
-        result   = convert.call('<div class="wrapper"><!-- __RSC_0__ --></div>', registry)
+        registry = [{ token: "__RUACT_0__", name: "Button", ref: ref, props: {} }]
+        result   = convert.call('<div class="wrapper"><!-- __RUACT_0__ --></div>', registry)
 
         expect(result.type).to eq("div")
         child = result.props["children"]
@@ -143,5 +143,183 @@ module Ruact
                                             })
       end
     end
+
+    describe "input validation (Story 7.4)" do
+      describe "nil input" do
+        it "raises Ruact::HtmlConverterError" do
+          expect { described_class.convert(nil) }.to raise_error(Ruact::HtmlConverterError)
+        end
+
+        it "message contains 'received nil; expected a String of HTML'" do
+          expect { described_class.convert(nil) }
+            .to raise_error(Ruact::HtmlConverterError,
+                            /HtmlConverter\.convert received nil; expected a String of HTML/)
+        end
+
+        it "message contains the 'Most likely cause' hint" do
+          expect { described_class.convert(nil) }
+            .to raise_error(Ruact::HtmlConverterError, /Most likely cause:/)
+          expect { described_class.convert(nil) }
+            .to raise_error(Ruact::HtmlConverterError, /missing yield, an empty respond_to branch/)
+        end
+
+        it "message contains the documentation pointer" do
+          expect { described_class.convert(nil) }
+            .to raise_error(Ruact::HtmlConverterError,
+                            /See HtmlConverter\.convert documentation for the canonical contract\./)
+        end
+
+        it "message points at the spec's file:line, not html_converter.rb (Called from)" do
+          expected_line = __LINE__ + 1
+          expect { described_class.convert(nil) }
+            .to raise_error(Ruact::HtmlConverterError,
+                            /Called from: #{Regexp.escape(__FILE__)}:#{expected_line}/)
+        end
+
+        it "does not invoke Nokogiri::HTML::DocumentFragment.parse" do
+          allow(Nokogiri::HTML::DocumentFragment).to receive(:parse).and_call_original
+          expect { described_class.convert(nil) }.to raise_error(Ruact::HtmlConverterError)
+          expect(Nokogiri::HTML::DocumentFragment).not_to have_received(:parse)
+        end
+      end
+
+      describe "non-String inputs" do
+        it "raises with 'got Integer' and 'Received: 42' for an Integer" do
+          expect { described_class.convert(42) }
+            .to raise_error(Ruact::HtmlConverterError,
+                            /HtmlConverter\.convert expected a String of HTML; got Integer/)
+          expect { described_class.convert(42) }
+            .to raise_error(Ruact::HtmlConverterError, /Received: 42/)
+        end
+
+        it "raises with 'got Symbol' for a Symbol" do
+          expect { described_class.convert(:symbol) }
+            .to raise_error(Ruact::HtmlConverterError, /got Symbol/)
+          expect { described_class.convert(:symbol) }
+            .to raise_error(Ruact::HtmlConverterError, /Received: :symbol/)
+        end
+
+        it "raises with 'got Array' for an Array" do
+          expect { described_class.convert(["array"]) }
+            .to raise_error(Ruact::HtmlConverterError, /got Array/)
+          expect { described_class.convert(["array"]) }
+            .to raise_error(Ruact::HtmlConverterError, /Received: \["array"\]/)
+        end
+
+        it "raises with 'got Hash' for a Hash" do
+          expect { described_class.convert({ hash: 1 }) }
+            .to raise_error(Ruact::HtmlConverterError, /got Hash/)
+          expect { described_class.convert({ hash: 1 }) }
+            .to raise_error(Ruact::HtmlConverterError, /Received: \{.*hash.*1.*\}/)
+        end
+
+        it "raises with 'got Object' for a generic Object" do
+          expect { described_class.convert(Object.new) }
+            .to raise_error(Ruact::HtmlConverterError, /got Object/)
+        end
+
+        it "message points at the spec's file:line for non-nil non-String input" do
+          expected_line = __LINE__ + 1
+          expect { described_class.convert(42) }
+            .to raise_error(Ruact::HtmlConverterError,
+                            /Called from: #{Regexp.escape(__FILE__)}:#{expected_line}/)
+        end
+
+        it "truncates large input previews to ≤ 84 chars (80 + '...')" do
+          large_value = (1..10_000).to_a
+          message = nil
+          begin
+            described_class.convert(large_value)
+          rescue Ruact::HtmlConverterError => e
+            message = e.message
+          end
+
+          received_line = message.lines.find { |l| l.include?("Received:") }
+          expect(received_line).not_to be_nil
+          preview = received_line.sub(/^\s*Received:\s/, "").strip
+          expect(preview.length).to be <= 84
+          expect(preview).to end_with("...")
+        end
+      end
+
+      describe "subclasses and edge cases" do
+        it "accepts String subclasses (e.g. ActionView SafeBuffer-like)" do
+          safe_buffer_class = Class.new(String)
+          input = safe_buffer_class.new("<div>hi</div>")
+          expect { described_class.convert(input) }.not_to raise_error
+
+          result = described_class.convert(input)
+          expect(result).to be_a(Ruact::Flight::ReactElement)
+          expect(result.type).to eq("div")
+        end
+
+        it "accepts an empty string without raising" do
+          expect { described_class.convert("") }.not_to raise_error
+        end
+
+        it "raises Ruact::HtmlConverterError (not NoMethodError) for BasicObject inputs" do
+          basic = BasicObject.new
+          expect { described_class.convert(basic) }
+            .to raise_error(Ruact::HtmlConverterError, /HtmlConverter\.convert expected a String of HTML/)
+        end
+
+        it "produces a readable message even when value#inspect raises" do
+          hostile = Class.new do
+            def inspect
+              raise "I refuse to introspect"
+            end
+          end.new
+
+          expect { described_class.convert(hostile) }
+            .to raise_error(Ruact::HtmlConverterError, /Received: <inspect raised>/)
+        end
+
+        it "produces a readable message even when value#class raises (BasicObject)" do
+          basic = BasicObject.new
+          expect { described_class.convert(basic) }
+            .to raise_error(Ruact::HtmlConverterError) do |error|
+              expect(error.message).to include("got ")
+              expect(error.message).not_to match(/got\s*$/)
+            end
+        end
+      end
+
+      describe "backtrace shape" do
+        it "frame 0 of the backtrace points outside the gem" do
+          described_class.convert(nil)
+        rescue Ruact::HtmlConverterError => e
+          expect(e.backtrace.first).not_to include("/lib/ruact/html_converter.rb")
+          expect(e.backtrace.first).to include(__FILE__)
+        end
+
+        it "frame 0 references the test file when called from a spec" do
+          described_class.convert(42)
+        rescue Ruact::HtmlConverterError => e
+          expect(e.backtrace.first).to start_with(__FILE__)
+        end
+      end
+    end
+
+    # Detailed coverage of HtmlConverter input validation (nil + non-String inputs,
+    # backtrace shape, BasicObject handling) lives in the "input validation (Story 7.4)"
+    # block above (lines 147-300). This regression suite is intentionally minimal — two
+    # smoke specs that name the suite for greppability via `:story_7_7` and the
+    # "Story 7.7" describe substring; do NOT duplicate the 7.4 detailed coverage here.
+    describe "edge cases (Story 7.7) — code-review regression suite", :story_7_7 do
+      it "raises Ruact::HtmlConverterError for nil input (smoke; full coverage at :147-184)" do
+        expect { described_class.convert(nil) }.to raise_error(Ruact::HtmlConverterError) do |error|
+          expect(error.message).to include("received nil")
+          expect(error.message).to include("expected a String of HTML")
+        end
+      end
+
+      it "raises Ruact::HtmlConverterError for a non-String input (smoke; full coverage at :186-243)" do
+        expect { described_class.convert(42) }.to raise_error(Ruact::HtmlConverterError) do |error|
+          expect(error.message).to include("expected a String of HTML")
+          expect(error.message).to include("got Integer")
+          expect(error.message).to include("Received: 42")
+        end
+      end
+    end
   end
 end

data/spec/ruact/install_generator_spec.rb

@@ -208,5 +208,98 @@ RSpec.describe Ruact do # rubocop:disable RSpec/SpecFilePathFormat
         expect(content).not_to include('from "vite-plugin-ruact"')
       end
     end
+
+    describe "server-functions scaffold (Story 8.0a — AC8)", :story_8_0a do
+      # Reproduces append_gitignore_entries logic from the install generator
+      # so the spec can be expressed without a full Rails::Generators::TestCase.
+      let(:gitignore_entries) do
+        [
+          "app/javascript/.ruact/server-functions.ts",
+          # Story 9.3 — route-driven (v2) parallel inspection target.
+          "app/javascript/.ruact/server-functions.next.ts",
+          "tmp/cache/ruact/"
+        ]
+      end
+
+      # Mirror of the real generator's append_gitignore_entries logic
+      # (gem/lib/generators/ruact/install/install_generator.rb). Kept in sync
+      # at line-set membership granularity — the previous substring-based
+      # version drifted from the real generator after the Chunk 1 review's
+      # line-set fix and the Re-run 2026-05-14 patch brings this helper
+      # back into parity.
+      def append_gitignore_entries(dest_root)
+        gitignore = File.join(dest_root, ".gitignore")
+        return :no_gitignore unless File.exist?(gitignore)
+
+        existing_lines = File.read(gitignore).each_line.to_set { |line| line.chomp.strip }
+        new_entries = gitignore_entries.reject { |e| existing_lines.include?(e) }
+        return :already_present if new_entries.empty?
+
+        File.open(gitignore, "a") do |io|
+          io.puts
+          io.puts "# ruact (Story 8.0a — auto-generated server-functions module)"
+          new_entries.each { |entry| io.puts entry }
+        end
+        :appended
+      end
+
+      def create_gitkeep(dest_root)
+        keep = File.join(dest_root, "app/javascript/.ruact/.gitkeep")
+        FileUtils.mkdir_p(File.dirname(keep))
+        return :already_present if File.exist?(keep)
+
+        File.write(keep, "")
+        :created
+      end
+
+      it "creates .ruact/.gitkeep so the directory is checkable in (Story 8.0a)" do
+        result = create_gitkeep(tmpdir)
+        expect(result).to eq(:created)
+        expect(File).to exist(File.join(tmpdir, "app/javascript/.ruact/.gitkeep"))
+      end
+
+      it "appends both .gitignore entries when missing (Story 8.0a)", :aggregate_failures do
+        write_file(".gitignore", "/tmp\n")
+        append_gitignore_entries(tmpdir)
+        content = read_file(".gitignore")
+        expect(content).to include("app/javascript/.ruact/server-functions.ts")
+        expect(content).to include("app/javascript/.ruact/server-functions.next.ts")
+        expect(content).to include("tmp/cache/ruact/")
+      end
+
+      it "is idempotent — running twice does not duplicate entries (Story 8.0a — pitfall #5)" do
+        write_file(".gitignore", "/tmp\n")
+        append_gitignore_entries(tmpdir)
+        append_gitignore_entries(tmpdir)
+
+        content = read_file(".gitignore")
+        expect(content.scan("app/javascript/.ruact/server-functions.ts").size).to eq(1)
+        expect(content.scan("tmp/cache/ruact/").size).to eq(1)
+      end
+
+      it "does not write to .gitignore when both entries already exist" do
+        write_file(".gitignore", "/tmp\napp/javascript/.ruact/server-functions.ts\n" \
+                                 "app/javascript/.ruact/server-functions.next.ts\ntmp/cache/ruact/\n")
+        result = append_gitignore_entries(tmpdir)
+        expect(result).to eq(:already_present)
+      end
+
+      it "still appends 'tmp/cache/ruact/' when only a longer prefix-matching path is present " \
+         "(Re-run 2026-05-14 — line-set semantics, not substring)", :aggregate_failures do
+        # The Chunk 1 review's line-set fix makes the real generator append
+        # `tmp/cache/ruact/` even when the file already contains a deeper
+        # path like `tmp/cache/ruact/some-cache.bin`. The helper used to
+        # use substring matching, which would skip the entry — a silent
+        # drift between helper and generator. This test pins the helper
+        # to the same semantics.
+        write_file(".gitignore", "/tmp\ntmp/cache/ruact/some-cache.bin\n")
+        append_gitignore_entries(tmpdir)
+        content = read_file(".gitignore")
+        # Exact-line match: a new "tmp/cache/ruact/" line is appended even
+        # though the file already contains "tmp/cache/ruact/some-cache.bin"
+        expect(content.each_line.to_a).to include("tmp/cache/ruact/\n")
+        expect(content).to include("app/javascript/.ruact/server-functions.ts")
+      end
+    end
   end
 end