rtmapi 0.6.1 → 0.6.2

data/lib/rtmapi.rb

@@ -244,10 +244,10 @@ class RememberTheMilk
         data = new_hash
       elsif data.class == RememberTheMilkHash  # only one list
         data = process_task_list( data[:id], data.arrayify_value(:taskseries) )
-      elsif data.class == NilClass  # empty list
+      elsif data.class == NilClass || (data.class == String && data == args['list_id']) # empty list
         data = new_hash
       else                                      # who knows...  
-        debug( "got a class of (%s) when processing tasks.  passing it on through", data.class )
+        debug( "got a class of (%s [%s]) when processing tasks.  passing it on through", data.class, data )
       end
     when :groups
       # contacts expected to be array, so look at each group and fix it's contact
@@ -336,28 +336,26 @@ class RememberTheMilk
  
   def call_api_method( method, args={} )
     
-    unless args.has_key?(:test_data)
-      args['method'] = "rtm.#{method}"
-      args['api_key'] = @api_key
-      args['auth_token'] ||= @auth_token if @auth_token
-
-      # make sure everything in our arguments is a string
-      args.each do |key,value|
-        key_s = key.to_s
-        args.delete(key) if key.class != String
-        args[key_s] = value.to_s
-      end
+    args['method'] = "rtm.#{method}"
+    args['api_key'] = @api_key
+    args['auth_token'] ||= @auth_token if @auth_token
+
+    # make sure everything in our arguments is a string
+    args.each do |key,value|
+      key_s = key.to_s
+      args.delete(key) if key.class != String
+      args[key_s] = value.to_s
+    end
+
+    args['api_sig'] = sign_request(args)
 
-      args['api_sig'] = sign_request(args)
+    debug( 'rtm.%s(%s)', method, args.inspect )
 
-      debug( 'rtm.%s(%s)', method, args.inspect )
-    end
-    
     attempts_left = @max_connection_attempts
     
     begin
-    if args.has_key?(:test_data)
-      @xml_parser.string = args[:test_data]
+    if args.has_key?('test_data')
+      @xml_parser.string = args['test_data']
     else
       attempts_left -= 1
       response = Net::HTTP.get_response(@uri.host, "#{@uri.path}?#{args.keys.collect {|k| "#{CGI::escape(k).gsub(/ /,'+')}=#{CGI::escape(args[k]).gsub(/ /,'+')}"}.join('&')}")
@@ -547,7 +545,8 @@ class RememberTheMilkTask < RememberTheMilkHash
     other_due = (other.has_key?(:tasks) && other.tasks.class == Array) ? other.task[:due] : nil
     other_due = @@BeginningOfEpoch unless other_due.class == Time
 
-    # sort based on due date, then priority, then name
+    # sort based on priority, then due date, then name
+    # which is the rememberthemilk default
     # if 0 was false in ruby, we could have done
     # prio <=> other_due || due <=> other_due || self['name'].to_s <=> other['name'].to_s
     # but it's not, so oh well....

data/test/data/test_rtm_tasks_getList_empty.1.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<rsp stat="ok"><tasks><list id="759197"/></tasks></rsp>

data/test/test-rtmapi.rb

@@ -258,6 +258,13 @@ class TestRememberTheMilk < Test::Unit::TestCase
     assert_equal "only one task in this list", data.values[0].name
   end
 
+  def test_rtm_tasks_getList_empty
+    list_id = "759197"
+    data = @rtm.tasks.getList( :list_id => list_id )  
+    assert_equal RememberTheMilkHash, data.class
+    assert_equal 0, data.keys.size
+  end
+
 
   def test_rtm_get_task_and_is_complete
     data = @rtm.tasks.getList( :list_id => '421865' )
@@ -497,8 +504,6 @@ class TestRememberTheMilk < Test::Unit::TestCase
     
   end
   
-  # TODO:  add-- def test_rtm_tasks_getList_empty
-  
   def test_rtm_tasks_setRecurrence
     list_id = @APITestListId
     tasks = @rtm.tasks.getList( :list_id => list_id )

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.1
 specification_version: 1
 name: rtmapi
 version: !ruby/object:Gem::Version 
-  version: 0.6.1
-date: 2007-02-01 00:00:00 -05:00
+  version: 0.6.2
+date: 2007-02-05 00:00:00 -05:00
 summary: Simple library for interfacing with rememberthemilk.com.
 require_paths: 
 - lib
@@ -67,6 +67,7 @@ files:
 - test/data/test_rtm_tasks_add.3.xml
 - test/data/test_rtm_tasks_getList.1.xml
 - test/data/test_rtm_tasks_getList_all.1.xml
+- test/data/test_rtm_tasks_getList_empty.1.xml
 - test/data/test_rtm_tasks_getList_from_smartlist.1.xml
 - test/data/test_rtm_tasks_getList_with_only_one_task.1.xml
 - test/data/test_rtm_tasks_setDueDate.1.xml