rtfm-filemanager 7.1.3 → 7.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc43a3881cc5f944d08ca2f0aeaaf70f712b79b77e51cbccebf9df7a892282f3
-  data.tar.gz: f7b1897e5accadf7d638b72bcd50ce8b88691162a60261baf7added43fe1cc09
+  metadata.gz: 506054b29faa54cff3af682e83d26356aefec7f631e99f5777a09f7321045816
+  data.tar.gz: 8276bf6d6271fa8364dc03cfb81b106761eb68597464597bd21f1a728cfb07cf
 SHA512:
-  metadata.gz: e0b54e7a21bae71705dd1a3d4978cd435c0d6119f876c8de23709feb68483343eeabdf39a287de5dcd48a8ec5758ee467028f661e9bae9a4925ac240a2cdf53b
-  data.tar.gz: bf57c7c14d8bdeb2ebc907b92fe373416c7f69b5691903115be61f90d89fdeeaf26a20445099251057b7c7e4f7e0714dec8583134cdabf9a38f1d86916942c7d
+  metadata.gz: 49917f6e6f31fe5d21575829565da7720fe7a76d9ea369451d4b4789c139971ee804bbcb1880f58585c987063b6552661c37a95715c9572fe71b355bb0f0f65a
+  data.tar.gz: '09254076afa868509902e490e417050e6dbdb09f3b2d47417ae197d1179ef314e013e6aa52465f5c2ee7a074559eecaa8c908478ad6a0e7a5b6e4e68c057a7a5'

data/README.md

@@ -1,7 +1,22 @@
 # RTFM - Ruby Terminal File Manager
- 
+
 ![Ruby](https://img.shields.io/badge/language-Ruby-red) [![Gem Version](https://badge.fury.io/rb/rtfm-filemanager.svg)](https://badge.fury.io/rb/rtfm-filemanager) ![Unlicense](https://img.shields.io/badge/license-Unlicense-green) ![Stay Amazing](https://img.shields.io/badge/Stay-Amazing-important)
 
+## Version 7.2
+
+**BREAKING CHANGE** - Batch Operation Behavior:
+
+Version 7.2 introduces a **breaking change** to how batch operations work with tagged items:
+
+- **Previous behavior**: Operations affected tagged items + selected item (always)
+- **New behavior**: Operations affect tagged items OR selected item (not both)
+  - When items ARE tagged → operate ONLY on tagged items
+  - When NO items are tagged → operate on selected item only
+
+This provides consistent, predictable behavior across all operations including: delete, copy, move, symlink, bulk rename, change permissions, change ownership, and open.
+
+**Migration**: If you want the selected item included in a batch operation, explicitly tag it first with 't'.
+
 ## Version 7.1
 
 Version 7.1 adds comprehensive compressed archive viewing capabilities:

data/bin/rtfm

@@ -18,7 +18,7 @@
 #             get a great understanding of the code itself by simply sending
 #             or pasting this whole file into you favorite AI for coding with
 #             a prompt like this: "Help me understand every part of this code".
-@version    = '7.1.3' # Fixed permission change color update and broken symlink deletion
+@version    = '7.2.0' # BREAKING: Batch operations now work on tagged OR selected, not both
 
 # SAVE & STORE TERMINAL {{{1
 ORIG_STTY = `stty -g`.chomp
@@ -1124,6 +1124,17 @@ def show_version # {{{3
 end
 
 def refresh_all # {{{3
+  # Re-read terminal size to handle window resizing
+  begin
+    new_h, new_w = IO.console.winsize
+    # Validate terminal size (minimum 10x20 to be usable)
+    if new_h && new_w && new_h >= 10 && new_w >= 20
+      @h, @w = new_h, new_w
+    end
+  rescue
+    # Keep current size if we can't read new size
+  end
+
   # Clear remote directory cache if in remote mode
   if @remote_mode
     @remote_files_cache = []
@@ -1635,6 +1646,10 @@ def undo_last_operation # {{{3
       undo_link(operation)
     when 'bulk_rename'
       undo_bulk_rename(operation)
+    when 'permissions'
+      undo_permissions(operation)
+    when 'ownership'
+      undo_ownership(operation)
     else
       @pB.say("Unknown operation type: #{operation[:type]}".fg(196))
       return
@@ -1727,7 +1742,7 @@ def undo_bulk_rename(operation) # {{{3
   operation[:renames].reverse.each do |rename_info|
     old_path = rename_info[:old_path]
     new_path = rename_info[:new_path]
-    
+
     if File.exist?(new_path)
       FileUtils.mv(new_path, old_path)
     else
@@ -1736,6 +1751,38 @@ def undo_bulk_rename(operation) # {{{3
   end
 end
 
+def undo_permissions(operation) # {{{3
+  # Restore old permissions
+  operation[:items].each do |item_info|
+    path = item_info[:path]
+    old_mode = item_info[:mode]
+
+    if File.exist?(path)
+      File.chmod(old_mode, path)
+    else
+      raise "Cannot undo permissions: #{path} not found"
+    end
+  end
+  # Invalidate cache to show updated colors
+  @dir_cache.delete_if { |key, _| key.start_with?("#{Dir.pwd}:") }
+  @pL.update = true
+end
+
+def undo_ownership(operation) # {{{3
+  # Restore old ownership
+  operation[:items].each do |item_info|
+    path = item_info[:path]
+    old_uid = item_info[:uid]
+    old_gid = item_info[:gid]
+
+    if File.exist?(path)
+      File.chown(old_uid, old_gid, path)
+    else
+      raise "Cannot undo ownership: #{path} not found"
+    end
+  end
+end
+
 # RECENTLY ACCESSED FILES {{{2
 def track_file_access(file_path) # {{{3
   return unless File.exist?(file_path)
@@ -1970,23 +2017,21 @@ end
 
 # BULK RENAME {{{2
 def bulk_rename # {{{3
-  if @tagged.empty?
-    @pB.say("No files tagged for bulk rename. Tag files first with 't'".fg(196))
-    return
-  end
-  
+  # Use tagged items if any exist, otherwise use selected item
+  items = @tagged.empty? ? [@selected] : @tagged
+
   @pB.say("Bulk rename pattern: ".fg(156))
   @pR.say(build_pattern_help)
   @pR.update = false
-  
+
   pattern = @pCmd.ask('Pattern: ', '')
   return if pattern.nil? || pattern.strip.empty?
-  
+
   # Parse and preview renames
   rename_operations = []
   errors = []
-  
-  @tagged.each do |file|
+
+  items.each do |file|
     next unless File.exist?(file)
     
     old_name = File.basename(file)
@@ -3243,9 +3288,11 @@ def delete_items # {{{3
   prompt_text = @trash ? "Move to trash? (y/n)" : "⚠️  PERMANENTLY DELETE? (y/n)"
   @pB.say(" #{prompt_text}".fg(action_color))
   if getchr == 'y'
+    # Use tagged items if any exist, otherwise use selected item
+    items = @tagged.empty? ? [@selected] : @tagged
     # Collect paths - include broken symlinks since they can be moved/deleted
     # File.exist? returns false for broken symlinks, but File.symlink? still works
-    paths = (@tagged + [@selected]).uniq.select { |p| File.exist?(p) || File.symlink?(p) }
+    paths = items.select { |p| File.exist?(p) || File.symlink?(p) }
     if paths.empty?
       @pB.say("No valid items to #{action.downcase}".fg(196))
     else
@@ -3279,14 +3326,20 @@ def delete_items # {{{3
         # Cannot undo permanent deletion, so don't add to undo history
       end
       @tagged.clear
-      
-      # Store the old preview text to detect if it needs updating
-      old_preview_text = @pR.text
-      
+
+      # Store the currently selected item to restore selection after refresh
+      previously_selected = @selected ? File.basename(@selected) : nil
+
       # Refresh the file list to reflect deletions
       @pL.update = true
       render  # This will update @files and @selected
-      
+
+      # Try to restore the previous selection if it still exists
+      if previously_selected && @files
+        restored_index = @files.index(previously_selected)
+        @index = restored_index if restored_index
+      end
+
       # After render, check if we still have files
       if @files.empty?
         # No files left in directory - clear the preview
@@ -3323,8 +3376,11 @@ end
 
 def change_ownership # {{{3
   require 'etc'
-  gnm = Etc.getgrgid(File.stat(@selected).gid).name
-  unm = Etc.getpwuid(File.stat(@selected).uid).name
+  # Use tagged items if any exist, otherwise use selected item
+  items = @tagged.empty? ? [@selected] : @tagged
+  first_item = items.first
+  gnm = Etc.getgrgid(File.stat(first_item).gid).name
+  unm = Etc.getpwuid(File.stat(first_item).uid).name
   ans = @pB.ask('Change ownership (user:group): ', "#{unm}:#{gnm}")
   # Reset bottom pane after input
   @pB.clear; @pB.update = true
@@ -3332,16 +3388,37 @@ def change_ownership # {{{3
   user, group = ans.split(':')
   uid = Etc.getpwnam(user).uid
   gid = Etc.getgrnam(group).gid
-  File.chown(uid, gid, @selected)
-  @tagged.each { |t| File.chown(uid, gid, t) rescue nil }
   if user == unm && group == gnm
     @pB.say('No change in ownership')
   else
+    # Record old ownership for undo
+    old_ownership = items.map do |item|
+      stat = File.stat(item)
+      {
+        path: item,
+        uid: stat.uid,
+        gid: stat.gid,
+        user: Etc.getpwuid(stat.uid).name,
+        group: Etc.getgrgid(stat.gid).name
+      }
+    end
+
+    # Change ownership
+    items.each { |item| File.chown(uid, gid, item) rescue nil }
     @pB.say("Ownership changed to #{user}:#{group}")
+
+    # Add to undo history
+    add_undo_operation({
+      type: 'ownership',
+      items: old_ownership,
+      timestamp: Time.now
+    })
   end
 end
 
 def change_permissions # {{{3
+  # Use tagged items if any exist, otherwise use selected item
+  items = @tagged.empty? ? [@selected] : @tagged
   # strip leading "-" off e.g. "-rwxr-xr-x" → "rwxr-xr-x"
   default = @fileattr.split[1][1..]
   ans = @pB.ask('Permissions: ', default)
@@ -3350,6 +3427,25 @@ def change_permissions # {{{3
   return if ans.nil? || ans.strip.empty?
   mode = if ans =~ /^\d{3}$/          # "755"
            ans.to_i(8)
+         elsif ans =~ /^[+-][rwx]+$/   # "+x", "-w", "+rw", etc.
+           # Modify current permissions
+           current = File.stat(items.first).mode & 0o777
+           operation = ans[0]
+           chars = ans[1..-1].chars
+           # Calculate permission bits to add/remove
+           bits = chars.map do |c|
+             case c
+             when 'r' then 0o444  # r for all (user, group, other)
+             when 'w' then 0o222  # w for all
+             when 'x' then 0o111  # x for all
+             else 0
+             end
+           end.sum
+           if operation == '+'
+             current | bits  # Add permissions
+           else
+             current & ~bits # Remove permissions
+           end
          elsif ans.length == 3           # "rwx" → "rwxrwxrwx"
            # compute the single octal digit
            digit = ans.chars.map do |c|
@@ -3372,13 +3468,24 @@ def change_permissions # {{{3
   if mode.nil?
     @pB.say('Invalid mode')
   else
-    current = File.stat(@selected).mode & 0o777
-    if mode == current
+    current = File.stat(items.first).mode & 0o777
+    if mode == current && items.size == 1
       @pB.say("No change needed (already #{mode.to_s(8)})")
     else
-      File.chmod(mode, @selected)
-      @tagged.each { |t| File.chmod(mode, t) rescue nil }
+      # Record old permissions for undo
+      old_permissions = items.map { |item| { path: item, mode: File.stat(item).mode & 0o777 } }
+
+      # Change permissions
+      items.each { |item| File.chmod(mode, item) rescue nil }
       @pB.say("Permissions changed to: #{mode.to_s(8)}")
+
+      # Add to undo history
+      add_undo_operation({
+        type: 'permissions',
+        items: old_permissions,
+        timestamp: Time.now
+      })
+
       # Invalidate cache for current directory to show updated colors
       @dir_cache.delete_if { |key, _| key.start_with?("#{Dir.pwd}:") }
       @pL.update = true
@@ -4975,19 +5082,20 @@ def command(cmd, timeout: 5, return_both: false) # {{{2
 end
 
 def copy_move_link(type) # COPY OR MOVE TAGGED ITEMS {{{2
-  @tagged.uniq!
-  
+  # Use tagged items if any exist, otherwise use selected item
+  items = @tagged.empty? ? [@selected] : @tagged.uniq
+
   # Determine destination directory based on mode
   dest_dir = if @dual_pane
                @active_pane == :left ? @pwd_left : @pwd_right
              else
                Dir.pwd
              end
-  
+
   # Track operations for undo
   operations = []
-  
-  @tagged.each do |item|
+
+  items.each do |item|
     dest = File.join(dest_dir, File.basename(item))
     dest += '1' if File.exist?(dest)
     while File.exist?(dest)
@@ -5039,7 +5147,12 @@ def copy_move_link(type) # COPY OR MOVE TAGGED ITEMS {{{2
   end
   
   @tagged = []
-  
+
+  # Store the currently selected item to restore selection after refresh (for move operations)
+  if type == 'move'
+    previously_selected = @selected ? File.basename(@selected) : nil
+  end
+
   # Set update flags for proper refresh - let render system handle the actual refresh
   if @dual_pane
     # Update the destination pane
@@ -5051,8 +5164,14 @@ def copy_move_link(type) # COPY OR MOVE TAGGED ITEMS {{{2
     # Also update the preview pane
     @pPreview.update = true if @pPreview
   end
-  
+
   render
+
+  # Restore selection after move operations
+  if type == 'move' && previously_selected && @files
+    restored_index = @files.index(previously_selected)
+    @index = restored_index if restored_index
+  end
 end
 
 def mark_latest # UPDATE MARKS LIST {{{2
@@ -5162,7 +5281,8 @@ def open_selected(html = nil) # OPEN SELECTED FILE {{{2
     return
   end
   tmpfile = File.join(Dir.tmpdir, 'rtfm_err.log')
-  paths   = (@tagged + [@selected]).uniq
+  # Use tagged items if any exist, otherwise use selected item
+  paths   = @tagged.empty? ? [@selected] : @tagged
   if html # html mode - open in HTML-browser
     esc = paths.map { |p| Shellwords.escape(p) }.join(' ')
     shell("xdg-open #{esc} &", err: tmpfile)
@@ -5700,15 +5820,24 @@ end
 setborder
 
 ## Catch change in terminal resize, redraw {{{2
-Signal.trap('WINCH') do 
+Signal.trap('WINCH') do
   # Don't refresh/render if an external interactive program is running
   # This prevents RTFM from painting over programs like HyperList when
   # switching terminals in window managers like i3-wm
   unless @external_program_running
-    @h, @w = IO.console.winsize
-    @pT.update = @pL.update = @pR.update = @pB.update = true
-    refresh
-    render
+    begin
+      new_h, new_w = IO.console.winsize
+      # Validate terminal size (minimum 10x20 to be usable)
+      if new_h && new_w && new_h >= 10 && new_w >= 20
+        @h, @w = new_h, new_w
+        @pT.update = @pL.update = @pR.update = @pB.update = true
+        refresh
+        render
+      end
+    rescue => e
+      # Silently ignore resize errors to prevent crashes
+      # User can manually refresh with 'r' key if needed
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rtfm-filemanager
 version: !ruby/object:Gem::Version
-  version: 7.1.3
+  version: 7.2.0
 platform: ruby
 authors:
 - Geir Isene
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-21 00:00:00.000000000 Z
+date: 2025-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rcurses
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '7.4'
 description: |-
-  RTFM v7.1.3: Fixed permission change color update and broken symlink deletion.
+  RTFM v7.2.0: BREAKING CHANGE - Batch operations now work ONLY on tagged items when items are tagged (not tagged + selected). If no items are tagged, operations work on the selected item only.
    A full featured terminal browser with syntax highlighted files, images shown in the terminal, videos thumbnailed, etc. Features include remote SSH/SFTP browsing, interactive SSH shell, comprehensive undo system, bookmarks, and much more. You can bookmark and jump around easily, delete, rename, copy, symlink and move files. RTFM is one of the most feature-packed terminal file managers.
 email: g@isene.com
 executables: