rt_rubocop_defaults 2.7.1 → 2.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11489ab87e42886abe3ec639b325ae09565d9c02604bb71add836f7a940d58c6
-  data.tar.gz: aa948688f3aa934a7306fbf61fd0b9014c129cedf98e9488e039e9ca66b01482
+  metadata.gz: f63a1da86e4b5eb679400632e400c4cbf243696cc7bbc70966c699c7b9277181
+  data.tar.gz: d53cf09810e47e2747bd5939e011331debe7e70d3f1fd9105a5077f764b54a9e
 SHA512:
-  metadata.gz: 776ab8550a8e773616a1958ba47557b66c4b3f1b2f0f92a00934570f365d5ad5bc186772a3e19276991187792a27b9dbee7a30d46dc86d39a3555141437cd54f
-  data.tar.gz: c060997be8f1c5e0087502962000dea349b5fd72d169ece525e9ce808885b27c742a110334b738c8072cd49198970501b163acece977e232ac4f1c4c7868a0ca
+  metadata.gz: 71f634a74709be61b9acca582b74a87150394b184cfd0d729fdfd64eb6b66b2d740678edb39eab70cf85ab29c81fb0e870663fbaa34d68f825e002e97fbbb118
+  data.tar.gz: 7b231c67e17bb9825e6ab19ffd586593d3ac9272173e72cf12bb6fb763a5aae04d1d83670aa3ed620e6a2ca5d4c66ba3d1af1850bf3282e2b6bee9647ed3dab6

data/config/default.yml

@@ -208,3 +208,8 @@ RSpec/Rails/HaveHttpStatus:
 # New cop name
 RSpecRails/HaveHttpStatus:
   Enabled: false
+
+RSpec/UnexpectedRequires:
+  Description: Check that rspec files do not contain requires.
+  Enabled: true
+  VersionAdded: "2.8.0"

data/lib/rt_rubocop_defaults/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RTRuboCopDefaults
-  VERSION = "2.7.1"
+  VERSION = "2.8.1"
 end

data/lib/rt_rubocop_defaults.rb

@@ -4,3 +4,5 @@ require "rt_rubocop_defaults/version"
 require "rt_rubocop_defaults/inject"
 
 RTRuboCopDefaults::Inject.defaults!
+
+require "rubocop/cop/rspec/unexpected_requires"

data/lib/rubocop/cop/rspec/unexpected_requires.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks that rspec files do not contain requires.
+      #
+      # As this can lead to unexpected behavior 
+      # later when the code is not used with rspec.
+      #
+      # Require the necessary files in the projects config or
+      # where you need it instead.
+      #
+      # @example
+      #   # bad
+      #   require "lib/use_cases/my_work"
+      #
+      #   describe UseCases::MyWork do
+      #
+      #   end
+      #
+      #   # good
+      #   describe UseCases::MyWork do
+      #
+      #   end
+      #
+      class UnexpectedRequires < Base
+        MSG = 'Do not require anything in a test file.'
+
+        IGNORED_PATTERN = /(spec|rails)_helper/
+
+        def_node_matcher :require_symbol?, <<~PATTERN
+          (send #rspec? :require $_ ...)
+        PATTERN
+
+        def on_new_investigation
+          @ignore_file = processed_source.path.match?(IGNORED_PATTERN)
+        end
+
+        def on_send(node)
+          return if @ignore_file
+
+          require_symbol?(node) do |match|
+            next if match.respond_to?(:value) &&
+              match.value.match?(IGNORED_PATTERN)
+
+            add_offense(node, message: MSG)
+          end
+        end
+      end
+    end
+  end
+end

data/rt_rubocop_defaults.gemspec

@@ -25,4 +25,6 @@ Gem::Specification.new do |spec|
   spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.add_dependency "rubocop", "~> 1.61"
+  # HINT: Needed as long as the `RSpec::UnexpectedRequires` cop is part of this repo
+  spec.add_dependency "rubocop-rspec", "~> 3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rt_rubocop_defaults
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.8.1
 platform: ruby
 authors:
 - Andreas Eger
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-04-18 00:00:00.000000000 Z
+date: 2024-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.61'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
 description: rubocop defaults used at runtastic
 email:
 - andreas.eger@runtastic.com
@@ -42,6 +56,7 @@ files:
 - lib/rt_rubocop_defaults.rb
 - lib/rt_rubocop_defaults/inject.rb
 - lib/rt_rubocop_defaults/version.rb
+- lib/rubocop/cop/rspec/unexpected_requires.rb
 - rt_rubocop_defaults.gemspec
 homepage: https://github.com/runtastic/rt_rubocop_defaults
 licenses: