rt_rubocop_defaults 2.7.0 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa2a8249676db757cefd40551140632f9269940a564e294086794cb00dad4e14
-  data.tar.gz: efc89668d9719dc2f6679e0f95404095ddca6ad8d7a06fcfc5a7e6027fa1aefe
+  metadata.gz: 8222f836d95f9d35647d6875b30347491754bf9b5fd704868246c7ef8b91684b
+  data.tar.gz: f3d6c565037f1afcde1b03005637243c9b39ca6b3e513b32dfdec4638561ac63
 SHA512:
-  metadata.gz: d7f06b18449f697ebe4b1cef8106d0d195663b8c8babdde619044cb8c86bdc4f2bf09d46b3e23d6f34d20cd064584262662ea31fd0acaa78d990bd14e509aaae
-  data.tar.gz: 351f754a6c29d318b2fb77b0da96bfdb61707303adb390944d579b0635ed91f055861c7b27b8aa0c7943439fe5207ffec8a877eeeb0ce825cb6db7e8dafd0c34
+  metadata.gz: ca74896b5e1f47bd082570f6f276e978c358566fc9d93413efe36a50ee9172778da98ef9ae4094212cde1728ded9650d157c7aa630e3534c4aecc4a57c0510ca
+  data.tar.gz: 4f4990c983cdc12e8ee7fb6ebfc72d2a4b4ee4d7aee64fe443b0b29c8bacfb81e7f43c477c2f74dd0bbe0bfee222632785141c013602b9e0afee94fccced9fb4

data/config/default.yml

@@ -199,7 +199,17 @@ RSpec/NoExpectationExample:
 RSpec/FactoryBot/SyntaxMethods:
   Enabled: false
 
-#### RSpec/
+#### Rails/
 # https://docs.rubocop.org/rubocop-rspec/cops_rspec_rails.html#rspecrailshavehttpstatus
+# Old cop name
 RSpec/Rails/HaveHttpStatus:
-  Enabled: false
+  Enabled: false
+
+# New cop name
+RSpecRails/HaveHttpStatus:
+  Enabled: false
+
+RSpec/UnexpectedRequires:
+  Description: Check that rspec files do not contain requires.
+  Enabled: true
+  VersionAdded: "2.8.0"

data/lib/rt_rubocop_defaults/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RTRuboCopDefaults
-  VERSION = "2.7.0"
+  VERSION = "2.8.0"
 end

data/lib/rt_rubocop_defaults.rb

@@ -4,3 +4,5 @@ require "rt_rubocop_defaults/version"
 require "rt_rubocop_defaults/inject"
 
 RTRuboCopDefaults::Inject.defaults!
+
+require "rubocop/cop/rspec/unexpected_requires"

data/lib/rubocop/cop/rspec/unexpected_requires.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks that rspec files do not contain requires.
+      #
+      # As this can lead to unexpected behavior 
+      # later when the code is not used with rspec.
+      #
+      # Require the necessary files in the projects config or
+      # where you need it instead.
+      #
+      # @example
+      #   # bad
+      #   require "lib/use_cases/my_work"
+      #
+      #   describe UseCases::MyWork do
+      #
+      #   end
+      #
+      #   # good
+      #   describe UseCases::MyWork do
+      #
+      #   end
+      #
+      class UnexpectedRequires < Base
+        MSG = 'Do not require anything in a test file.'
+
+        IGNORED_PATTERN = /(spec|rails)_helper/
+
+        def_node_matcher :require_symbol?, <<~PATTERN
+          (send #rspec? :require $_ ...)
+        PATTERN
+
+        def on_new_investigation
+          @ignore_file = processed_source.path.match?(IGNORED_PATTERN)
+        end
+
+        def on_send(node)
+          return if @ignore_file
+
+          require_symbol?(node) do |match|
+            next if match.respond_to?(:value) &&
+              match.value.match?(IGNORED_PATTERN)
+
+            add_offense(node, message: MSG)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rt_rubocop_defaults
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.8.0
 platform: ruby
 authors:
 - Andreas Eger
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-05 00:00:00.000000000 Z
+date: 2024-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -42,6 +42,7 @@ files:
 - lib/rt_rubocop_defaults.rb
 - lib/rt_rubocop_defaults/inject.rb
 - lib/rt_rubocop_defaults/version.rb
+- lib/rubocop/cop/rspec/unexpected_requires.rb
 - rt_rubocop_defaults.gemspec
 homepage: https://github.com/runtastic/rt_rubocop_defaults
 licenses:
@@ -63,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: rubocop defaults used at runtastic