rt_rubocop_defaults 1.2.3 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b426be9c1d796e95bbf18bf56488fc7373bfbb726418224088d50c3fe308b507
-  data.tar.gz: 70ead4a86a6fd2a3a08a0d017b1d6e276e02cdfd07052f5c56d2878ad8546b2a
+  metadata.gz: 87d79f8b110c2820f41659a05ca76c74c414ce2770f79ae7783e5638dd20b913
+  data.tar.gz: 43acb56184255a52ae6d15d2e3cc965bff0d9fca66fecef4d76a5c550d52e05e
 SHA512:
-  metadata.gz: eab27ccca6a584c59e3146c8666056b9f5f763a6c325d0505ed6e09efb536b38d9e2858665fb5f694fcd9a5ba875e5df376ce90927a82756c76142a639a2d915
-  data.tar.gz: 5dafe401a7ec99bff6465fda847a7f5e5a13fad46eb9f401660a73a10074e8bd501d1bec0384c8e63181f424aa2906354b21a4bfad6f1c5dc81e78f9ef315e33
+  metadata.gz: c5f9b353cb76d8f92fe68c64557478db5aa73314f1425c7b85c27ea560f7f2b9e352cfd09ab32851707f5b8d7c9b6ece36e123856c0512f0bf97c898fa43322a
+  data.tar.gz: ecc08566f134538a832a9efd0009b88286306125501bc48aec20728b952f15a1e875dc195e36a59648ee004cacafe4a78a276ffd16d197f917544c929d9549f4

data/README.md

@@ -56,6 +56,8 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/runtas
 This project is intended to be a safe, welcoming space for collaboration, and
 contributors are expected to adhere to the [code of conduct][cc].
 
+Check out our [career page](https://www.runtastic.com/career/) if you'd like to work with us.
+
 ## License
 The gem is available as open source under [the terms of the MIT License][mit].
 

data/config/default.yml

@@ -3,7 +3,7 @@ AllCops:
   CacheRootDirectory: '.git'
   Exclude:
     - coverage/**/*
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.5
 
 
 ### Lint
@@ -12,60 +12,70 @@ Lint/NestedMethodDefinition:
   Exclude:
     - api/sinatra/**/*
 
-### Metrics
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
 
-Layout/LineLength:
-  Max: 119
-  Exclude:
-    - Guardfile
-    - Gemfile
-  IgnoreCopDirectives: true
+Lint/EmptyBlock:
+  Enabled: true
 
-Metrics/LineLength:
-  Max: 119
-  Exclude:
-    - Guardfile
-    - Gemfile
-  IgnoreCopDirectives: true
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
 
-Metrics/MethodLength:
+Lint/ToEnumArguments:
   Enabled: true
-  CountComments: false # count full line comments?
-  Max: 10
-  Severity: refactor
-  Exclude:
-    - api/sinatra/**/*
+
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
+### Metrics
 
 Metrics/AbcSize:
   Max: 18
   Severity: refactor
   Exclude:
-    - api/sinatra/**/*
-
-Metrics/CyclomaticComplexity:
-  Severity: refactor
+    - 'api/sinatra/**/*'
+    - 'app/api/routes.rb'
 
 Metrics/BlockLength:
   Exclude:
     - '*.gemspec'
     - '**/*.rake'
-    - 'config/initialize/*'
-    - 'spec/**/*'
     - 'api/**/*'
+    - 'app/api/routes.rb'
+    - 'config/initialize/**/*'
+    - 'config/initializers/**/*'
+    - 'spec/**/*'
 
 Metrics/ClassLength:
   Exclude:
     - spec/**/*
 
+Metrics/CyclomaticComplexity:
+  Severity: refactor
+
+Layout/LineLength:
+  Max: 119
+  Exclude:
+    - Guardfile
+    - Gemfile
+  IgnoreCopDirectives: true
+
+Metrics/MethodLength:
+  CountComments: false # count full line comments?
+  Max: 10
+  Severity: refactor
+  Exclude:
+    - 'api/sinatra/**/*'
+    - 'app/api/routes.rb'
+
 Metrics/ModuleLength:
   Exclude:
-    - spec/requests/**/*
+    - 'app/api/routes.rb'
+    - 'spec/requests/**/*'
 
 ### Style / Layout
-Style/AlignHash:
-  EnforcedColonStyle: table
-  EnforcedHashRocketStyle: table
 
+#### Hash
 Layout/HashAlignment:
   EnforcedColonStyle: table
   EnforcedHashRocketStyle: table
@@ -73,48 +83,75 @@ Layout/HashAlignment:
 Style/HashSyntax:
   EnforcedStyle: ruby19_no_mixed_keys
 
-Style/MultilineOperationIndentation:
-  Description: Checks indentation of binary operations that span more than one line.
-  EnforcedStyle: indented
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
 
 Layout/MultilineOperationIndentation:
   Description: Checks indentation of binary operations that span more than one line.
   EnforcedStyle: indented
 
-Style/RaiseArgs:
-  EnforcedStyle: compact
+#### Rest
+Style/ArgumentsForwarding:
+  Enabled: true
 
-Style/SignalException:
-  EnforcedStyle: only_raise
+Style/CollectionCompact:
+  Enabled: true
 
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
+Style/Documentation:
+  Enabled: false
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
 
 Style/DoubleNegation:
   Enabled: false
 
-Style/RegexpLiteral:
+Style/ExponentialNotation:
+  # https://docs.rubocop.org/rubocop/cops_style.html#styleexponentialnotation
+  Enabled: true
+  EnforcedStyle: engineering
+
+Style/NegatedIfElseCondition:
+  Enabled: true
+
+Style/NumericLiterals:
+  Description: Add underscores to large numeric literals to improve their readability.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#underscores-in-numerics
   Enabled: false
 
 Style/PerlBackrefs:
   Enabled: false
 
-Style/Documentation:
-  Enabled: false
+Style/RaiseArgs:
+  EnforcedStyle: compact
 
-Style/NumericLiterals:
-  Description: Add underscores to large numeric literals to improve their readability.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#underscores-in-numerics
+Style/RegexpLiteral:
   Enabled: false
 
-Style/HashEachMethods:
+Style/SignalException:
+  EnforcedStyle: only_raise
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/SwapValues:
   Enabled: true
-Style/HashTransformKeys:
-  Enabled: false
-Style/HashTransformValues:
+
+Style/OptionalBooleanParameter:
   Enabled: false
+
 ### RSpec
 
+RSpec/DescribeClass:
+  Exclude:
+    - spec/integration/**/*
+
+RSpec/ExampleLength:
+  Enabled: false
+
 RSpec/ExampleWording:
   IgnoredWords:
     - only
@@ -125,11 +162,10 @@ RSpec/FilePath:
   Exclude:
     - spec/**/*
 
-RSpec/DescribeClass:
-  Exclude:
-    - spec/integration/**/*
+RSpec/MessageExpectation:
+  Enabled: false
 
-RSpec/ExampleLength:
+RSpec/MultipleExpectations:
   Enabled: false
 
 RSpec/NamedSubject:
@@ -138,8 +174,5 @@ RSpec/NamedSubject:
 RSpec/NestedGroups:
   Enabled: false
 
-RSpec/MultipleExpectations:
-  Enabled: false
-
-RSpec/MessageExpectation:
+RSpec/MultipleMemoizedHelpers:
   Enabled: false

data/lib/rt_rubocop_defaults/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RTRuboCopDefaults
-  VERSION = "1.2.3"
+  VERSION = "2.2.0"
 end

data/rt_rubocop_defaults.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.description   = "rubocop defaults used at runtastic"
   spec.license       = "MIT"
   spec.homepage      = "https://github.com/runtastic/rt_rubocop_defaults"
-  spec.required_ruby_version = "~> 2.2"
+  spec.required_ruby_version = "~> 2.5"
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.77"
+  spec.add_dependency "rubocop", "~> 1.2"
   spec.add_development_dependency "bundler", "> 1.13", "< 3"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "> 10.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rt_rubocop_defaults
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 2.2.0
 platform: ruby
 authors:
 - Andreas Eger
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-18 00:00:00.000000000 Z
+date: 2020-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.77'
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.77'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -48,14 +48,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '10.0'
 description: rubocop defaults used at runtastic
@@ -89,14 +89,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: rubocop defaults used at runtastic