rstub 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d031d969fbd0db57f5ec06b0a02d363433312a3
-  data.tar.gz: 0bb0fea0e4bfbffc1f0bdd21ca4dc17276d5a9c8
+  metadata.gz: 943eb63a834b2c3622df251eeecb0d16c46fc860
+  data.tar.gz: 4cdf00730e7ad425f768667891b9f23a0182e834
 SHA512:
-  metadata.gz: 1dbe528955a923d9a448a5e17161eaa8d6a12960fa52d6fed879f02398997689eea16da8941452371024563cd55ff047124e19af151f96768e7c13e6d836efd5
-  data.tar.gz: 0970f3cf25f9cf6c0cb10e79612aa5214db99f9a950af6e4ebd05911e35dc88d2d7ceef4205b24d13132841c8ef85222d95cc3226a343e578f604cfc79124349
+  metadata.gz: 51e364d0b062290793fe40c6e6ddfbd9b4def9f56f5b41df971a61bae9b204a2c26037462404f8546a860b8646d11fd87794abb7457e4560ca7435e20fd031df
+  data.tar.gz: 6ffead0bd9caea29da9e8476fe01f2383baec42c9f72df930d820d73259132139e0d3c24e40548392db9334a45762ee41d8490930bc8273d0ee4f535c2344d23

data/lib/rstub/file_parser.rb

@@ -1,3 +1,5 @@
+# FileParser goes through a file and writes the contents of it to a target file,
+# but it ignores anything between the delimiters # STUB and # ENDSTUB.
 class FileParser
   def stub(target_file, file)
     File.open(file, 'r') do |readable_file|
@@ -10,12 +12,12 @@ class FileParser
   private
 
   def start_stubbing?(line, stubbing)
-    return true if !!/#\s*stub\s*/i.match(line)
+    return true if /#\s*stub\s*/i.match(line)
     stubbing
   end
 
   def end_stubbing?(line, stubbing)
-    return false if !!/#\s*endstub\s*/i.match(line)
+    return false if /#\s*endstub\s*/i.match(line)
     stubbing
   end
 

data/lib/rstub/path_parser.rb

@@ -1,6 +1,8 @@
+# PathParser parses directory and file paths into a hash with directory and file
+# arrays.
 class PathParser
   def self.directory?(directory)
-    !!/^\.?\w+$/.match(directory)
+    !(/^\.?\w+$/ =~ directory).nil?
   end
 
   def get_globs(files)
@@ -12,35 +14,35 @@ class PathParser
 
   private
 
-  def is_glob?(file)
-    !!/\*/.match(file)
+  def glob?(file)
+    !(/\*/ =~ file).nil?
   end
 
   def check_globs(files)
     new_files = []
-    files.each { |file| new_files << (is_glob?(file) ? Dir.glob(file) : file) }
+    files.each { |file| new_files << (glob?(file) ? Dir.glob(file) : file) }
     new_files.flatten
   end
 
   def in_directory?(file)
-    !!/\//.match(file)
+    !(%r{\/} =~ file).nil?
   end
 
-  def parse_files_in_directories(file)
+  def extract_directories(file)
     file.split('/').slice(0...-1)
   end
 
   def parse_out_directories(files)
     directories = []
     files.each do |file|
-      directories <<  parse_files_in_directories(file) if in_directory?(file)
+      directories << extract_directories(file) if in_directory?(file)
     end
     directories.flatten
   end
 
   def get_directories(files)
     files.select { |file| PathParser.directory?(file) }
-         .concat(parse_out_directories(files))
+      .concat(parse_out_directories(files))
   end
 
   def get_files_from_directory(files, directories)

data/lib/rstub.rb

@@ -1,6 +1,9 @@
 require 'rstub/file_parser'
 require 'rstub/path_parser'
 
+# RStub takes command line arguments, calls PathParser to parse them, creates
+# new files according to those arguments, and calls FileParser to parse those
+# files and write them to the newly generated files.
 class RStub
   attr_reader :file_parser, :path_parser
   attr_accessor :target, :files, :directories, :target_files
@@ -11,7 +14,7 @@ class RStub
   end
 
   def start(args = [])
-    raise 'Not enough arguments' if args.size < 2
+    fail ArgumentError, 'Not enough arguments' if args.size < 2
     parse_args(args)
     make_new_directory_structure
     parse_files
@@ -24,7 +27,9 @@ class RStub
   # string
   def parse_args(args)
     self.target = args.pop
-    raise 'The last argument needs to be a directory' unless PathParser.directory?(target)
+    unless PathParser.directory?(target)
+      fail ArgumentError, 'The last argument needs to be a directory'
+    end
     self.files = args
   end
 
@@ -33,7 +38,7 @@ class RStub
   end
 
   def make_new_directories
-    directories.each { |dir| Dir.mkdir("#{target}/#{dir}") unless dir == target }
+    directories.each { |d| Dir.mkdir("#{target}/#{d}") unless d == target }
   end
 
   def make_new_files
@@ -43,7 +48,7 @@ class RStub
   def parse_files_and_directories
     parsed_path = path_parser.get_globs(files)
     self.files = parsed_path[:files].select { |file| File.exist? file }
-    self.target_files = files.map { |file| "#{target}/#{file}"}
+    self.target_files = files.map { |file| "#{target}/#{file}" }
     self.directories = parsed_path[:directories]
   end
 

data/rstub.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = 'rstub'
-  s.version = '0.1.1'
+  s.version = '0.1.2'
 
   s.date = '2015-05-30'
   s.summary = 'A gem to stub out code'

data/spec/file_parser_spec.rb

@@ -14,7 +14,7 @@ describe FileParser do
     end
 
     def add_text(text)
-      File.open('foo.rb', 'w') { |f| f.puts text}
+      File.open('foo.rb', 'w') { |f| f.puts text }
     end
 
     def stub_all

data/spec/path_parser_spec.rb

@@ -25,26 +25,27 @@ describe PathParser do
     let(:path_parser) { PathParser.new }
 
     it 'returns the same array when there is no match' do
-      expect(path_parser.get_globs(['foo.rb'])[:files]).to match_array(['foo.rb'])
+      expect(path_parser.get_globs(['foo.rb'])[:files])
+        .to match_array(['foo.rb'])
     end
 
     it 'returns glob matches from current directory' do
       expect(path_parser.get_globs(['*']))
-        .to match_array({ directories: ['foobar'],
-                          files: ['baz.rb', 'foo.rb', 'foobar/foobaz.rb']})
+        .to match_array(directories: ['foobar'],
+                        files: %w(baz.rb foo.rb foobar/foobaz.rb))
     end
 
     it 'adds glob matches to the rest of the files' do
       expect(path_parser.get_globs(['*', 'foo/bar.rb'])[:directories])
-        .to match_array(['foo', 'foobar'])
+        .to match_array(%w(foo foobar))
       expect(path_parser.get_globs(['*', 'foo/bar.rb'])[:files])
-        .to match_array(['foo/bar.rb', 'baz.rb', 'foo.rb', 'foobar/foobaz.rb'])
+        .to match_array(%w(foo/bar.rb baz.rb foo.rb foobar/foobaz.rb))
     end
 
     it 'returns glob matches from lowel directory' do
       expect(path_parser.get_globs(['*/*']))
-        .to match_array({ directories: ['foobar'],
-                          files: ['foobar/foobaz.rb'] })
+        .to match_array(directories: ['foobar'],
+                        files: ['foobar/foobaz.rb'])
     end
   end
 end

data/spec/rstub_spec.rb

@@ -21,16 +21,16 @@ describe RStub do
     end
 
     it 'raises error with invalid number of arguments' do
-      expect{rstub.start}.to raise_error('Not enough arguments')
-      expect{rstub.start(['foo'])}.to raise_error('Not enough arguments')
+      expect { rstub.start }.to raise_error('Not enough arguments')
+      expect { rstub.start(['foo']) }.to raise_error('Not enough arguments')
     end
 
     it 'raises error if the last argument isn\'t a directory' do
-      expect{rstub.start(['foo.rb', 'baz.rb'])}
+      expect { rstub.start(['foo.rb', 'baz.rb']) }
         .to raise_error('The last argument needs to be a directory')
-      expect{rstub.start(['target', 'foo.rb'])}
+      expect { rstub.start(['target', 'foo.rb']) }
         .to raise_error('The last argument needs to be a directory')
-      expect{rstub.start(['foo.rb', '*'])}
+      expect { rstub.start(['foo.rb', '*']) }
         .to raise_error('The last argument needs to be a directory')
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rstub
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Justin Kim