rspreadsheet 0.4.5 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1baffe562cc732b33a3919529ebac6eee2a4e337
-  data.tar.gz: 0405d76a41fecf70a3a131f0fcfdabd41877cb71
+SHA256:
+  metadata.gz: fdaab0a6bad4e406aa6e180c1a0b5d21d7f1e01586d0275449e6a824852d07c6
+  data.tar.gz: 83f64bbd8b7c94c924ce0b75794995c4f90f2d14630f5a87b2f96d2fae80a6cc
 SHA512:
-  metadata.gz: a60aa7bc6cbcd3af3d8de9b161b220d8f9f0db92279ee14715a107cd7bb0f902e27dfb87d4b3c42e86634f198c7163e18a01a8721b5a7501ade4d54246cd93a9
-  data.tar.gz: 7f44c68924b04255565aaf06e0ac77ba6b3e719a748630122f8f7fd2bff5fe563033321a1e42db3c1070a9164627dd373fec7cba42901b2e9fe4536ac5f3c7b1
+  metadata.gz: 324d95798062e62cdb99a8039b48e46b80ddd33c31a6963e6c51af5da01f0858db51fd737937b1744b33d8b085a4b03e0ed81c92d4523e20a961ba7c437bda55
+  data.tar.gz: 60445dbdb2965e661db8e0b1213039aa89ad0b8a53ac61de4aa7e2005a9b4274bfd8bdad66cc6a494f4bc331e06c0f2012eab2150787859e018f977e6fd68214

data/.gitignore

@@ -26,7 +26,7 @@ build/
 .*kate-swp
 .*kate-swp.bak
 .directory
-.rake-tasks~
+.rake_tasks~
 
 ## Environment normalisation:
 /.bundle/
@@ -34,7 +34,6 @@ build/
 
 # for a library or gem, you might want to ignore these files since the code is
 # intended to run in multiple environments; otherwise, check them in:
-
 Gemfile.lock
 .ruby-version
 .ruby-gemset
@@ -47,4 +46,8 @@ Gemfile.lock
 /spec/testfile1/
 
 #temporary
-/w
+/w
+*~
+
+# rspec failure tracking
+.rspec_status

data/.travis.yml

@@ -1,11 +1,19 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.0.0
-  - 2.1.10
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
+  - 2.0.0  # latest 2.0 by 2019-05 
+  - 2.1.10 # latest 2.1 by 2019-05
+  - 2.2.10 # latest 2.2 by 2019-05
+  - 2.3.8  # latest 2.3 by 2019-05
+  - 2.4.6  # latest 2.4 by 2019-05
+  - 2.5.5  # latest 2.5 by 2019-05
+  - 2.6.3  # latest 2.6 by 2019-05
+  - 2.1.5  #  ruby in debian 8 jessie
+  - 2.3.3  #  ruby in debian 9 stretch
+  - 2.5.5  # ruby in debian 10 buster
+
+
+# tesing versions with native libxml2 in debian
 script: 'bundle exec rake'
 matrix:
   include:
@@ -19,6 +27,6 @@ matrix:
 notifications:
   email:
     recipients:
-      - jatesins@ncsu.edu
+      - travis@kub.cz
     on_failure: change
     on_success: never

data/DEVEL_BLOG.md

@@ -66,7 +66,7 @@ RSpreadsheet.generate('pricelist.ods') do
 ## Guiding ideas
   * xml document is always synchronized with the data. So the save is trivial.
   * no duplication of data. Objects like RowArray should containg minimum information. This one exists solely to speed up cell search. Taken to extream it is questionable, whether we need such objects at all, it might be possible to always work with xml directly.
-  * all cells and rows only server as proxy. they hold index and worksheet pointer and everytime read or write is done, the xml is newly searched. until there is a xmlnode caching we have no problem
+  * all cells and rows only serve as a proxy. They hold index and worksheet pointer and everytime read or write is done, the xml is newly searched. until there is a xmlnode caching we have no problem
   * all cells returned for particular coordinates are **always the same object**. This way we have no problem to synchronize changes.
     
 ## Known Issues
@@ -81,11 +81,11 @@ RSpreadsheet.generate('pricelist.ods') do
 ### Automated testing
 
   * ``bundle exec guard`` will get tested any changes as soon as they are summitted
-  * ``rake spec`` runs all test manually
+  * ``bundle exec rake spec`` runs all test manually
 
 ### Automated utilities
  
-  * [travis-ci](https://travis-ci.org/gorn/rspreadsheet) provides automated testing
+  * [travis-ci](https://travis-ci.org/gorn/rspreadsheet) provides automated testing - it tests every commit even in branches
   * [github](https://github.com/gorn/rspreadsheet) hosts the repository where you can get the code
   * [coverals](https://coveralls.io/r/gorn/rspreadsheet) checks how well source is covered by tests
 
@@ -94,13 +94,16 @@ RSpreadsheet.generate('pricelist.ods') do
 1. Make changes
 2. Test if all tests pass (run `bundle exec guard` to test automatically). If not go to 1.
 3. Build and install locally using script `./reinstall_local_gem.sh` (see [details](reinstall_local_gem.sh))
-4. Now can locally and manually use/test the gem. This should not be replacement for automated testing. If you make some changes, go to 1.
-5. When happy, increment the version number and `git add .; git commit -am'commit message'; git push`
-6. ``rake release`` - creates a version tag in git and pushes the code to github + Rubygems. After this is succesfull the new version appears as release in Github and RubyGems.
+4. Now can locally and manually use/test the gem. This should not be replacement for automated testing. If you make any changes, go to 1.
+5. If you want to test in travis before the release, you can `git push` the changes and let [travis](https://travis-ci.org/gorn/rspreadsheet) test them. 
+   If you want to be extra prudent you can do this in feature branch by `git checkout -b <feature-branch-name>; git push -u origin <feature-branch-name>`
+6. When happy, increment the version number and `git add .; git commit -am'commit message'; git push`
+7. ``rake release`` - creates a version tag in git and pushes the code to github + Rubygems. After this is succesfull the new version appears as release in Github and RubyGems.
+8. If you have used the feature branch, than delete it.
 
-gem alternative to points 3-6
+gem alternative to step 3 and 7
 
-    gem build rspreadsheet.gemspec              -\   These two lines together are in install.sh
+    gem build rspreadsheet.gemspec              -\   These two lines together are in reinstall_local_gem.sh
     sudo gem install rspreadsheet-x.y.z.gem     -/   which should be invoked from parent directory
     gem push rspreadsheet-x.y.z.gem             releases the gem, do not forgot to update version in rspreadsheet.gemspec before doing this
 

data/README.md

@@ -9,19 +9,13 @@ The gem allows you to acces your file and modify any cell of it, **without** tou
 ## Examples of usage
 
 ```ruby
-require 'rspreadsheet'
-book = Rspreadsheet.open('./test.ods')
-sheet = book.worksheets(1)
+sheet = Rspreadsheet.open('./test.ods').worksheets(1)
 
-# get value of a cell B5 (there are more ways to do this)
-sheet.B5                       # => 'cell value'
-sheet[5,2]                     # => 'cell value'
-sheet.row(5).cell(2).value   # => 'cell value'
-
-# set value of a cell B5
-sheet.F5 = 'text'
-sheet[5,2] = 7
-sheet.cell(5,2).value = 1.78
+sheet.B5 = 'Cat'
+sheet.B5                    #=>  'Cat'
+sheet['B', 5]               #=>  'Cat'
+sheet['B', 5] = 'Mouse'
+sheet.row(5).cell(2).value  #=>  'Mouse'
 
 # working with cell format
 sheet.cell(5,2).format.bold = true
@@ -55,32 +49,41 @@ book.save('different_filename.ods')
 
 ## Installation and Configuration
 
-Gem is on [Rubygems](https://rubygems.org/gems/rspreadsheet) so you can install it by
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'rspreadsheet'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
 
     $ gem install rspreadsheet
 
-or add <code>gem 'rspreadsheet'</code> to your Gemfile and execute  <code>bundle</code>. 
+If you get this error concering libxml, like
 
-If you get this error
+    checking for libxml/xmlversion.h in /opt/include/libxml2,/opt/local/include/libxml2,/usr/local/include/libxml2,/usr/include/libxml2... no
+    *** extconf.rb failed ***
+or 
 
     mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h 
-    
+        
 then you might not have installed libxml for ruby. I.e. in debian something like <code>sudo aptitude install ruby-libxml</code> or using equivalent command in other package managers.
 
 ## Contibutions, ideas and wishes welcomed
 
 ### Nonprogrammers
-If you need any help or find a bug please [submit an issue](https://github.com/gorn/rspreadsheet/issues) here. I appreciate any feedback and even if you can not help with code, it is interesting for me to hear from you. Different people have different needs and I want to hear about them. If you are a programmer and you have any ideas, wishes, etc you are welcomed to fork the repository and submit a pull request preferably including a failing test.
 
-Alhought this gem is still in beta stage I use in everyday and it works fine. Currently I am experimenting with syntax to get stabilized. **Any suggestions regarding the syntax is very welcomed**
+File a [bug report](https://github.com/gorn/rspreadsheet/issues). I appreciate any feedback and even if you can not help with code, it is interesting for me to hear from you. Different people have different needs and I want to hear about them. 
+
+Alhought this gem is still in beta stage I use in everyday and it works fine. Any suggestions regarding the syntax is very welcomed.
 
 ### Programmers
 
-1. [Fork it](http://github.com/gorn/rspreadsheet/fork) and clone it ([troubleshooting](https://github.com/gorn/rspreadsheet/blob/master/DEVEL_BLOG.md#installation-troubleshooting))
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+File a [bug report](https://github.com/gorn/rspreadsheet/issues) or [fork it](http://github.com/gorn/rspreadsheet/fork) and file a pull request. You do not have to contribute a code, failing tests are welcomed as well.
 
 ## Why another OpenDocument spreadsheet gem?
 
@@ -102,3 +105,7 @@ One of the main ideas is that the manipulation with OpenDOcument files should be
 * [Code documentation](http://www.rubydoc.info/github/gorn/rspreadsheet) is hosted on [rubydoc.info](http://www.rubydoc.info/)
 * [Changelog](CHANGELOG.md)
 * [Documentation for developers](DEVEL_BLOG.md) containing ideas for future development and documentation on testing tools
+
+## License
+
+The gem is available as open source under the terms of the [GPL licence](LICENCE.md).

data/Rakefile

@@ -1,10 +1,8 @@
-require 'rspec/core/rake_task'
-require 'bundler/gem_tasks'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
-# Default directory to look in is `/specs`
-# Run with `rake spec`
-RSpec::Core::RakeTask.new(:spec) do |task|
-  task.rspec_opts = ['--color', '--format', 'nested']
+RSpec::Core::RakeTask.new(:spec)  do |task|
+  task.rspec_opts = ['--color', '--format', 'd']  # jak se ma formatova vystup
 end
 
-task :default => :spec
+task :default => :spec

data/lib/helpers/class_extensions.rb

@@ -10,9 +10,6 @@ if RUBY_VERSION > '2.1'
           inject(0){ |sum, element| sum.to_f + element.to_f } || identity
         end
       end
-      def self.marker
-        'yes'
-      end
     end
     
     refine LibXML::XML::Node do
@@ -72,9 +69,6 @@ else # Monkeypatching
         inject(0){ |sum, element| sum.to_f + element.to_f } || identity
       end
     end
-    def self.marker
-      'yes2'
-    end
   end
 
   class LibXML::XML::Node

data/lib/rspreadsheet/cell.rb

@@ -157,7 +157,7 @@ class Cell < XMLTiedItem
         when gt == :percentage then
           remove_all_value_attributes_and_content
           set_type_attribute('percentage')
-          Tools.set_ns_attribute(xmlnode,'office','value', '%0.2d%' % avalue.to_f) 
+          Tools.set_ns_attribute(xmlnode,'office','value', ('%0.2d' % avalue.to_f)+'%') 
           xmlnode << Tools.prepare_ns_node('text','p', (avalue.to_f*100).round.to_s+'%')
         when gt == :currency then
           remove_all_value_attributes_and_content

data/lib/rspreadsheet/image.rb

@@ -67,7 +67,7 @@ class Image < XMLTiedItem
   
   def initialize_from_file(filename,mime)
     # ověřit, zda soubor na disku existuje TODO: tady by to chtělo zobecnit na IO
-    raise 'File does not exist or it is not accessible' unless File.exists?(filename)
+    raise 'File does not exist or it is not accessible' unless File.exist?(filename)
     @original_filename = filename
     @mime = mime
     self
@@ -115,4 +115,4 @@ class Image < XMLTiedItem
 # 
 end
 
-end
+end

data/lib/rspreadsheet/tools.rb

@@ -119,10 +119,10 @@ module Tools
       'css3t'=>"http://www.w3.org/TR/css3-text/",
       'manifest'=>"urn:oasis:names:tc:opendocument:xmlns:manifest:1.0"
     }
-    if @pomnode.nil?
+    if !defined?(@pomnode) or @pomnode.nil?
       @pomnode = LibXML::XML::Node.new('xxx')
     end
-    if @ns.nil? then @ns={} end
+    if !defined?(@ns) or @ns.nil? then @ns={} end
     if @ns[prefix].nil?
       @ns[prefix] = LibXML::XML::Namespace.new(@pomnode, prefix, ns_array[prefix])
     end
@@ -192,11 +192,3 @@ module Tools
 end
   
 end
-
-# @private
-class Range
-  def size
-    res = self.end-self.begin+1
-    res>0 ? res : 0
-  end
-end

data/lib/rspreadsheet/version.rb

@@ -1,3 +1,3 @@
 module Rspreadsheet
-  VERSION = "0.4.5"
+  VERSION = "0.4.7"
 end

data/lib/rspreadsheet/worksheet.rb

@@ -111,7 +111,7 @@ class Worksheet
   end
   alias :cell :cells
   def column(param)
-    r,coli = Rspreadsheet::Tools.a2c(1,param)
+    _,coli = Rspreadsheet::Tools.a2c(1,param)
     Column.new(self,coli)
   end
   # Allows syntax like sheet.F15. TO catch errors easier, allows only up to three uppercase letters in colum part, althought it won't be necessarry to restrict.

data/lib/rspreadsheet/xml_tied_item.rb

@@ -92,6 +92,9 @@ class XMLTiedItem < XMLTied
       self.singleton_class.send(:define_method, method, raise_destroyed_cell_error)
     end
     self.singleton_class.send(:define_method, :inspect, -> { "#<%s:0x%x destroyed cell>" % [self.class,object_id] })  # define descriptive inspect
+    if self.singleton_class.respond_to? :remove_method # in ruby 2.5 and higher
+      self.singleton_class.remove_method :invalid_reference? if self.singleton_class.method_defined? :invalid_reference?
+    end
     self.singleton_class.send(:define_method, :invalid_reference?, -> { true }) # define invalid_reference? method
     # invalidate variables
     @xml_tied_parent=nil

data/lib/rspreadsheet/xml_tied_repeatable.rb

@@ -18,13 +18,13 @@ module XMLTiedArray_WithRepeatableItems
   include XMLTiedArray
 
   def my_subnode_range(aindex)
-    node, range = find_subnode_with_range(aindex)
+    _, range = find_subnode_with_range(aindex)
     return range
   end
   
   # vrátí xmlnode na souřadnici aindex
   def my_subnode(aindex)
-    result1, result2 = find_subnode_with_range(aindex)
+    result1, _ = find_subnode_with_range(aindex)
     return result1
   end
 
@@ -112,7 +112,7 @@ module XMLTiedArray_WithRepeatableItems
   # clean up item from xml (handle possible detachments) and itemcache. leave the object invalidation on the object
   # this should not be called from nowhere but XMLTiedItem.delete
   def delete_subitem(aindex)
-    options = subitem_xml_options
+#     options = subitem_xml_options
     delete_my_subnode_respect_repeated(aindex)  # vymaž node z xml
     @itemcache.delete(aindex)
     @itemcache.keys.sort.select{|i| i>=aindex+1 }.each do |i| 
@@ -148,4 +148,4 @@ module XMLTiedArray_WithRepeatableItems
   end  
 end
 
-end
+end

data/rspreadsheet.gemspec

@@ -8,8 +8,9 @@ Gem::Specification.new do |spec|
   spec.version       = Rspreadsheet::VERSION
   spec.authors       = ["Jakub A.Těšínský"]
   spec.email         = ["jAkub.cz (A is at)"]
-  spec.summary       = %q{Manipulating spreadsheets with Ruby (read / create / modify OpenDocument Spreadsheet).}
-  spec.description   = %q{Manipulating OpenDocument spreadsheets with Ruby. This gem can create new, read existing files abd modify them. When modyfying files, it tries to change as little as possible, making it as much forward compatifle as possible.}
+  spec.summary       = 'Manipulating LibreOffice Calc (OpenDocument Spreadsheet) files from Ruby (read / create / modify).'
+  spec.description   = 'Manipulating LibreOffice Calc (OpenDocument Spreadsheet) files with Ruby. This gem can create new, read existing files abd modify them. When modyfying files, it tries to change as little as possible, making it as much forward compatible as possible.'
+
   spec.homepage      = "https://github.com/gorn/rspreadsheet"
   spec.license       = "GPL"
 
@@ -33,17 +34,25 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'andand', '~>1.3'
 
   # development dependencies
-  spec.add_development_dependency "bundler", '~> 1.5'
-  spec.add_development_dependency "rake", '~>0.9'
+  if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4.5')
+    # ruby 2.4.5 and up
+    spec.add_development_dependency "bundler", '>= 1.5', '<3'   # some 2.5 rubyies contain already bundler 2 included
+    spec.add_development_dependency "rake", '~>10.0'
+  else
+    # ruby up to 2.4.5
+    spec.add_development_dependency "bundler", '~> 1.5'
+    spec.add_development_dependency "rake", '~>0.9'
+  end
   # testig - see http://bit.ly/1n5yM51
   spec.add_development_dependency "rspec", '~>2.0'       # running tests
   spec.add_development_dependency 'pry-nav', '~>0.0'     # enables pry 'next', 'step' commands
   spec.add_development_dependency "coveralls", '~>0.7' # inspecting coverage of tests
 
+
   # optional and testing
   if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.5')
-    spec.add_development_dependency "guard", '~>2.13'
-    spec.add_development_dependency "guard-rspec", '~>4.6'
+#    spec.add_development_dependency "guard", '~>2.13'
+#    spec.add_development_dependency "guard-rspec", '~>4.6'
   end
 
 #   spec.add_development_dependency 'equivalent-xml'     # implementing xml diff

data/spec/cell_spec.rb

@@ -345,7 +345,7 @@ describe Rspreadsheet::Cell do
     @cell.formula='=1+5'
     @cell.formula.should eq '=1+5'
   end
-  it 'unsets cell type when formula set - we can not guess it correctly', :focus do
+  it 'unsets cell type when formula set - we can not guess it correctly' do
     @cell = @sheet1.cell(1,1)
     @cell.value = 'ahoj'
     @cell.type.should eq :string
@@ -449,11 +449,11 @@ describe Rspreadsheet::Cell do
     @cell.border_top.should_not be_nil ## ?????
   end
   
-  it 'automatically creates new style, if a style is automatic, some of its attributes changes and there are several cells pointing to it', :penting=>'' do
+  it 'automatically creates new style, if a style is automatic, some of its attributes changes and there are several cells pointing to it', :pending=>'' do
   
   end
   
-  it 'gracedully accepts nil in assignement' do
+  it 'gracefully accepts nil in assignement' do
     expect {
       @sheet2.cell('B1').value = nil
       @sheet2.cell('B2').value = nil

data/spec/class_extensions_spec.rb

@@ -21,7 +21,7 @@ if RUBY_VERSION > '2.1'
       @m2 = LibXML::XML::Node.new('a')
     end
     it 'can compare nodes' do
-      @n.to_s.should == @m.to_s
+      @n.to_s.should be == @m.to_s
       @n.to_s.should_not == @m2.to_s
     end
     it 'has correct elements' do

data/spec/image_spec.rb

@@ -4,7 +4,7 @@ describe Rspreadsheet::Image do
   before do
     @testfile_filename = $test_filename_images
     @tmp_testfile_filename = '/tmp/testfile2-image.ods'
-    File.delete(@tmp_testfile_filename) if File.exists?(@tmp_testfile_filename) # delete temp file
+    File.delete(@tmp_testfile_filename) if File.exist?(@tmp_testfile_filename) # delete temp file
 
     @testimage_filename  = './spec/test-image-blue.png'
     @testimage2_filename = './spec/test-image.png'
@@ -13,9 +13,9 @@ describe Rspreadsheet::Image do
     @sheet2 = @workbook.worksheets(2)
   end
   after do
-    File.delete(@tmp_testfile_filename) if File.exists?(@tmp_testfile_filename) # delete temp file
+    File.delete(@tmp_testfile_filename) if File.exist?(@tmp_testfile_filename) # delete temp file
   end
-  it 'is accesible when included in spreadsheet', :xpending do
+  it 'is accesible when included in spreadsheet' do
     @sheet.images_count.should == 1
     @image = @sheet.images(1)
     
@@ -80,7 +80,7 @@ describe Rspreadsheet::Image do
     @sheet2.images_count.should == 1
     @image = @sheet2.images(1)
     
-    File.delete(tmp_test_image) if File.exists?(tmp_test_image)
+    File.delete(tmp_test_image) if File.exist?(tmp_test_image)
     Zip::File.open(@tmp_testfile_filename) do |zip|  ## TODO: this is UGLY - it should not be extracting contents here
       zip.extract(@image.internal_filename,tmp_test_image)
     end
@@ -104,4 +104,4 @@ describe Rspreadsheet::Image do
 #   it 'has dimensions defaulting to size of the image once it is inserted' do
 #   end
   
-end
+end

data/spec/io_spec.rb

@@ -4,7 +4,7 @@ using ClassExtensions if RUBY_VERSION > '2.1'
 describe Rspreadsheet do
   before do
     @tmp_filename = '/tmp/testfile.ods'
-    File.delete(@tmp_filename) if File.exists?(@tmp_filename)  # delete temp file
+    File.delete(@tmp_filename) if File.exist?(@tmp_filename)  # delete temp file
   end
   
   

data/spec/row_spec.rb

@@ -255,7 +255,7 @@ describe Rspreadsheet::Row do
     @row.cells(1).value.should == 1
     @row.cells(3).blank?.should be_truthy
   end
-  it 'can be mass assigned by sheet[]= method', :focus do
+  it 'can be mass assigned by sheet[]= method' do
     @sheet1[1] = ['foo','baz']
   end
   it 'cells can be wiped out by truncate method' do

data/spec/rspreadsheet_spec.rb

@@ -4,10 +4,10 @@ using ClassExtensions if RUBY_VERSION > '2.1'
 describe Rspreadsheet do
   before do
     @tmp_filename = '/tmp/testfile.ods'        # delete temp file before tests
-    File.delete(@tmp_filename) if File.exists?(@tmp_filename)
+    File.delete(@tmp_filename) if File.exist?(@tmp_filename)
   end
   after do
-    File.delete(@tmp_filename) if File.exists?(@tmp_filename) # delete temp file after tests
+    File.delete(@tmp_filename) if File.exist?(@tmp_filename) # delete temp file after tests
   end
   
   it 'can open ods testfile and reads its content correctly' do
@@ -119,7 +119,7 @@ describe Rspreadsheet do
       book.save
       book.save('/tmp/different_filename.ods')
     end.not_to raise_error
-    File.delete('/tmp/different_filename.ods') if File.exists?('/tmp/different_filename.ods') # delete after tests
+    File.delete('/tmp/different_filename.ods') if File.exist?('/tmp/different_filename.ods') # delete after tests
   end
   it 'examples from advanced syntax GUIDE are working' do
     def p(*par); end # supress p in the example

data/spec/spec_helper.rb

@@ -2,10 +2,26 @@
 require 'bundler/setup'
 Bundler.setup
 
-RSpec.configure do |c|
-  c.fail_fast = true
-#   c.warnings = true
-  c.treat_symbols_as_metadata_keys_with_true_values = true # so i can run individual test just by appending :focus to them
+RSpec.configure do |config|
+  config.fail_fast = true
+#   config.warnings = true
+  
+  # so i can run individual test just by appending :focus to them
+  config.treat_symbols_as_metadata_keys_with_true_values = true if config.respond_to? :treat_symbols_as_metadata_keys_with_true_values= # older form
+#  config.filter_run_when_matching(:focus)     
+    
+## preparing for RSpec 4 (will be default in RSpec 4
+  
+  if config.respond_to? :expect_with and config.respond_to? :include_chain_clauses_in_custom_matcher_descriptions  
+    config.expect_with :rspec do |expectations|
+      expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+    end
+  end
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true if mocks.respond_to? :verify_partial_doubles
+  end
+  config.shared_context_metadata_behavior = :apply_to_host_groups if config.respond_to? :shared_context_metadata_behavior
+
 end
 
 # this enables Coveralls
@@ -18,3 +34,6 @@ $test_filename_images = './spec/testfile2-images.ods'
 
 # require my gem
 require 'rspreadsheet'
+
+
+

data/spec/spec_helper.rb.template

@@ -0,0 +1,100 @@
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

data/spec/worksheet_spec.rb

@@ -90,6 +90,8 @@ describe Rspreadsheet::Worksheet do
       @sheet[-2,-5].should be_nil
       
       Rspreadsheet.raise_on_negative_coordinates = pom  # reset the setting back
+  
+      Rspreadsheet.configuration { |config| config.raise_on_negative_coordinates.should be == pom }
     end
     it 'returns nil with negative index or raise if configured to do so' do
       pom = Rspreadsheet.raise_on_negative_coordinates

data/spec/xml_tied_spec.rb

@@ -25,6 +25,6 @@ describe Rspreadsheet::XMLTiedArray do
     
     tx = TestXMLTiedArray.new
     expect {tx.insert_new_empty_subnode_before(0)}.to raise_error IndexError
-    expect {tx.insert_new_empty_subnode_before(1)}.to raise_error /create empty xmlnode/
+    expect {tx.insert_new_empty_subnode_before(1)}.to raise_error(/create empty xmlnode/)
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspreadsheet
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.7
 platform: ruby
 authors:
 - Jakub A.Těšínský
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-04 00:00:00.000000000 Z
+date: 2019-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -42,30 +42,36 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.5'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.5'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -108,9 +114,10 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
-description: Manipulating OpenDocument spreadsheets with Ruby. This gem can create
-  new, read existing files abd modify them. When modyfying files, it tries to change
-  as little as possible, making it as much forward compatifle as possible.
+description: Manipulating LibreOffice Calc (OpenDocument Spreadsheet) files with Ruby.
+  This gem can create new, read existing files abd modify them. When modyfying files,
+  it tries to change as little as possible, making it as much forward compatible as
+  possible.
 email:
 - jAkub.cz (A is at)
 executables: []
@@ -159,6 +166,7 @@ files:
 - spec/row_spec.rb
 - spec/rspreadsheet_spec.rb
 - spec/spec_helper.rb
+- spec/spec_helper.rb.template
 - spec/test-image-blue.png
 - spec/test-image.png
 - spec/testfile1.ods
@@ -187,11 +195,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
-summary: Manipulating spreadsheets with Ruby (read / create / modify OpenDocument
-  Spreadsheet).
+summary: Manipulating LibreOffice Calc (OpenDocument Spreadsheet) files from Ruby
+  (read / create / modify).
 test_files:
 - spec/cell_spec.rb
 - spec/class_extensions_spec.rb
@@ -202,6 +210,7 @@ test_files:
 - spec/row_spec.rb
 - spec/rspreadsheet_spec.rb
 - spec/spec_helper.rb
+- spec/spec_helper.rb.template
 - spec/test-image-blue.png
 - spec/test-image.png
 - spec/testfile1.ods