rspotify 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3821a59eda0417ad48c54dfedcb48f81e7b9a20d
-  data.tar.gz: c00df9a3e146bec3f253d6837295e7b2b1ee8291
+  metadata.gz: 4976cbb938eca04f4a36e3084052c4ed1fb0d119
+  data.tar.gz: 0f6d2a0a7a6a5a73eda3d8e5a26ca4e6070c0de1
 SHA512:
-  metadata.gz: 639c192ff705248d9567659cbec7acfb799ed97c185810efb73fe380e64d5302894111bb0a79cc8a6567f0e22e87177663db1a5816dcd233eb70c388bba14771
-  data.tar.gz: 3331bbe544c3ca3ad49cdeb3802effc5c223c16d9345e354a161d165b8b77b16f66057a81b47247a89ad0424083ad922611afcad620702af16176208830a8771
+  metadata.gz: fa34c1e3e875b2bf8d34a65d0f524473a5d28aaf7b997da6f30b2c7d0de4024bf965523cf23f9ff1368138042eaee4702fcc561012746b8f155687533f9ac3f4
+  data.tar.gz: 7d3a74a7c1308fcabb2297f6968f9e6bebb87c88d4175305b971682f4116f8db37de6ad900676be3e61f79ad7db4ac4c665ab9a52cd156a7aab5842d67864283

data/README.md

@@ -28,7 +28,7 @@ artists = RSpotify::Artist.search('Arctic Monkeys')
 arctic_monkeys = artists.first
 arctic_monkeys.popularity      #=> 74
 arctic_monkeys.genres          #=> ["Alternative Pop/Rock", "Indie", ...]
-arctic_monkeys.top_tracks[:US] #=> (Track array)
+arctic_monkeys.top_tracks(:US) #=> (Track array)
 
 albums = arctic_monkeys.albums
 albums.first.name #=> "AM"
@@ -51,7 +51,7 @@ albums = RSpotify::Album.search('The Wall')
 tracks = RSpotify::Track.search('Thriller')
 ```
 
-If you prefer, you can find them directly by id:
+Find by id:
 
 ```ruby
 arctic_monkeys = RSpotify::Artist.find('7Ln80lUS6He07XvHI8qqHH')
@@ -81,7 +81,7 @@ Then just copy and paste them like so:
 ```ruby
 RSpotify.authenticate("<your_client_id>", "<your_client_secret>")
 
-# Now you can access any public playlist and much more!
+# Now you can access any public playlist and much more
 
 playlist = RSpotify::Playlist.find('wizzler', '00wHcTN0zQiun4xri9pmvX')
 playlist.name               #=> "Movie Soundtrack Masterpieces"

data/lib/rspotify.rb

@@ -27,7 +27,6 @@ module RSpotify
   end
 
   VERBS.each do |verb|
-
     define_singleton_method verb do |path, *params|
       url = API_URI + path
       response = RestClient.send(verb, url, *params)

data/lib/rspotify/base.rb

@@ -58,10 +58,10 @@ module RSpotify
 
     # Returns array of RSpotify objects matching the query, ordered by popularity
     #
-    # @param query [String]
-    # @param type [String]
-    # @param limit [Integer]
-    # @param offset [Integer]
+    # @param query  [String]  The search query's keywords.
+    # @param type   [String]  Valid types are: album, artist and track
+    # @param limit  [Integer] Maximum number of objects to return. Minimum: 1. Maximum: 50.
+    # @param offset [Integer] The index of the first object to return. Use with limit to get the next set of objects.
     # @return [Array<Album>, Array<Artist>, Array<Track>]
     #
     # @example
@@ -73,6 +73,11 @@ module RSpotify
     #           albums = RSpotify::Base.search('AM', 'album', 10)
     #           albums.size #=> 10
     def self.search(query, type, limit = 20, offset = 0)
+      if limit < 1 || limit > 50
+        warn "Limit must be between 1 and 50"
+        return false
+      end
+
       pluralized_type = "#{type}s"
       type_class = RSpotify.const_get(type.capitalize)
 
@@ -123,13 +128,13 @@ module RSpotify
     #           track.instance_variable_get("@popularity") #=> 62
     def method_missing(method_name, *args)
       attr = "@#{method_name}"
-      super unless instance_variable_defined? attr 
+      super unless instance_variable_defined? attr
 
-      attr_value = instance_variable_get attr 
+      attr_value = instance_variable_get attr
       return attr_value unless attr_value.nil?
 
       complete!
-      instance_variable_get attr 
+      instance_variable_get attr
     end
 
     # Overrides Object#respond_to? to also consider methods dynamically generated by {#method_missing}

data/lib/rspotify/playlist.rb

@@ -26,7 +26,7 @@ module RSpotify
     end
 
     # Spotify does not support search for playlists. Prints warning and returns false
-    def self.search(*args)
+    def self.search(*)
       warn 'Spotify API does not support search for playlists'
       false
     end

data/lib/rspotify/user.rb

@@ -16,7 +16,7 @@ module RSpotify
     end
 
     # Spotify does not support search for users. Prints warning and returns false
-    def self.search(*args)
+    def self.search(*)
       warn 'Spotify API does not support search for users'
       false
     end

data/lib/rspotify/version.rb

@@ -1,3 +1,3 @@
 module RSpotify
-  VERSION = '0.7.0'
+  VERSION = '0.7.1'
 end

data/spec/lib/rspotify/playlist_spec.rb

@@ -16,7 +16,7 @@ describe RSpotify::Playlist do
       expect(@playlist.collaborative)            .to eq    false
       expect(@playlist.external_urls['spotify']) .to eq    'http://open.spotify.com/user/wizzler/playlist/00wHcTN0zQiun4xri9pmvX'
       expect(@playlist.description)              .to match /Iconic soundtracks featured in some of the greatest movies/
-      expect(@playlist.followers['total'])       .to eq    12
+      expect(@playlist.followers['total'])       .to be    > 0
       expect(@playlist.href)                     .to eq    'https://api.spotify.com/v1/users/wizzler/playlists/00wHcTN0zQiun4xri9pmvX'
       expect(@playlist.id)                       .to eq    '00wHcTN0zQiun4xri9pmvX'
       expect(@playlist.images.first['url'])      .to match %r{https://dv72vokf4bztv\.cloudfront}

data/spec/lib/rspotify/track_spec.rb

@@ -10,7 +10,7 @@ describe RSpotify::Track do
     it 'should find track with correct attributes' do
       expect(@track.available_markets)        .to include *%w(AD AT BE BG CA EE ES FR GR MC TW US)
       expect(@track.disc_number)              .to eq 1
-      expect(@track.duration_ms)              .to eq 272394
+      expect(@track.duration_ms)              .to eq 272_394
       expect(@track.explicit)                 .to eq false
       expect(@track.external_ids['isrc'])     .to eq 'GBCEL1300362'
       expect(@track.external_urls['spotify']) .to eq 'https://open.spotify.com/track/3jfr0TF6DQcOLat8gGn7E2'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspotify
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Guilherme Sad
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-27 00:00:00.000000000 Z
+date: 2014-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest_client