rspec_trunk_flaky_tests 0.16.0-x86_64-linux-gnu → 0.16.1.pre.beta.1-x86_64-linux-gnu

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4aa42bb66e71ae7974d8266a4f855e200ac9360b2163076570dc3fb6f80a981b
-  data.tar.gz: b3b0812cb108a512545ea9fca4b78463494dff6f9c02d56dde8605ad53458c95
+  metadata.gz: edc3377f870ba1220f46175a4ff60805876690e64d6d4cf6a7f0edf28ae0e3cd
+  data.tar.gz: 480eb3025ac401c2a91450f1b3a0443446a87903426291f77bb4c33a28f1caad
 SHA512:
-  metadata.gz: 92a82de9f5ea29e2af865d58ccc5c2f4864e5e2ce3768a83220f89154a5021ef7d6a5a9e2743251870205ee0ed2b7f94c0fee82529bffaa8e95408c2fa6facc1
-  data.tar.gz: b74348928e274919853bb9aa04cfc6b0ad2836d7cba27045dcc86f8c205a0a028e64377f954aa3bdb35f54bf0d73714017a92e3546b7fbf2667392daad991b57
+  metadata.gz: 7949788d501fa9df38cf087f23d169a745eeef19e278a63280d4c56eec0fd2ed137bf66b8ef0f61b3541eb87037f9a9cd5529a7f57017b159570d82105bb40fa
+  data.tar.gz: 1d6fd2a9d9a4c58bdd66496be18a4c1801d1f05f6ce065977966b03779d29de33903677282cb7b3cc0167abd6005dfcc52c0011283dd72fc21dc9e49d8a04e48

data/lib/trunk_spec_helper.rb

@@ -71,13 +71,25 @@ module RSpec
 
         run = @current_run = Run.new
         RSpec::Core::Example.prepend(ExampleExtension)
-        RSpec.configure do |config|
-          config.before(:example) do
-            skip('Quarantine lookup failed, skipping test run') if run.abort_remaining?
-          end
-          config.around(:each) { |example| Trunk.run_counting_attempts(example) }
-          config.reporter.register_listener AnalyticsListener.new(run), :example_finished, :close
+        RSpec::Core::ExampleGroup.singleton_class.prepend(ExampleGroupExtension)
+        RSpec.configure { |config| install(config, run) }
+      end
+
+      def install(config, run)
+        # prepend_before, to also run ahead of before hooks configured before this file was required.
+        config.prepend_before(:example) do |example|
+          run.start_attempt(example)
+          next unless run.abort_remaining?
+
+          # RSpec starts no new examples once it wants to quit, so this is an in-place
+          # re-run (e.g. rspec-retry), where a skip would hide the failure.
+          failure = run.abort_failure(example)
+          raise failure if failure
+
+          skip('Quarantine lookup failed, skipping test run')
         end
+        config.around(:each) { |example| Trunk.run_counting_attempts(example) }
+        config.reporter.register_listener AnalyticsListener.new(run), :example_finished, :close
       end
 
       def disabled?
@@ -163,6 +175,8 @@ module RSpec
         @report = report
         @quarantining_disabled = false
         @lookup_failed = false
+        @abort_failures = {}.compare_by_identity
+        @quarantined_failures = {}.compare_by_identity
       end
 
       def quarantining_disabled?
@@ -177,9 +191,20 @@ module RSpec
         lookup_failed? && Trunk.quarantine_query_failure_exit?
       end
 
+      def abort_failure(example)
+        @abort_failures[example]
+      end
+
+      def start_attempt(example)
+        @quarantined_failures.delete(example)
+      end
+
       # Whether a failure of `example` with `exception` is quarantined. If the
       # quarantine machinery itself blows up, the failure must stand.
       def quarantine?(example, exception)
+        # A replayed abort failure didn't happen on this attempt, so it can't be quarantined.
+        return false if abort_failure(example).equal?(exception)
+
         check_quarantine(example, exception)
       rescue StandardError => e
         puts Colors.yellow("Quarantine check errored (#{e.class}: #{e.message}), treating test as not quarantined")
@@ -202,10 +227,7 @@ module RSpec
             puts Colors.yellow('Failed to check quarantining status, no failures will be quarantined')
             @lookup_failed = true
           end
-          if Trunk.quarantine_query_failure_exit?
-            puts Colors.red('Quarantine lookup failed, exiting early')
-            RSpec.world.wants_to_quit = true
-          end
+          abort_run(example, exception) if Trunk.quarantine_query_failure_exit?
           false
         elsif result.quarantining_disabled_for_repo
           unless quarantining_disabled?
@@ -214,8 +236,7 @@ module RSpec
           end
           false
         elsif result.test_is_quarantined
-          # monitor the override in the metadata
-          Trunk.write_metadata(example.metadata, :trunk_quarantined_exception, exception)
+          record_quarantined(example, exception)
           puts Colors.green("Test is quarantined, overriding exception: #{exception}")
           true
         else
@@ -223,6 +244,19 @@ module RSpec
           false
         end
       end
+
+      def abort_run(example, exception)
+        puts Colors.red('Quarantine lookup failed, exiting early')
+        # The first: a replay's after hooks raise their own errors again anyway.
+        @abort_failures[example] ||= exception
+        RSpec.world.wants_to_quit = true
+      end
+
+      def record_quarantined(example, exception)
+        failures = (@quarantined_failures[example] ||= []) << exception
+        recorded = failures.one? ? exception : RSpec::Core::MultipleExceptionError.new(*failures)
+        Trunk.write_metadata(example.metadata, :trunk_quarantined_exception, recorded)
+      end
     end
 
     # Prepended to RSpec::Core::Example. RSpec uses the existence of an exception
@@ -268,6 +302,22 @@ module RSpec
       end
     end
 
+    # RSpec fails the run when a before(:context) hook raises, even if every example's failure was
+    # quarantined. A green status alone isn't enough: a pending example hides the error in its
+    # pending_exception and still ends up :passed.
+    module ExampleGroupExtension
+      def run(reporter = RSpec::Core::NullReporter)
+        passed = super
+        return passed unless passed == false && Trunk.current_run
+
+        examples = descendant_filtered_examples
+        examples.any? && examples.all? do |example|
+          example.metadata[:trunk_quarantined_exception] &&
+            %i[passed pending].include?(example.execution_result.status)
+        end
+      end
+    end
+
     # Formats failures for the report as plain text suitable for storage and the web UI.
     module FailureFormatter
       # A no-op colorizer passed to RSpec's ExceptionPresenter.
@@ -362,12 +412,15 @@ module RSpec
         @run = run
       end
 
+      # --dry-run reports every example as passed without running it.
       def example_finished(notification)
-        add_test_case(notification.example)
+        add_test_case(notification.example) unless RSpec.configuration.dry_run?
       end
 
       # trunk-ignore(rubocop/Metrics/MethodLength,rubocop/Metrics/AbcSize)
       def close(_notification)
+        return if RSpec.configuration.dry_run?
+
         if @run.quarantining_disabled?
           puts Colors.yellow('Note: Quarantining is disabled for this repo. Test failures were not quarantined.')
         end
@@ -407,8 +460,8 @@ module RSpec
         name = example.full_description
         file, classname = Trunk.file_and_classname(example)
         line = example.metadata[:line_number]
-        started_at = example.execution_result.started_at.to_i
-        finished_at = example.execution_result.finished_at.to_i
+        started_at = example.execution_result.started_at.to_f
+        finished_at = example.execution_result.finished_at.to_f
 
         attempt_number = example.metadata[:retry_attempts] || example.metadata[:trunk_attempt_number] || 0
         # set the status to failure, but mark it as quarantined

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_trunk_flaky_tests
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1.pre.beta.1
 platform: x86_64-linux-gnu
 authors:
 - Trunk Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2026-09-28 00:00:00.000000000 Z
+date: 2026-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core