rspec_trunk_flaky_tests 0.14.0.pre.beta.2 → 0.14.0.pre.beta.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 408ca964aad8a355970e382136d223184afff694543cefaa546170a405a0d5cf
-  data.tar.gz: d52653eb7de5b9d3f58983bdb14d76fdb364b7f9976abf6ac8876652cacbc30c
+  metadata.gz: 69ead5f580e531391a6a6746a7160e5d719cb92ffb911fc5b818d75120501f3f
+  data.tar.gz: a4bc7a5438e9d233ef8048a7c84871f0709af2ec13b2f6b975313fbd8531176d
 SHA512:
-  metadata.gz: 862f020fd6c96d7fe08f572a001ae7d8d4db383e0048a45a04aea7afc0b7261e1efafcf1f1c677e9271bf60195513a2f8317f8c478be8178757ce00659eebe49
-  data.tar.gz: 0f87e16e146da81248d386b9d60aadd6c0b3f1f8646eb0d6751947cbbac9ca2e8e00be842fa04bccc7ce2d9a9ee391d2f8f8a17bb7148c04e96f203bfacaebce
+  metadata.gz: 7ff22ceedb68d2e03c816681013359a5a6b917e28a72e51de8aebe2131fead066c8859da274715a8f0062123c1a361747ff3ebe45600542d72c375d4a8c79b47
+  data.tar.gz: 0adb3eba10a07cbe34392d2aefe253bde069dcfaa0ac621e60c294225bd7b7bac34115845520be2bfb8d502224b36bf0cd545fc3845c7fd231daafbcda7f736e

data/lib/trunk_spec_helper.rb

@@ -108,11 +108,25 @@ module RSpec
       # decide if we want to fail the test or not
       # trunk-ignore(rubocop/Naming/AccessorMethodName)
       def set_exception(exception)
-        return set_exception_core(exception) if metadata[:pending]
+        # Pending stays green, except a fixed pending example is a real failure.
+        return set_exception_core(exception) if metadata[:pending] && !pending_example_fixed?(exception)
         return set_exception_core(exception) if trunk_disabled
         return set_exception_core(exception) if metadata[:retry_attempts]&.positive?
 
+        handle_quarantine_check_safely(exception)
+      end
+
+      # If the quarantine machinery itself blows up, the failure must stand.
+      def handle_quarantine_check_safely(exception)
         handle_quarantine_check(exception)
+      rescue StandardError => e
+        puts "Quarantine check errored (#{e.class}: #{e.message}), treating test as not quarantined".yellow
+        set_exception_core(exception)
+      end
+
+      def pending_example_fixed?(exception)
+        defined?(RSpec::Core::Pending::PendingExampleFixedError) &&
+          exception.is_a?(RSpec::Core::Pending::PendingExampleFixedError)
       end
 
       # trunk-ignore(rubocop/Metrics/AbcSize,rubocop/Metrics/MethodLength,rubocop/Metrics/CyclomaticComplexity)
@@ -401,10 +415,13 @@ class TrunkAnalyticsListener
       # the build (the pending expectation was violated), so it is a failure here too.
       [Status.new('failure'), example.exception || quarantined_exception]
     when :pending
-      # Not a skip (handled above), so this is a pending example whose body ran and
-      # failed as expected: the pending expectation ("this should fail") was met, so
-      # RSpec keeps the build green -- report it as a success.
-      [Status.new('success'), nil]
+      # A quarantined fixed-pending is left :pending but pending_fixed? -- still a
+      # failure. Otherwise the pending "should fail" expectation was met -> success.
+      if result.pending_fixed?
+        [Status.new('failure'), quarantined_exception || example.exception]
+      else
+        [Status.new('success'), nil]
+      end
     else
       [Status.new(result.status.to_s), example.exception || quarantined_exception]
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec_trunk_flaky_tests
 version: !ruby/object:Gem::Version
-  version: 0.14.0.pre.beta.2
+  version: 0.14.0.pre.beta.3
 platform: ruby
 authors:
 - Trunk Technologies, Inc.