rspec_starter 1.7.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1947eae49107431f8c61def126cb43b29b32629cff7a2bee05797122feedf40d
-  data.tar.gz: fa7e4572d94a5772d7cc381e38e6e439fde32e76b53600a0f180ae0dac5921b9
+  metadata.gz: 4a565e16879216ea00dd45fcfbff269c7f9f56a85bad93172001b15bb719f0fc
+  data.tar.gz: fdcaadb0b04aa523ffe1a5c63b4bc2e2338980bca0d24a904754982362c7e27b
 SHA512:
-  metadata.gz: e01eca047641fc5580e601ad8f90b814b60d3965a4b45dfb2422ae3df33d1216f1e45a7a80c9b593370de371086b74f0ff0d43494f478ed511c98e4ab3628e79
-  data.tar.gz: 25a3ca57549ba4c59b196b4d463a8988277f243040fe6231032a460602b6a82d6c110b6dc7c95f72fdb0762a83aac13beb5111363c475ee2693f0b3b57ec8a39
+  metadata.gz: 7adf0a1b84fb3afa6bd4e9c498767e99f371233cf236e46f3ba2f8c75f445368dbbde80ea11ad37a24ab17469f5838192101c0b8b6c66bb045d9f92e8d3b81ec
+  data.tar.gz: 165ac11d37d3ddbdda32bd8040a138d684474835f1334d89f9385a67ed1a55970a9e4476024b239c2c8a0fa0b1799fcacaa3273301aaeccad8eb5606bfdc6fe4

data/.github/workflows/check_pull_request.yml

@@ -0,0 +1,54 @@
+# This workflow will download prebuilt Ruby versions, install dependencies and run checks against Pull Requests.
+
+name: Check Pull Request
+on:
+  pull_request:
+    branches: [ master ]
+env:
+  # The pull request can have less than, or equal to, this number of rubocop issues and pass.
+  RUBOCOP_ISSUE_THRESHOLD: 5
+jobs:
+  rspec:
+    name: Run RSpec
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.6', '2.7', '3.0']
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+        # change this to (see https://github.com/ruby/setup-ruby#versioning):
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Execute rspec command
+        run: bundle exec rspec
+  rubocop:
+    name: Run Rubocop
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.6']
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+        # change this to (see https://github.com/ruby/setup-ruby#versioning):
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Execute rubo command
+        run: bundle exec rubo
+      - name: Evaluate rubo threshold
+        run: |
+          count=$(cat rubocop/total-violations-count.txt)
+          if [[ "$count" -gt $RUBOCOP_ISSUE_THRESHOLD ]]; then
+              echo "Failure: Found $count RuboCop issue(s). It must have $RUBOCOP_ISSUE_THRESHOLD or less. \
+          Run 'rubo' and resolve the issues listed in rubocop/style-issues.html"
+              exit 1
+          else
+              echo "Success: Found $count RuboCop issue(s), which is less than the limit of $RUBOCOP_ISSUE_THRESHOLD"
+          fi

data/.rubocop.yml

@@ -12,9 +12,3 @@ inherit_gem:
 
 Rails:
   Enabled: false
-
-Style/NumericPredicate:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false

data/CHANGELOG.md

@@ -1,63 +1,87 @@
 # CHANGELOG
 
-Issues marked as **(Internal)** mark internal development work. Issues are tracked at https://github.com/roberts1000/rspec_starter/issues.
+Issues are tracked at https://github.com/roberts1000/rspec_starter/issues. Issues marked as **(Internal)** only affect development.
+
+## 2.0.0 (Aug 11, 2021)
+
+1. [#101](../../issues/101): Remove Ruby 2.4 support.
+1. [#106](../../issues/106): Remove Ruby 2.5 support.
+1. [#109](../../issues/109): Remove support for legacy API.
+1. [#112](../../issues/112): Change `--no-xvfb` ref to `--skip-display-server` in help output.
+1. [#114](../../issues/114): Fix `quiet` and `stop_on_problem` not getting overridden through the `start` block.
+1. [#116](../../issues/116): Setup GitHub Pull Request action. **(Internal)**
+1. [#120](../../issues/120): Add `rubocop_plus` `~> 2.0` to the `Gemfile`. **(Internal)**
+
+## 1.8.1 (Apr 14, 2020)
+
+1. [#97](../../issues/97): Fix "Using the last argument as keyword" deprecation warning.
+
+## 1.8.0 (Apr 03, 2020)
+
+1. [#88](../../issues/88): Use `os ~> 1.1.0`.
+1. [#90](../../issues/90): Use `pry-byebug ~> 3.9.0`. **(Internal)**
+1. [#92](../../issues/92): Update ruby versions in `.travis.yml`. **(Internal)**
+
+## 1.7.2 (Dec 20, 2019)
+
+1. [#84](../../issues/84): Removed unneeded `/` in templates.
 
 ## 1.7.1 (Dec 13, 2019)
 
-1. [#80](../../issues/80) Fix call to missing `remove_dummy` method.
+1. [#80](../../issues/80): Fix call to missing `remove_dummy` method.
 
 ## 1.7.0 (Dec 12, 2019)
 
-1. [#74](../../issues/74) Make `rspec_starter --init` detect Rails engines correctly.
-1. [#75](../../issues/75) Let `remove_tmp_folder` task remove the tmp folder from `dummy` apps.
+1. [#74](../../issues/74): Make `rspec_starter --init` detect Rails engines correctly.
+1. [#75](../../issues/75): Let `remove_tmp_folder` task remove the tmp folder from `dummy` apps.
 
 ## 1.6.0 (Dec 09, 2019)
 
-1. [#56](../../issues/56) Move old starter code to a `legacy` folder so it can still be used. **(Internal)**
-1. [#58](../../issues/58) Add step based interface.
-1. [#59](../../issues/59) Use `rake ~> 13.0` for development. **(Internal)**
-1. [#61](../../issues/61) Use `pry-byebug ~> 3.7.0` for development. **(Internal)**
-1. [#63](../../issues/63) Modernize the CHANGELOG. **(Internal)**
-1. [#66](../../issues/66) Update ruby versions and use bundler 2.0.2 in `travis.yml`. **(Internal)**
+1. [#56](../../issues/56): Move old starter code to a `legacy` folder so it can still be used. **(Internal)**
+1. [#58](../../issues/58): Add step based interface.
+1. [#59](../../issues/59): Use `rake ~> 13.0` for development. **(Internal)**
+1. [#61](../../issues/61): Use `pry-byebug ~> 3.7.0` for development. **(Internal)**
+1. [#63](../../issues/63): Modernize the CHANGELOG. **(Internal)**
+1. [#66](../../issues/66): Update ruby versions and use bundler 2.0.2 in `travis.yml`. **(Internal)**
 
 ## 1.5.0 (Feb 19, 2019)
 
-1. [#51](../../issues/51) Report an exit status of 1 if DB Preparation or RSpec fails.
+1. [#51](../../issues/51): Report an exit status of 1 if DB Preparation or RSpec fails.
 
 ## 1.4.0 (Oct 12, 2018)
 
-1. [#41](../../issues/41) Isolate rebuild command string into a dedicated method. **(Internal)**
-1. [#43](../../issues/43) Add instructions for creating custom steps.
-1. [#45](../../issues/45) Fix the database rebuild command hanging when there's too much output.
+1. [#41](../../issues/41): Isolate rebuild command string into a dedicated method. **(Internal)**
+1. [#43](../../issues/43): Add instructions for creating custom steps.
+1. [#45](../../issues/45): Fix the database rebuild command hanging when there's too much output.
 
 ## 1.3.0 (Aug 30, 2018)
 
-1. [#37](../../issues/37) Change `cri` version to `~> 2.0`.
+1. [#37](../../issues/37): Change `cri` version to `~> 2.0`.
 
 ## 1.2.0 (Aug 08, 2018)
 
-1. [#23](../../issues/23) Remove `rubocop_plus` from Gemfile. **(Internal)**
-1. [#24](../../issues/24) Update ruby versions in `.travis.yml`. **(Internal)**
-1. [#26](../../issues/26) Use `bundler` `1.16.3` in `.travis.yml`. **(Internal)**
-1. [#29](../../issues/29) Use `cri` `~> 2.12.0`.
-1. [#31](../../issues/31) Remove support for Ruby 2.2.
-1. [#33](../../issues/33) Use `rake` `~> 12.0` in development. **(Internal)**
+1. [#23](../../issues/23): Remove `rubocop_plus` from Gemfile. **(Internal)**
+1. [#24](../../issues/24): Update ruby versions in `.travis.yml`. **(Internal)**
+1. [#26](../../issues/26): Use `bundler` `1.16.3` in `.travis.yml`. **(Internal)**
+1. [#29](../../issues/29): Use `cri` `~> 2.12.0`.
+1. [#31](../../issues/31): Remove support for Ruby 2.2.
+1. [#33](../../issues/33): Use `rake` `~> 12.0` in development. **(Internal)**
 
 ## 1.1.1 (May 06, 2018)
 
-1. [#6](../../issues/6) Cleanup rubocop issues in the `start_rspec` template.
+1. [#6](../../issues/6): Cleanup rubocop issues in the `start_rspec` template.
 
 ## 1.1.0 (Feb 02, 2018)
 
-1. [#5](../../issues/5) Ensure XVFB is detected correctly.
-1. [#7](../../issues/7) Prepare the database when the project is a Rails engine.
-1. [#9](../../issues/9) Add an `rspec_starter --init` command that installs an initial script.
-1. [#11](../../issues/11) Add `rubocop_plus` gem for internal code cleanup. **(Internal)**
-1. [#15](../../issues/15) Change the highlight color of the output from yellow to blue.
+1. [#5](../../issues/5): Ensure XVFB is detected correctly.
+1. [#7](../../issues/7): Prepare the database when the project is a Rails engine.
+1. [#9](../../issues/9): Add an `rspec_starter --init` command that installs an initial script.
+1. [#11](../../issues/11): Add `rubocop_plus` gem for internal code cleanup. **(Internal)**
+1. [#15](../../issues/15): Change the highlight color of the output from yellow to blue.
 
 ## 1.0.1 (May 10, 2017)
 
-1. [#1](../../issues/1) Improve the logic for deciding when the database preparation step successfully completes.
+1. [#1](../../issues/1): Improve the logic for deciding when the database preparation step successfully completes.
 
 ## 1.0.0 (Apr 06, 2017)
 

data/Gemfile

@@ -2,3 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rspec_starter.gemspec
 gemspec
+
+group :development do
+  gem 'rubocop_plus', '~> 2.0', require: false
+end

data/LICENSE.md

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2017
+Copyright (c) 2021 roberts1000
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -6,13 +6,16 @@ rspec_starter also helps eliminate differences between operating systems. For ex
 
 rspec_starter currently works natively for Rails applications, Rails Engines and raw ruby applications/gems that are not database dependent. However, rspec_starter is flexible and you can add your own tasks to support other types of projects.
 
-## Version Strategy
+## Versioning Strategy
 
-Releases are versioned using [semver 2.0.0](https://semver.org/spec/v2.0.0.html).
+Releases are versioned using [SemVer 2.0.0](https://semver.org/spec/v2.0.0.html) with the following caveats:
+
+1. Support for a Ruby version, that reaches EOL, is removed in a major or minor release.
+1. Support for a Ruby on Rails version, that reaches EOL, is removed in a major or minor release.
 
 ## Supported Ruby Versions
 
-2.3.0+
+2.6.0+
 
 ## Installation
 
@@ -231,5 +234,4 @@ Run `bin/start_rspec --help` to see a list of command line options. Command line
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/roberts1000/rspec_starter.
-
+Bug reports and pull requests are welcome on the rspec_starter [issues](https://github.com/roberts1000/rspec_starter) page.

data/Rakefile

@@ -5,8 +5,7 @@ RSpec::Core::RakeTask.new(:spec)
 
 task :default => :spec
 
-# Adds the ability to run 'rake console' in the terminal and have a console
-# that already knows about the gem
+desc "Start a Pry console with rspec_starter loaded (run bin/console to start an IRB console)"
 task :console do
   exec "pry -r rspec_starter -I ./lib"
   # exec "irb -r didit_rails_framework -I ./lib"

data/bin/console

@@ -6,5 +6,7 @@ require "rspec_starter"
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-require "pry"
-Pry.start
+# Run 'rake console' to start a pry console.
+
+require "irb"
+IRB.start

data/exe/rspec_starter

@@ -65,12 +65,9 @@ command = Cri::Command.define do
     exit 0
   end
 
-  run do |options, args, cmd|
-  end
+  run
 end
 # rubocop:enable Metrics/BlockLength
 
-begin
-  command.run(ARGV)
-  exit 0
-end
+command.run(ARGV)
+exit 0

data/lib/rspec_starter.rb

@@ -31,17 +31,15 @@ require 'rspec_starter/tasks/remove_tmp_folder'
 require 'rspec_starter/tasks/start_rspec'
 require 'rspec_starter/tasks/verify_display_server'
 
-require 'rspec_starter/legacy'
-
 # Setup pry for development when running "rake console". Guard against load
 # errors in production (since pry is only loaded as a DEVELOPMENT dependency
 # in the .gemspec)
-# rubocop:disable Lint/HandleExceptions
+# rubocop:disable Lint/SuppressedException
 begin
   require "pry"
 rescue LoadError
 end
-# rubocop:enable Lint/HandleExceptions
+# rubocop:enable Lint/SuppressedException
 
 # The main entry point for the RspecStarter gem. The 'bin/start_rspec' file contains a block of code like this:
 #
@@ -54,9 +52,8 @@ end
 # The start method that is executed is show below. The call to 'instance_eval(&block)' below is the special sauce that
 # makes 'self' equal the RspecStarter module inside the block.
 module RspecStarter
-  def self.start(defaults={}, &block)
-    # If a block is missing, then the user is using the old method based starter.
-    return invoke_legacy_starter(defaults) unless block_given?
+  def self.start(&block)
+    show_missing_start_block_error_and_exit unless block
 
     # Loads the information from the bin/start_rspec file and loads/parses the options. Provides info to the @runner.
     @environment = Environment.new(ARGV, &block)
@@ -80,7 +77,18 @@ module RspecStarter
       end
 
       # If we get here RSpec has been started and the rspec_starter's job is done.
-      exit(0)
+      exit 0
     end
   end
+
+  def self.show_missing_start_block_error_and_exit
+    msg = "Error: RspecStarter.start was called without a block. It should be called like this: \n\n" \
+          "       RspecStarter.start do\n" \
+          "         command \"echo 'something'\"\n" \
+          "         task :some_task_name\n" \
+          "         #     ... more tasks and commands ...\n" \
+          "       end".colorize(:red)
+    puts msg
+    exit 1
+  end
 end

data/lib/rspec_starter/command.rb

@@ -45,7 +45,7 @@ module RspecStarter
       puts @stdout
       puts @stderr
       puts "There was an error running '#{@command_string}'. It returned with exit status #{@status.exitstatus}.\n" \
-        "See the output above for details or manually run the command for more information.".colorize(:red)
+           "See the output above for details or manually run the command for more information.".colorize(:red)
     end
 
     def colored_command_string

data/lib/rspec_starter/help.rb

@@ -42,17 +42,17 @@ module RspecStarter
   end
 
   def self.write_help_examples_section(colored_script_name)
-    # rubocop:disable Metrics/LineLength
     puts "\nExamples:"
     puts "       #{colored_script_name} #{'spec/features'.colorize(:light_blue)} (only run specs in the specs/features folder)"
+    # rubocop:disable Layout/LineLength
     puts "       #{colored_script_name} #{'spec/features/some_spec:53'.colorize(:light_blue)} (run the spec on line 53 of the spec/features_some_spec.rb file)"
-    puts "       #{colored_script_name} #{'--no-xvfb'.colorize(:light_blue)} #{'spec/requests/some_spec'.colorize(:light_blue)} (don't start XVFB since it's not needed for request specs)"
+    puts "       #{colored_script_name} #{'--skip-display-server'.colorize(:light_blue)} #{'spec/requests/some_spec'.colorize(:light_blue)} (don't start XVFB since it's not needed for request specs)"
+    # rubocop:enable Layout/LineLength
     puts "       #{'SIMPLECOV_FORMATTER=rcov'.colorize(:light_blue)} #{colored_script_name} (use with environment variables)\n"
-    # rubocop:enable Metrics/LineLength
   end
 
   def self.write_available_tasks
-    subclasses = ObjectSpace.each_object(Class).select { |klass| klass < RspecStarterTask }.sort { |a, b| a.name <=> b.name }
+    subclasses = ObjectSpace.each_object(Class).select { |klass| klass < RspecStarterTask }.sort_by(&:name)
 
     puts "\nAvailable Tasks:"
     subclasses.each do |klass|
@@ -62,26 +62,32 @@ module RspecStarter
   end
 
   def self.write_task_info(colored_script_name)
-    puts "\nTask Options:"
-    puts "       These options can be used inside the #{colored_script_name} file on #{"task".colorize(:light_blue)} lines."
-    puts "       This list is computed dynamically based on the tasks that are enabled in the #{colored_script_name} file."
-    puts "       Every task accepts the following options:"
-    puts "          #{"quiet".colorize(:light_blue)} (true/false - Tell the task to be verbose. Some tasks may disregard at times.)"
-    puts "          #{"stop_on_problem".colorize(:light_blue)} (true/false - Tell the task to stop startup if it encounters a problem.)"
-    puts ""
+    write_task_info_header(colored_script_name)
 
-    sorted_task_options = Hash[@environment.options.registered_task_options.sort_by do |klass, options|
+    sorted_task_options = @environment.options.registered_task_options.sort_by do |klass, _options|
       RspecStarterTask.name_for_class(klass)
-    end]
-
-    sorted_task_options.each do |klass, options|
-      dsl_options = options.select(&:is_dsl_option?).sort {|a,b| a.name <=> b.name }
-      unless dsl_options.empty?
-        puts "       :#{RspecStarterTask.name_for_class(klass).to_s.colorize(:light_blue)}"
-        dsl_options.each do |option|
-                  puts "          #{option.name.colorize(:light_blue)} (#{option.description})"
-        end
+    end
+
+    sorted_task_options.to_h.each do |klass, options|
+      dsl_options = options.select(&:is_dsl_option?).sort_by(&:name)
+      next if dsl_options.empty?
+
+      puts "       :#{RspecStarterTask.name_for_class(klass).to_s.colorize(:light_blue)}"
+      dsl_options.each do |option|
+        puts "          #{option.name.colorize(:light_blue)} (#{option.description})"
       end
     end
   end
+
+  def self.write_task_info_header(colored_script_name)
+    puts "\nTask Options:"
+    puts "       These options can be used inside the #{colored_script_name} file on #{'task'.colorize(:light_blue)} lines."
+    puts "       This list is computed dynamically based on the tasks that are enabled in the #{colored_script_name} file."
+    puts "       Every task accepts the following options:"
+    # rubocop:disable Layout/LineLength
+    puts "          #{'quiet'.colorize(:light_blue)} (true/false - Tell the task to be verbose. Some tasks may disregard at times.)"
+    puts "          #{'stop_on_problem'.colorize(:light_blue)} (true/false - Tell the task to stop startup if it encounters a problem.)"
+    # rubocop:enable Layout/LineLength
+    puts ""
+  end
 end

data/lib/rspec_starter/option.rb

@@ -3,7 +3,7 @@ module RspecStarter
   class Option
     attr_reader :name, :default, :description, :key, :owner, :switch, :switch_description
 
-    def initialize(name:, default:, description: "", owner:, switch:, switch_description: "")
+    def initialize(name:, default:, owner:, switch:, description: "", switch_description: "")
       @owner = owner
       @switch = switch
       @switch_description = switch_description
@@ -62,14 +62,14 @@ module RspecStarter
       return unless switch.nil? && name.nil?
 
       raise "#{owner.name}#register_options is trying to create an option but 'name:' or 'switch:' are not specified. " \
-        "At least one must be specified."
+            "At least one must be specified."
     end
 
     def validate_default_is_true_false_for_switch
       return unless switch && ![true, false].include?(default)
 
       raise "#{owner.name}#register_options is trying to create an option for switch #{switch}. Options with switches " \
-        "can only return true/false. Set the 'default' argument to true or false for the option."
+            "can only return true/false. Set the 'default' argument to true or false for the option."
     end
 
     def validate_switch_is_like_name
@@ -77,8 +77,8 @@ module RspecStarter
       return if name == @simplified_switch
 
       raise "#{owner.name}#register_options is trying to create an option with name #{name} and switch #{switch}. " \
-        "The switch must be the same as the name when hyphens are converted to underscores and leading hyphens " \
-        "are removed."
+            "The switch must be the same as the name when hyphens are converted to underscores and leading hyphens " \
+            "are removed."
     end
   end
 end

data/lib/rspec_starter/options.rb

@@ -36,7 +36,7 @@ module RspecStarter
     # If name is specified, this option can be used inside the start block on a task.
     def register_task_option(klass, name: nil, default: nil, description: "", switch: nil, switch_description: "")
       new_option = RspecStarter::Option.new(name: name, default: default, description: description, owner: klass, switch: switch,
-                                            switch_description: switch_description)
+        switch_description: switch_description)
       @registered_task_options[klass] << new_option
     end
 

data/lib/rspec_starter/rspec_starter_task.rb

@@ -11,20 +11,20 @@
 # that determines whether a problem should cause the entire start-up process to stop when the task encounters a problem.
 class RspecStarterTask < RspecStarterStep
   def self.register_option(hash)
-    @options_registrar.register_task_option(self, hash)
+    @options_registrar.register_task_option(self, **hash)
   end
 
   def self.description
     ""
   end
 
-  private
-
   # Convert something like VerifyDisplayServer to :verify_display_server
   def self.name_for_class(klass)
     klass.name.underscore.to_sym
   end
 
+  private
+
   def print_starting_message
     print "#{@starting_message} ..."
   end

data/lib/rspec_starter/task_context.rb

@@ -1,5 +1,5 @@
 module RspecStarter
-  # TaskContext's are created to when parsing the RspecStater.start block. They hold the args and Task class name. They are
+  # TaskContext's are created to when parsing the RspecStater.start block. They hold the ARGS and Task class name. They are
   # asked to create instances of Task subclasses from this information when it is time to execute. The also resolve the options
   # that each Task is allowed to access.
   class TaskContext < StepContext
@@ -25,37 +25,39 @@ module RspecStarter
 
     private
 
+    def registered_task_options
+      environment.options.registered_task_option(@step_class)
+    end
+
     def build_options
       options = super
-      add_defaults_to_options(options)
-      apply_args_to_options(options)
-      apply_command_line_switches_to_options(options)
+      add_task_option_defaults(options)
+      apply_start_block_option_overrides(options)
+      apply_command_line_switch_overrides(options)
       options
     end
 
-    def add_defaults_to_options(options)
-      registered_options = environment.options.registered_task_option(@step_class)
-      registered_options.each { |option| options.add(option.key, option.default) }
+    # Each Task can define options that are unique to the task, along with default values for those options. Add those
+    # options and values now. (The values may be overridden by the user.)
+    def add_task_option_defaults(options)
+      registered_task_options.each { |option| options.add(option.key, option.default) }
     end
 
-    def apply_args_to_options(options)
-      registered_options = environment.options.registered_task_option(@step_class)
-      dsl_option_names = registered_options.select(&:is_dsl_option?).collect { |option| option.name.to_sym }
-      @requested_args.each do |key, value|
-        next unless dsl_option_names.include?(key)
-
-        options.update(key, value, add_missing: false)
-      end
+    # Users can specify options for each task inside their project's "start" block. These options can override the default
+    # value for the global options that all tasks have, or the task specific options that a task defines by calling
+    # register_task_option. If the user tries to define an option that the task doesn't understand, it is ignored.
+    def apply_start_block_option_overrides(options)
+      @requested_args.each { |option_name, option_value| options.update(option_name, option_value, add_missing: false) }
     end
 
-    def apply_command_line_switches_to_options(options)
-      registered_options = environment.options.registered_task_option(@step_class)
+    # Command line switches can also affect options. Adjust an options that are impacted by command line switches that are
+    # present.
+    def apply_command_line_switch_overrides(options)
       present_switches = environment.options.present_switches
-      registered_options.each do |option|
-        # The switch could be nil for the option, which means the step isn't registering a switch for this option. The step
-        # developer just wants to register an option for the dsl (which is applied earlier).
-        if option.switch
-          options.update(option.key, !option.default, add_missing: false) if present_switches.include?(option.switch)
+      registered_task_options.each do |option|
+        # present_switches is a list of all valid switches that have been supplied by the user.
+        if option.switch && present_switches.include?(option.switch)
+          options.update(option.key, !option.default, add_missing: false)
         end
       end
     end

data/lib/rspec_starter/tasks/rebuild_rails_app_database.rb

@@ -7,10 +7,10 @@ class RebuildRailsAppDatabase < RspecStarterTask
 
   def self.register_options
     register_option default: false, switch: '--skip-db-prep',
-                    switch_description: "DO NOT prepare the Rails application database"
+      switch_description: "DO NOT prepare the Rails application database"
     register_option name: "command",
-                    default: "DISABLE_DATABASE_ENVIRONMENT_CHECK=1 RAILS_ENV=test rake db:drop db:create db:migrate",
-                    description: "A command string that is used to rebuild the database."
+      default: "DISABLE_DATABASE_ENVIRONMENT_CHECK=1 RAILS_ENV=test rake db:drop db:create db:migrate",
+      description: "A command string that is used to rebuild the database."
   end
 
   def should_skip?
@@ -37,7 +37,7 @@ class RebuildRailsAppDatabase < RspecStarterTask
     puts @stdout
     puts @stderr
     puts "\n\nThere was an error rebuilding the test database.  See the output above for details " \
-      "or manually run '#{options.command}' for more information.".colorize(:red)
+         "or manually run '#{options.command}' for more information.".colorize(:red)
   end
 
   private

data/lib/rspec_starter/tasks/remove_tmp_folder.rb

@@ -6,11 +6,11 @@ class RemoveTmpFolder < RspecStarterTask
 
   def self.register_options
     register_option name: "remove_dummy_tmp",
-                    default: false,
-                    description: "true/false to remove the tmp folder for the dummy app too."
+      default: false,
+      description: "true/false to remove the tmp folder for the dummy app too."
     register_option name: "dummy_path",
-                    default: "spec/dummy",
-                    description: "Relative path to the dummy folder."
+      default: "spec/dummy",
+      description: "Relative path to the dummy folder."
   end
 
   # Let subsequent steps run if this task runs into a problem deleting the tmp folder. This value can be overridden in

data/lib/rspec_starter/tasks/start_rspec.rb

@@ -6,10 +6,10 @@ class StartRspec < RspecStarterTask
 
   def self.register_options
     register_option name: "skip_display_server", default: false, switch: '--skip-display-server',
-                    switch_description: "DO NOT check for a display server",
-                    description: "true/false to enable/disable starting the display server"
+      switch_description: "DO NOT check for a display server",
+      description: "true/false to enable/disable starting the display server"
     register_option name: "command", default: "bundle exec rspec",
-                    description: "A command string that is used to start RSpec."
+      description: "A command string that is used to start RSpec."
   end
 
   def self.default_quiet
@@ -56,7 +56,7 @@ class StartRspec < RspecStarterTask
 
   def determine_command
     cmd = enhanced_command
-    options.rspec_args_string.empty? ? cmd : cmd + " " + options.rspec_args_string
+    options.rspec_args_string.empty? ? cmd : "#{cmd} #{options.rspec_args_string}"
   end
 
   # Returns a string that will either be 'xvfb-run bundle exec rspec' or 'bundle exec rspec'

data/lib/rspec_starter/version.rb

@@ -1,3 +1,3 @@
 module RspecStarter
-  VERSION = "1.7.1".freeze
+  VERSION = "2.0.0".freeze
 end

data/lib/templates/rails_engine_start_rspec

@@ -12,7 +12,7 @@ require "bundler/setup"
 require "rspec_starter"
 
 # The path to the application's root folder.
-APP_ROOT = Pathname.new File.expand_path('../', __dir__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 # Create a custom task. For more information about custom tasks, see
 # https://github.com/roberts1000/rspec_starter. Once defined, add

data/lib/templates/rails_start_rspec

@@ -12,7 +12,7 @@ require "bundler/setup"
 require "rspec_starter"
 
 # The path to the application's root folder.
-APP_ROOT = Pathname.new File.expand_path('../', __dir__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 # Create a custom task. For more information about custom tasks, see
 # https://github.com/roberts1000/rspec_starter. Once defined, add

data/lib/templates/start_rspec

@@ -12,7 +12,7 @@ require "bundler/setup"
 require "rspec_starter"
 
 # The path to the application's root folder.
-APP_ROOT = Pathname.new File.expand_path('../', __dir__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 # Create a custom task. For more information about custom tasks, see
 # https://github.com/roberts1000/rspec_starter. Once defined, add

data/rspec_starter.gemspec

@@ -5,7 +5,7 @@ require 'rspec_starter/version'
 Gem::Specification.new do |spec|
   spec.name          = "rspec_starter"
   spec.version       = RspecStarter::VERSION
-  spec.authors       = ["Roberts"]
+  spec.authors       = ["roberts1000"]
   spec.email         = ["roberts@corlewsolutions.com"]
 
   spec.summary       = "A Ruby gem that helps run RSpec in a standard manner."
@@ -19,13 +19,15 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.required_ruby_version = '>= 2.6.0'
+
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "pry-byebug", "~> 3.7.0"
+  spec.add_development_dependency "pry-byebug", "~> 3.9.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
 
   spec.add_dependency "activesupport", ">= 5.2.2"
   spec.add_dependency "colorize", "~> 0.8.1"
   spec.add_dependency "cri", "~> 2.0"
-  spec.add_dependency "os", "~> 1.0.0"
+  spec.add_dependency "os", "~> 1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_starter
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 2.0.0
 platform: ruby
 authors:
-- Roberts
+- roberts1000
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-13 00:00:00.000000000 Z
+date: 2021-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 3.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 3.9.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.1.0
 description: A Ruby gem that helps run RSpec in a standard manner.
 email:
 - roberts@corlewsolutions.com
@@ -130,10 +130,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/check_pull_request.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.md
@@ -152,14 +152,6 @@ files:
 - lib/rspec_starter/help.rb
 - lib/rspec_starter/helpers.rb
 - lib/rspec_starter/helpers/which.rb
-- lib/rspec_starter/legacy.rb
-- lib/rspec_starter/legacy/help.rb
-- lib/rspec_starter/legacy/legacy_runner.rb
-- lib/rspec_starter/legacy/steps/invoke_rspec_step.rb
-- lib/rspec_starter/legacy/steps/prepare_database_step.rb
-- lib/rspec_starter/legacy/steps/remove_tmp_folder_step.rb
-- lib/rspec_starter/legacy/steps/step.rb
-- lib/rspec_starter/legacy/steps/verify_xvfb_step.rb
 - lib/rspec_starter/option.rb
 - lib/rspec_starter/options.rb
 - lib/rspec_starter/rspec_starter_task.rb
@@ -188,14 +180,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubygems_version: 3.2.24
 signing_key: 
 specification_version: 4
 summary: A Ruby gem that helps run RSpec in a standard manner.

data/.travis.yml

@@ -1,12 +0,0 @@
-language: ruby
-cache: bundler
-rvm:
-  - 2.3.8
-  - 2.4.9
-  - 2.5.7
-  - 2.6.5
-before_install: gem install bundler -v 2.0.2
-notifications:
-  email:
-    on_success: never # default: change
-    on_failure: never # default: always

data/lib/rspec_starter/legacy.rb

@@ -1,16 +0,0 @@
-# This module loads the legacy RspecStarter code that uses the non-block DSL. It will be removed in 2.0.0.
-# The file is loaded when RspecStarter starts, but most of the legacy code is not loaded until the
-# 'invoke_legacy_starter' method is called.
-module RspecStarter
-  def self.invoke_legacy_starter(defaults)
-    require 'rspec_starter/legacy/legacy_runner'
-    # puts "[DEPRECATION NOTICE] Your #{helpers.starter_script_file_name} file uses an old method for starting RSpec.\n" \
-    #   "RspecStarter 1.6.0 introduced a new interface that is faster and more flexible.\n" \
-    #   "To upgrade:\n" \
-    #   "  1. Run 'rspec_starter --init' to install a new bin/start_rspec file.\n" \
-    #   "  2. Your old bin/start_rspec will be renamed to bin/start_rspec.bak. If you customized\n" \
-    #   "     this file, open it up and consider moving the changes to the new bin/start_rspec file.\n" \
-    #   "     See https://github.com/roberts1000/rspec_starter for instructions on the new interface.\n".colorize(:yellow)
-    LegacyRunner.new(defaults).run
-  end
-end

data/lib/rspec_starter/legacy/help.rb

@@ -1,40 +0,0 @@
-module RspecStarter
-  # Method that support the help option on the bin/start_rspec script.
-  module Help
-    def should_show_help?
-      ARGV.any? { |option| option.include? "--help" }
-    end
-
-    def show_help
-      # Figure out the file name that invoked the rspec_starter helper.  This is the name of the script; it be called anything.
-      script_name = calling_file_name
-      puts "Usage: #{script_name.colorize(:light_blue)} #{'[options] [options for RSpec]'.colorize(:light_blue)}\n"
-      puts "       #{script_name} will look for its own options first then pass any remaining options to rspec"
-
-      # rubocop:disable Metrics/LineLength
-      puts "\nOptions: (run 'rspec --help' to see RSpec's options)"
-      puts "       #{'--no-xvfb'.colorize(:light_blue)}   DO NOT run XVFB (this can speed up RSpec when running tests that don't need XVFB)"
-      puts "       #{'--no-prep'.colorize(:light_blue)}   DO NOT prepare the test database (can speed up testing if you know the DB is clean)"
-
-      puts "\nExamples:"
-      puts "       #{script_name.colorize(:light_blue)} #{'spec/features'.colorize(:light_blue)} (only run specs in the specs/features folder)"
-      puts "       #{script_name.colorize(:light_blue)} #{'spec/features/some_spec:53'.colorize(:light_blue)} (run the spec on line 53 of the spec/features_some_spec.rb file)"
-      puts "       #{script_name.colorize(:light_blue)} #{'--no-xvfb'.colorize(:light_blue)} #{'spec/requests/some_spec'.colorize(:light_blue)} (don't start XVFB since it's not needed for request specs)"
-      puts "       #{'SIMPLECOV_FORMATTER=rcov'.colorize(:light_blue)} #{script_name.colorize(:light_blue)} (use with environment variables)\n"
-      # rubocop:enable Metrics/LineLength
-    end
-
-    # This is ugly, but it gives us some added flexibility.  Users can invoke the rspec_starter method from any script or
-    # executable.  This method attempts to find out the name of the script/exectuable.
-    # "caller" returns the method stack, and because of the location of this file in the gem, we happen to be the 4th item in the
-    # the array (hence "caller[3]" below).
-    #
-    # This method may not return a pretty result in all cases, but it's decent if the user has defined a script in their project
-    # (possibly in the bin folder, or root of the project).
-    def calling_file_name
-      # rubocop:disable Performance/Caller
-      caller[3].split(":")[0]
-      # rubocop:enable Performance/Caller
-    end
-  end
-end

data/lib/rspec_starter/legacy/legacy_runner.rb

@@ -1,90 +0,0 @@
-require 'pathname'
-require 'open3'
-
-require_relative 'help'
-require_relative 'steps/step'
-require_relative 'steps/verify_xvfb_step'
-require_relative 'steps/prepare_database_step'
-require_relative 'steps/remove_tmp_folder_step'
-require_relative 'steps/invoke_rspec_step'
-
-module RspecStarter
-  # This is a simple class that encapulates the process of running RSpec.  When a Runner is created, it creates a set of
-  # steps that will be executed, in order, when the 'run' method is invoked.  Each step encapsulates an action that can be
-  # taken to help invoke Rspec.  Steps are typically independent do not depend on information from other steps.  However
-  # this is not a hard rule.  If more complex steps are needed, feel free to create them.  Each steps knows about the main
-  # runner object, so the runner object is a good place to store shared info.
-  class LegacyRunner
-    include Help
-    attr_reader :xvfb_installed, :step_num, :steps
-
-    def initialize(defaults)
-      @steps = []
-      @step_num = 1
-      @xvfb_installed = RspecStarter.which("xvfb-run")
-      @prep_db_step = PrepareDatabaseStep.new(defaults, self)
-      @run_rspec_step = InvokeRspecStep.new(defaults, self)
-      @steps << VerifyXvfbStep.new(defaults, self)
-      @steps << @prep_db_step
-      @steps << RemoveTmpFolderStep.new(defaults, self)
-      @steps << @run_rspec_step
-    end
-
-    def run
-      return show_help if should_show_help? # If we show help, exit and don't do anything else.
-
-      @steps.each do |step|
-        next unless step.should_execute?
-
-        step.execute
-        @step_num += 1
-        break if step.failed?
-      end
-
-      finalize_exit
-    end
-
-    def project_is_rails_app?
-      File.file?(File.join(Dir.pwd, 'config', 'application.rb'))
-    end
-
-    def project_is_rails_engine?
-      return false unless project_has_lib_dir?
-
-      Dir["#{Dir.pwd}/lib/**/*.rb"].each do |file|
-        return true if File.readlines(file).detect { |line| line.match(/\s*class\s+.*<\s+::Rails::Engine/) }
-      end
-      false
-    end
-
-    def project_has_lib_dir?
-      Dir.exist?("#{Dir.pwd}/lib")
-    end
-
-    def operating_system_name
-      result = `uname`
-      return 'Linux' if result.include?('Linux')
-      return 'MacOS' if result.include?('Darwin')
-
-      'Unknown'
-    end
-
-    def is_linux?
-      operating_system_name == 'Linux'
-    end
-
-    def is_mac?
-      operating_system_name == 'MacOS'
-    end
-
-    def xvfb_installed?
-      @xvfb_installed
-    end
-
-    def finalize_exit
-      exit(1) if @run_rspec_step.rspec_exit_status.nonzero?
-      exit(1) if @prep_db_step.exit_status.nonzero?
-      exit(0)
-    end
-  end
-end

data/lib/rspec_starter/legacy/steps/invoke_rspec_step.rb

@@ -1,50 +0,0 @@
-module RspecStarter
-  # The step that actually starts the RSpec.
-  class InvokeRspecStep < RspecStarter::Step
-    attr_reader :rspec_exit_status
-
-    def initialize(defaults, runner)
-      super(runner)
-
-      @allow_xvfb = defaults.fetch(:allow_xvfb, true)
-      @relevant_options = ["--no-xvfb"]
-      @success_or_skipped = nil # Will be updated once step executes
-      @rspec_exit_status = nil # Will be updated once step executes
-      @user_wants_to_skip_xvfb = ARGV.any? { |option| option.include?("--no-xvfb") }
-      init_rspec_options
-    end
-
-    def init_rspec_options
-      step_options = []
-      @runner.steps.each { |step| step_options.concat(step.relevant_options) }
-      @rspec_options = ARGV - step_options.to_a
-    end
-
-    def should_execute?
-      true
-    end
-
-    def failed?
-      !@success_or_skipped
-    end
-
-    def execute
-      cmd = command
-      cmd = "#{cmd} #{@rspec_options.join(' ')}" unless @rspec_options.empty?
-      puts "[#{@runner.step_num}] Running specs with '#{cmd.colorize(:light_blue)}' ...\n\n"
-      system cmd
-      @rspec_exit_status = $CHILD_STATUS.exitstatus
-      @success_or_skipped = true
-    end
-
-    # Returns a string that will either be 'xvfb-run bundle exec rspec' or 'bundle exec rspec'
-    def command
-      base = "bundle exec rspec"
-      return base if @runner.is_mac?
-      return base unless @allow_xvfb
-      return base if @user_wants_to_skip_xvfb
-
-      @runner.xvfb_installed? ? "xvfb-run #{base}" : base
-    end
-  end
-end

data/lib/rspec_starter/legacy/steps/prepare_database_step.rb

@@ -1,60 +0,0 @@
-module RspecStarter
-  # The steps that destorys and rebuilds the DB before running RSpec.
-  class PrepareDatabaseStep < RspecStarter::Step
-    attr_reader :exit_status
-
-    def initialize(defaults, runner)
-      super(runner)
-
-      @prepare_database = defaults.fetch(:prepare_db, true)
-      @relevant_options << '--no-prep-db'
-      @user_wants_to_skip = ARGV.any? { |option| option.include?("--no-prep-db") }
-      @success_or_skipped = nil # Will be updated once step executes
-      @exit_status = 0 # Will be updated once step executes
-    end
-
-    def failed?
-      !@success_or_skipped
-    end
-
-    def should_execute?
-      return false if @user_wants_to_skip
-      return false unless @prepare_database
-
-      @runner.project_is_rails_app? || @runner.project_is_rails_engine?
-    end
-
-    def execute
-      return @success_or_skipped = true if should_skip?
-
-      rebuild_cmd = rebuild_command
-      print "[#{@runner.step_num}] Preparing the test database with '#{rebuild_cmd.colorize(:light_blue)}' ... "
-      _stdout, stderr, exit_status = Open3.capture3(rebuild_cmd)
-      @exit_status = exit_status.exitstatus
-      @success_or_skipped = successful?(stderr)
-
-      if @success_or_skipped
-        puts "Success".colorize(:green)
-      else
-        puts "Fail".colorize(:red) + "\n\n"
-        puts stderr
-        puts "\n\nThere was an error rebuilding the test database.  See the output above for details.".colorize(:red)
-        puts "or manually run '#{rebuild_cmd}' for more information.".colorize(:red)
-      end
-    end
-
-    private
-
-    def rebuild_command
-      "rake db:drop db:create db:migrate RAILS_ENV=test"
-    end
-
-    # Simply checking the exitstatus isn't good enough.  When rake aborts due to a bug, it will still
-    # return a zero exit status.  We need to see if 'rake aborted!' has been written to the output.
-    def successful?(stderr)
-      return false if @exit_status.nonzero?
-
-      !stderr.include?("rake aborted!")
-    end
-  end
-end

data/lib/rspec_starter/legacy/steps/remove_tmp_folder_step.rb

@@ -1,46 +0,0 @@
-module RspecStarter
-  # The step that removes the tmp folder.
-  class RemoveTmpFolderStep < RspecStarter::Step
-    def initialize(defaults, runner)
-      super(runner)
-
-      @remove_tmp_folder = defaults.fetch(:remove_tmp, true)
-      @runner = runner
-      @relevant_options << "--no-remove-tmp"
-      @user_wants_to_skip_removal = ARGV.any? { |option| option.include?("--no-remove-tmp") }
-      @success_or_skipped = nil # Will be updated once step executes
-    end
-
-    def failed?
-      !@success_or_skipped
-    end
-
-    def should_execute?
-      return false if @user_wants_to_skip_removal
-
-      @remove_tmp_folder
-    end
-
-    def execute
-      return @success_or_skipped = true unless should_execute?
-
-      existed_before = tmp_folder_exists?
-
-      print "[#{@runner.step_num}] Removing #{'tmp'.colorize(:light_blue)} folder ... "
-      system "rm -rf tmp/"
-
-      if tmp_folder_exists?
-        @succss_or_skipped = false
-        puts "Failed (The tmp folder could not be removed.)".red
-      else
-        @success_or_skipped = true
-        info = existed_before ? "" : " (the tmp folder didn't exist)"
-        puts "Success!!#{info}".colorize(:green)
-      end
-    end
-
-    def tmp_folder_exists?
-      File.exist?(File.join(Dir.pwd, "tmp"))
-    end
-  end
-end

data/lib/rspec_starter/legacy/steps/step.rb

@@ -1,15 +0,0 @@
-module RspecStarter
-  # Abstract super class for a step.
-  class Step
-    attr_reader :relevant_options
-
-    def initialize(runner)
-      @runner = runner
-      @relevant_options = []
-    end
-
-    def should_skip?
-      !should_execute?
-    end
-  end
-end

data/lib/rspec_starter/legacy/steps/verify_xvfb_step.rb

@@ -1,49 +0,0 @@
-module RspecStarter
-  # The step that makes sure XVFB is installed on the system.  When feature tests run, they need a display server to power the
-  # browsr that will execute the feature tests.  MacOS provides its own display server that always runs.  Linux needs one
-  # installed and activated.
-  class VerifyXvfbStep < RspecStarter::Step
-    def initialize(defaults, runner)
-      super(runner)
-
-      @relevant_options << '--no-xvfb'
-      @use_xvfb = defaults.fetch(:use_xvfb, true)
-      @user_wants_to_skip_xvfb = ARGV.any? { |option| option.include?("--no-xvfb") }
-    end
-
-    # This step doesn't really fail.  Although there may be problems with how XVFB is installed, it's only a problem when the
-    # user is trying to run feature specs.  The user may be in a situation where he's working on Linux and XVFB isn't installed,
-    # but he may not have any feature specs to run.  We shouldn't block the tests from running just because XVFB hasn't been
-    # installed yet.  So we just warn the user and put the ball in his court.  If he's running feature specs with a busted
-    # XVFB setup, we have at least warned him.
-    def failed?
-      false
-    end
-
-    def should_execute?
-      return false if @user_wants_to_skip_xvfb
-
-      @use_xvfb
-    end
-
-    # There are two cases we need to be checked
-    #   1. A Linux user does not have xvfb installed (xvfb is needed to run RSpec feature tests on Linux).
-    #   2. A Mac User has xvfb installed.   (Macs have their own display server so xvfb is not needed; a dev might have mistakenly
-    #      tried to install, so we can check for it just in case.)
-    def execute
-      return if should_skip?
-
-      print "[#{@runner.step_num}] Verifying display server ... "
-
-      if @runner.is_linux? && !@runner.xvfb_installed?
-        return puts "Warning (XVFB is not installed.  Feature specs will fail.)".colorize(:yellow)
-      end
-
-      if @runner.is_mac? && @runner.xvfb_installed?
-        return puts "Warning (XVFB has been installed.  It's not needed on a Mac and may cause specs to fail.)".colorize(:yellow)
-      end
-
-      puts "Success!!".colorize(:green)
-    end
-  end
-end