rspec_starter 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 07651d1f45ae7e33bb3d5de51c198c87f6be0749803084eeae6ed4e2e2a2dfdb
-  data.tar.gz: '00769c37402ced8b3ce2c3d362bd6277d348d77e9f50d20c639ec2921425a47d'
+  metadata.gz: b7a2a86b983cbb4231b3ee5e0df34039dc24d60ec93da40f0ac33c8ca45489bc
+  data.tar.gz: 74ad3cc39ccb76534796183a0a1000ed26bb8cadbb1f9fe58266cb55348753e4
 SHA512:
-  metadata.gz: a06b48f11b0e5240dcc51761de9304e342d67e7d1d194823b1d3f64af98ad65499bcfafcefef8d2b1903f80e51ee9ad4bc39cd8fa12d2e29a90cdbd5b3c9ddc7
-  data.tar.gz: 5dc317a2c50d27d56bae0a2e7d556d803fe2c913fae7ed9aad9b9645e2ba0363cc111e83d5ff900a65e2237db941c5562358e34edb2293774fe5c8802c19d14c
+  metadata.gz: e514511743c4c243ce522a0ee318855de398a3c495fcfe503761cead264f63de1bdae3ccf6a70f353d9b64a6c6bb31d9fc9249e7b75c540376574cc0af460ca1
+  data.tar.gz: 34b4fbf5a1e2e71d0b45606fcd8b6e4bc8343725050aebd7cc7ed07115c1f23e5cfafc61e136e42e2c71852c7a6f9e1519911f3bb6816745b33896fd946adf19

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 Issues marked as **(Internal)** mark internal development work. Issues are tracked at https://github.com/roberts1000/rspec_starter/issues.
 
+## 1.7.0 (Dec 12, 2019)
+
+1. [#74](../../issues/74) Make `rspec_starter --init` detect Rails engines correctly.
+1. [#75](../../issues/75) Let `remove_tmp_folder` task remove the tmp folder from `dummy` apps.
+
 ## 1.6.0 (Dec 09, 2019)
 
 1. [#56](../../issues/56) Move old starter code to a `legacy` folder so it can still be used. **(Internal)**

data/exe/rspec_starter

@@ -47,7 +47,7 @@ command = Cri::Command.define do
     template_path =
       if helpers.project_is_rails_app?
         File.expand_path('../lib/templates/rails_start_rspec', __dir__)
-      elsif helpers.project_is_rails_app?
+      elsif helpers.project_is_rails_engine?
         File.expand_path('../lib/templates/rails_engine_start_rspec', __dir__)
       else
         File.expand_path('../lib/templates/start_rspec', __dir__)

data/lib/rspec_starter/tasks/remove_tmp_folder.rb

@@ -4,6 +4,15 @@ class RemoveTmpFolder < RspecStarterTask
     "Remove the #{'tmp'.colorize(:light_blue)} folder from the project."
   end
 
+  def self.register_options
+    register_option name: "remove_dummy_tmp",
+                    default: false,
+                    description: "true/false to remove the tmp folder for the dummy app too."
+    register_option name: "dummy_path",
+                    default: "spec/dummy",
+                    description: "Relative path to the dummy folder."
+  end
+
   # Let subsequent steps run if this task runs into a problem deleting the tmp folder. This value can be overridden in
   # the applications bin/start_rspec file if the user adds 'stop_on_problem: true' to the task line.
   def self.default_stop_on_problem
@@ -11,18 +20,50 @@ class RemoveTmpFolder < RspecStarterTask
   end
 
   def starting_message
-    "Removing #{'tmp'.highlight} folder"
+    if options.remove_dummy
+      "Removing #{'tmp/'.highlight} and #{relative_dummy_tmp_folder_path.highlight} folders"
+    else
+      "Removing #{'tmp/'.highlight} folder"
+    end
   end
 
   def execute
-    success "the tmp folder didn't exist" unless tmp_folder_exists?
+    remove_tmp_folder
+    remove_dummy_tmp_folder
+  end
+
+  private
+
+  def remove_tmp_folder
+    return unless tmp_folder_exists?
+
     system "rm -rf tmp/"
     problem "the tmp folder could not be removed." if tmp_folder_exists?
   end
 
-  private
+  def remove_dummy_tmp_folder
+    return unless options.remove_dummy
+    return unless dummy_tmp_folder_exists?
+
+    system "rm -rf #{absolute_dummy_tmp_folder_path}"
+    problem "the #{relative_dummy_tmp_folder_path} folder could not be removed." if dummy_tmp_folder_exists?
+  end
 
   def tmp_folder_exists?
-    File.exist?(File.join(Dir.pwd, "tmp"))
+    Dir.exist?(File.join(Dir.pwd, "tmp"))
+  end
+
+  def relative_dummy_tmp_folder_path
+    File.join(options.dummy_path, "tmp/")
+  end
+
+  def absolute_dummy_tmp_folder_path
+    File.join(Dir.pwd, options.dummy_path, "tmp/")
+  end
+
+  def dummy_tmp_folder_exists?
+    return false if options.dummy_path.nil?
+
+    Dir.exist?(absolute_dummy_tmp_folder_path)
   end
 end

data/lib/rspec_starter/version.rb

@@ -1,3 +1,3 @@
 module RspecStarter
-  VERSION = "1.6.0".freeze
+  VERSION = "1.7.0".freeze
 end

data/lib/templates/rails_engine_start_rspec

@@ -32,7 +32,7 @@ APP_ROOT = Pathname.new File.expand_path('../', __dir__)
 # Tasks are run from the top down.
 RspecStarter.start do
   task :verify_display_server
-  task :remove_tmp_folder
+  task :remove_tmp_folder, remove_dummy_tmp: true
   task :rebuild_rails_app_database
   task :start_rspec
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_starter
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Roberts
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-09 00:00:00.000000000 Z
+date: 2019-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler