rspec_starter 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84e5bb86c48d3b70522183229c840a33c9bc494743fc92525c6ba0c56818c42f
-  data.tar.gz: 6d5fc579a8fce581378bbe3d60bec9acbdce422f829147361013ac66b4835745
+  metadata.gz: bb6c3b840f892e7eb22465923f63708c2dd3942a21fb86754caf1ed9a25984f3
+  data.tar.gz: a37965d96323b5bf2f40611000e8c74c7f9b269c36dd461a0b3317fcccbdda3d
 SHA512:
-  metadata.gz: fd401edef689649b8fcefe70012cb71e89aa5f5851012526eadfc4f17eb239e3ccb1d4fb2f39b3b2dde12aa8010d5e95f3b3b17ef55650fd24e690e4bd4a418f
-  data.tar.gz: f46ac44e3b5d4608c4174ff94c70a7c65b25c4e2ed9f4d2fe3c730b237d17e55345d695075a5206d8ee112b144a862f41a8588c3a63568d92db674770a03131e
+  metadata.gz: 9b83cc5cd091593252a806854b35913e420ea38a90bdee5bfd26a2af270e13820ef40d3c7f2364e07d8e8e3e31d6b5b4fdbe45d55c0f44690300b3018b920136
+  data.tar.gz: e342445d01317ca1f239abca6dd566285863fb0d1411ef46df87b7cff91a8f1eb8b31528931a98262bb281a94fad205bd2d33e6141131bfa9c08fd1603656c81

data/.travis.yml

@@ -1,10 +1,11 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.3.3
-  - 2.4.4
-  - 2.5.1
-before_install: gem install bundler -v 1.16.3
+  - 2.3.7
+  - 2.4.5
+  - 2.5.3
+  - 2.6.1
+before_install: gem install bundler -v 2.0.1
 notifications:
   email:
     on_success: never # default: change

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 1.5.0 (Feb 19, 2019)
+
+1. Report an exit status of 1 if DB Preparation or RSpec fails.  (Issue #51)
+
 ## 1.4.0 (Oct 12, 2018)
 
 1. Isolate rebuild command string into a dedicated method..  (Issue #41)

data/README.md

@@ -17,9 +17,9 @@ rspec_starter can currently perform the following steps (these steps can be togg
 - Verify XVFB is installed when running on a Linux box
 - Start RSpec with `bundle exec rspec` or `xvfb-run bundle exec rspec` (depending on the needs of the OS)
 
-## Versioning Strategy
+## Version Policy
 
-This gem uses [Semantic Versioning 2.0.0](https://semver.org/spec/v2.0.0.html).
+Releases are versioned using [semver 2.0.0](https://semver.org/spec/v2.0.0.html).
 
 ## Supported Ruby Versions
 
@@ -63,12 +63,12 @@ which tells start_rspec, to tell rspec, to only run the feature tests.  Run the
 
 ## Custom Steps
 
-rspec_starter does not currently have support for creating custom steps.  However, there are some techniques that can achieve the same results.  rspec_starter currently implements 4 "steps" which can be turned on or off.  The steps are implemented by classes and are evaluated in this order: 
+rspec_starter does not currently have support for creating custom steps.  However, there are some techniques that can achieve the same results.  rspec_starter currently implements 4 "steps" which can be turned on or off.  The steps are implemented by classes and are evaluated in this order:
 
 1. `VerifyXvfbStep` - Ensures xvfb is installed on systems where it should be used (.i.e. Linux).
 1. `PrepareDatabaseStep` - Runs `rake db:drop db:create db:migrate RAILS_ENV=test`.
 1. `RemoveTmpFolderStep` - Deletes the `tmp` folder.
-1. `InvokeRspecStep` - Runs `bundle exec rspec`. 
+1. `InvokeRspecStep` - Runs `bundle exec rspec`.
 
 All steps implement an `execute` method that actually runs the step. You can inject custom code before or after any one of those steps.
 
@@ -92,7 +92,7 @@ module CustomStep
 end
 
 RspecStarter::PrepareDatabaseStep.prepend CustomStep
- 
+
 Dir.chdir APP_ROOT do
   RspecStarter.start(prepare_db: true, remove_tmp: true, allow_xvfb: true)
 end

data/lib/rspec_starter.rb

@@ -3,6 +3,16 @@ require 'colorize'
 require "rspec_starter/version"
 require_relative 'rspec_starter/runner'
 
+# Setup pry for development when running "rake console". Guard against load
+# errors in production (since pry is only loaded as a DEVELOPMENT dependency
+# in the .gemspec)
+# rubocop:disable Lint/HandleExceptions
+begin
+  require "pry"
+rescue LoadError
+end
+# rubocop:enable Lint/HandleExceptions
+
 # Entry point for the RspecStarter gem.
 module RspecStarter
   # The 'start' method takes arguments that can be used to control the steps that are executed when running Rspec.  These

data/lib/rspec_starter/runner.rb

@@ -23,10 +23,12 @@ module RspecStarter
       @steps = []
       @step_num = 1
       @xvfb_installed = RspecStarter.which("xvfb-run")
+      @prep_db_step = PrepareDatabaseStep.new(defaults, self)
+      @run_rspec_step = InvokeRspecStep.new(defaults, self)
       @steps << VerifyXvfbStep.new(defaults, self)
-      @steps << PrepareDatabaseStep.new(defaults, self)
+      @steps << @prep_db_step
       @steps << RemoveTmpFolderStep.new(defaults, self)
-      @steps << InvokeRspecStep.new(defaults, self)
+      @steps << @run_rspec_step
     end
 
     def run
@@ -38,6 +40,8 @@ module RspecStarter
         @step_num += 1
         break if step.failed?
       end
+
+      finalize_exit
     end
 
     def project_is_rails_app?
@@ -74,5 +78,11 @@ module RspecStarter
     def xvfb_installed?
       @xvfb_installed
     end
+
+    def finalize_exit
+      exit(1) if @run_rspec_step.rspec_exit_status.nonzero?
+      exit(1) if @prep_db_step.exit_status.nonzero?
+      exit(0)
+    end
   end
 end

data/lib/rspec_starter/steps/invoke_rspec_step.rb

@@ -1,11 +1,14 @@
 module RspecStarter
   # The step that actually starts the RSpec.
   class InvokeRspecStep < RspecStarter::Step
+    attr_reader :rspec_exit_status
+
     def initialize(defaults, runner)
       super(runner)
       @allow_xvfb = defaults.fetch(:allow_xvfb, true)
       @relevant_options = ["--no-xvfb"]
       @success_or_skipped = nil # Will be updated once step executes
+      @rspec_exit_status = nil # Will be updated once step executes
       @user_wants_to_skip_xvfb = ARGV.any? { |option| option.include?("--no-xvfb") }
       init_rspec_options
     end
@@ -29,6 +32,7 @@ module RspecStarter
       cmd = "#{cmd} #{@rspec_options.join(' ')}" unless @rspec_options.empty?
       puts "[#{@runner.step_num}] Running specs with '#{cmd.colorize(:light_blue)}' ...\n\n"
       system cmd
+      @rspec_exit_status = $CHILD_STATUS.exitstatus
       @success_or_skipped = true
     end
 

data/lib/rspec_starter/steps/prepare_database_step.rb

@@ -1,12 +1,15 @@
 module RspecStarter
   # The steps that destorys and rebuilds the DB before running RSpec.
   class PrepareDatabaseStep < RspecStarter::Step
+    attr_reader :exit_status
+
     def initialize(defaults, runner)
       super(runner)
       @prepare_database = defaults.fetch(:prepare_db, true)
       @relevant_options << '--no-prep-db'
       @user_wants_to_skip = ARGV.any? { |option| option.include?("--no-prep-db") }
       @success_or_skipped = nil # Will be updated once step executes
+      @exit_status = 0 # Will be updated once step executes
     end
 
     def failed?
@@ -24,7 +27,8 @@ module RspecStarter
 
       rebuild_cmd = rebuild_command
       print "[#{@runner.step_num}] Preparing the test database with '#{rebuild_cmd.colorize(:light_blue)}' ... "
-      _stdout, stderr, _status = Open3.capture3(rebuild_cmd)
+      _stdout, stderr, exit_status = Open3.capture3(rebuild_cmd)
+      @exit_status = exit_status.exitstatus
       @success_or_skipped = successful?(stderr)
 
       if @success_or_skipped
@@ -47,7 +51,7 @@ module RspecStarter
     # Simply checking the exitstatus isn't good enough.  When rake aborts due to a bug, it will still
     # return a zero exit status.  We need to see if 'rake aborted!' has been written to the output.
     def successful?(stderr)
-      return false if $CHILD_STATUS.exitstatus.nonzero?
+      return false if @exit_status.nonzero?
       !stderr.include?("rake aborted!")
     end
   end

data/lib/rspec_starter/version.rb

@@ -1,3 +1,3 @@
 module RspecStarter
-  VERSION = "1.4.0".freeze
+  VERSION = "1.5.0".freeze
 end

data/rspec_starter.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.14"
+  spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "pry-byebug", "~> 3.6.0"
   spec.add_development_dependency "rake", "~> 12.0"
   spec.add_development_dependency "rspec", "~> 3.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_starter
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Roberts
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-12 00:00:00.000000000 Z
+date: 2019-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -146,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: A Ruby gem that helps run RSpec in a standard manner.