rspec_starter 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 94076d4db8d8a8e83410f07f9134d2e94d3bff4d
-  data.tar.gz: 300135da1ef3d8c491e75f2a092690d1941caaf7
+  metadata.gz: 4c9da79a01f7f899551da8967be196b0ae0de2e4
+  data.tar.gz: 5ac202d616c486bbcc3a41fea93f8527181eed8a
 SHA512:
-  metadata.gz: 6c35c1d6769f02ddf3e435017b854bafeb70ab7e12fb737902a4e8052412bc9c710a261f916eecc56002cef2b5a0a932bf897fe3f9ff94e0d2abf15f7039201f
-  data.tar.gz: 7525262e24ad869c37ea1a327bfa345939b5d1a6b35c68d206ff54ac5d6c454c7b60f39adba9bdc2e6689a1a8436a89f8f6adbb8257c426380800affc441e077
+  metadata.gz: f0f5da7b49b6b93d1e7089c494a991332728687829089891d02b4b4986a93b966e4767851889d4f3e4b6a65c531dd33970afdf6c3cb8e199c592b975b2257e1c
+  data.tar.gz: 8a6d3e14c89e453c7b496a49b8a498c1b3bb206c820b2930c0af591738f4d9f69fd343fac3a4cc0c70e99743fa3271825fd58fff0d3bd0c3371ff3fcf9c9ccd2

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
-## 0.1.0 (Apr 06, 2017)
+## 1.0.1 (May 10, 2017)
+
+1. (Fix) Improve the logic for deciding when the database preparation step has successfully completed, and format the error output better.  (Issue #1)
+
+## 1.0.0 (Apr 06, 2017)
 
 1. Initial Release

data/lib/rspec_starter/steps/prepare_database_step.rb

@@ -24,18 +24,33 @@ module RspecStarter
       rebuild_cmd = "rake db:drop db:create db:migrate RAILS_ENV=test"
       print "[#{@runner.step_num}] Preparing the test database with '#{rebuild_cmd.rs_yellow}' ... "
       _stdin, _stdout, stderr = Open3.popen3(rebuild_cmd)
-      error_msg_array = stderr.readlines
+      output_array = prepare_output_array(stderr.readlines)
 
-      if error_msg_array.empty?
+      if successful?(output_array)
         puts "Success".rs_green
+        puts output_array
         @success_or_skipped = true
       else
-        puts "\n\n"
-        puts error_msg_array
+        puts "Fail".rs_red + "\n\n"
+        puts output_array
         puts "\n\nThere was an error rebuilding the test database.  See the output above for details.".rs_red
         puts "or manually run '#{rebuild_cmd}' for more information.".rs_red
         @success_or_skipped = false
       end
     end
+
+    private
+
+    # Simply checking the exitstatus isn't good enough.  When rake aborts due to a bug, it will still
+    # return a zero exit status.  We need to see if 'rake aborted!' has been written to the output.
+    def successful?(output_array)
+      return false if $?.exitstatus.nonzero?
+      not output_array.any? { |result| result.include? "rake aborted!"}
+    end
+
+    def prepare_output_array(array)
+      (0..array.size-1).each { |i| array[i] = "    #{array[i].strip}".rs_red }
+      array
+    end
   end
 end

data/lib/rspec_starter/version.rb

@@ -1,3 +1,3 @@
 module RspecStarter
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_starter
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Roberts
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-04-06 00:00:00.000000000 Z
+date: 2017-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler