rspec_on_failure 0.1.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dfe76197162f75903969fc14398f10a0ef5303b7
-  data.tar.gz: 98ee7e8eaf05fc9a46ff902014e12c0064b79629
+  metadata.gz: ea10d3320e923830fc00ce40dfc03899f0da511f
+  data.tar.gz: 2572ad00a6ba1a95d8de57fb9d2899a9145ced74
 SHA512:
-  metadata.gz: a568989a4a16620960e0e23d8ff8f2ccd743d733c5076caa4171d40d08ba0d1443fc5a1d5d516bf9c935601fd5516ba3cd8263b7889f8762b8bf8892b27fe041
-  data.tar.gz: 9e3cf964634da64774f6e1b48fd886aebbd747c6bc76d05f2c6f0ce939cb0d5da398c740da1a7c5257cc925b3305f431d2739b67b80c2afe5ac6af4c2ce0c020
+  metadata.gz: 3762ee0570b803c2077cab03699add33950777da2961d68130288b0515e111372b3aee00cd8f81da93427011f212edb4b1ab08351adaa3aced79a2d55e2c7742
+  data.tar.gz: fb2c1fde304c4dd11a0cd95975d8c24d743fb2520dabe681bc230f3a1f3c38da9576603167b5e593502b10dcc6344617c8f4e4e1f64c60c6d75efd74c913c505

data/Changelog.md

@@ -0,0 +1,16 @@
+# Changelog
+
+This project follows [semver 2.0.0](http://semver.org/spec/v2.0.0.html) and the
+recommendations of [keepachangelog.com](http://keepachangelog.com/).
+
+## (Unreleased)
+
+## 1.0.0 (2019-10-18)
+
+### Breaking changes
+- Rescue a broader set of exceptions, not just `RSpec::Expectations::ExpectationNotMetError`
+
+### Fixed
+- It was failing to trigger the `on_failure` block when the failure was due to an
+  exception other than a `ExpectationNotMetError`, like `Capybara::ElementNotFound`.
+

data/License

@@ -0,0 +1,18 @@
+Copyright (c) 2019 Tyler Rick
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and
+associated documentation files (the "Software"), to deal in the Software without restriction,
+including without limitation the rights to use, copy, modify, merge, publish, distribute,
+sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial
+portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/{README.md → Readme.md}

@@ -2,23 +2,35 @@
 
 Provide additional debugging information to be printed if a test fails.
 
-In case the debugging information you want to display on failure cannot be easily determined prior
+In case the debugging information you want to display on failure cannot be easily determined *prior*
 to evaluating the expectation. This won't work as expected, for example:
 
-  expect(user).to be_valid, user.errors.full_messages
+```ruby
+expect(user).to be_valid, user.errors.full_messages
+```
 
-because user.errors.full_messages is evaluated *before* it actually calls user.valid?, so it will be empty.
+because `user.errors.full_messages` gets evaluated too soon. This will show the list of errors as it
+was *prior* to calling `user.valid?` (that is, an empty array), rather than the list of errors as it
+was *after* validating therecord, which is what we actually want.
 
 Instead, you can do this, which defers evaluation of the debug information until the time of the
 failure:
 
+```ruby
    on_failure ->{ user.errors.full_messages } do
-     user.should be_valid
+     expect(user).to be_valid
    end
+```
 
 If no block is given, the provided on_failure proc remains in effect until the end of the current
 example.
 
+```ruby
+   on_failure ->{ user.errors.full_messages }
+   expect(user).to be_valid
+   expect(user.errors[:name]).to include "is required"
+```
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/rspec_on_failure.rb

@@ -14,12 +14,16 @@ module RspecOnFailure
   # failure:
   #
   #    on_failure ->{ user.errors.full_messages } do
-  #      user.should be_valid
+  #      expect(user).to be_valid
   #    end
   #
   # If no block is given, the provided on_failure proc remains in effect until the end of the current
   # example.
   #
+  #    on_failure ->{ user.errors.full_messages }
+  #    expect(user).to be_valid
+  #    expect(user.errors[:name]).to include "is required"
+  #
   def on_failure(on_failure_proc)
     if block_given?
       on_failure_call_proc(on_failure_proc) do
@@ -34,7 +38,7 @@ module RspecOnFailure
   def on_failure_call_proc(on_failure_proc)
     begin
       yield
-    rescue RSpec::Expectations::ExpectationNotMetError
+    rescue RSpec::Support::AllExceptionsExceptOnesWeMustNotRescue
       run_failure_call_proc on_failure_proc
       raise
     end
@@ -51,7 +55,7 @@ RSpec.configure do |config|
   config.include RspecOnFailure
   config.after(:each) do |example|
     begin
-      if example.exception.is_a? RSpec::Expectations::ExpectationNotMetError
+      if example.exception and RSpec::Support::AllExceptionsExceptOnesWeMustNotRescue === example.exception
         run_failure_call_proc example.metadata[:on_failure], example
         #puts %(@_on_failure_proc=#{(@_on_failure_proc).inspect})
         run_failure_call_proc @_on_failure_proc,             example

data/lib/rspec_on_failure/version.rb

@@ -1,3 +1,5 @@
 module RspecOnFailure
-  VERSION = "0.1.1"
+    def self.version
+      "1.0.0"
+    end
 end

data/rspec_on_failure.gemspec

@@ -5,22 +5,13 @@ require "rspec_on_failure/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "rspec_on_failure"
-  spec.version       = RspecOnFailure::VERSION
+  spec.version       = RspecOnFailure.version
   spec.authors       = ["Tyler Rick"]
   spec.email         = ["tyler@tylerrick.com"]
 
   spec.summary       = %q{Provide additional debugging information to be printed if a test fails.}
   spec.homepage      = "https://github.com/TylerRick/rspec_on_failure"
 
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
-  if spec.respond_to?(:metadata)
-    spec.metadata["allowed_push_host"] = "https://rubygems.org"
-  else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
-  end
-
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_on_failure
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Tyler Rick
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-13 00:00:00.000000000 Z
+date: 2019-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -62,10 +62,12 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- Changelog.md
 - Gemfile
 - Gemfile.lock
-- README.md
+- License
 - Rakefile
+- Readme.md
 - bin/console
 - bin/setup
 - lib/rspec_on_failure.rb
@@ -73,8 +75,7 @@ files:
 - rspec_on_failure.gemspec
 homepage: https://github.com/TylerRick/rspec_on_failure
 licenses: []
-metadata:
-  allowed_push_host: https://rubygems.org
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -91,7 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.14.3
 signing_key: 
 specification_version: 4
 summary: Provide additional debugging information to be printed if a test fails.