rspec_jsonapi_serializer 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc87e1c0dd34c16432247cfbb0050bf67e1666b557f49a60b2400cbf84e62d40
-  data.tar.gz: 7cb83bb3fb733102671a0fe860dfd12a2e8d2070e0613879cf22502462d40254
+  metadata.gz: a01005a800b62bc1790bef3c0b41d7f39528016cbc3f44255100d60c06f6e3f7
+  data.tar.gz: 6870f0d87b139a4e50bedabc2af25faae9a9aa10918ee20cf7a31947b57ecb3e
 SHA512:
-  metadata.gz: 9e22aa5740094b7d307b8ea1a738546d1fde3bcbe8f28043e66d6211bf85cb457cc2d36a0d819c1f1f507f6c6980f1a699b5ff55d11d2b88d08c3478c4252b9a
-  data.tar.gz: bacc318b8c1d7756c9109113b116a2d710d966efa9578b2dc61e07ab67056d9300d1a0138b69d5e415186c49160813247e2a9a7083385c3af4836011fd6cdaba
+  metadata.gz: b3de4e1e8b9253c30fd625113d0633e70a175546c071c413164af646fceb3785bcd1bb0c310e47f0b91162f48d0a7c989807cc32e13754b4376d89ecdebb195d
+  data.tar.gz: b65538587e22e77df17ef8acaca5694ca9212b7827e9e8ec35dcf4583b860f6ca287396b92bdb01a88aa623f7fabe520c76ff95036c8efb22351f8453e74c771

data/lib/rspec_jsonapi_serializer/matchers/association_matcher.rb

@@ -3,6 +3,7 @@
 require "rspec_jsonapi_serializer/matchers/base"
 require "rspec_jsonapi_serializer/matchers/association_matchers/serializer_matcher"
 require "rspec_jsonapi_serializer/matchers/association_matchers/id_method_name_matcher"
+require "rspec_jsonapi_serializer/matchers/association_matchers/object_method_name_matcher"
 require "rspec_jsonapi_serializer/metadata/relationships"
 
 module RSpecJSONAPISerializer
@@ -33,32 +34,22 @@ module RSpecJSONAPISerializer
         self
       end
 
-      def description
-        description = "#{association_message} #{expected}"
+      def object_method_name(value)
+        add_submatcher AssociationMatchers::ObjectMethodNameMatcher.new(value, expected)
 
-        [description, submatchers.map(&:description)].flatten.join(' ')
-      end
-
-      def failure_message
-        "Expected #{expectation}"
+        self
       end
 
-      def failure_message_when_negated
-        "Did not expect #{expectation}"
+      def main_failure_message
+        [expected_message, actual_message].compact.join(", ")
       end
 
       private
 
       attr_reader :relationship_matcher, :relationship_type
 
-      def expectation
-        expectation = "#{serializer_name} to #{association_message} #{expected}"
-
-        submatchers_expectations = failing_submatchers.map do |submatcher|
-          "(#{submatcher.expectation})"
-        end.compact.join(", ")
-
-        [expectation, submatchers_expectations].reject(&:nil?).reject(&:empty?).join(" ")
+      def expected_message
+        "expected #{serializer_name} to #{association_message} #{expected}"
       end
 
       def relationship_matches?
@@ -70,7 +61,7 @@ module RSpecJSONAPISerializer
       end
 
       def association_message
-        relationship_matcher.to_s.split("_").join(" ")
+        relationship_matcher.to_s.split('_')
       end
 
       def actual

data/lib/rspec_jsonapi_serializer/matchers/association_matchers/id_method_name_matcher.rb

@@ -9,7 +9,7 @@ module RSpecJSONAPISerializer
         def initialize(value, relationship_target)
           super(value)
 
-          @relationship_target = relationship_target
+          @relationship_target  = relationship_target
         end
 
         def matches?(serializer_instance)
@@ -18,18 +18,18 @@ module RSpecJSONAPISerializer
           actual == expected
         end
 
-        def description
-          "with id method name #{expected}"
-        end
-
-        def expectation
-          [ "with id method name #{expected}", actual_message ].compact.join(", ")
+        def main_failure_message
+          [expected_message, actual_message].compact.join(", ")
         end
 
         private
 
         attr_reader :relationship_target
 
+        def expected_message
+          "expected #{serializer_name} to use #{expected} as id_method_name for #{relationship_target}"
+        end
+
         def actual_message
           actual ? "got #{actual} instead" : nil
         end

data/lib/rspec_jsonapi_serializer/matchers/association_matchers/object_method_name_matcher.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require "rspec_jsonapi_serializer/metadata/relationships"
+
+module RSpecJSONAPISerializer
+  module Matchers
+    module AssociationMatchers
+      class ObjectMethodNameMatcher < Base
+        def initialize(value, relationship_target)
+          super(value)
+
+          @relationship_target  = relationship_target
+        end
+
+        def matches?(serializer_instance)
+          @serializer_instance = serializer_instance
+
+          actual == expected
+        end
+
+        def main_failure_message
+          [expected_message, actual_message].compact.join(", ")
+        end
+
+        private
+
+        attr_reader :relationship_target
+
+        def expected_message
+          "expected #{serializer_name} to use #{expected} as object_method_name for #{relationship_target}"
+        end
+
+        def actual_message
+          actual ? "got #{actual} instead" : nil
+        end
+
+        def actual
+          metadata.relationship(relationship_target).object_method_name
+        end
+
+        def metadata
+          Metadata::Relationships.new(serializer_instance)
+        end
+      end
+    end
+  end
+end

data/lib/rspec_jsonapi_serializer/matchers/association_matchers/serializer_matcher.rb

@@ -18,18 +18,18 @@ module RSpecJSONAPISerializer
           actual == expected
         end
 
-        def description
-          "with serializer #{expected}"
-        end
-
-        def expectation
-          [ "with serializer #{expected}", actual_message ].compact.join(", ")
+        def main_failure_message
+          [expected_message, actual_message].compact.join(", ")
         end
 
         private
 
         attr_reader :relationship_target
 
+        def expected_message
+          "expected #{serializer_name} to use #{expected} as serializer for #{relationship_target}"
+        end
+
         def actual_message
           actual ? "got #{actual} instead" : nil
         end

data/lib/rspec_jsonapi_serializer/matchers/base.rb

@@ -13,17 +13,27 @@ module RSpecJSONAPISerializer
       end
 
       def failure_message
-        raise NotImplementedError
+        ([main_failure_message] + submatcher_failure_messages).compact.join("\n")
       end
 
       def failure_message_when_negated
-        raise NotImplementedError
+        ([main_failure_message_when_negated] + submatcher_failure_messages_when_negated)
+          .compact
+          .join("\n")
       end
 
       protected
 
       attr_reader :expected, :serializer_instance, :submatchers
 
+      def main_failure_message
+        raise NotImplementedError
+      end
+
+      def main_failure_message_when_negated
+        raise NotImplementedError
+      end
+
       def add_submatcher(submatcher)
         submatchers << submatcher
       end
@@ -40,6 +50,16 @@ module RSpecJSONAPISerializer
         serializer_instance.class.name
       end
 
+      private
+
+      def submatcher_failure_messages
+        failing_submatchers.map(&:failure_message)
+      end
+
+      def submatcher_failure_messages_when_negated
+        failing_submatchers.map(&:failure_message_when_negated)
+      end
+
       def failing_submatchers
         @failing_submatchers ||= submatchers.select do |submatcher|
           !submatcher.matches?(serializer_instance)

data/lib/rspec_jsonapi_serializer/matchers/belong_to_matcher.rb

@@ -17,20 +17,16 @@ module RSpecJSONAPISerializer
         association_matcher.id_method_name(value)
       end
 
-      def serializer(value)
-        association_matcher.serializer(value)
-      end
-
-      def description
-        association_matcher.description
+      def object_method_name(value)
+        association_matcher.object_method_name(value)
       end
 
-      def failure_message
-        association_matcher.failure_message
+      def serializer(value)
+        association_matcher.serializer(value)
       end
 
-      def failure_message_when_negated
-        association_matcher.failure_message_when_negated
+      def main_failure_message
+        association_matcher.main_failure_message
       end
 
       private

data/lib/rspec_jsonapi_serializer/matchers/have_attribute_matcher.rb

@@ -19,35 +19,17 @@ module RSpecJSONAPISerializer
       end
 
       def as_nil
-        as(nil)
-      end
-
-      def description
-        description = "have attribute #{expected}"
+        add_submatcher HaveAttributeMatchers::AsMatcher.new(expected, nil)
 
-        [description, submatchers.map(&:description)].flatten.join(' ')
-      end
-
-      def failure_message
-        "Expected #{expectation}."
+        self
       end
 
-      def failure_message_when_negated
-        "Did not expect #{expectation}."
+      def main_failure_message
+        "expected #{serializer_name} to have attribute #{expected}." unless has_attribute?
       end
 
       private
 
-      def expectation
-        expectation = "#{serializer_name} to have attribute #{expected}"
-
-        submatchers_expectations = failing_submatchers.map do |submatcher|
-          "(#{submatcher.expectation})"
-        end.compact.join(", ")
-
-        [expectation, submatchers_expectations].reject(&:nil?).reject(&:empty?).join(" ")
-      end
-
       def attributes
         @attributes ||= serializer_instance.class.try(:attributes_to_serialize) || {}
       end

data/lib/rspec_jsonapi_serializer/matchers/have_attribute_matchers/as_matcher.rb

@@ -18,30 +18,20 @@ module RSpecJSONAPISerializer
           actual == expected
         end
 
-        def description
-          "as #{expected_to_string}"
-        end
-
-        def expectation
-          [ "as #{expected_to_string}", actual_message ].compact.join(", ")
+        def failure_message
+          [expected_message, actual_message].compact.join(", ")
         end
 
         private
 
         attr_reader :attribute
 
-        def expected_to_string
-          value_to_string(expected)
+        def expected_message
+          "expected #{serializer_instance.class.name} to serialize #{attribute} as #{expected}"
         end
 
         def actual_message
-          "got #{value_to_string(actual)} instead" if attributes.has_key?(attribute)
-        end
-
-        def value_to_string(value)
-          return 'nil' if value.nil?
-
-          value.to_s
+          "got #{actual.nil? ? 'nil' : actual} instead" if attributes.has_key?(attribute)
         end
 
         def actual

data/lib/rspec_jsonapi_serializer/matchers/have_id_matcher.rb

@@ -11,7 +11,7 @@ module RSpecJSONAPISerializer
         actual == expected
       end
 
-      def failure_message
+      def main_failure_message
         "expected that #{serializer_name} to have id :#{expected}, got :#{actual} instead"
       end
 

data/lib/rspec_jsonapi_serializer/matchers/have_link_matcher.rb

@@ -19,35 +19,17 @@ module RSpecJSONAPISerializer
       end
 
       def as_nil
-        as(nil)
-      end
-
-      def description
-        description = "have link #{expected}"
+        add_submatcher HaveLinkMatchers::AsMatcher.new(expected, nil)
 
-        [description, submatchers.map(&:description)].flatten.join(' ')
-      end
-
-      def failure_message
-        "Expected #{expectation}."
+        self
       end
 
-      def failure_message_when_negated
-        "Did not expect #{expectation}."
+      def main_failure_message
+        "expected #{serializer_name} to have link #{expected}." unless has_link?
       end
 
       private
 
-      def expectation
-        expectation = "#{serializer_name} to have link #{expected}"
-
-        submatchers_expectations = failing_submatchers.map do |submatcher|
-          "(#{submatcher.expectation})"
-        end.compact.join(", ")
-
-        [expectation, submatchers_expectations].reject(&:nil?).reject(&:empty?).join(" ")
-      end
-
       def has_link?
         links.has_key?(expected)
       end

data/lib/rspec_jsonapi_serializer/matchers/have_link_matchers/as_matcher.rb

@@ -18,30 +18,20 @@ module RSpecJSONAPISerializer
           actual == expected
         end
 
-        def description
-          "as #{expected_to_string}"
-        end
-
-        def expectation
-          [ "as #{expected_to_string}", actual_message ].compact.join(", ")
+        def failure_message
+          [expected_message, actual_message].compact.join(", ")
         end
 
         private
 
         attr_reader :link
 
-        def expected_to_string
-          value_to_string(expected)
+        def expected_message
+          "expected #{serializer_instance.class.name} to serialize link #{link} as #{expected}"
         end
 
         def actual_message
-          "got #{value_to_string(actual)} instead" if links.has_key?(link)
-        end
-
-        def value_to_string(value)
-          return 'nil' if value.nil?
-
-          value.to_s
+          "got #{actual.nil? ? 'nil' : actual} instead" if links.has_key?(link)
         end
 
         def actual

data/lib/rspec_jsonapi_serializer/matchers/have_many_matcher.rb

@@ -17,20 +17,16 @@ module RSpecJSONAPISerializer
         association_matcher.id_method_name(value)
       end
 
-      def serializer(value)
-        association_matcher.serializer(value)
-      end
-
-      def description
-        association_matcher.description
+      def object_method_name(value)
+        association_matcher.object_method_name(value)
       end
 
-      def failure_message
-        association_matcher.failure_message
+      def serializer(value)
+        association_matcher.serializer(value)
       end
 
-      def failure_message_when_negated
-        association_matcher.failure_message_when_negated
+      def main_failure_message
+        association_matcher.main_failure_message
       end
 
       private

data/lib/rspec_jsonapi_serializer/matchers/have_meta_matcher.rb

@@ -19,35 +19,17 @@ module RSpecJSONAPISerializer
       end
 
       def as_nil
-        as(nil)
-      end
-
-      def description
-        description = "serialize meta #{expected}"
+        add_submatcher HaveMetaMatchers::AsMatcher.new(expected, nil)
 
-        [description, submatchers.map(&:description)].flatten.join(' ')
-      end
-
-      def failure_message
-        "Expected #{expectation}."
+        self
       end
 
-      def failure_message_when_negated
-        "Did not expect #{expectation}."
+      def main_failure_message
+        "expected #{serializer_name} to serialize meta #{expected}." unless has_meta?
       end
 
       private
 
-      def expectation
-        expectation = "#{serializer_name} to serialize meta #{expected}"
-
-        submatchers_expectations = failing_submatchers.map do |submatcher|
-          "(#{submatcher.expectation})"
-        end.compact.join(", ")
-
-        [expectation, submatchers_expectations].reject(&:nil?).reject(&:empty?).join(" ")
-      end
-
       def metas
         @metas ||= serializable_hash.dig(:data, :meta) || {}
       end

data/lib/rspec_jsonapi_serializer/matchers/have_meta_matchers/as_matcher.rb

@@ -18,33 +18,22 @@ module RSpecJSONAPISerializer
           actual == expected
         end
 
-        def description
-          "as #{expected_to_string}"
-        end
-
-        def expectation
-          [ "as #{expected_to_string}", actual_message ].compact.join(", ")
+        def failure_message
+          [expected_message, actual_message].compact.join(", ")
         end
 
         private
 
         attr_reader :meta
 
-        def expected_to_string
-          value_to_string(expected)
+        def expected_message
+          "expected #{serializer_instance.class.name} to serialize meta #{meta} as #{expected}"
         end
 
         def actual_message
           "got #{actual.nil? ? 'nil' : actual} instead" if metas.has_key?(meta)
         end
 
-        def value_to_string(value)
-          return 'nil' if value.nil?
-
-          value.to_s
-        end
-
-
         def actual
           metas[meta]
         end

data/lib/rspec_jsonapi_serializer/matchers/have_one_matcher.rb

@@ -17,20 +17,16 @@ module RSpecJSONAPISerializer
         association_matcher.id_method_name(value)
       end
 
-      def serializer(value)
-        association_matcher.serializer(value)
-      end
-
-      def description
-        association_matcher.description
+      def object_method_name(value)
+        association_matcher.object_method_name(value)
       end
 
-      def failure_message
-        association_matcher.failure_message
+      def serializer(value)
+        association_matcher.serializer(value)
       end
 
-      def failure_message_when_negated
-        association_matcher.failure_message_when_negated
+      def main_failure_message
+        association_matcher.main_failure_message
       end
 
       private

data/lib/rspec_jsonapi_serializer/matchers/have_type_matcher.rb

@@ -11,7 +11,7 @@ module RSpecJSONAPISerializer
         actual == expected
       end
 
-      def failure_message
+      def main_failure_message
         "expected that #{serializer_name} to have type :#{expected}, got :#{actual} instead"
       end
 

data/lib/rspec_jsonapi_serializer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RSpecJSONAPISerializer
-  VERSION = "1.2.1"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_jsonapi_serializer
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Mateus Cruz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-05-21 00:00:00.000000000 Z
+date: 2023-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jsonapi-serializer
@@ -35,6 +35,7 @@ files:
 - lib/rspec_jsonapi_serializer/matchers.rb
 - lib/rspec_jsonapi_serializer/matchers/association_matcher.rb
 - lib/rspec_jsonapi_serializer/matchers/association_matchers/id_method_name_matcher.rb
+- lib/rspec_jsonapi_serializer/matchers/association_matchers/object_method_name_matcher.rb
 - lib/rspec_jsonapi_serializer/matchers/association_matchers/serializer_matcher.rb
 - lib/rspec_jsonapi_serializer/matchers/base.rb
 - lib/rspec_jsonapi_serializer/matchers/belong_to_matcher.rb
@@ -50,13 +51,13 @@ files:
 - lib/rspec_jsonapi_serializer/matchers/have_type_matcher.rb
 - lib/rspec_jsonapi_serializer/metadata/relationships.rb
 - lib/rspec_jsonapi_serializer/version.rb
-homepage: https://github.com/teamintricately/rspec_jsonapi_serializer
+homepage: https://github.com/mateuscruz/rspec_jsonapi_serializer
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/teamintricately/rspec_jsonapi_serializer
-  source_code_uri: https://github.com/teamintricately/rspec_jsonapi_serializer
-  changelog_uri: https://github.com/teamintricately/rspec_jsonapi_serializer/blob/main/CHANGELOG.md
+  homepage_uri: https://github.com/mateuscruz/rspec_jsonapi_serializer
+  source_code_uri: https://github.com/mateuscruz/rspec_jsonapi_serializer
+  changelog_uri: https://github.com/mateuscruz/rspec_jsonapi_serializer/blob/main/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths: