rspec_controller_helpers 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b816731a16523117cdac6f32b731ff71bed46b02
-  data.tar.gz: 4541661168a86e51362be90c193da3f0eeb765d2
+  metadata.gz: bd32a83c2aef3899917f4cd11337cbc64f6e8b9a
+  data.tar.gz: da04fb1ec5fd120de6fe43b3e788521e3ff61fd8
 SHA512:
-  metadata.gz: 2e7316be23023c08cd48b15681708dab43c40d6c8bcdca49075d4cfb447cd4936a1818d607e9dde1e64b2688d1893531d71103d8e36d95cc9bc99014573b8eb3
-  data.tar.gz: 6b10f3bf98a8dc33731e951e09e1bca23c31f29b0c0e856452964f7a26d46bc7faeeda4f854ee28136ab51913f548b350f03b3b83458315062066d9e8b4dd94b
+  metadata.gz: a8464d1920a23fceb2429250f5b7cecfe48c8154107def64754596620bde9524f1a0dbc7432edd4d0e76405a7d02a4c54c33750d0628f377577fe89bd1041d25
+  data.tar.gz: 2cdc8dd41c6eb863ed2c094f530bb8fbfe60d9f1e745a0f1c6879e91198ecdbe77f7dc676ee6ff95e14ab45210ba6f6d58149edc57dac84ea83691bc89856475

data/lib/rspec_controller_helpers/resourceful.rb

@@ -1,23 +1,45 @@
 RSpec.shared_examples_for 'a resourceful controller' do |model, raw_options|
-  let(:options) { raw_options || {} }
-  let(:symbol) { options[:symbol] || model.name.downcase.to_sym }
-  let(:factory) { options[:factory] || symbol }
-
-  let(:tests) do
-    all = [:index, :new, :create, :show, :edit, :update, :delete]
-    except = options[:except] || []
-    options[:only] || (all - except)
+  let(:default_options) do
+    {
+      only: [:index, :new, :create, :show, :edit, :update, :delete],
+      except: [],
+      formats: {} # They all default to :html
+    }
   end
+  let(:options) { default_options.merge(raw_options) }
+  let(:model_name) { options[:model_name] || model.name.downcase.to_sym }
+  let(:factory) { options[:factory] || model_name }
+  let(:endpoints) { options[:only] - options[:except] }
+
+  let(:formats) do
+    endpoints
+      .map { |t| { t => [:html] } }
+      .reduce(:merge)
+      .merge(options[:formats])
+  end
+
+  let(:json_response) { JSON.parse(response.body) }
 
   describe "GET /<resource>" do
     let!(:objects) { create_list(factory, 3) }
     subject { get :index }
 
-    it "renders the index page" do
-      if tests.include? :index
+    it 'is successful' do
+      if endpoints.include? :index
         subject
         expect(response).to have_http_status(:ok)
-        expect(response).to render_template(:index)
+      end
+    end
+
+    it "renders the index page" do
+      if endpoints.include? :index
+        subject
+        if formats[:index].include? :html
+          expect(response).to render_template(:index)
+        end
+        if formats[:index].include? :json
+          expect(json_response.length).to eq(3)
+        end
       end
     end
   end
@@ -25,21 +47,29 @@ RSpec.shared_examples_for 'a resourceful controller' do |model, raw_options|
   describe "GET /<resource>/new" do
     subject { get :new }
 
-    it "renders the new page" do
-      if tests.include? :new
+    it 'is successful' do
+      if endpoints.include? :new
         subject
         expect(response).to have_http_status(:ok)
-        expect(response).to render_template(:new)
+      end
+    end
+
+    it "renders the new page" do
+      if endpoints.include? :new
+        subject
+        if formats[:new].include? :html
+          expect(response).to render_template(:new)
+        end
       end
     end
   end
 
   describe "POST /<resource>" do
     let(:attributes) { attributes_for(factory) }
-    subject { post :create, symbol => attributes }
+    subject { post :create, model_name => attributes }
 
     it "creates a new object" do
-      if tests.include? :create
+      if endpoints.include? :create
         expect { subject }.to change { model.count }.by(1)
       end
     end
@@ -49,11 +79,24 @@ RSpec.shared_examples_for 'a resourceful controller' do |model, raw_options|
     let(:object) { create(factory) }
     subject { get :show, id: object.id }
 
-    it "renders the show page" do
-      if tests.include? :show
+    it 'is successful' do
+      if endpoints.include? :show
         subject
         expect(response).to have_http_status(:ok)
-        expect(response).to render_template(:show)
+      end
+    end
+
+    it "renders the show page" do
+      if endpoints.include? :show
+        subject
+        if formats[:show].include? :html
+          expect(response).to render_template(:show)
+        end
+        if formats[:show].include? :json
+          desired_attributes = attributes_for(factory).keys
+          attributes = object.attributes.select { |k, _| desired_attributes.include?(k) }
+          expect(json_response).to eq(attributes)
+        end
       end
     end
   end
@@ -62,11 +105,19 @@ RSpec.shared_examples_for 'a resourceful controller' do |model, raw_options|
     let(:object) { create(factory) }
     subject { get :edit, id: object.id }
 
-    it "renders the edit page" do
-      if tests.include? :edit
+    it 'is successful' do
+      if endpoints.include? :edit
         subject
         expect(response).to have_http_status(:ok)
-        expect(response).to render_template(:edit)
+      end
+    end
+
+    it "renders the edit page" do
+      if endpoints.include? :edit
+        subject
+        if formats[:edit].include? :html
+          expect(response).to render_template(:edit)
+        end
       end
     end
   end
@@ -74,10 +125,10 @@ RSpec.shared_examples_for 'a resourceful controller' do |model, raw_options|
   describe "PATCH /<resource>/:id" do
     let(:object) { create(factory) }
     let(:new_attributes) { attributes_for(factory) }
-    subject { patch :update, id: object.id, symbol => new_attributes }
+    subject { patch :update, id: object.id, model_name => new_attributes }
 
     it "updates the object" do
-      if tests.include? :update
+      if endpoints.include? :update
         subject
         object.reload
         new_attributes.each do |k, v|
@@ -92,7 +143,7 @@ RSpec.shared_examples_for 'a resourceful controller' do |model, raw_options|
     subject { delete :destroy, id: object.id }
 
     it "deletes the object" do
-      if tests.include? :destroy
+      if endpoints.include? :destroy
         expect { subject }.to change { model.count }.by(-1)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec_controller_helpers
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Derek Kniffin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-19 00:00:00.000000000 Z
+date: 2016-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-rails