rspec_api_blueprint_matchers 0.1.2 → 0.1.3

data/lib/rspec_apib/response.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "json"
 module RSpecApib
   class Response
@@ -27,13 +28,12 @@ module RSpecApib
       raw_response.response_headers
     end
 
-
     private
 
     attr_accessor :raw_response
 
     def is_json?
-      content_type=~/json/
+      content_type =~ /json/
     end
   end
 end

data/lib/rspec_apib/rspec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rspec/matchers"
 require "rspec_apib/transaction_validator"
 require "rspec_apib/transaction_coverage_validator"
@@ -16,12 +17,12 @@ RSpec::Matchers.define :match_api_docs_for do |path:, request_method:, content_t
 
   end
 
-  failure_message do |actual|
+  failure_message do |_actual|
     error_messages.join("\n")
   end
 end
 
-RSpec::Matchers.define :have_covered_all_api_documentation do | parser: RSpecApib.config.default_parser |
+RSpec::Matchers.define :have_covered_all_api_documentation do |parser: RSpecApib.config.default_parser|
   error_messages = []
   Transaction = Struct.new(:request, :response)
   match do |actual|
@@ -34,7 +35,7 @@ RSpec::Matchers.define :have_covered_all_api_documentation do | parser: RSpecApi
 
   end
 
-  failure_message do |actual|
+  failure_message do |_actual|
     error_messages.join("\n")
   end
 end

data/lib/rspec_apib/transaction_coverage_report.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RSpecApib
   class TransactionCoverageReport
     def initialize(transactions:, parser: RSpecApib.config.default_parser)
@@ -6,8 +7,8 @@ module RSpecApib
     end
 
     def uncovered_transactions
-      documented_transaction_tracker = parser.http_transactions.inject({}) do |acc, t|
-        acc[t]=false
+      documented_transaction_tracker = parser.http_transactions.each_with_object({}) do |t, acc|
+        acc[t] = false
         acc
       end
       transactions.each do |requested_tx|
@@ -15,7 +16,7 @@ module RSpecApib
           documented_transaction_tracker[dtx] = true if dtx.matches?(requested_tx.request, requested_tx.response)
         end
       end
-      documented_transaction_tracker.reject {|k,v| v}.keys
+      documented_transaction_tracker.reject {|_k, v| v}.keys
     end
 
     def undocumented_transactions

data/lib/rspec_apib/transaction_coverage_validator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rspec_apib/transaction_coverage_report"
 module RSpecApib
   class TransactionCoverageValidator
@@ -9,18 +10,18 @@ module RSpecApib
       errors = []
       reporter = TransactionCoverageReport.new(transactions: transactions, parser: parser)
       uncovered = reporter.uncovered_transactions
-      if uncovered.length > 0
+      unless uncovered.empty?
         uncovered.each do |tx|
           errors << self.class.uncovered_tx_message(tx)
         end
       end
       undocumented = reporter.undocumented_transactions
-      if undocumented.length > 0
+      unless undocumented.empty?
         undocumented.each do |tx|
           errors << self.class.undocumented_tx_message(tx)
         end
       end
-      if errors.length > 0
+      if !errors.empty?
         error_messages.concat errors
         error_messages << "Coverage Summary: #{uncovered.length} uncovered and #{undocumented.length} undocumented transactions"
         false

data/lib/rspec_apib/transaction_validator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RSpecApib
   class TransactionValidator
     # validate_request_schema can be :always, :never, :when_defined

data/lib/rspec_apib/transcluder.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RSpecApib::Transcluder
   REGEX = /:\[[^\]]*\]\(([^\)]*)\)/
   def self.each_line(file, &block)
@@ -15,7 +16,7 @@ module RSpecApib::Transcluder
   end
 
   def self.transclude(file, line, &block)
-    line.gsub!(REGEX) do |match|
+    line.gsub!(REGEX) do |_match|
       transclude_file = $1
       unless transclude_file =~ /^\//
         transclude_file = File.expand_path(transclude_file, File.dirname(file))
@@ -26,5 +27,4 @@ module RSpecApib::Transcluder
     yield line
   end
 
-
 end

data/lib/rspec_apib/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RSpecApib
-  VERSION = "0.1.2"
+  VERSION = "0.1.3".freeze
 end

data/lib/rspec_apib.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rspec_apib/version"
 require "rspec_apib/parser"
 require "rspec_apib/extractors"
@@ -7,7 +8,7 @@ require "rspec_apib/config"
 require "rspec_apib/request"
 require "rspec_apib/response"
 module RSpecApib
-  ROOT_THREAD_VARS = :"rspec_apib"
+  ROOT_THREAD_VARS = :rspec_apib
   # The global configuration object
   # If a block is passed into this method, it is yielded with
   # the config object and all actions are performed from within the

data/lib/transcluder.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RSpecApib::Transcluder
 
 end

data/rspec_api_blueprint_matchers.gemspec

@@ -1,7 +1,8 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'rspec_apib/version'
+require "rspec_apib/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "rspec_api_blueprint_matchers"
@@ -9,8 +10,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Shift Commerce Ltd"]
   spec.email         = ["team@shiftcommerce.com"]
 
-  spec.summary       = %q{API Blueprint Tools For RSpec}
-  spec.description   = %q{API Blueprint Tools For RSpec - Matching http transactions against an API Blueprint document to ensure the API that you are implementing matches the API that is documented which your clients will expect to be the case.}
+  spec.summary       = "API Blueprint Tools For RSpec"
+  spec.description   = "API Blueprint Tools For RSpec - Matching http transactions against an API Blueprint document to ensure the API that you are implementing matches the API that is documented which your clients will expect to be the case."
   spec.homepage      = "https://github.com/shiftcommerce/rspec_api_blueprint_matchers"
   spec.license       = "MIT"
 
@@ -26,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "byebug"
   spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rubocop", "0.46"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec_api_blueprint_matchers
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Shift Commerce Ltd
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.46'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.46'
 description: API Blueprint Tools For RSpec - Matching http transactions against an
   API Blueprint document to ensure the API that you are implementing matches the API
   that is documented which your clients will expect to be the case.
@@ -103,8 +117,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".ruby-version"
 - ".travis.yml"
 - Dockerfile
 - Gemfile
@@ -115,6 +132,12 @@ files:
 - bin/setup
 - codeship-services.yml
 - codeship-steps.yml
+- config/rubocop/.lint_rubocop.yml
+- config/rubocop/.metrics_rubocop.yml
+- config/rubocop/.performance_rubocop.yml
+- config/rubocop/.rails_rubocop.yml
+- config/rubocop/.style_rubocop.yml
+- docker-compose.yml
 - lib/rspec_api_blueprint_matchers.rb
 - lib/rspec_apib.rb
 - lib/rspec_apib/config.rb
@@ -175,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: API Blueprint Tools For RSpec