rspec 1.1.12 → 1.2.0

data/spec/spec/example/example_group_factory_spec.rb

@@ -6,7 +6,7 @@ module Spec
       describe "#get" do
         attr_reader :example_group
         before(:each) do
-          @example_group_class = Class.new(ExampleGroup)
+          @example_group_class = Class.new(ExampleGroupDouble)
           ExampleGroupFactory.register(:registered_type, @example_group_class)
         end
 
@@ -15,32 +15,28 @@ module Spec
         end
 
         it "should return the default ExampleGroup type for nil" do
-          ExampleGroupFactory.get(nil).should == ExampleGroup
+          ExampleGroupFactory[nil].should == ExampleGroup
         end
 
         it "should return the default ExampleGroup for an unregistered non-nil value" do
-          ExampleGroupFactory.get(:does_not_exist).should == ExampleGroup
+          ExampleGroupFactory[:does_not_exist].should == ExampleGroup
         end
 
         it "should return custom type if registered" do
-          ExampleGroupFactory.get(:registered_type).should == @example_group_class
-        end
-
-        it "should return the actual type when that is what is submitted" do
-          ExampleGroupFactory.get(@example_group_class).should == @example_group_class
+          ExampleGroupFactory[:registered_type].should == @example_group_class
         end
 
         it "should get the custom type after setting the default" do
-          @alternate_example_group_class = Class.new(ExampleGroup)
+          @alternate_example_group_class = Class.new(ExampleGroupDouble)
           ExampleGroupFactory.default(@alternate_example_group_class)
-          ExampleGroupFactory.get(:registered_type).should == @example_group_class
+          ExampleGroupFactory[:registered_type].should == @example_group_class
         end
       end
 
       describe "#create_example_group" do
         attr_reader :parent_example_group
         before do
-          @parent_example_group = Class.new(ExampleGroup) do
+          @parent_example_group = Class.new(ExampleGroupDouble) do
             def initialize(*args, &block)
               ;
             end
@@ -62,7 +58,7 @@ module Spec
             Spec::Example::ExampleGroupFactory.create_example_group do; end
           }.should raise_error(ArgumentError)
         end
-        
+
         it "should raise when no block is given" do
           lambda { Spec::Example::ExampleGroupFactory.create_example_group "foo" }.should raise_error(ArgumentError)
         end
@@ -112,7 +108,26 @@ module Spec
           ) {}
           custom_example_group.superclass.should == parent_example_group
         end
-        
+
+        it "should create a type indicated by spec_path for a path-like key" do
+          Spec::Example::ExampleGroupFactory.register('path/to/custom/', parent_example_group)
+          custom_example_group = Spec::Example::ExampleGroupFactory.create_example_group(
+            "example_group", :spec_path => "./spec/path/to/custom/some_spec.rb"
+          ) {}
+          custom_example_group.superclass.should == parent_example_group
+        end
+
+        it "should use the longest key that matches when creating a type indicated by spec_path" do
+          longer = Class.new parent_example_group
+          Spec::Example::ExampleGroupFactory.register(:longer, longer)
+          long = Class.new parent_example_group
+          Spec::Example::ExampleGroupFactory.register(:long, long)
+          custom_example_group = Spec::Example::ExampleGroupFactory.create_example_group(
+            "example_group", :spec_path => "./spec/longer/some_spec.rb"
+          ) {}
+          custom_example_group.superclass.should == longer
+        end
+
         it "sets the spec_path from the caller" do
           options = {}
           shared_example_group = Spec::Example::ExampleGroupFactory.create_example_group("foo", options) {}
@@ -152,19 +167,19 @@ module Spec
           end
           Spec::Runner.options.example_groups.should_not include(example_group)
         end
-        
+
         after(:each) do
           Spec::Example::ExampleGroupFactory.reset
         end
       end
-      
+
       describe "#create_shared_example_group" do
         it "registers a new shared example group" do
           shared_example_group = Spec::Example::ExampleGroupFactory.create_shared_example_group("something shared") {}
           shared_example_group.should be_an_instance_of(Spec::Example::SharedExampleGroup)
           SharedExampleGroup.should include(shared_example_group)
         end
-        
+
         it "sets the spec_path from the caller" do
           options = {}
           shared_example_group = Spec::Example::ExampleGroupFactory.create_shared_example_group("foo", options) {}
@@ -172,34 +187,6 @@ module Spec
         end
       end
 
-      describe "#registered_or_ancestor_of_registered?" do
-        before(:each) do
-          @unregistered_parent = Class.new(ExampleGroup)
-          @registered_child = Class.new(@unregistered_parent)
-          @unregistered_grandchild = Class.new(@registered_child)
-          Spec::Example::ExampleGroupFactory.register :registered_child, @registered_child
-        end
-        
-        it "should return true for empty list" do
-          Spec::Example::ExampleGroupFactory.registered_or_ancestor_of_registered?([]).should be_true
-        end
-        
-        it "should return true for a registered example group class" do
-          Spec::Example::ExampleGroupFactory.registered_or_ancestor_of_registered?([@registered_child]).should be_true
-        end
-
-        it "should return true for an ancestor of a registered example_group_classes" do
-          Spec::Example::ExampleGroupFactory.registered_or_ancestor_of_registered?([@unregistered_parent]).should be_true
-        end
-
-        it "should return false for a subclass of a registered example_group_class" do
-          Spec::Example::ExampleGroupFactory.registered_or_ancestor_of_registered?([@unregistered_grandchild]).should be_false
-        end
-
-        after(:each) do
-          Spec::Example::ExampleGroupFactory.reset
-        end
-      end
     end
   end
 end

data/spec/spec/example/example_group_methods_spec.rb

@@ -12,21 +12,21 @@ module Spec
           options.backtrace_tweaker = mock("backtrace_tweaker", :null_object => true)
           @reporter = FakeReporter.new(@options)
           options.reporter = reporter
-          @example_group = Class.new(ExampleGroup) do
+          @example_group = Class.new(ExampleGroupDouble) do
             describe("ExampleGroup")
             it "does nothing"
           end
         end
         
         after(:each) do
-          ExampleGroup.reset
+          ExampleGroupDouble.reset
         end
 
         ["describe","context"].each do |method|
           describe "##{method}" do
             describe "when creating an ExampleGroup" do
               before(:each) do
-                @parent_example_group = Class.new(ExampleGroup) do
+                @parent_example_group = Class.new(ExampleGroupDouble) do
                   example "first example" do; end
                 end
                 @child_example_group = @parent_example_group.__send__ method, "Child" do
@@ -66,17 +66,36 @@ module Spec
           end
         end
         
-        [:specify, :it].each do |method|
+        [:example, :specify, :it].each do |method|
           describe "##{method.to_s}" do
-            it "should should create an example" do
+            it "should add an example" do
               lambda {
                 @example_group.__send__(method, "")
               }.should change { @example_group.examples.length }.by(1)
             end
+            
+            describe "creates an ExampleDescription" do
+              before(:all) do
+                @example_group = Class.new(ExampleGroupDouble).describe("bar")
+                @example_description = @example_group.__send__(method, "foo", {:this => :that}, "the backtrace") {}
+              end
+              
+              specify "with a description" do
+                @example_description.description.should == "foo"
+              end
+
+              specify "with options" do
+                @example_description.options.should == {:this => :that}
+              end
+              
+              specify "with a backtrace" do
+                @example_description.backtrace.should == "the backtrace"
+              end
+            end
           end
         end
         
-        [:xit, :xspecify].each do |method|
+        [:xexample, :xit, :xspecify].each do |method|
           describe "##{method.to_s}" do
             before(:each) do
               Kernel.stub!(:warn)
@@ -95,10 +114,9 @@ module Spec
           end
         end
         
-
         describe "#examples" do
           it "should have Examples" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               it "should exist" do; end
             end
             example_group.examples.length.should == 1
@@ -106,7 +124,7 @@ module Spec
           end
 
           it "should not include methods that begin with test (only when TU interop is loaded)" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               def test_any_args(*args)
                 true.should be_true
               end
@@ -123,12 +141,13 @@ module Spec
                 # forces the run
               end
             end
+            
             example_group.examples.length.should == 1
             example_group.run(options).should be_true
           end
 
           it "should include methods that begin with should and has an arity of 0 in suite" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               def shouldCamelCase
                 true.should be_true
               end
@@ -149,7 +168,7 @@ module Spec
               end
             end
             example_group.should have(4).examples
-            descriptions = example_group.examples.collect {|example| example.description.to_s}
+            descriptions = example_group.examples.collect {|e| e.description}
             descriptions.should include(
               "shouldCamelCase",
               "should_any_args",
@@ -162,7 +181,7 @@ module Spec
           end
 
           it "should not include methods that begin with test_ and has an arity > 0 in suite" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               def test_invalid(foo)
                 1.should == 1
               end
@@ -174,7 +193,7 @@ module Spec
           end
 
           it "should not include methods that begin with should_ and has an arity > 0 in suite" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               def should_invalid(foo)
                 1.should == 2
               end
@@ -193,7 +212,7 @@ module Spec
           end
 
           it "should run should_methods" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               def should_valid
                 1.should == 2
               end
@@ -322,8 +341,8 @@ module Spec
               example_group.spec_path.should == File.expand_path("blah")
             end
 
-            it ".description_options should return all the options passed in" do
-              example_group.description_options.should == {:a => "b", :spec_path => "blah"}
+            it ".options should return all the options passed in" do
+              example_group.options.should == {:a => "b", :spec_path => "blah"}
             end
 
           end
@@ -334,14 +353,14 @@ module Spec
             example_group.description.should eql(example_group.description)
           end
 
-          it "should not add a space when description_text begins with #" do
+          it "should not add a space when description begins with #" do
             child_example_group = Class.new(example_group) do
               describe("#foobar", "Does something")
             end
             child_example_group.description.should == "ExampleGroup#foobar Does something"
           end
 
-          it "should not add a space when description_text begins with ." do
+          it "should not add a space when description begins with ." do
             child_example_group = Class.new(example_group) do
               describe(".foobar", "Does something")
             end
@@ -357,6 +376,11 @@ module Spec
             example_group.set_description("")
             example_group.description.should =~ /Class:/
           end
+          
+          it "is cached" do
+            example_group.set_description("describe me")
+            example_group.description.should be(example_group.description)
+          end
         end
 
         describe "#description_parts" do
@@ -365,7 +389,7 @@ module Spec
           end
 
           it "should return an Array of the description args from each class in the hierarchy" do
-            parent_example_group = Class.new(ExampleGroup) do
+            parent_example_group = Class.new(ExampleGroupDouble) do
               describe("Parent")
             end
             
@@ -385,6 +409,10 @@ module Spec
               Spec::Example::ExampleGroup
             ]
           end
+          
+          it "caches the description parts" do
+            example_group.description_parts.should equal(example_group.description_parts)
+          end
         end
 
         describe "#described_type" do
@@ -396,7 +424,7 @@ module Spec
           end
 
           it "should return #described_type of superclass when no passed in type" do
-            parent_example_group = Class.new(ExampleGroup) do
+            parent_example_group = Class.new(ExampleGroupDouble) do
               describe Object, "#foobar"
             end
             child_example_group = Class.new(parent_example_group) do
@@ -404,25 +432,15 @@ module Spec
             end
             child_example_group.described_type.should == Object
           end
-        end
-
-        describe "#remove_after" do
-          it "should unregister a given after(:each) block" do
-            after_all_ran = false
-            proc = Proc.new { after_all_ran = true }
-
-            example_group = Class.new(ExampleGroup) do
-              specify("example") {}
-              after(:each, &proc)
+          
+          it "is cached per example group" do
+            klass = Class.new
+            group = Class.new(ExampleGroupDouble) do
+              describe(klass)
             end
-
-            example_group.run(options)
-            after_all_ran.should be_true
-
-            after_all_ran = false
-            example_group.remove_after(:each, &proc)
-            example_group.run(options)
-            after_all_ran.should be_false
+            group.should_receive(:description_parts).once.and_return([klass])
+            group.described_type
+            group.described_type
           end
         end
 
@@ -463,7 +481,7 @@ module Spec
 
         describe "#class_eval" do
           it "should allow constants to be defined" do
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               FOO = 1
               it "should reference FOO" do
                 FOO.should == 1
@@ -485,7 +503,7 @@ module Spec
           end
         end
 
-        describe '#unregister' do
+        describe '#remove_example_group' do
           before(:each) do
             Spec::Runner.options.add_example_group example_group
           end
@@ -498,7 +516,7 @@ module Spec
         describe "#run" do
           describe "given an example group with at least one example" do
             it "should call add_example_group" do
-              example_group = Class.new(ExampleGroup) do
+              example_group = Class.new(ExampleGroupDouble) do
                 example("anything") {}
               end
               reporter.should_receive(:add_example_group)
@@ -508,7 +526,7 @@ module Spec
 
           describe "given an example group with no examples" do
             it "should NOT call add_example_group" do
-              example_group = Class.new(ExampleGroup) do end
+              example_group = Class.new(ExampleGroupDouble) do end
               reporter.should_not_receive(:add_example_group)
               example_group.run(options)
             end
@@ -517,7 +535,7 @@ module Spec
 
         describe "#matcher_class=" do 
           it "should call new and matches? on the class used for matching examples" do 
-            example_group = Class.new(ExampleGroup) do
+            example_group = Class.new(ExampleGroupDouble) do
               it "should do something" do end
               def self.specified_examples
                 ["something"]
@@ -552,7 +570,7 @@ module Spec
 
         describe "#backtrace" do        
           it "returns the backtrace from where the example group was defined" do
-            example_group = Class.new(ExampleGroup).describe("foo") do
+            example_group = Class.new(ExampleGroupDouble).describe("foo") do
               example "bar" do; end
             end
             example_group.backtrace.join("\n").should include("#{__FILE__}:#{__LINE__-3}")
@@ -564,13 +582,13 @@ module Spec
             Kernel.stub!(:warn)
           end
           it "sends a deprecation warning" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             Kernel.should_receive(:warn).with(/#example_group_backtrace.*deprecated.*#backtrace instead/m)
             example_group.example_group_backtrace
           end
 
           it "returns the backtrace from where the example group was defined" do
-            example_group = Class.new(ExampleGroup).describe("foo") do
+            example_group = Class.new(ExampleGroupDouble).describe("foo") do
               example "bar" do; end
             end
             example_group.example_group_backtrace.join("\n").should include("#{__FILE__}:#{__LINE__-3}")
@@ -579,21 +597,21 @@ module Spec
         
         describe "#before" do
           it "stores before(:each) blocks" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             block = lambda {}
             example_group.before(:each, &block)
             example_group.before_each_parts.should include(block)
           end
 
           it "stores before(:all) blocks" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             block = lambda {}
             example_group.before(:all, &block)
             example_group.before_all_parts.should include(block)
           end
 
           it "stores before(:suite) blocks" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             parts = []
             ExampleGroupMethods.stub!(:before_suite_parts).and_return(parts)
             block = lambda {}
@@ -605,21 +623,21 @@ module Spec
         
         describe "#after" do
           it "stores after(:each) blocks" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             block = lambda {}
             example_group.after(:each, &block)
             example_group.after_each_parts.should include(block)
           end
 
           it "stores after(:all) blocks" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             block = lambda {}
             example_group.after(:all, &block)
             example_group.after_all_parts.should include(block)
           end
 
           it "stores after(:suite) blocks" do
-            example_group = Class.new(ExampleGroup) {}
+            example_group = Class.new(ExampleGroupDouble) {}
             parts = []
             ExampleGroupMethods.stub!(:after_suite_parts).and_return(parts)
             block = lambda {}
@@ -628,6 +646,22 @@ module Spec
           end
         end
 
+        describe "#run_before_all" do
+          it "does not create an instance if before_all_parts are empty" do
+            example_group = Class.new(ExampleGroupDouble) { example("one example") {} }
+            example_group.should_not_receive(:new)
+            example_group.__send__ :run_before_all, nil
+          end
+        end
+        
+        describe "#run_after_all" do
+          it "does not create an instance if after_all_parts are empty" do
+            example_group = Class.new(ExampleGroupDouble) { example("one example") {} }
+            example_group.should_not_receive(:new)
+            example_group.__send__ :run_after_all, true, {}, nil
+          end
+        end
+
       end
     end
   end