rspec 1.0.0 → 1.3.1

data/spec/spec/runner/drb_command_line_spec.rb

@@ -1,81 +1,146 @@
-require File.dirname(__FILE__) + '/../../spec_helper.rb'
-
-describe "DrbCommandLine without running local server" do
-  
-  unless Config::CONFIG['ruby_install_name'] == 'jruby'
-    it "should print error when there is no running local server" do
-      err = StringIO.new
-      out = StringIO.new
-      Spec::Runner::DrbCommandLine.run(['--version'], err, out, false)
-    
-      err.rewind
-      err.read.should =~ /No server is running/
-    end
-  end    
-end
+require 'spec_helper'
 
-describe "DrbCommandLine with local server" do
+module Spec
+  module Runner
+    unless jruby?
+      describe DrbCommandLine do
 
-  unless Config::CONFIG['ruby_install_name'] == 'jruby'  
-    before(:all) do
-      DRb.start_service("druby://localhost:8989", Spec::Runner::CommandLine)
-      $drb_example_file_counter = 0
-    end
-    
-    before(:each) do
-      create_dummy_spec_file
-      $drb_example_file_counter = $drb_example_file_counter + 1
-    end
-    
-    after(:each) do
-      File.delete(@dummy_spec_filename)
-    end
-    
-    after(:all) do
-      DRb.stop_service      
-    end
+        context "without server running" do
+          it "prints error" do
+            err = out = StringIO.new
+            DrbCommandLine.run(OptionParser.parse(['--version'], err, out))
 
-    it "should run against local server" do
-      out = run_spec_via_druby(['--version'])
-      out.should =~ /RSpec/n
-    end
-    
-    it "should output green colorized text when running with --colour option" do
-      out = run_spec_via_druby(["--colour", @dummy_spec_filename])
-      out.should =~ /\e\[32m/n
-    end
-    
-    it "should output red colorized text when running with -c option" do      
-      out = run_spec_via_druby(["-c", @dummy_spec_filename])
-      out.should =~ /\e\[31m/n
-    end
+            err.rewind
+            err.read.should =~ /No server is running/
+          end
+          
+          it "returns nil" do
+            err = out = StringIO.new
+            result = DrbCommandLine.run(OptionParser.parse(['--version'], err, out))
+            result.should be_false
+          end
+        end    
 
-    def create_dummy_spec_file
-      @dummy_spec_filename = File.expand_path(File.dirname(__FILE__)) + "/_dummy_spec#{$drb_example_file_counter}.rb"
-      File.open(@dummy_spec_filename, 'w') do |f|
-        f.write %{
-describe "DUMMY CONTEXT for 'DrbCommandLine with -c option'" do
-  it "should be output with green bar" do
-    true.should be_true
-  end
+        context "with server running" do
+          class ::CommandLineForDrbSpec
+            def self.run(argv, stderr, stdout)
+              orig_options = Spec::Runner.options
+              tmp_options = Spec::Runner::OptionParser.parse(argv, stderr, stdout)
+              Spec::Runner.use tmp_options
+              Spec::Runner::CommandLine.run(tmp_options)
+            ensure
+              Spec::Runner.use orig_options
+            end
+          end
 
-  it "should be output with red bar" do
-    violated("I want to see a red bar!")
-  end
-end
-}
-      end
-    end
-    
-    def run_spec_via_druby(args)
-      err, out = StringIO.new, StringIO.new
-      out.instance_eval do
-        def tty?; true end
+          before(:all) do
+            DRb.start_service("druby://127.0.0.1:8989", ::CommandLineForDrbSpec)
+            @@drb_example_file_counter = 0
+          end
+
+          before(:each) do
+            create_dummy_spec_file
+            @@drb_example_file_counter = @@drb_example_file_counter + 1
+          end
+
+          after(:each) do
+            File.delete(@dummy_spec_filename)
+          end
+
+          after(:all) do
+            DRb.stop_service
+          end
+
+          it "returns true" do
+            err = out = StringIO.new
+            result = DrbCommandLine.run(OptionParser.parse(['--version'], err, out))
+            result.should be_true
+          end
+
+          it "should run against local server" do
+            out = run_spec_via_druby(['--version'])
+            out.should =~ /rspec \d+\.\d+\.\d+.*/n
+          end
+
+          it "should output green colorized text when running with --colour option" do
+            out = run_spec_via_druby(["--colour", @dummy_spec_filename])
+            out.should =~ /\e\[32m/n
+          end
+
+          it "should output red colorized text when running with -c option" do
+            out = run_spec_via_druby(["-c", @dummy_spec_filename])
+            out.should =~ /\e\[31m/n
+          end
+
+          def create_dummy_spec_file
+            @dummy_spec_filename = File.expand_path(File.dirname(__FILE__)) + "/_dummy_spec#{@@drb_example_file_counter}.rb"
+            File.open(@dummy_spec_filename, 'w') do |f|
+              f.write %{
+                describe "DUMMY CONTEXT for 'DrbCommandLine with -c option'" do
+                  it "should be output with green bar" do
+                    true.should be_true
+                  end
+
+                  it "should be output with red bar" do
+                    violated("I want to see a red bar!")
+                  end
+                end
+              }
+            end
+          end
+
+          def run_spec_via_druby(argv)
+            err, out = StringIO.new, StringIO.new
+            out.instance_eval do
+              def tty?; true end
+            end
+            options = ::Spec::Runner::Options.new(err, out)
+            options.argv = argv
+            Spec::Runner::DrbCommandLine.run(options)
+            out.rewind; out.read
+          end
+        end
+
+        context "#port" do
+          before do
+            @options = stub("options", :drb_port => nil)
+          end
+          
+          context "with no additional configuration" do
+            it "defaults to 8989" do
+              Spec::Runner::DrbCommandLine.port(@options).should == 8989
+            end
+          end
+          
+          context "with RSPEC_DRB environment variable set" do
+            def with_RSPEC_DRB_set_to(val)
+              original = ENV['RSPEC_DRB']
+              begin
+                ENV['RSPEC_DRB'] = val
+                yield
+              ensure
+                ENV['RSPEC_DRB'] = original
+              end
+            end
+            
+            it "uses RSPEC_DRB value" do
+              with_RSPEC_DRB_set_to('9000') do
+                Spec::Runner::DrbCommandLine.port(@options).should == 9000
+              end
+            end
+
+            context "and config variable set" do
+              it "uses configured value" do
+                @options.stub(:drb_port => '5000')
+                with_RSPEC_DRB_set_to('9000') do
+                  Spec::Runner::DrbCommandLine.port(@options).should == 5000
+                end
+              end
+            end
+
+          end
+        end
       end
-      Spec::Runner::DrbCommandLine.run(args, err, out, false, true)
-      out.rewind; out.read
     end
   end
-  
 end
-

data/spec/spec/runner/example_group_runner_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+module Spec
+  module Runner
+    describe ExampleGroupRunner do
+      before(:each) do
+        err = StringIO.new('')
+        out = StringIO.new('')
+        @options = Options.new(err, out)
+        @runner = Spec::Runner::ExampleGroupRunner.new(@options)
+      end
+
+      after(:each) do
+        Spec::Expectations.differ = nil
+      end
+
+      describe "#load_files" do
+        it "should load UTF-8 encoded files" do
+          file = File.expand_path(File.dirname(__FILE__) + "/resources/utf8_encoded.rb")
+          @options.files << file
+          @runner.load_files(@options.files_to_load).should == @options.files_to_load
+        end
+      end
+    end
+  end
+end

data/spec/spec/runner/examples.txt

@@ -0,0 +1,2 @@
+Sir, if you were my husband, I would poison your drink.
+Madam, if you were my wife, I would drink it.

data/spec/spec/runner/failed.txt

@@ -0,0 +1,3 @@
+heckler_spec.rb
+command_line_spec.rb
+reporter_spec.rb

data/spec/spec/runner/formatter/base_formatter_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+module Spec
+  module Runner
+    module Formatter
+      describe BaseFormatter do
+        subject { BaseFormatter.new(nil,nil) }
+        it {should respond_to(:start                ).with(1).argument }
+        it {should respond_to(:example_group_started).with(1).argument }
+        it {should respond_to(:example_started      ).with(1).argument }
+        # -3 indicates that one of the arguments is optional, with a default
+        # value assigned. This is due to deprecated_pending_location. Once
+        # that is removed, this should be changed to 2.
+        it {should respond_to(:example_pending      ).with(-3).arguments}
+        it {should respond_to(:example_passed       ).with(1).argument }
+        it {should respond_to(:example_failed       ).with(3).arguments}
+        it {should respond_to(:start_dump           ).with(0).arguments}
+        it {should respond_to(:dump_failure         ).with(2).arguments}
+        it {should respond_to(:dump_summary         ).with(4).arguments}
+        it {should respond_to(:dump_pending         ).with(0).arguments}
+        it {should respond_to(:close                ).with(0).arguments}
+        
+        it "deprecates add_example_group" do
+          Spec.should_receive(:deprecate)
+          subject.add_example_group(stub('example group'))
+        end
+      end
+    end
+  end
+end

data/spec/spec/runner/formatter/base_text_formatter_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+require 'spec/runner/formatter/base_text_formatter'
+
+module Spec
+  module Runner
+    module Formatter
+      describe BaseTextFormatter do
+        
+        before :all do
+          @sandbox = "spec/sandbox"
+        end
+
+        it "should create the directory contained in WHERE if it does not exist" do
+          FileUtils.should_receive(:mkdir_p).with(@sandbox)
+          File.stub!(:open)
+          BaseTextFormatter.new({},"#{@sandbox}/temp.rb")
+        end
+        
+        context "(deprecations)" do
+          before(:each) do
+            Kernel.stub!(:warn)
+            @io = StringIO.new
+            @options = mock('options')
+            @options.stub!(:dry_run).and_return(false)
+            @options.stub!(:colour).and_return(false)
+            @options.stub!(:autospec).and_return(false)
+            @formatter = Class.new(BaseTextFormatter) do
+              def method_that_class_magenta(message)
+                magenta(message)
+              end
+              def method_that_class_colourise(message, failure)
+                colourise(message, failure)
+              end
+            end.new(@options, @io)
+            @failure = stub('failure', :pending_fixed? => false)
+          end
+          
+          context "#colourise" do
+            it "warns when subclasses call colourise" do
+              Spec.should_receive(:deprecate)
+              @formatter.method_that_class_colourise('this message', @failure)
+            end
+            
+            it "delegates to colorize_failure" do
+              @formatter.should_receive(:colorize_failure).with('this message', @failure)
+              @formatter.colourise('this message', @failure)
+            end
+          end
+          
+          context "#magenta" do
+            it "warns when subclasses call magenta" do
+              Spec.should_receive(:deprecate).with(/#magenta/)
+              @formatter.method_that_class_magenta('this message')
+            end
+
+            it "delegates to red" do
+              @formatter.should_receive(:red).with('this message')
+              @formatter.method_that_class_magenta('this message')
+            end
+          end
+          
+        end
+        
+        describe "#colour (protected)" do
+          before(:each) do
+            @original_RSPEC_COLOR = ENV['RSPEC_COLOR']
+          end
+          
+          it "does not colorize when output_to_file? returns true" do
+            out = StringIO.new
+            options = stub('options', :colour => true, :autospec => false)
+            formatter = BaseTextFormatter.new(options,out)
+            formatter.stub!(:output_to_tty?).and_return(true)
+            formatter.stub!(:output_to_file?).and_return(true)
+            formatter.__send__(:colour, 'foo', "\e[32m").should == "foo"
+          end
+          
+          it "colorizes when colour? and output_to_tty? return true" do
+            out = StringIO.new
+            options = stub('options', :colour => true, :autospec => false)
+            formatter = BaseTextFormatter.new(options,out)
+            formatter.stub!(:output_to_tty?).and_return(true)
+            formatter.__send__(:colour, 'foo', "\e[32m").should == "\e[32mfoo\e[0m"
+          end
+          
+          it "colorizes when ENV['RSPEC_COLOR'] is set even if colour? and output_to_tty? return false" do
+            out = StringIO.new
+            options = stub('options', :colour => false)
+            formatter = BaseTextFormatter.new(options,out)
+            formatter.stub!(:output_to_tty?).and_return(false)
+            
+            ENV['RSPEC_COLOR'] = 'true'
+            
+            formatter.__send__(:colour, 'foo', "\e[32m").should == "\e[32mfoo\e[0m"
+          end
+          
+          it "colorizes when autospec? is true even if colour? and output_to_tty? return false" do
+            out = StringIO.new
+            options = stub('options', :colour => true, :autospec => true)
+            formatter = BaseTextFormatter.new(options,out)
+            formatter.stub!(:output_to_tty?).and_return(false)
+            
+            formatter.__send__(:colour, 'foo', "\e[32m").should == "\e[32mfoo\e[0m"
+          end
+          
+          after(:each) do
+            ENV['RSPEC_COLOR'] = @original_RSPEC_COLOR
+          end
+        end
+      end
+    end
+  end
+end

data/spec/spec/runner/formatter/failing_example_groups_formatter_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+require 'spec/runner/formatter/failing_example_groups_formatter'
+
+module Spec
+  module Runner
+    module Formatter
+      describe FailingExampleGroupsFormatter do
+        attr_reader :example_group, :formatter, :io
+
+        before(:each) do
+          @io = StringIO.new
+          options = mock('options')
+          @formatter = FailingExampleGroupsFormatter.new(options, io)
+          @example_group = Class.new(::Spec::Example::ExampleGroup)
+        end
+        
+        it "should add example name for each failure" do
+          formatter.example_group_started(Spec::Example::ExampleGroupProxy.new(Class.new(::Spec::Example::ExampleGroupDouble).describe("b 1")))
+          formatter.example_failed("e 1", nil, Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          formatter.example_group_started(Spec::Example::ExampleGroupProxy.new(Class.new(::Spec::Example::ExampleGroupDouble).describe("b 2")))
+          formatter.example_failed("e 2", nil, Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          formatter.example_failed("e 3", nil, Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          io.string.should include("b 1")
+          io.string.should include("b 2")
+        end
+
+        it "should delimit ExampleGroup superclass descriptions with :" do
+          parent_example_group = Class.new(example_group).describe("Parent")
+          child_example_group = Class.new(parent_example_group).describe("#child_method")
+          grand_child_example_group = Class.new(child_example_group).describe("GrandChild")
+
+          formatter.example_group_started(Spec::Example::ExampleGroupProxy.new(grand_child_example_group))
+          formatter.example_failed("failure", nil, ::Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          io.string.should == "Parent#child_method GrandChild\n"
+        end
+
+        it "should remove druby url, which is used by Spec::Distributed" do
+          @formatter.example_group_started(Spec::Example::ExampleGroupProxy.new(Class.new(::Spec::Example::ExampleGroupDouble).describe("something something (druby://99.99.99.99:99)")))
+          @formatter.example_failed("e 1", nil, ::Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          io.string.should == "something something\n"
+        end
+      end
+    end
+  end
+end

data/spec/spec/runner/formatter/failing_examples_formatter_spec.rb

@@ -1,28 +1,33 @@
-require File.dirname(__FILE__) + '/../../../spec_helper.rb'
+require 'spec_helper'
+require 'spec/runner/formatter/failing_examples_formatter'
 
 module Spec
   module Runner
     module Formatter
-      describe "FailingExamplesFormatter" do
+      describe FailingExamplesFormatter do
         before(:each) do
           @io = StringIO.new
-          @formatter = FailingExamplesFormatter.new(@io)
+          options = mock('options')
+          @formatter = FailingExamplesFormatter.new(options, @io)
         end
 
         it "should add example name for each failure" do
-          @formatter.add_behaviour("b 1")
-          @formatter.example_failed("e 1", nil, Reporter::Failure.new(nil, RuntimeError.new))
-          @formatter.add_behaviour("b 2")
-          @formatter.example_failed("e 2", nil, Reporter::Failure.new(nil, RuntimeError.new))
-          @formatter.example_failed("e 3", nil, Reporter::Failure.new(nil, RuntimeError.new))
+          example_group_1 = Class.new(::Spec::Example::ExampleGroupDouble).describe("A")
+          example_group_2 = Class.new(example_group_1).describe("B")
+
+          @formatter.example_group_started(Spec::Example::ExampleGroupProxy.new(example_group_1))
+          @formatter.example_failed(example_group_1.it("a1"){}, nil, ::Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          @formatter.example_group_started(Spec::Example::ExampleGroupProxy.new(example_group_2))
+          @formatter.example_failed(example_group_2.it("b2"){}, nil, ::Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
+          @formatter.example_failed(example_group_2.it("b3"){}, nil, ::Spec::Runner::Reporter::Failure.new("g", nil, RuntimeError.new))
           @io.string.should eql(<<-EOF
-b 1 e 1
-b 2 e 2
-b 2 e 3
+A a1
+A B b2
+A B b3
 EOF
 )
         end
       end
     end
   end
-end
+end