rspec-webservice_matchers 4.4.3 → 4.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10922f68985209c2dfb8f08ff3a6269ce8724b4c
-  data.tar.gz: 4cca8e7182f75db36d5a3acb005cf203a39dc1df
+  metadata.gz: a2c6cf504ff19bde93e91498bd7e392ef410b94c
+  data.tar.gz: c2803564cafe83bda06abc3a195e1723e6185d22
 SHA512:
-  metadata.gz: e3752edb32f97200ab11577f196986c732f96987652d93dd4b2e29ad96e931d31e5e8f0cf81781f0bb9c6311c4cc91f0f4b7c067256c6852d6d265ab3649526a
-  data.tar.gz: be33eefe6233553fd30fec273a086b1aea04d798d9e01b60004f42a905cc30204682ac988ef88476f678c584c0fed2c063403de3c816c7581f94daf3bf0e11af
+  metadata.gz: 1c6bd1e678ed71303bbc8e6a6396870268195b8a41889656f1a5f5c17088f6a11cd8ddc8daeb86e27d9c7446668d01704baff79abae46245432d06e666729ab8
+  data.tar.gz: 3a49f67bf48853a73b47b6f71d2f6e5eee6d43590caad741303e6dbc7216e0f7fdc7cdf591741808cc8e2dc76d7155febd0acc30b0c097d2b528ff66c27155f2

data/HISTORY.md

@@ -1,3 +1,7 @@
+4.5.0
+-----
+Removed the Excon dependency entirely.
+
 4.4.3
 -----
 Changed the Google PageSpeed Insights threshold to 85, the value for

data/README.md

@@ -9,11 +9,13 @@ A [gem](https://rubygems.org/gems/rspec-webservice_matchers) to black-box test a
 expect('github.com').to have_a_valid_cert
 ```
 
-It's a tool for doing **Test Driven Devops** (I just made that up). See [the introductory blog post](http://robb.weblaws.org/2014/01/16/new-open-source-library-for-test-driven-devops/) for more about my motivations.
+It's a tool for doing **Test Driven Devops** (I just made that up). See [the introductory blog post](http://robb.weblaws.org/2014/01/16/new-open-source-library-for-test-driven-devops/) for the backstory and [Nonstop QA - a SaaS built on it](https://nonstop.qa).
 
 This library takes a minimalist approach: it simply adds new RSpec matchers. Therefore, you can use your own RSpec writing style; there's no new DSL to learn.
 
-If you're too busy to install this and code the tests by hand, you can try the [new hosted service which runs these RSpec matchers in the cloud](http://nonstop.qa).
+If you're too busy to install this and code the tests by hand, you can try the [new hosted service which runs these RSpec matchers in the cloud](http://nonstop.qa): [![QA Status](http://nonstop.qa/projects/20/badges/default.svg)](http://nonstop.qa/projects/20-nonstop-qa)
+
+
 
 
 Installation
@@ -29,7 +31,7 @@ These new RSpec matchers:
                                | Notes
 -------------------------------|------------------------------------------------
 **be_up**                      | Looks for a 200, but will follow up to four redirects
-**be_fast**                    | Checks for Google [PageSpeed](https://developers.google.com/speed/pagespeed/insights/) score >= 90. Expects the environment variable `WEBSERVICE_MATCHER_INSIGHTS_KEY` to contain a [Google "server" API key](https://developers.google.com/speed/docs/insights/v2/getting-started) with PageSpeed Insights API enabled.
+**be_fast**                    | Checks for Google [PageSpeed](https://developers.google.com/speed/pagespeed/insights/) score >= 85. Expects the environment variable `WEBSERVICE_MATCHER_INSIGHTS_KEY` to contain a [Google "server" API key](https://developers.google.com/speed/docs/insights/v2/getting-started) with PageSpeed Insights API enabled.
 **enforce_https_everywhere**   | Passes if the site will _only_ allow SSL connections. See the [EFF project, HTTPS Everywhere](https://www.eff.org/https-everywhere)
 **have_a_valid_cert**          | Will fail if there's no cert, or it's expired or incorrectly configured
 **be_status**                  | A low-level matcher to explicitly check for a 200, 503, or any other code

data/lib/rspec/webservice_matchers/be_fast.rb

@@ -7,22 +7,25 @@ module RSpec
     module BeFast
       def self.parse(json:)
         response = JSON.parse(json)
-        {
-          score: response['ruleGroups']['SPEED']['score']
-        }
+        unless response.key?('ruleGroups')
+          raise "Couldn't parse the PageSpeed response: #{response.inspect}"
+        end
+        score = response.fetch('ruleGroups').fetch('SPEED').fetch('score')
+        { score: score }
       end
 
       def self.page_speed_score(url:)
         url_param = CGI.escape(Util.make_url(url))
         key       = ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY']
         if key.nil?
-          fail 'be_fast requires the WEBSERVICE_MATCHER_INSIGHTS_KEY '\
-               'environment variable to be set to a Google PageSpeed '\
-               'Insights API key.'
+          raise 'be_fast requires the WEBSERVICE_MATCHER_INSIGHTS_KEY '\
+                'environment variable to be set to a Google PageSpeed '\
+                'Insights API key.'
         end
         endpoint  = 'https://www.googleapis.com/pagespeedonline/v2/runPagespeed'
         api_url   = "#{endpoint}?url=#{url_param}&screenshot=false&key=#{key}"
-        BeFast.parse(json: Excon.get(api_url).body)[:score]
+        response = Faraday.get(api_url)
+        BeFast.parse(json: response.body).fetch(:score)
       end
 
       RSpec::Matchers.define :be_fast do

data/lib/rspec/webservice_matchers/util.rb

@@ -1,4 +1,3 @@
-require 'excon'
 require 'faraday'
 require 'faraday_middleware'
 

data/lib/rspec/webservice_matchers/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module WebserviceMatchers
-    VERSION = '4.4.3'
+    VERSION = '4.5.0'
   end
 end

data/rspec-webservice_matchers.gemspec

@@ -25,7 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'webmock'
 
   spec.add_runtime_dependency 'rspec', '~> 3.0'
-  spec.add_runtime_dependency 'excon'
   spec.add_runtime_dependency 'faraday'
   spec.add_runtime_dependency 'faraday_middleware'
 end

data/spec/rspec/webservice_matchers/page_speed_spec.rb

@@ -16,8 +16,8 @@ describe RSpec::WebserviceMatchers::BeFast do
   end
 
   describe '#be_fast' do
-    it 'performs a Google PageSpeed Insights API query on a slow site' do
-      expect('nonstop.qa').not_to be_fast
+    it 'performs a Google PageSpeed Insights API query on a fast site' do
+      expect('nonstop.qa').to be_fast
     end
 
     it 'raises a friendly error if the api key has not been set' do

data/spec/spec_helper.rb

@@ -26,12 +26,8 @@ RSpec.configure do |config|
 
     # Insights API
     key = ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY']
-    WebMock.stub_request(:get, "https://www.googleapis.com/pagespeedonline/v2/runPagespeed?key=#{key}&screenshot=false&url=http://nonstop.qa")
-      .with(headers:
-        {
-          'Host' => 'www.googleapis.com:443',
-          'User-Agent' => 'excon/0.45.4'
-        })
+    WebMock.stub_request(:get, "https://www.googleapis.com/pagespeedonline/v2/runPagespeed?key=#{key}&screenshot=false&url=http://nonstop.qa").
+         with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Faraday v0.9.2'})
       .to_return(
         status: 200,
         body: IO.read('spec/fixtures/pagespeed.json'),

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-webservice_matchers
 version: !ruby/object:Gem::Version
-  version: 4.4.3
+  version: 4.5.0
 platform: ruby
 authors:
 - Robb Shecter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-01 00:00:00.000000000 Z
+date: 2016-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: excon
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement