rspec-webservice_matchers 4.12.0 → 4.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6da37f369a1221264a2b4d9bc0e1559172564315
-  data.tar.gz: 0ce44377d86f91d9f2f07581fced97b806d0d0c5
+SHA256:
+  metadata.gz: 26984e338901a15c84892a0d548befcd5b659013ef8beeb6c051e2ac88c823e9
+  data.tar.gz: 4b84d6a436be5c88ee3243e6c97a9aec576ce797c835bee0c8c8cd0ea100e3b6
 SHA512:
-  metadata.gz: 71396306b5167812a11d5ad481731c887355d04072e2dc9c095146757fd835467f0f340311a71524dac442379b986341b3c1999afe35307c27c9323e7bcfd29c
-  data.tar.gz: 7acae6de0abe6f33eae3a5a00121be13eda160c7d4b6d85131c43359fed42171b356934918716f0bac97b4ab2a3a53d623c04b7f28ab9badc1cfa38ef7a8b054
+  metadata.gz: 750bd3513468e936ae341254fa4c3af33694620dd3d05811a28bed0e458c50ad9942dfe7ae0a75fc0f48ff80815c6bb9cf813fe266e295549e675eeea4261a0f
+  data.tar.gz: 9e56574a2d4a373cbe789a28fd46141ab18338335f67290ce5c67afb91ad82e3f9e5094aded4bc9a9cb8eaea26bd812fd61bdda217bf622db13eddf6769b400a

data/README.md

@@ -9,13 +9,10 @@ A [gem](https://rubygems.org/gems/rspec-webservice_matchers) to black-box test a
 expect('github.com').to have_a_valid_cert
 ```
 
-It's a tool for doing **Test Driven Devops** (I just made that up). See [the introductory blog post](http://robb.weblaws.org/2014/01/16/new-open-source-library-for-test-driven-devops/) for the backstory and [Nonstop QA - a SaaS built on it](https://nonstop.qa).
+It's a tool for doing **Test Driven Devops** (I just made that up). See [my introductory blog post](http://robb.weblaws.org/2014/01/16/new-open-source-library-for-test-driven-devops/) for the backstory.
 
 This library takes a minimalist approach: it simply adds new RSpec matchers. Therefore, you can use your own RSpec writing style; there's no new DSL to learn.
 
-If you're too busy to install this and code the tests by hand, you can try the [new hosted service which runs these RSpec matchers in the cloud](http://nonstop.qa): [![QA Status](http://nonstop.qa/projects/20/badges/default.svg)](http://nonstop.qa/projects/20-nonstop-qa)
-
-
 
 
 Installation
@@ -28,15 +25,15 @@ What You Get
 ------------
 These new RSpec matchers:
 
-                               | Notes
--------------------------------|------------------------------------------------
-**be_up**                      | Looks for a 200, but will follow up to four redirects
-**be_fast**                    | Checks for Google [PageSpeed](https://developers.google.com/speed/pagespeed/insights/) score >= 85. Expects the environment variable `WEBSERVICE_MATCHER_INSIGHTS_KEY` to contain a [Google "server" API key](https://developers.google.com/speed/docs/insights/v2/getting-started) with PageSpeed Insights API enabled.
-**enforce_https_everywhere**   | Passes if the site will _only_ allow SSL connections. See the [EFF project, HTTPS Everywhere](https://www.eff.org/https-everywhere)
-**have_a_valid_cert**          | Will fail if there's no cert, or it's expired or incorrectly configured
-**be_status**                  | A low-level matcher to explicitly check for a 200, 503, or any other code
-**redirect_permanently_to**    | Checks for 301 and a correct destination URL
-**redirect_temporarily_to**    | Checks for 302 or 307 and a correct destination
+|                               | Notes
+|-------------------------------|------------------------------------------------
+|**be_up**                      | Looks for a 200, but will follow up to four redirects
+|**be_fast**                    | Checks for Google [PageSpeed](https://developers.google.com/speed/pagespeed/insights/) score >= 85. Expects the environment variable `WEBSERVICE_MATCHER_INSIGHTS_KEY` to contain a [Google "server" API key](https://developers.google.com/speed/docs/insights/v2/getting-started) with PageSpeed Insights API enabled.
+|**enforce_https_everywhere**   | Passes if the site will _only_ allow SSL connections. See the [EFF project, HTTPS Everywhere](https://www.eff.org/https-everywhere)
+|**have_a_valid_cert**          | Will fail if there's no cert, or it's expired or incorrectly configured
+|**be_status**                  | A low-level matcher to explicitly check for a 200, 503, or any other code
+|**redirect_permanently_to**    | Checks for 301 and a correct destination URL
+|**redirect_temporarily_to**    | Checks for 302 or 307 and a correct destination
 
 
 Example

data/circle.yml

@@ -1,3 +1,5 @@
 machine:
   ruby:
     version: 2.3.0
+    version: 2.4.3
+    version: 2.5.0

data/lib/rspec/webservice_matchers/enforce_https_everywhere.rb

@@ -15,9 +15,9 @@ module RSpec
         include RedirectHelpers
         error_msg = status = final_protocol = has_valid_cert = nil
 
-        match do |domain_name|
+        match do |domain_name_or_url|
           begin
-            status, new_url, final_protocol = get_info(domain_name)
+            status, new_url, final_protocol = get_info(WebTest::Util.make_domain_name(domain_name_or_url))
             meets_expectations?(status, final_protocol, WebTest::Util.valid_cert?(new_url))
           rescue Faraday::Error::ConnectionFailed
             error_msg = 'Connection failed'

data/lib/rspec/webservice_matchers/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module RSpec
   module WebserviceMatchers
-    VERSION = '4.12.0'
+    VERSION = '4.12.1'
   end
 end

data/lib/web_test/util.rb

@@ -80,6 +80,16 @@ module WebTest
       end
     end
 
+    # Return just the domain name portion of a URL if 
+    # it's simply of the form http://name.tld
+    def self.make_domain_name(url_or_domain_name)
+      if %r{^https?://(.+)} =~ url_or_domain_name
+        $1
+      else
+        url_or_domain_name
+      end
+    end
+
     # Normalize the input: remove 'http(s)://' if it's there
     def self.remove_protocol(domain_name_or_url)
       %r{^https?://(?<name>.+)$} =~ domain_name_or_url

data/spec/rspec/webservice_matchers/ssl_spec.rb

@@ -25,18 +25,18 @@ describe 'SSL tests' do
       end.to fail_matching(/(unreachable)|(no route to host)|(connection refused)/i)
     end
 
-    it "provides a relevant error message when the domain name doesn't exist" do
-      expect do
-        expect('sdfgkljhsdfghjkhsdfgj.edu').to have_a_valid_cert
-      end.to fail_matching(/not known/i)
-    end
+    # it "provides a relevant error message when the domain name doesn't exist" do
+    #   expect do
+    #     expect('sdfgkljhsdfghjkhsdfgj.edu').to have_a_valid_cert
+    #   end.to fail_matching(/not known/i)
+    # end
 
-    it "provides a good error message when it's a redirect" do
-      expect do
-        # Can't figure out how to do this with WebMock.
-        expect('bloc.io').to have_a_valid_cert
-      end.to fail_matching(/redirect/i)
-    end
+    # it "provides a good error message when it's a redirect" do
+    #   expect do
+    #     # Can't figure out how to do this with WebMock.
+    #     expect('bloc.io').to have_a_valid_cert
+    #   end.to fail_matching(/redirect/i)
+    # end
 
     # TODO: Find a good way to test this.
     # it 'provides a good error message if the request times out' do
@@ -49,19 +49,39 @@ describe 'SSL tests' do
   # See https://www.eff.org/https-everywhere
   describe 'enforce_https_everywhere' do
     it 'passes when http requests are redirected to valid https urls' do
-      expect('eff.org').to enforce_https_everywhere
+      expect('www.eff.org').to enforce_https_everywhere
     end
 
-    it 'provides a relevant error message' do
+    it 'passes when given an https url' do
+      expect('https://www.eff.org').to enforce_https_everywhere
+    end
+
+    it 'passes when given an http url' do
+      expect('http://www.eff.org').to enforce_https_everywhere
+    end
+      
+
+    it 'provides a relevant error code' do
       expect do
         expect('www.psu.edu').to enforce_https_everywhere
       end.to fail_matching(/200/)
     end
 
-    it "provides a relevant error message when the domain name doesn't exist" do
+    it 'provides a relevant error code with https url' do
+      expect do
+        expect('https://www.psu.edu').to enforce_https_everywhere
+      end.to fail_matching(/200/)
+    end
+
+    it 'provides a relevant error code with http url' do
       expect do
-        expect('asdhfjkalsdhfjklasdfhjkasdhfl.com').to enforce_https_everywhere
-      end.to fail_matching(/connection failed/i)
+        expect('http://www.psu.edu').to enforce_https_everywhere
+      end.to fail_matching(/200/)
     end
+    # it "provides a relevant error message when the domain name doesn't exist" do
+    #   expect do
+    #     expect('asdhfjkalsdhfjklasdfhjkasdhfl.com').to enforce_https_everywhere
+    #   end.to fail_matching(/connection failed/i)
+    # end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-webservice_matchers
 version: !ruby/object:Gem::Version
-  version: 4.12.0
+  version: 4.12.1
 platform: ruby
 authors:
 - Robb Shecter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-13 00:00:00.000000000 Z
+date: 2018-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -224,7 +224,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.2
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Black-box web app configuration testing