rspec-webservice_matchers 4.10.0 → 4.13

data/spec/rspec/webservice_matchers/protocol_spec.rb

@@ -31,7 +31,7 @@ describe 'be_status' do
     }.to fail_matching(/404/)
   end
 
-  it 'succeeds even if the site times out on the first try' do
+  xit 'succeeds even if the site times out on the first try' do
     expect('http://www.timeout-once.com').to be_status 200
   end
 
@@ -61,11 +61,7 @@ describe 'be_up' do
     }.to fail_matching(/^received status 404$/i)
   end
 
-  it 'succeeds even if the site times out on the first try' do
+  xit 'succeeds even if the site times out on the first try' do
     expect('http://www.timeout-once.com').to be_up
   end
-
-  it 'works on cars.com' do
-    expect('http://cars.com').to be_up
-  end
 end

data/spec/rspec/webservice_matchers/public_api_spec.rb

@@ -10,7 +10,7 @@ describe '#up?' do
     expect(WebTest::Util.up?('temp-redirector.org')).to be_truthy
   end
 
-  it 'retries timeout errors once' do
+  xit 'retries timeout errors once' do
     expect(WebTest::Util.up?('http://www.timeout-once.com')).to be_truthy
   end
 end

data/spec/rspec/webservice_matchers/redirect_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require 'rspec/webservice_matchers'
 
@@ -16,27 +17,27 @@ describe 'redirect_permanently_to' do
   end
 
   it 'gives a good error message for the wrong redirect type' do
-    expect {
+    expect do
       expect('temp-redirector.org').to redirect_permanently_to 'http://a-page.com/a/page.txt'
-    }.to fail_matching(/temporary/i)
+    end.to fail_matching(/temporary/i)
   end
 
   it 'gives a good error message for a redirect to the wrong location' do
-    expect {
+    expect do
       expect('perm-redirector.com').to redirect_permanently_to 'http://the-wrong-site.com/'
-    }.to fail_matching(/location/i)
+    end.to fail_matching(/location/i)
   end
 
   it 'gives a good error message for a non-redirect status' do
-    expect {
+    expect do
       expect('notfound.com').to redirect_permanently_to 'http://the-wrong-site.com/'
-    }.to fail_matching(/^not a redirect: received status 404$/i)
+    end.to fail_matching(/^not a redirect: received status 404$/i)
   end
 
   it 'gives a good error message when the hostname is bad' do
-    expect {
-      expect('asdhfjadhsfksd.com').to redirect_permanently_to 'http://the-wrong-site.com/'
-    }.to fail_matching(/not known/i)
+    expect do
+      expect('not-a-domain.com').to redirect_permanently_to 'http://the-wrong-site.com/'
+    end.to fail_matching(/not known/i)
   end
 end
 
@@ -54,26 +55,26 @@ describe 'redirect_temporarily_to' do
   end
 
   it 'gives a good error message for the wrong redirect type' do
-    expect {
+    expect do
       expect('perm-redirector.com').to redirect_temporarily_to 'www.website.com/'
-    }.to fail_matching(/permanent/i)
+    end.to fail_matching(/permanent/i)
   end
 
   it 'gives a good error message for a redirect to the wrong location' do
-    expect {
+    expect do
       expect('temp-307-redirector.net').to redirect_temporarily_to 'www.nowhere.com'
-    }.to fail_matching(/location/i)
+    end.to fail_matching(/location/i)
   end
 
   it 'gives a good error message for a non-redirect status' do
-    expect {
+    expect do
       expect('notfound.com').to redirect_temporarily_to 'www.nowhere.com'
-    }.to fail_matching(/^not a redirect: received status 404$/i)
+    end.to fail_matching(/^not a redirect: received status 404$/i)
   end
 
   it 'gives a good error message when the hostname is bad' do
-    expect {
-      expect('234678234687234.com').to redirect_temporarily_to 'www.nowhere.com'
-    }.to fail_matching(/not known/i)
+    expect do
+      expect('not-a-domain.com').to redirect_temporarily_to 'www.nowhere.com'
+    end.to fail_matching(/not known/i)
   end
 end

data/spec/rspec/webservice_matchers/ssl_spec.rb

@@ -1,62 +1,87 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require 'rspec/webservice_matchers'
 
-describe 'have_a_valid_cert matcher' do
-  it 'passes when SSL is properly configured' do
-    # EFF created the HTTPS Everywhere movement
-    # TODO: set up a test server for this. (?)
-    expect('www.eff.org').to have_a_valid_cert
-  end
+describe 'SSL tests' do
+  before(:each) { WebMock.allow_net_connect! }
+  after(:each)  { WebMock.disable_net_connect! }
 
-  it 'fails if the server is not serving SSL at all' do
-    expect {
-      expect('www.psu.edu').to have_a_valid_cert
-    }.to fail_matching(/443/)
-  end
+  describe 'have_a_valid_cert matcher' do
+    it 'passes when SSL is properly configured' do
+      # EFF created the HTTPS Everywhere movement
+      # TODO: set up a test server for this. (?)
+      expect('www.eff.org').to have_a_valid_cert
+    end
 
-  it 'provides a relevant error message' do
-    expect {
-      expect('www.psu.edu').to have_a_valid_cert
-    }.to fail_matching(/(unreachable)|(no route to host)|(connection refused)/i)
-  end
+    it 'fails if the server is not serving SSL at all' do
+      expect do
+        expect('neverssl.com').to have_a_valid_cert
+      end.to fail_matching(/Unable to verify/)
+    end
 
-  it "provides a relevant error message when the domain name doesn't exist" do
-    expect {
-      expect('sdfgkljhsdfghjkhsdfgj.edu').to have_a_valid_cert
-    }.to fail_matching(/not known/i)
-  end
+    it 'provides a relevant error message' do
+      expect do
+        expect('neverssl.com').to have_a_valid_cert
+      end.to fail_matching(/(unreachable)|(no route to host)|(connection refused)|(redirect was detected)/i)
+    end
 
-  it "provides a good error message when it's a redirect" do
-    expect {
-      # Can't figure out how to do this with WebMock.
-      expect('bloc.io').to have_a_valid_cert
-    }.to fail_matching(/redirect/i)
-  end
+    xit "provides a relevant error message when the domain name doesn't exist" do
+      expect do
+        expect('sdfgkljhsdfghjkhsdfgj.edu').to have_a_valid_cert
+      end.to fail_matching(/not known/i)
+    end
 
-  # TODO: Find a good way to test this.
-  # it 'provides a good error message if the request times out' do
-  #   expect {
-  #     expect('www.myapp.com').to have_a_valid_cert
-  #   }.to fail_matching(/(timeout)|(execution expired)/)
-  # end
-end
+    xit "provides a good error message when it's a redirect" do
+      expect do
+        # Can't figure out how to do this with WebMock.
+        expect('bloc.io').to have_a_valid_cert
+      end.to fail_matching(/redirect/i)
+    end
 
-# See https://www.eff.org/https-everywhere
-describe 'enforce_https_everywhere' do
-  it 'passes when http requests are redirected to valid https urls' do
-    expect('eff.org').to enforce_https_everywhere
+    # TODO: Find a good way to test this.
+    xit 'provides a good error message if the request times out' do
+      expect {
+        expect('www.myapp.com').to have_a_valid_cert
+      }.to fail_matching(/(timeout)|(execution expired)/)
+    end
   end
 
-  it 'provides a relevant error message' do
-    expect {
-      expect('www.psu.edu').to enforce_https_everywhere
-    }.to fail_matching(/200/)
-  end
+  # See https://www.eff.org/https-everywhere
+  describe 'enforce_https_everywhere' do
+    it 'passes when http requests are redirected to valid https urls' do
+      expect('www.eff.org').to enforce_https_everywhere
+    end
+
+    it 'passes when given an https url' do
+      expect('https://www.eff.org').to enforce_https_everywhere
+    end
+
+    it 'passes when given an http url' do
+      expect('http://www.eff.org').to enforce_https_everywhere
+    end
+
+    it 'provides a relevant error code' do
+      expect do
+        expect('neverssl.com').to enforce_https_everywhere
+      end.to fail_matching(/200/)
+    end
+
+    it 'provides a relevant error code with https url' do
+      expect do
+        expect('https://neverssl.com').to enforce_https_everywhere
+      end.to fail_matching(/200/)
+    end
 
-  it "provides a relevant error message when the domain name doesn't exist" do
-    expect {
-      expect('asdhfjkalsdhfjklasdfhjkasdhfl.com').to enforce_https_everywhere
-    }.to fail_matching(/connection failed/i)
+    it 'provides a relevant error code with http url' do
+      expect do
+        expect('http://neverssl.com').to enforce_https_everywhere
+      end.to fail_matching(/200/)
+    end
+    # it "provides a relevant error message when the domain name doesn't exist" do
+    #   expect do
+    #     expect('asdhfjkalsdhfjklasdfhjkasdhfl.com').to enforce_https_everywhere
+    #   end.to fail_matching(/connection failed/i)
+    # end
   end
 end

data/spec/spec_helper.rb

@@ -1,56 +1,5 @@
 # frozen_string_literal: true
-require 'webmock/rspec'
+require 'web_mock_config'
+require 'failure_matchers'
 
-RSpec.configure do |config|
-  config.before(:each) do
-    WebMock.stub_request :any, 'http://a-page.com/a/page.txt'
-    WebMock.stub_request :any, 'www.website.com'
-    WebMock.stub_request(:any, /notfound.com/).to_return(status: 404)
-    WebMock.stub_request(:any, 'outoforder.com').to_return(status: 503)
-
-    # A host which doesn't support HEAD
-    WebMock.stub_request(:head, 'appengine.com').to_return(status: 405)
-    WebMock.stub_request(:get,  'appengine.com').to_return(status: 200)
-
-    WebMock.stub_request(:any, 'perm-redirector.com')
-           .to_return(status: 301, headers: { Location: 'http://www.website.com/' })
-
-    WebMock.stub_request(:any, 'temp-redirector.org')
-           .to_return(status: 302, headers: { Location: 'http://a-page.com/a/page.txt' })
-
-    WebMock.stub_request(:any, 'temp-307-redirector.net')
-           .to_return(status: 307, headers: { Location: 'http://a-page.com/a/page.txt' })
-
-    # Timeout scenarios
-    WebMock.stub_request(:any, 'www.timeout.com').to_timeout
-    WebMock.stub_request(:any, 'www.timeout-once.com').to_timeout.then.to_return(body: 'abc')
-
-    # Insights API
-    key = ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY']
-    WebMock.stub_request(:get, "https://www.googleapis.com/pagespeedonline/v2/runPagespeed?key=#{key}&screenshot=false&url=http://nonstop.qa")
-           .with(headers: { 'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Faraday v0.9.2' })
-           .to_return(
-             status: 200,
-             body: IO.read('spec/fixtures/pagespeed.json'),
-             headers: {})
-
-    WebMock.allow_net_connect!
-  end
-end
-
-module RSpec
-  # Matchers to help test RSpec matchers
-  module Matchers
-    def fail
-      raise_error(RSpec::Expectations::ExpectationNotMetError)
-    end
-
-    def fail_with(message)
-      raise_error(RSpec::Expectations::ExpectationNotMetError, message)
-    end
-
-    def fail_matching(regex)
-      raise_error(RSpec::Expectations::ExpectationNotMetError, regex)
-    end
-  end
-end
+SAMPLE_PAGESPEED_JSON_RESPONSE = 'spec/fixtures/pagespeed.json'

data/spec/web_mock_config.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+require 'faraday'
+require 'webmock/rspec'
+
+RSpec.configure do |config|
+  config.before(:each) do
+    # HOSTS WHICH RETURN ERRORS
+    WebMock.stub_request(:any, /notfound.com/).to_return(status: 404)
+    WebMock.stub_request(:any, 'outoforder.com').to_return(status: 503)
+    WebMock.stub_request(:any, 'not-a-domain.com')
+           .to_raise(Faraday::ConnectionFailed.new('Failed to open TCP ' \
+                     'connection to asdhfjkahsdfadfd.com:80 ' \
+                     '(getaddrinfo: nodename nor servname provided, ' \
+                     'or not known)'))
+
+    # FUNCTIONING WEB PAGES
+    WebMock.stub_request :any, 'http://a-page.com/a/page.txt'
+    WebMock.stub_request :any, 'www.website.com'
+
+    # A HOST WHICH DOESN'T SUPPORT HEAD
+    WebMock.stub_request(:head, 'appengine.com').to_return(status: 405)
+    WebMock.stub_request(:get,  'appengine.com').to_return(status: 200)
+
+    # FUNCTIONING REDIRECTS
+    WebMock.stub_request(:head, 'perm-redirector.com')
+           .to_return(status: 301,
+                      body: '',
+                      headers: { Location: 'http://www.website.com/' })
+
+    WebMock.stub_request(:any, 'temp-redirector.org')
+           .to_return(status: 302,
+                      headers: { Location: 'http://a-page.com/a/page.txt' })
+
+    WebMock.stub_request(:any, 'temp-307-redirector.net')
+           .to_return(status: 307,
+                      headers: { Location: 'http://a-page.com/a/page.txt' })
+
+    # TIMEOUT SCENARIOS
+    WebMock.stub_request(:any, 'www.timeout.com').to_timeout
+    WebMock.stub_request(:any, 'www.timeout-once.com').to_timeout
+           .then.to_return(body: 'abc')
+
+    # PageSpeed Insights API
+    key = ENV['WEBSERVICE_MATCHER_INSIGHTS_KEY']
+    WebMock.stub_request(:get,
+                         'https://www.googleapis.com/pagespeedonline/v5/' \
+                         "runPagespeed?key=#{key}&screenshot=false" \
+                         '&url=https://constant.qa')
+           .to_return(
+             status: 200,
+             body: IO.read('spec/fixtures/pagespeed.json'),
+             headers: {})
+  end
+end

data/spec/web_test/be_fast_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+require 'spec_helper'
 require 'web_test/be_fast'
 
 RSpec.describe WebTest::BeFast do
@@ -6,7 +7,7 @@ RSpec.describe WebTest::BeFast do
 
   describe '#test' do
     it 'handles a fast site' do
-      result = WebTest::BeFast.test url: 'http://nonstop.qa'
+      result = WebTest::BeFast.test url: 'https://constant.qa'
       expect(result.success?).to be true
       expect(result.score).to be >= 85
     end
@@ -14,9 +15,9 @@ RSpec.describe WebTest::BeFast do
 
   describe '#parse' do
     it 'can parse the overall score' do
-      api_response = File.read(SAMPLE_JSON_RESPONSE)
+      api_response = File.read(SAMPLE_PAGESPEED_JSON_RESPONSE)
       data = WebTest::BeFast.parse json: api_response
-      expect(data[:score]).to eq 85
+      expect(data[:score]).to eq 91
     end
   end
 
@@ -32,5 +33,14 @@ RSpec.describe WebTest::BeFast do
         WebTest::BeFast::TestResult.new { |r| r.success = true }
       end.to raise_error(ArgumentError, /score/i)
     end
+
+    it 'requires :response' do
+      expect do
+        WebTest::BeFast::TestResult.new { |r|
+          r.success = true
+          r.score = 90
+        }
+      end.to raise_error(ArgumentError, /response/i)      
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-webservice_matchers
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: '4.13'
 platform: ruby
 authors:
 - Robb Shecter
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-03-31 00:00:00.000000000 Z
+date: 2021-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -95,82 +95,83 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-core
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-expectations
+  name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: rspec-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: validated_object
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.1.0
 description: Black-box web app configuration testing
 email:
-- robb@weblaws.org
+- robb@public.law
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - Gemfile
 - HISTORY.md
@@ -192,13 +193,14 @@ files:
 - lib/web_test/be_up.rb
 - lib/web_test/util.rb
 - rspec-webservice_matchers.gemspec
+- spec/failure_matchers.rb
 - spec/fixtures/pagespeed.json
-- spec/rspec/webservice_matchers/page_speed_spec.rb
 - spec/rspec/webservice_matchers/protocol_spec.rb
 - spec/rspec/webservice_matchers/public_api_spec.rb
 - spec/rspec/webservice_matchers/redirect_spec.rb
 - spec/rspec/webservice_matchers/ssl_spec.rb
 - spec/spec_helper.rb
+- spec/web_mock_config.rb
 - spec/web_test/be_fast_spec.rb
 - spec/web_test/be_up_spec.rb
 - spec/web_test/util_spec.rb
@@ -206,7 +208,7 @@ homepage: https://github.com/dogweather/rspec-webservice_matchers
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -214,26 +216,26 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.2.9
+signing_key:
 specification_version: 4
 summary: Black-box web app configuration testing
 test_files:
+- spec/failure_matchers.rb
 - spec/fixtures/pagespeed.json
-- spec/rspec/webservice_matchers/page_speed_spec.rb
 - spec/rspec/webservice_matchers/protocol_spec.rb
 - spec/rspec/webservice_matchers/public_api_spec.rb
 - spec/rspec/webservice_matchers/redirect_spec.rb
 - spec/rspec/webservice_matchers/ssl_spec.rb
 - spec/spec_helper.rb
+- spec/web_mock_config.rb
 - spec/web_test/be_fast_spec.rb
 - spec/web_test/be_up_spec.rb
 - spec/web_test/util_spec.rb