rspec-webservice_matchers 0.0.5 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f523d14031fccb0830c1107be6e032769ec6a9ca
-  data.tar.gz: 002708e606a501f751ef4b431121e9dc88956f67
+  metadata.gz: e17330d2e905a3120dc64763b72b809c09ff8d1f
+  data.tar.gz: 92b596e81ef958fdbeedb9a3d055e86652491a22
 SHA512:
-  metadata.gz: 492a5913d17beb16d18384dc782d945eb073c485b8e5fd3e5d35c5f47f012c8553c8de2e0fc30a2a5c2ce52323fbeb190acedc64783a1f16b02ade18feaca7bb
-  data.tar.gz: a08db1c519eea652b3d85082133d0103783d2ad844a0b65415b0457348725253835c12817e4c2787c03eb6facf8c0df19f47c22146d8149989facd3c75533f03
+  metadata.gz: 0d28212c35e26776331e5890c7147e15e1bebc0eb6f594980e7d9006bb1a56fbb18b577ae473ebee312c200a669fe810701831ff09c510f345fba18fd11de527
+  data.tar.gz: ffc8b713dab93ef563264ca49dbdab0f50ad3dcb3a3a6140c6a1a20d27d8b570d0de0ffe8629df44870d1df342c41c77490dde98e2a0792cc6d22a05691c855b

data/README.md

@@ -1,6 +1,6 @@
 # RSpec::WebserviceMatchers
 
-This gem enables you to black-box test a web app's server configuration. For example, whether its SSL certificate is correctly configured and not expired. It's a tool for doing **Test Driven Devops**. (I just made that up.)
+This [gem](https://rubygems.org/gems/rspec-webservice_matchers) enables you to black-box test a web app's server configuration. For example, whether its SSL certificate is correctly configured and not expired. It's a tool for doing **Test Driven Devops**. (I just made that up.)
 
 Installation
 ------------

data/lib/rspec/webservice_matchers/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module WebserviceMatchers
-    VERSION = "0.0.5"
+    VERSION = "0.1.0"
   end
 end

data/lib/rspec/webservice_matchers.rb

@@ -4,18 +4,23 @@ require 'curb'
 module RSpec
   module WebserviceMatchers
 
-    def self.has_valid_ssl_cert?(domain_name)
+    def self.has_valid_ssl_cert?(domain_name_or_url)
+      # Normalize the input: remove 'http(s)://' if it's there
+      if %r|^https?://(.+)$| === domain_name_or_url
+        domain_name_or_url = $1
+      end
+
+      # Test by seeing if Curl retrieves without complaining
       begin
-        Curl.get "https://#{domain_name}"  # Faster than Curl.head; not sure why.
+        Curl::Easy.http_head "https://#{domain_name_or_url}"
         return true
       rescue Curl::Err::ConnectionFailedError, Curl::Err::SSLCACertificateError, Curl::Err::SSLPeerCertificateError
-        # Not serving SSL, expired, or incorrect domain name
+        # Not serving SSL, expired, or incorrect domain name in certificate
         return false
       end
     end
 
     # Would this function be helpful?
-
     #
     # Return true if the domain serves content via SSL
     # without checking certificate validity.
@@ -36,12 +41,14 @@ module RSpec
     # See https://www.relishapp.com/rspec/rspec-expectations/v/3-0/docs/custom-matchers/define-matcher
     
 
+    # Test whether https is correctly implemented
     RSpec::Matchers.define :have_a_valid_cert do
-      match do |domain_name|
-        RSpec::WebserviceMatchers.has_valid_ssl_cert?(domain_name)
+      match do |domain_name_or_url|
+        RSpec::WebserviceMatchers.has_valid_ssl_cert?(domain_name_or_url)
       end
     end
 
+    # Pass successfully if we get a 301 to the place we intend.
     RSpec::Matchers.define :redirect_permanently_to do |expected|
       match do |url|
         # TODO: Refactor this code. Submit as pull request to Curb.
@@ -57,6 +64,10 @@ module RSpec
       end
     end    
 
+    # This is a high level matcher which checks three things:
+    # 1. Permanent redirect
+    # 2. to an https url
+    # 3. which is correctly configured
     RSpec::Matchers.define :enforce_https_everywhere do
       match do |domain_name|
         # TODO: Refactor this code. Submit as pull request to Curb.
@@ -68,7 +79,7 @@ module RSpec
           key, value = line.split(': ')
           header[key] = value
         end
-        (result.response_code == 301) && (/https/ === header['Location'])
+        (result.response_code == 301) && (/https/ === header['Location']) && (RSpec::WebserviceMatchers.has_valid_ssl_cert?(header['Location']))
       end
     end    
 

data/spec/rspec/webservice_matchers/redirect_spec.rb

@@ -7,9 +7,3 @@ describe 'redirect_permanently_to' do
   end
 end
 
-# See https://www.eff.org/https-everywhere
-describe 'enforce_https_everywhere' do
-  it 'passes when http requests are redirected to https urls' do
-    expect('eff.org').to enforce_https_everywhere
-  end
-end

data/spec/rspec/webservice_matchers/ssl_spec.rb

@@ -14,4 +14,12 @@ describe 'have_a_valid_cert matcher' do
       expect('www.psu.edu').to have_a_valid_cert    
     }.to raise_error(RSpec::Expectations::ExpectationNotMetError)
   end
-end
+end
+
+
+# See https://www.eff.org/https-everywhere
+describe 'enforce_https_everywhere' do
+  it 'passes when http requests are redirected to valid https urls' do
+    expect('eff.org').to enforce_https_everywhere
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-webservice_matchers
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors:
 - Robb Shecter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-16 00:00:00.000000000 Z
+date: 2014-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler