rspec-system 1.4.0 → 1.5.0

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+1.5.0
+=====
+
+This release renames the helpers to something more succinct:
+
+* shell (was system_run)
+* rcp (was system_rcp)
+* node (was system_node)
+
+This patch also deprecates the system_setup_block in favour of before :suite instead.
+
+In the next major release, the old helpers and system_setup_block will stop working so it is recommended to look out for the deprecation messages and adjust your code now so that the next major release (2.x) will continue to work.
+
+#### Detailed Changes
+
+* Deprecate usage of system_setup_block (Ken Barber)
+* Rename old helpers to shell, node, rcp (Ken Barber)
+
+-------------------------------
+
 1.4.0
 =====
 

data/README.md

@@ -29,21 +29,26 @@ Start by creating a helper file in `spec/spec_helper_system.rb` containing somet
     require 'rspec-system/spec_helper'
 
     RSpec.configure do |c|
-      c.system_setup_block = proc do
-        include RSpecSystem::Helpers
+      c.before :suite do
         # Insert some setup tasks here
-        system_run('yum install -y ntp')
+        shell 'yum install -y ntp'
       end
     end
 
-Create the directory `spec/system` in your project, its recommended to make sure your unit tests go into `spec/unit` instead so you can isolate them easily during test time. Add files with the spec prefix ie. `mytests_spec.rb` and make sure they always include the line `require 'spec_helper_system'` eg.:
+Within this file we can fine tune the behaviour of rspec-system, but more importantly we can use the before :suite rspec hook to provide setup tasks that must occur before all your tests.
+
+Create the directory `spec/system` in your project, its recommended to make sure your unit tests go into `spec/unit` instead so you can isolate them easily during test time. Add files with the spec prefix ie. `mytests_spec.rb` and make sure they always include the line `require 'spec_helper_system'`.
+
+An example file would look like this:
 
     require 'spec_helper_system'
 
     describe 'basics' do
       it 'should cat /etc/resolv.conf' do
-        system_run('cat /etc/resolv.conf') do |r|
+        shell 'cat /etc/hosts' do |r|
           r.stdout.should =~ /localhost/
+          r.exit_code.should be_zero
+          r.stderr.should be_empty
         end
       end
     end
@@ -52,7 +57,6 @@ Also consult the examples in the `examples` directory in the source of this libr
 
 For your reference, here are the list of custom rspec configuration items that can be overriden in your `spec_helper_system.rb` file:
 
-* *system_setup_block* - this accepts a proc that is called after node setup, but before every test (ie. before suite). The goal of this option is to provide a good place for node setup independant of tests.
 * *system_tmp* - For some of our activity, we require a temporary file area. By default we just a random temporary path, so you normally do not need to set this.
 
 Currently to get the nice formatting rspec-system specific formatter its recommended to use the Rake task, so add the following to your `Rakefile`:
@@ -66,16 +70,16 @@ That will setup the `spec:system` rake task.
 A nodeset file outlines all the node configurations for your tests. The concept here is to define one or more 'nodesets' each nodeset containing one or more 'nodes'. Create the file in your projects root directory as `.nodeset.yml`.
 
     ---
-    default_set: 'centos-58-x64'
+    default_set: 'centos-59-x64'
     sets:
-      'centos-58-x64':
+      'centos-59-x64':
         nodes:
           'main.vm':
-            prefab: 'centos-58-x64'
-      'debian-606-x64':
+            prefab: 'centos-59-x64'
+      'debian-607-x64':
         nodes:
           'main.vm':
-            prefab: 'debian-606-x64'
+            prefab: 'debian-607-x64'
 
 The file must adhere to the Kwalify schema supplied in `resources/kwalify-schemas/nodeset_schema.yml`.
 
@@ -94,7 +98,7 @@ Prefabs are designed to be generic across different hosting environments. For ex
 
 For this reason there are various `provider_specific` settings that apply to different provider types. For now though, only `vagrant` specific settings are provided.
 
-`facts` in the prefab are literally dumps of `facter -p` on the host stored in the prefab file so you can look them up without addressing the machine. These are accessed using the `system_node#facts` method on the helper results and can be used in conditional logic during test runs and setup tasks. Not all the facts are supplied, only the more interesting ones.
+`facts` in the prefab are literally dumps of `facter -p` on the host stored in the prefab file so you can look them up without addressing the machine. These are accessed using the `node#facts` method on the helper results and can be used in conditional logic during test runs and setup tasks. Not all the facts are supplied, only the more interesting ones.
 
 #### Custom Prefabs
 
@@ -214,7 +218,7 @@ I want to start an eco-system of plugins for rspec-system, but do it in a sane w
 
 * node providers - that is, abstractions around other virtualisation, cloud or system tools. Right now a NodeSet is tied to a virtual type, but I think this isn't granual enough. Some ideas for future providers are:
     * blimpy - for firing up EC2 and OpenStack nodes, useful for Jenkins integration
-    * vmware vsphere - for those who have VMWare vSphere deployed already, this would be an awesome bonus.
+    * vmware fusion - for using vmware fusion with vagrant
     * razor - for launching bare metail nodes for testing purposes. Could be really useful to have baremetal tests for software that needs it like `facter`.
     * manual - not everything has to be 'launched' I can see a need for defining a static configuration for older machines that can't be poked and peeked. Of course, we might need to add cleanup tasks for this case.
 * helper libraries - libraries that provide test helpers, and setup helpers for testing development on the software in question.

data/examples/spec/system/test1_spec.rb

@@ -2,10 +2,10 @@ require 'spec_helper'
 
 describe "test1" do
   it 'run test1 - part1' do
-    system_run("cat /etc/resolv.conf")
+    shell "cat /etc/resolv.conf"
   end
 
   it 'run test1 - part2' do
-    system_run("cat /etc/issue")
+    shell "cat /etc/issue"
   end
 end

data/lib/rspec-system/helpers.rb

@@ -15,61 +15,64 @@ require 'rspec-system/result'
 #
 # And Actions:
 #
-# * +system_run+ - runs a command on a node
-# * +system_rcp+ - remote copies to a node
+# * +shell+ - runs a command on a node
+# * +rcp+ - remote copies to a node
 #
-# @example Using run within your tests
-#   describe 'test running' do
-#     it 'run cat' do
-#       system_run 'cat /etc/resolv.conf' do |r|
-#         r.exit_code.should == 0
-#         r.stdout.should =~ /localhost/
-#       end
-#     end
-#   end
-# @example Using rcp in your tests
-#   describe 'test running' do
-#     it 'copy my files' do
-#       system_rcp :sp => 'mydata', :dp => '/srv/data'.should be_true
-#     end
-#   end
 # @example Using node in your tests
 #   describe 'test running' do
 #     it 'do something if redhat' do
-#       if system_node.facts['operatingsystem'] == 'RedHat' do
-#         system_run 'cat /etc/redhat-release'
+#       if node.facts['operatingsystem'] == 'RedHat' do
+#         shell 'cat /etc/redhat-release'
 #       end
 #     end
 #   end
 # @example Make your own helper
 #   describe 'my own helper' do
 #     def install_puppet
-#       facts = system_node.facts
+#       facts = node.facts
 #
 #       # Grab PL repository and install PL copy of puppet
 #       if facts['osfamily'] == 'RedHat'
-#         system_run('rpm -ivh http://yum.puppetlabs.com/el/5/products/i386/puppetlabs-release-5-6.noarch.rpm')
-#         system_run('yum install -y puppet')
+#         shell 'rpm -ivh http://yum.puppetlabs.com/el/5/products/i386/puppetlabs-release-5-6.noarch.rpm'
+#         shell 'yum install -y puppet'
 #       elsif facts['osfamily'] == 'Debian'
-#         system_run("wget http://apt.puppetlabs.com/puppetlabs-release-#{facts['lsbdistcodename']}.deb")
-#         system_run("dpkg -i puppetlabs-release-#{facts['lsbdistcodename']}.deb")
-#         system_run('apt-get update')
-#         system_run('apt-get install -y puppet')
+#         shell "wget http://apt.puppetlabs.com/puppetlabs-release-#{facts['lsbdistcodename']}.deb"
+#         shell "dpkg -i puppetlabs-release-#{facts['lsbdistcodename']}.deb"
+#         shell 'apt-get update'
+#         shell 'apt-get install -y puppet'
 #       end
 #     end
 #
 #     it 'test installing latest puppet' do
 #       install_puppet
-#       system_run('puppet apply --version') do |r|
-#         r.exit_code == 0
+#       shell 'puppet apply --version' do |r|
+#         r.exit_code.should be_zero
 #         r.stdout.should =~ /3.1/
-#         r.stderr.should == ''
+#         r.stderr.should be_empty
 #       end
 #     end
 #   end
 module RSpecSystem::Helpers
   # @!group Actions
 
+  # @!macro shell_method
+  #   @api public
+  #   @overload $0(options)
+  #     @param options [Hash] options for command execution
+  #     @option options [String] :command command to execute. Mandatory.
+  #     @option options [String] :c alias for :command
+  #     @option options [RSpecSystem::Node] :node (defaults to what was defined
+  #       default in your YAML file, otherwise if there is only one node it uses
+  #       that) specifies node to execute command on.
+  #     @option options [RSpecSystem::Node] :n alias for :node
+  #   @overload $0(command)
+  #     @param command [String] command to execute
+  #   @yield [result] yields result when called as a block
+  #   @yieldparam result [RSpecSystem::Result] result of run containing
+  #     :exit_code, :stdout and :stderr
+  #   @return [RSpecSystem::Result] result of run containing :exit_code,
+  #     :stdout and :stderr
+
   # Runs a shell command on a test host.
   #
   # When invoked as a block a result hash is yielded to the block as a
@@ -85,20 +88,29 @@ module RSpecSystem::Helpers
   # to worry about that.
   #
   # @api public
-  # @param options [Hash, String] options for command execution, if passed a
-  #   string it will just use that for the command instead as a convenience.
-  # @option options [String] :command command to execute. Mandatory.
-  # @option options [String] :c alias for :command
-  # @option options [RSpecSystem::Node] :node (defaults to what was defined
-  #   default in your YAML file, otherwise if there is only one node it uses
-  #   that) specifies node to execute command on.
-  # @option options [RSpecSystem::Node] :n alias for :node
-  # @yield [result] yields result when called as a block
-  # @yieldparam result [RSpecSystem::Result] a result containing :exit_code,
-  #   :stdout and :stderr
-  # @return [RSpecSystem::Result] a result containing :exit_code, :stdout and
-  #   :stderr
-  def system_run(options)
+  # @macro shell_method
+  # @example Using it as a helper
+  #   it 'test a command' do
+  #     shell 'cat /etc/hosts' do |r|
+  #       # Test stdout contains 'localhost'
+  #       r.stdout.should =~ /localhost/
+  #       # Test stderr is empty
+  #       r.stderr.should == ''
+  #       # Test exit_code is 0
+  #       r.exit_code.should == 0
+  #     end
+  #   end
+  # @example Running arbitrary commands
+  #   it 'run some commands' do
+  #     # Run a command without testing results
+  #     shell 'echo "foobar" > /tmp/foo'
+  #
+  #     # Now we try to cat the file, and make sure it worked
+  #     shell 'cat /tmp/foo' do |r|
+  #       r.stdout.should =~ /foobar/
+  #     end
+  #   end
+  def shell(options, &block)
     ns = rspec_system_node_set
     dn = ns.default_node
 
@@ -117,7 +129,7 @@ module RSpecSystem::Helpers
     }.merge(options)
 
     if options[:c].nil?
-      raise "Cannot use system_run with no :command option"
+      raise "Cannot use shell with no :command option"
     end
 
     result = RSpecSystem::Result.new(ns.run(options))
@@ -129,7 +141,32 @@ module RSpecSystem::Helpers
     end
   end
 
-  # Remotely copy files to a test node
+  # Legacy method for running a shell command.
+  #
+  # @deprecated Use {#shell} instead
+  # @macro shell_method
+  def system_run(options, &block)
+    log.warn('system_run is deprecated, use shell instead')
+
+    shell(options, &block)
+  end
+
+  # @!macro rcp_method
+  #   @param options [Hash] options for command execution
+  #   @option options [String] :source_path source to copy files from (currently
+  #      only locally)
+  #   @option options [String] :sp alias for source_path
+  #   @option options [String] :destination_path destination for copy
+  #   @option options [String] :dp alias for dest_path
+  #   @option options [RSpecSystem::Node] :destination_node (default_node) destination node
+  #     to transfer files to. Optional.
+  #   @option options [RSpecSystem::Node] :d alias for destination_node
+  #   @option options [RSpecSystem::Node] :source_node ('') Reserved
+  #     for future use. Patches welcome.
+  #   @option options [RSpecSystem::Node] :s alias for source_node
+  #   @return [Bool] returns true if successful
+
+  # Remotely copy files to a test host
   #
   # Just specify a source path, destination path, and optionally a destination
   # node (if the default isn't enough) and go.
@@ -138,20 +175,14 @@ module RSpecSystem::Helpers
   # node provider, however this abstraction should mean you shouldn't need
   # to worry about that.
   #
-  # @param options [Hash] options for command execution
-  # @option options [String] :source_path source to copy files from (currently
-  #    only locally)
-  # @option options [String] :sp alias for source_path
-  # @option options [String] :destination_path destination for copy
-  # @option options [String] :dp alias for dest_path
-  # @option options [RSpecSystem::Node] :destination_node (default_node) destination node 
-  #   to transfer files to. Optional.
-  # @option options [RSpecSystem::Node] :d alias for destination_node
-  # @option options [RSpecSystem::Node] :source_node ('') Reserved
-  #   for future use. Patches welcome.
-  # @option options [RSpecSystem::Node] :s alias for source_node
-  # @return [Bool] returns true if successful
-  def system_rcp(options)
+  # @macro rcp_method
+  # @example Copying a path remotely
+  #   describe 'test running' do
+  #     it 'copy my files' do
+  #       rcp :sp => 'mydata', :dp => '/srv/data'.should be_true
+  #     end
+  #   end
+  def rcp(options)
     ns = rspec_system_node_set
     options = {
       :source_path => options[:sp],
@@ -168,21 +199,33 @@ module RSpecSystem::Helpers
     sp = options[:sp]
     dp = options[:dp]
 
-    log.info("system_rcp from #{sp} to #{d.name}:#{dp} executed")
+    log.info("rcp from #{sp} to #{d.name}:#{dp} executed")
     ns.rcp(options)
   end
 
+  # Legacy method for copying a file to a test host
+  #
+  # @deprecated Use {#rcp} instead
+  # @macro rcp_method
+  def system_rcp(options)
+    log.warn('system_rcp is deprecated, use rcp instead')
+    rcp(options)
+  end
+
   # @!group Queries
 
+  # @!macro node_method
+  #   @param options [Hash] search criteria
+  #   @option options [String] :name the canonical name of the node
+  #   @return [RSpecSystem::Node] node object
+
   # Returns a particular node object from the current nodeset given a set of
   # criteria.
   #
   # If no options are supplied, it tries to return the default node.
   #
-  # @param options [Hash] search criteria
-  # @option options [String] :name the canonical name of the node
-  # @return [RSpecSystem::Node] node object
-  def system_node(options = {})
+  # @macro node_method
+  def node(options = {})
     ns = rspec_system_node_set
     options = {
       :name => ns.default_node.name,
@@ -196,4 +239,13 @@ module RSpecSystem::Helpers
       return ns.nodes[name]
     end
   end
+
+  # Legacy method for querying nodes
+  #
+  # @deprecated Use {#node} instead
+  # @macro node_method
+  def system_node(options = {})
+    log.warn('system_node is deprecated, use node instead')
+    node(options)
+  end
 end

data/lib/rspec-system/spec_helper.rb

@@ -6,6 +6,8 @@ require 'yaml'
 require 'pp'
 require 'tempfile'
 
+include RSpecSystem::Helpers
+
 RSpec.configure do |c|
   include RSpecSystem::Log
   c.include RSpecSystem::Helpers
@@ -52,25 +54,35 @@ RSpec.configure do |c|
   def start_nodes
     ns = rspec_system_node_set
 
-    log.info "START RSPEC-SYSTEM SETUP"
-    log.info "Setname is: " + ns.setname
-    log.info "Configuration is: " + ns.config.pretty_inspect
-    log.info "Virtual Environment type is: #{ns.env_type}"
-    log.info "Default node is: #{ns.default_node.name}"
-    log.info "Destroy node is: #{ns.destroy}"
+    puts "Starting nodes"
+    puts
+    puts "Setname is: " + ns.setname
+    puts "Configuration is: " + ns.config.pretty_inspect
+    puts "Virtual Environment type is: #{ns.env_type}"
+    puts "Default node is: #{ns.default_node.name}"
+    puts "Destroy node is: #{ns.destroy}"
+    puts
 
     ns.setup
+
+    puts
+    puts "Finished starting nodes"
+    puts "================================================================="
   end
 
   def stop_nodes
-    log.info 'FINALIZE RSPEC-SYSTEM SETUP'
+    puts 'Stopping nodes'
+    puts
     rspec_system_node_set.teardown
+    puts 'Finished stopping nodes'
+    puts "================================================================="
   end
 
   def call_custom_setup_block
     # Run test specific setup routines
     if pr = RSpec.configuration.system_setup_block then
       log.info "Running custom setup block"
+      log.warn "The system_setup_block methodology will be deprecated in the next major release, use before :suite instead"
       pr.call
       log.info "Finished running custom setup block"
     end
@@ -92,6 +104,7 @@ RSpec.configure do |c|
   end
 
   c.after :suite do
+    puts "================================================================="
     # After Suite exceptions get captured it seems
     begin
       stop_nodes

data/rspec-system.gemspec

@@ -2,7 +2,7 @@
 Gem::Specification.new do |s|
   # Metadata
   s.name        = "rspec-system"
-  s.version     = "1.4.0"
+  s.version     = "1.5.0"
   s.authors     = ["Ken Barber"]
   s.email       = ["ken@bob.sh"]
   s.homepage    = "https://github.com/puppetlabs/rspec-system"

data/spec/spec_helper_system.rb

@@ -11,6 +11,16 @@ module LocalHelpers
 end
 
 RSpec.configure do |c|
-  c.include RSpecSystem::Helpers
   c.include ::LocalHelpers
+
+  c.before :suite do
+    shell 'echo foobar > /tmp/setupblock'
+  end
+
+  # NOTE: this is deprecated, but we do this for legacy testing purposes
+  # with the next major release we should remove this capability, and remove
+  # the test. Do not use this in your own tests any more!
+  c.system_setup_block = proc do
+    shell 'echo foobar > /tmp/setupblockold'
+  end
 end

data/spec/system/rcp_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper_system'
+
+describe "rcp:" do
+  it 'check rcp works' do
+    rcp(
+      :sp => fixture_root + 'example_dir',
+      :dp => '/tmp/example_destination'
+    )
+
+    shell 'cat /tmp/example_destination/example_file' do |r|
+      r.exit_code.should be_zero
+      r.stdout.should =~ /Test content 1234/
+    end
+  end
+
+  context 'legacy tests' do
+    it 'check system_rcp works' do
+      system_rcp(
+        :sp => fixture_root + 'example_dir',
+        :dp => '/tmp/example_destination'
+      )
+
+      shell 'cat /tmp/example_destination/example_file' do |r|
+        r.exit_code.should be_zero
+        r.stdout.should =~ /Test content 1234/
+      end
+    end
+  end
+end

data/spec/system/shell_spec.rb

@@ -0,0 +1,98 @@
+require 'spec_helper_system'
+
+describe "shell:" do
+  it 'check /tmp/setupblock to ensure before :suite executed' do
+    shell 'cat /tmp/setupblock' do |r|
+      r.stdout.should =~ /foobar/
+    end
+  end
+
+  it "cat /etc/hosts" do
+    shell "cat /etc/hosts" do |r|
+      r.exit_code.should be_zero
+      r.stdout.should =~ /localhost/
+    end
+  end
+
+  it "cat /etc/hosts - test results using hash method" do
+    shell "cat /etc/hosts" do |r|
+      r[:exit_code].should be_zero
+      r[:stdout].should =~ /localhost/
+    end
+  end
+
+  it 'piping should be preserved' do
+    shell 'rm -f /tmp/foo'
+    shell 'echo "foo bar baz" > /tmp/foo' do |r|
+      r.stderr.should be_empty
+      r.exit_code.should be_zero
+    end
+
+    shell 'cat /tmp/foo' do |r|
+      r.stdout.should =~ /foo bar baz/
+      r.exit_code.should be_zero
+    end
+    shell 'rm -f /tmp/foo'
+  end
+
+  it 'escape single quotes properly' do
+    shell 'rm -f /tmp/foo'
+    shell "echo 'foo bar baz' > /tmp/foo" do |r|
+      r.stderr.should be_empty
+      r.exit_code.should be_zero
+    end
+
+    shell 'cat /tmp/foo' do |r|
+      r.stdout.should =~ /foo bar baz/
+      r.exit_code.should be_zero
+    end
+    shell 'rm -f /tmp/foo'
+  end
+
+  it 'escape all quotes properly' do
+    shell 'rm -f ~vagrant/foo'
+    shell "su - vagrant -c 'echo \"foo bar baz\" > ~/foo'" do |r|
+      r.stderr.should be_empty
+      r.exit_code.should be_zero
+    end
+
+    shell 'cat ~vagrant/foo' do |r|
+      r.stdout.should =~ /foo bar baz/
+      r.exit_code.should be_zero
+    end
+    shell 'rm -f ~vagrant/foo'
+  end
+
+  it 'a string of commands should succeed' do
+    r = shell <<-EOS.gsub(/^ {6}/, '')
+      rm /tmp/foo
+      echo 'foo bar baz' > /tmp/foo
+      cat /tmp/foo
+      rm /tmp/foo
+    EOS
+    r.stdout.should =~ /foo bar baz/
+    r.exit_code.should be_zero
+  end
+
+  context 'legacy tests' do
+    it 'cat /etc/hosts - test results using hash method' do
+      shell 'cat /etc/hosts' do |r|
+        r[:exit_code].should be_zero
+        r[:stdout].should =~ /localhost/
+      end
+    end
+
+    it 'cat /etc/hosts - using system_run' do
+      system_run 'cat /etc/hosts' do |r|
+        r.exit_code.should be_zero
+        r.stdout.should =~ /localhost/
+      end
+    end
+
+    it 'cat /tmp/setupblockold to ensure the system_setup_block still works' do
+      shell 'cat /tmp/setupblockold' do |r|
+        r.stdout.should =~ /foobar/
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-system
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-29 00:00:00.000000000 Z
+date: 2013-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -155,8 +155,8 @@ files:
 - spec/fixtures/nodeset_example2.yml
 - spec/spec_helper.rb
 - spec/spec_helper_system.rb
-- spec/system/system_rcp_spec.rb
-- spec/system/system_run_spec.rb
+- spec/system/rcp_spec.rb
+- spec/system/shell_spec.rb
 - spec/unit/kwalify-schemas/nodeset_schema_spec.rb
 - spec/unit/kwalify-schemas/prefabs_schema_spec.rb
 - spec/unit/result_spec.rb
@@ -187,8 +187,8 @@ signing_key:
 specification_version: 3
 summary: System testing with rspec
 test_files:
-- spec/system/system_rcp_spec.rb
-- spec/system/system_run_spec.rb
+- spec/system/rcp_spec.rb
+- spec/system/shell_spec.rb
 - spec/unit/kwalify-schemas/nodeset_schema_spec.rb
 - spec/unit/kwalify-schemas/prefabs_schema_spec.rb
 - spec/unit/result_spec.rb

data/spec/system/system_rcp_spec.rb

@@ -1,15 +0,0 @@
-require 'spec_helper_system'
-
-describe "system_rcp:" do
-  it 'check system_rcp works' do
-    system_rcp(
-      :sp => fixture_root + 'example_dir',
-      :dp => '/tmp/example_destination'
-    )
-
-    system_run('cat /tmp/example_destination/example_file') do |r|
-      r.exit_code.should == 0
-      r.stdout.should =~ /Test content 1234/
-    end
-  end
-end

data/spec/system/system_run_spec.rb

@@ -1,70 +0,0 @@
-require 'spec_helper_system'
-
-describe "system_run:" do
-  it "cat /etc/hosts" do
-    system_run("cat /etc/hosts") do |r|
-      r.exit_code.should == 0
-      r.stdout.should =~ /localhost/
-    end
-  end
-
-  it "cat /etc/hosts - test results using hash method" do
-    system_run("cat /etc/hosts") do |r|
-      r[:exit_code].should == 0
-      r[:stdout].should =~ /localhost/
-    end
-  end
-
-  it 'piping should be preserved' do
-    system_run('rm -f /tmp/foo')
-    system_run('echo "foo bar baz" > /tmp/foo') do |r|
-      r.stderr.should == ''
-      r.exit_code.should == 0
-    end
-
-    system_run('cat /tmp/foo') do |r|
-      r.stdout.should =~ /foo bar baz/
-      r.exit_code.should == 0
-    end
-    system_run('rm -f /tmp/foo')
-  end
-
-  it 'escape single quotes properly' do
-    system_run('rm -f /tmp/foo')
-    system_run("echo 'foo bar baz' > /tmp/foo") do |r|
-      r.stderr.should == ''
-      r.exit_code.should == 0
-    end
-
-    system_run('cat /tmp/foo') do |r|
-      r.stdout.should =~ /foo bar baz/
-      r.exit_code.should == 0
-    end
-    system_run('rm -f /tmp/foo')
-  end
-
-  it 'escape all quotes properly' do
-    system_run('rm -f ~vagrant/foo')
-    system_run("su - vagrant -c 'echo \"foo bar baz\" > ~/foo'") do |r|
-      r.stderr.should == ''
-      r.exit_code.should == 0
-    end
-
-    system_run('cat ~vagrant/foo') do |r|
-      r.stdout.should =~ /foo bar baz/
-      r.exit_code.should == 0
-    end
-    system_run('rm -f ~vagrant/foo')
-  end
-
-  it 'a string of commands should succeed' do
-    r = system_run(<<-EOS.gsub(/^ {6}/, ''))
-      rm /tmp/foo
-      echo 'foo bar baz' > /tmp/foo
-      cat /tmp/foo
-      rm /tmp/foo
-    EOS
-    r.stdout.should =~ /foo bar baz/
-    r.exit_code.should == 0
-  end
-end