rspec-system 0.3.2 → 0.3.3

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 bundler_args: --without development
-script: "rspec"
+script: "SPEC_OPTS='--format=d' rake spec"
 rvm:
   - 1.8.7
   - 1.9.3

data/README.md

@@ -115,6 +115,22 @@ In Jenkins you should be able to use RSPEC\_SET in a test matrix, thus obtaining
 
 ### Plugins to rspec-system
 
+Right now we have two types of plugins, the framework is in a state of flux as to how one writes these things but here we go.
+
+#### Helper libraries
+
+Libraries that provide test helpers, and setup helpers for testing development on the software in question.
+
+* rspec-system-puppet <http://rubygems.org/gems/rspec-system-puppet>
+
+#### Node providers
+
+A node provider should provide the ability to launch nodes (or if they are already launched provide information to get to them), run commands on nodes, transfer files and shutdown nodes.
+
+That is, abstractions around other virtualisation, cloud or system tools. Right now we only have one of these for Vagrant using VirtualBox specifically and its in core.
+
+#### The Future of Plugins
+
 I want to start an eco-system of plugins for rspec-system, but do it in a sane way. Right now I see the following potential plugin types, if you think you can help please do:
 
 * node providers - that is, abstractions around other virtualisation, cloud or system tools. Right now a NodeSet is tied to a virtual type, but I think this isn't granual enough. Some ideas for future providers are:
@@ -124,10 +140,44 @@ I want to start an eco-system of plugins for rspec-system, but do it in a sane w
     * manual - not everything has to be 'launched' I can see a need for defining a static configuration for older machines that can't be poked and peeked. Of course, we might need to add cleanup tasks for this case.
 * helper libraries - libraries that provide test helpers, and setup helpers for testing development on the software in question.
     * distro - helpers that wrap common linux distro tasks, like package installation.
-    * puppet - helpers around installing different versions of puppet, PE as well - firing up masters. Perfect for testing modules I think. Puppet could be used a provisioner for setting up tests, as using shell commands for this purpose is a bit rough, not very idepotent and is re-inventing the wheel.
     * mcollective - for launching the basics, activemq, broker clusters. Useful for testing mcollective agents.
     * puppetdb - helpers for setting up puppetdb, probably using the modules we already have.
     * other config management tools - for the purposes of testing modules against them, or using them for test setup provisioners like I've mentioned before with Puppet.
     * others I'm sure ...
 
-These could be shipped as external gems, and plugged in to the rspec-system framework somehow.
+These could be shipped as external gems, and plugged in to the rspec-system framework somehow. Ideas on how to do this properly are very welcome, if you bring code as well :-).
+
+### CI Integration
+
+So currently I've only integrated this with Jenkins. If you have luck doing it on other CI platforms, feel free to add to this documentation.
+
+#### Jenkins
+
+My setup was:
+
+* Single box - 32GB of RAM and 8 cpus
+* Debian 7
+* Jenkins 1.510 (installed via packages from the jenkins repos)
+* Vagrant 1.1.5 (installed via packages from the vagrant site)
+* VirtualBox 4.2.10 (installed via packages from virtualbox)
+* RVM with Ruby 2.0.0
+
+The setup for a job is basically:
+
+* Setup your slave box to only have 1 executor (there is some bug here, something to do with vagrant not liking multiple projects)
+* Create new matrix build
+* Specify VCS settings etc. as per normal
+* Create a user defined axis called 'RSPEC_SET' and add your nodesets in there: fedora-18-x64, centos-64-x64 etc.
+* Use touchstone with a filter of RSPEC_SET=='centos-64-x64' so you don't chew up cycles running a whole batch of broken builds
+* Create an execute shell job like so:
+
+    #!/bin/bash
+    set +e
+
+    [[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm"
+    rvm use ruby-2.0.0@some_unique_name_here --create
+
+    bundle update
+    rake spec:system
+
+I went quite complex and had Github pull request integration working with this, and quite a few other nice features. If you need help setting it up get in touch.

data/lib/rspec-system/node_set/vagrant.rb

@@ -53,10 +53,10 @@ module RSpecSystem
 
       r = nil
       Dir.chdir(@vagrant_path) do
-        cmd = "vagrant ssh #{dest} --command \"cd /tmp && sudo #{cmd}\""
-        log.debug("[vagrant#run] Running command: #{cmd}")
-        r = systemu cmd
-        log.debug("[Vagrant#run] Finished running command: #{cmd}.")
+        ex = "vagrant ssh #{dest} --command \"cd /tmp && sudo sh -c '#{cmd}'\""
+        log.debug("[vagrant#run] Running command: #{ex}")
+        r = systemu ex
+        log.debug("[Vagrant#run] Finished running command: #{ex}.")
       end
 
       {

data/rspec-system.gemspec

@@ -2,7 +2,7 @@
 Gem::Specification.new do |s|
   # Metadata
   s.name        = "rspec-system"
-  s.version     = "0.3.2"
+  s.version     = "0.3.3"
   s.authors     = ["Ken Barber"]
   s.email       = ["ken@bob.sh"]
   s.homepage    = "https://github.com/kbarber/rspec-system"

data/spec/system/{basic_spec.rb → system_rcp_spec.rb}

@@ -1,13 +1,6 @@
 require 'spec_helper_system'
 
-describe "basic tests:" do
-  it "check system_run works" do
-    system_run("cat /etc/hosts") do |r|
-      r[:exit_code].should == 0
-      r[:stdout].should =~ /localhost/
-    end
-  end
-
+describe "system_rcp:" do
   it 'check system_rcp works' do
     system_rcp(
       :sp => fixture_root + 'example_dir',

data/spec/system/system_run_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper_system'
+
+describe "system_run:" do
+  it "cat /etc/hosts" do
+    system_run("cat /etc/hosts") do |r|
+      r[:exit_code].should == 0
+      r[:stdout].should =~ /localhost/
+    end
+  end
+
+  it 'piping should be preserved' do
+    system_run('rm -f /tmp/foo')
+    system_run('echo "foo" > /tmp/foo') do |r|
+      r[:stderr].should == ''
+      r[:exit_code].should == 0
+    end
+
+    system_run('cat /tmp/foo') do |r|
+      r[:stdout].should =~ /foo/
+      r[:exit_code].should == 0
+    end
+    system_run('rm -f /tmp/foo')
+  end
+
+  it 'escape single quotes properly' do
+    system_run('rm -f /tmp/foo')
+    system_run("echo 'foo' > /tmp/foo") do |r|
+      r[:stderr].should == ''
+      r[:exit_code].should == 0
+    end
+
+    system_run('cat /tmp/foo') do |r|
+      r[:stdout].should =~ /foo/
+      r[:exit_code].should == 0
+    end
+    system_run('rm -f /tmp/foo')
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-system
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-12 00:00:00.000000000 Z
+date: 2013-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -103,7 +103,8 @@ files:
 - spec/fixtures/nodeset_example2.yml
 - spec/spec_helper.rb
 - spec/spec_helper_system.rb
-- spec/system/basic_spec.rb
+- spec/system/system_rcp_spec.rb
+- spec/system/system_run_spec.rb
 - spec/unit/kwalify-schemas/nodeset_schema_spec.rb
 - spec/unit/kwalify-schemas/prefabs_schema_spec.rb
 homepage: https://github.com/kbarber/rspec-system
@@ -132,7 +133,8 @@ signing_key:
 specification_version: 3
 summary: System testing with rspec
 test_files:
-- spec/system/basic_spec.rb
+- spec/system/system_rcp_spec.rb
+- spec/system/system_run_spec.rb
 - spec/unit/kwalify-schemas/nodeset_schema_spec.rb
 - spec/unit/kwalify-schemas/prefabs_schema_spec.rb
 has_rdoc: