rspec-support 3.11.0 → 3.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15b095a31f89b4f715f85a98def34e8d8e401552aa3cbdd8e41e97229acaa7a3
-  data.tar.gz: 7e038fa362d523cc2b271357fd777624479e4952327d286261d3b5d6e503f664
+  metadata.gz: 92bef00902f2274e73ead3711ea3c341a34b07eb11cdf647a8d737e1d0c11382
+  data.tar.gz: 90317d4ebccad5e6da2abb4e2af56a1dbb217bd9961d3dc68ea80ff824f8117e
 SHA512:
-  metadata.gz: 631144fe2de1984bb09db168acbee96186e9709838f4a3c963d083007da80a529c45db2e80890548f78a07e8c190e374b1a40f669d0ca24c0d15030c306698ec
-  data.tar.gz: e9ecd3254c12547501b1bf973e56bc818189ffe979394603cad8fbbaf6b653b5ac51819ba50fb0df555e473f968f55b7359f8f77d38b36ee0b6ee0f2a96c8b00
+  metadata.gz: 025c00e2292a341c12cc2001f83a174749afa81802cc9df491563e9743ebcb3020c2d7c3743ddf5da43c127c7c5803e98d1640ebacd8ac6b5f4ccd51aa2b13e4
+  data.tar.gz: '0209a2909369b4da3fa8164bf47249455f69607019a7813fb598be8987dec613c3f3707484f767222b91b5b586a0eb05f63c783287284a314531736fc293264f'

data/Changelog.md

@@ -1,5 +1,52 @@
 ### Development
-[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.11.0...3-11-maintenance)
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.13.1...main)
+
+### 3.13.1 / 2024-02-23
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.13.0...v3.13.1)
+
+Bug Fixes:
+
+* Exclude ruby internal require warnings from `RSpec::Support::CallerFilter#first_non_rspec_line`.
+  (Jon Rowe, #593)
+
+### 3.13.0 / 2024-02-04
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.12.2...v3.13.0)
+
+Enchancements
+
+* Add `RubyFeatures#supports_syntax_suggest?`. (Jon Rowe, #571)
+
+### 3.12.2 / 2024-02-04
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.12.1...v3.12.2)
+
+Bug Fixes:
+
+* Properly surface errors from `in_sub_process`. (Jon Rowe, #575)
+* Add magic comment for freezing string literals. (Josh Nichols, #586)
+* Allow string keys for keyword arguments during verification of method
+  signatures, (but only on Ruby 3+). (@malcolmohare, #591)
+
+### 3.12.1 / 2023-06-26
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.12.0...v3.12.1)
+
+Bug Fixes:
+
+* Fix `RSpec::Support.thread_local_data` to be Thread local but not Fiber local.
+  (Jon Rowe, #581)
+
+### 3.12.0 / 2022-10-26
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.11.1...v3.12.0)
+Enhancements:
+
+* Add `RSpec::Support::RubyFeatures.distincts_kw_args_from_positional_hash?`
+  (Jean byroot Boussier, #535)
+
+### 3.11.1 / 2022-09-12
+[Full Changelog](http://github.com/rspec/rspec-support/compare/v3.11.0...v3.11.1)
+
+Bug Fixes:
+
+* Fix ripper detection on TruffleRuby. (Brandon Fish, #541)
 
 ### 3.11.0 / 2022-02-09
 [Full Changelog](http://github.com/rspec/rspec-support/compare/v3.10.3...v3.11.0)
@@ -104,7 +151,7 @@ Bug Fixes:
 Bug Fixes:
 
 * Ensure that inspecting a `SimpleDelegator` based object works regardless of
-  visibilty of the `__getobj__` method. (Jon Rowe, #369)
+  visibility of the `__getobj__` method. (Jon Rowe, #369)
 
 ### 3.8.0 / 2018-08-04
 [Full Changelog](http://github.com/rspec/rspec-support/compare/v3.7.1...v3.8.0)
@@ -212,7 +259,7 @@ Changes:
 
 Enhancements:
 
-* Improve formatting of `Delegator` based objects (e.g. `SimpleDelgator`) in
+* Improve formatting of `Delegator` based objects (e.g. `SimpleDelegator`) in
   failure messages and diffs. (Andrew Horner, #215)
 * Add `ComparableVersion`. (Yuji Nakayama, #245)
 * Add `Ripper` support detection. (Yuji Nakayama, #245)

data/lib/rspec/support/caller_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support "ruby_features"
 
 module RSpec
@@ -25,7 +27,7 @@ module RSpec
     # when `CallerFilter.first_non_rspec_line` is called from the top level of a required
     # file, but it depends on if rubygems is loaded or not. We don't want to have to deal
     # with this complexity in our `RSpec.deprecate` calls, so we ignore it here.
-    IGNORE_REGEX = Regexp.union(LIB_REGEX, "rubygems/core_ext/kernel_require.rb")
+    IGNORE_REGEX = Regexp.union(LIB_REGEX, "rubygems/core_ext/kernel_require.rb", "<internal:", %r{/lib/ruby/[^/]+/bundled_gems\.rb})
 
     if RSpec::Support::RubyFeatures.caller_locations_supported?
       # This supports args because it's more efficient when the caller specifies
@@ -34,7 +36,7 @@ module RSpec
       # be found in a small number of stack frames from `skip_frames`.
       #
       # Note that there is a risk to passing a `skip_frames` value that is too high:
-      # If it skippped the first non-rspec line, then this method would return the
+      # If it skipped the first non-rspec line, then this method would return the
       # 2nd or 3rd (or whatever) non-rspec line. Thus, you generally shouldn't pass
       # values for these parameters, particularly since most places that use this are
       # not hot spots (generally it gets used for deprecation warnings). However,

data/lib/rspec/support/comparable_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # @private
@@ -10,7 +12,7 @@ module RSpec
         @string = string
       end
 
-      def <=>(other) # rubocop:disable Metrics/AbcSize
+      def <=>(other)
         other = self.class.new(other) unless other.is_a?(self.class)
 
         return 0 if string == other.string

data/lib/rspec/support/differ.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support 'encoded_string'
 RSpec::Support.require_rspec_support 'hunk_generator'
 RSpec::Support.require_rspec_support "object_formatter"
@@ -6,7 +8,7 @@ require 'pp'
 
 module RSpec
   module Support
-    # rubocop:disable ClassLength
+    # rubocop:disable Metrics/ClassLength
     class Differ
       def diff(actual, expected)
         diff = ""
@@ -24,7 +26,7 @@ module RSpec
         diff.to_s
       end
 
-      # rubocop:disable MethodLength
+      # rubocop:disable Metrics/MethodLength
       def diff_as_string(actual, expected)
         encoding = EncodedString.pick_encoding(actual, expected)
 
@@ -52,7 +54,7 @@ module RSpec
       rescue Encoding::CompatibilityError
         handle_encoding_errors(actual, expected)
       end
-      # rubocop:enable MethodLength
+      # rubocop:enable Metrics/MethodLength
 
       def diff_as_object(actual, expected)
         actual_as_string = object_to_string(actual)
@@ -210,6 +212,6 @@ module RSpec
         end
       end
     end
-    # rubocop:enable ClassLength
+    # rubocop:enable Metrics/ClassLength
   end
 end

data/lib/rspec/support/directory_maker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support 'ruby_features'
 
 module RSpec

data/lib/rspec/support/encoded_string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # @private
@@ -60,7 +62,7 @@ module RSpec
         #     vs "\x80".encode('UTF-8','ASCII-8BIT', undef: :replace, replace: '<undef>')
         #     # => '<undef>'
         #   Encoding::CompatibilityError
-        #     when Encoding.compatibile?(str1, str2) is nil
+        #     when Encoding.compatible?(str1, str2) is nil
         #     e.g. utf_16le_emoji_string.split("\n")
         #     e.g. valid_unicode_string.encode(utf8_encoding) << ascii_string
         #   Encoding::InvalidByteSequenceError:
@@ -92,7 +94,7 @@ module RSpec
           string = remove_invalid_bytes(string)
           string.encode(@encoding)
         rescue Encoding::UndefinedConversionError, Encoding::InvalidByteSequenceError
-          # Originally defined as a constant to avoid uneeded allocations, this hash must
+          # Originally defined as a constant to avoid unneeded allocations, this hash must
           # be defined inline (without {}) to avoid warnings on Ruby 2.7
           #
           # In MRI 2.1 'invalid: :replace' changed to also replace an invalid byte sequence
@@ -108,7 +110,7 @@ module RSpec
           #
           string.encode(@encoding, :invalid => :replace, :undef => :replace, :replace => REPLACE)
         rescue Encoding::ConverterNotFoundError
-          # Originally defined as a constant to avoid uneeded allocations, this hash must
+          # Originally defined as a constant to avoid unneeded allocations, this hash must
           # be defined inline (without {}) to avoid warnings on Ruby 2.7
           string.dup.force_encoding(@encoding).encode(:invalid => :replace, :replace => REPLACE)
         end

data/lib/rspec/support/fuzzy_matcher.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # Provides a means to fuzzy-match between two arbitrary objects.

data/lib/rspec/support/hunk_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'diff/lcs'
 require 'diff/lcs/hunk'
 

data/lib/rspec/support/matcher_definition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # @private

data/lib/rspec/support/method_signature_verifier.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/support'
 RSpec::Support.require_rspec_support "ruby_features"
 RSpec::Support.require_rspec_support "matcher_definition"
@@ -8,7 +10,7 @@ module RSpec
     # keyword args of a given method.
     #
     # @private
-    class MethodSignature # rubocop:disable ClassLength
+    class MethodSignature # rubocop:disable Metrics/ClassLength
       attr_reader :min_non_kw_args, :max_non_kw_args, :optional_kw_args, :required_kw_args
 
       def initialize(method)
@@ -82,7 +84,7 @@ module RSpec
         def has_kw_args_in?(args)
           Hash === args.last &&
             could_contain_kw_args?(args) &&
-            (args.last.empty? || args.last.keys.any? { |x| x.is_a?(Symbol) })
+            (RubyFeatures.kw_arg_separation? || args.last.empty? || args.last.keys.any? { |x| x.is_a?(Symbol) })
         end
 
         # Without considering what the last arg is, could it
@@ -285,7 +287,7 @@ module RSpec
         @arbitrary_kw_args = @unlimited_args = false
       end
 
-      def with_expectation(expectation) # rubocop:disable MethodLength, Metrics/PerceivedComplexity
+      def with_expectation(expectation) # rubocop:disable Metrics/MethodLength
         return self unless MethodSignatureExpectation === expectation
 
         if expectation.empty?
@@ -361,7 +363,7 @@ module RSpec
       end
 
       def split_args(*args)
-        kw_args = if @signature.has_kw_args_in?(args)
+        kw_args = if @signature.has_kw_args_in?(args) && !RubyFeatures.kw_arg_separation?
                     last = args.pop
                     non_kw_args = last.reject { |k, _| k.is_a?(Symbol) }
                     if non_kw_args.empty?
@@ -370,6 +372,8 @@ module RSpec
                       args << non_kw_args
                       last.select { |k, _| k.is_a?(Symbol) }.keys
                     end
+                  elsif @signature.has_kw_args_in?(args) && RubyFeatures.kw_arg_separation?
+                    args.pop.keys
                   else
                     []
                   end
@@ -378,7 +382,7 @@ module RSpec
       end
     end
 
-    # Figures out wether a given method can accept various arguments.
+    # Figures out whether a given method can accept various arguments.
     # Surprisingly non-trivial.
     #
     # @private

data/lib/rspec/support/mutex.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # On 1.8.7, it's in the stdlib.
@@ -9,7 +11,7 @@ module RSpec
     # Some methods we don't need are deleted. Anything I don't
     # understand (there's quite a bit, actually) is left in.
     #
-    # Some formating changes are made to appease the robot overlord:
+    # Some formatting changes are made to appease the robot overlord:
     #   https://travis-ci.org/rspec/rspec-core/jobs/54410874
     # @private
     class Mutex

data/lib/rspec/support/object_formatter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support 'matcher_definition'
 
 module RSpec

data/lib/rspec/support/recursive_const_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # Provides recursive constant lookup methods useful for

data/lib/rspec/support/reentrant_mutex.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # Allows a thread to lock out other threads from a critical section of code,
@@ -62,7 +64,7 @@ module RSpec
       # On 1.9 and up, this is in core, so we just use the real one
       class Mutex < ::Mutex
         # If you mock Mutex.new you break our usage of Mutex, so
-        # instead we capture the original method to return Mutexs.
+        # instead we capture the original method to return Mutexes.
         NEW_MUTEX_METHOD = Mutex.method(:new)
 
         def self.new

data/lib/rspec/support/ruby_features.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rbconfig'
 RSpec::Support.require_rspec_support "comparable_version"
 
@@ -94,6 +96,27 @@ module RSpec
         end
       end
 
+      if RUBY_VERSION.to_f >= 3.2
+        def supports_syntax_suggest?
+          true
+        end
+      else
+        def supports_syntax_suggest?
+          false
+        end
+      end
+
+      if RUBY_VERSION.to_f >= 3.0
+        # https://rubyreferences.github.io/rubychanges/3.0.html#keyword-arguments-are-now-fully-separated-from-positional-arguments
+        def kw_arg_separation?
+          true
+        end
+      else
+        def kw_arg_separation?
+          false
+        end
+      end
+
       if RUBY_VERSION.to_f >= 2.7
         def supports_taint?
           false
@@ -116,6 +139,9 @@ module RSpec
         ripper_requirements.push(!Ruby.jruby_version.between?('9.0.0.0.rc1', '9.2.0.0'))
       end
 
+      # TruffleRuby disables ripper due to low performance
+      ripper_requirements.push(false) if Ruby.truffleruby?
+
       if ripper_requirements.all?
         def ripper_supported?
           true
@@ -126,6 +152,10 @@ module RSpec
         end
       end
 
+      def distincts_kw_args_from_positional_hash?
+        RUBY_VERSION >= '3.0.0'
+      end
+
       if Ruby.mri?
         def kw_args_supported?
           RUBY_VERSION >= '2.0.0'

data/lib/rspec/support/source/location.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     class Source

data/lib/rspec/support/source/node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support 'source/location'
 
 module RSpec

data/lib/rspec/support/source/token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support 'source/location'
 
 module RSpec

data/lib/rspec/support/source.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support 'encoded_string'
 RSpec::Support.require_rspec_support 'ruby_features'
 

data/lib/rspec/support/spec/deprecation_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpecHelpers
   def expect_deprecation_with_call_site(file, line, snippet=//)
     expect(RSpec.configuration.reporter).to receive(:deprecation).

data/lib/rspec/support/spec/diff_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'diff/lcs'
 
 module RSpec

data/lib/rspec/support/spec/formatting_support.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     module FormattingSupport

data/lib/rspec/support/spec/in_sub_process.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     module InSubProcess
@@ -7,10 +9,14 @@ module RSpec
 
         # Useful as a way to isolate a global change to a subprocess.
 
-        def in_sub_process(prevent_warnings=true) # rubocop:disable MethodLength, Metrics/AbcSize
+        def in_sub_process(prevent_warnings=true) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
           exception_reader, exception_writer = IO.pipe
           result_reader, result_writer = IO.pipe
 
+          # Set binary mode to avoid errors surrounding ascii-8bit to utf-8 conversion
+          # this happens with warnings on rspec-rails for example
+          [exception_reader, exception_writer, result_reader, result_writer].each { |io| io.binmode }
+
           pid = Process.fork do
             warning_preventer = $stderr = RSpec::Support::StdErrSplitter.new($stderr)
 

data/lib/rspec/support/spec/library_wide_checks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/support/spec/shell_out'
 
 module RSpec

data/lib/rspec/support/spec/shell_out.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'open3'
 require 'rake/file_utils'
 require 'shellwords'
@@ -77,6 +79,9 @@ module RSpec
           # This is a JRuby 9.2.1.x error
           %r{jruby/kernel/gem_prelude},
           %r{lib/jruby\.jar!/jruby/preludes},
+          # Ignore some JRuby errors for gems
+          %r{jruby/\d\.\d(\.\d)?/gems/aruba},
+          %r{jruby/\d\.\d(\.\d)?/gems/ffi},
         ]
 
       def strip_known_warnings(input)

data/lib/rspec/support/spec/stderr_splitter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stringio'
 
 module RSpec
@@ -39,7 +41,7 @@ module RSpec
       def write(line)
         return if line =~ %r{^\S+/gems/\S+:\d+: warning:} # http://rubular.com/r/kqeUIZOfPG
 
-        # Ruby 2.7.0 warnings from keyword argments span multiple lines, extend check above
+        # Ruby 2.7.0 warnings from keyword arguments span multiple lines, extend check above
         # to look for the next line.
         return if @last_line =~ %r{^\S+/gems/\S+:\d+: warning:} &&
                   line =~ %r{warning: The called method .* is defined here}

data/lib/rspec/support/spec/string_matcher.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/matchers'
 # Special matcher for comparing encoded strings so that
 # we don't run any expectation failures through the Differ,

data/lib/rspec/support/spec/with_isolated_directory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 
 RSpec.shared_context "isolated directory" do

data/lib/rspec/support/spec/with_isolated_stderr.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     module WithIsolatedStdErr

data/lib/rspec/support/spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/support'
 require 'rspec/support/spec/in_sub_process'
 

data/lib/rspec/support/version.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     module Version
-      STRING = '3.11.0'
+      STRING = '3.13.1'
     end
   end
 end

data/lib/rspec/support/warnings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/support'
 RSpec::Support.require_rspec_support "caller_filter"
 

data/lib/rspec/support/with_keywords_when_needed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Support.require_rspec_support("method_signature_verifier")
 
 module RSpec
@@ -9,7 +11,7 @@ module RSpec
       module_function
 
       if RSpec::Support::RubyFeatures.kw_args_supported?
-        # Remove this in RSpec 4 in favour of explictly passed in kwargs where
+        # Remove this in RSpec 4 in favour of explicitly passed in kwargs where
         # this is used. Works around a warning in Ruby 2.7
 
         def class_exec(klass, *args, &block)

data/lib/rspec/support.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RSpec
   module Support
     # @api private
@@ -89,8 +91,14 @@ module RSpec
     end
 
     # A single thread local variable so we don't excessively pollute that namespace.
-    def self.thread_local_data
-      Thread.current[:__rspec] ||= {}
+    if RUBY_VERSION.to_f >= 2
+      def self.thread_local_data
+        Thread.current.thread_variable_get(:__rspec) || Thread.current.thread_variable_set(:__rspec, {})
+      end
+    else
+      def self.thread_local_data
+        Thread.current[:__rspec] ||= {}
+      end
     end
 
     # @api private

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-support
 version: !ruby/object:Gem::Version
-  version: 3.11.0
+  version: 3.13.1
 platform: ruby
 authors:
 - David Chelimsky
@@ -48,7 +48,7 @@ cert_chain:
   ZsVDj6a7lH3cNqtWXZxrb2wO38qV5AkYj8SQK7Hj3/Yui9myUX3crr+PdetazSqQ
   F3MdtaDehhjC
   -----END CERTIFICATE-----
-date: 2022-02-09 00:00:00.000000000 Z
+date: 2024-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -125,7 +125,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rspec/rspec-support/issues
-  changelog_uri: https://github.com/rspec/rspec-support/blob/v3.11.0/Changelog.md
+  changelog_uri: https://github.com/rspec/rspec-support/blob/v3.13.1/Changelog.md
   documentation_uri: https://rspec.info/documentation/
   mailing_list_uri: https://groups.google.com/forum/#!forum/rspec
   source_code_uri: https://github.com/rspec/rspec-support
@@ -145,8 +145,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.5.6
 signing_key:
 specification_version: 4
-summary: rspec-support-3.11.0
+summary: rspec-support-3.13.1
 test_files: []