rspec-stripe 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05512b6ddcbfa7a5bb9f103342b47ba5a4fdd8e6
-  data.tar.gz: 2496b4b322b68869cdfeff2d1ec56c45f44d2e02
+  metadata.gz: daade85cd92797b42206cb26d6315c567a6221f9
+  data.tar.gz: b1478da2c27f3a35c7a7eb9a4f734d693fbda435
 SHA512:
-  metadata.gz: 7e159ef49ad43beab92b085691c5030ed167a30df5b935e3846cc8ba1bec92077be56d0208c741642b8eefae9e1c437211f940bb21ca858fbc388752e81cbf80
-  data.tar.gz: 3b54f7060a6f98bb27e748c13e7fa41dcf688a7f1bda285ccb6a740aa986bbeb6892c31be59cc309769120f46609a0a51aa3ae3d7f37012872a6edee8ca837ff
+  metadata.gz: 706614aa10bd7f12d6a382e8ca579d468cd59f3639dd7913e8da149a71287b4135cf72d3d5a7dc7c41910c740cec017218432a66774234589c818f96b23026ef
+  data.tar.gz: b9d59f7e601507397dcaba837fa80e396a5d9b837aa7c68b9b528b2f02392f61e1673c94736c70eccd18e1c487c6280d3d0fea0050e52e0ec538920a37e9e9ee

data/README.md

@@ -36,7 +36,7 @@ Installation
 
 1. Include `gem 'rspec-stripe'` in your Gemfile
 2. `bundle install`
-3. In your spec_helper.rb file, include `require 'rspec-stripe'` at the top. 
+3. In your spec_helper.rb file, include `require 'rspec-stripe'` at the top.
 4. Bootstrap it for RSpec:
 
 ```
@@ -44,3 +44,28 @@ RSpecStripe.configure do |config|
   config.configure_rspec_metadata!
 end
 ```
+
+Options Available
+============
+
+There are several options available to include in the stripe hash. The main options are `customer, plan, card, subscription`.
+
+### Customer
+For a new customer, use the value `:new` in your hash. New customers will be created and then destroyed just for this spec. This is the recommended use case as rspec-stripe wants to make setup repeatable and easy.
+
+For an existing customer, use the `"cus_something"` Stripe ID in your hash. Existing customers will not be destroyed when the spec is finished.
+
+### Plan
+For a new plan, use the value `:new` or any plan id that doesn't exist in your Stripe instance. New plans will be created and then destroyed just for this spec. This is the recommended use case. Currently, you cannot specify the plan details and a default is used. This will be expanded on in upcoming versions.
+
+For an existing plan, use the `"plan_id"` Stripe Plan ID in your hash. Existing plans will not be destroyed when the spec is finished.
+
+### Card
+Cards are always created new when specified. There are several different built-in card types given from the Stripe Docs. These card names are `:visa :mastercard :amex :discover :diners :jcb :card_declined :incorrect_number :invalid_expiry_month :invalid_expiry_year :invalid_cvc`. You can pass any of these card names for the card hash value and that card will be created as a default for the current customer and then delete it when done with the spec.
+
+Card requires that `customer` is defined and will raise an exception if the customer is not given (either new or existing is fine).
+
+### Subscription
+Subscriptions are always created new when specified. Use the value `"plan_id"` for the subscription field. The subscription will be created with this plan and then deleted after the spec.
+
+Subscription requires that `customer` is defined and will raise an exception if the customer is not given (either new or existing is fine).

data/lib/rspec-stripe/runner.rb

@@ -10,11 +10,7 @@ module RSpecStripe
       @customer = customer_factory.get if recipes[:customer]
       @plan = plan_factory.get if recipes[:plan]
       @card = card_factory.get if recipes[:card]
-
-      if recipes[:subscription]
-        @card ||= card_factory.get
-        @subscription = subscription_factory.get
-      end
+      @subscription = subscription_factory.get if recipes[:subscription]
     end
 
     def cleanup!

data/rspec-stripe.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
   s.files = `git ls-files`.split("\n")
 
-  s.version            = "0.0.3"
+  s.version            = "0.0.4"
   s.required_ruby_version = '>= 2.0.0'
   s.required_rubygems_version = '>= 1.6.2'
 end

data/spec/runner_spec.rb

@@ -5,6 +5,8 @@ require 'fakeweb'
 # making the calls that we want
 FakeWeb.allow_net_connect = false
 
+# All runner options here are what would hash in rspec's stripe: hash syntax
+# This is an authority on what options are available in any version
 describe RSpecStripe::Runner do
   describe "customer" do
     let(:customer_double) { double(Stripe::Customer) }
@@ -55,7 +57,7 @@ describe RSpecStripe::Runner do
       }
 
       it "creates the plan" do
-        runner = RSpecStripe::Runner.new({plan: "test"})
+        runner = RSpecStripe::Runner.new({plan: :new})
         runner.call!
       end
 
@@ -125,8 +127,6 @@ describe RSpecStripe::Runner do
   end
 
   describe "subscription" do
-    let(:card_double) { double(Stripe::Card) }
-
     context "without a customer" do
       it "raises error" do
         runner = RSpecStripe::Runner.new({subscription: "test"})
@@ -143,27 +143,13 @@ describe RSpecStripe::Runner do
           expect(stub).to receive(:create).once.with(plan: "test")
           stub
         }
-        expect(customer_double).to receive(:cards).once {
-          stub = double("cards")
-          expect(stub).to receive(:create).once.with(card: hash_including(number: card_number)) { card_double }
-          stub
-        }
       }
 
-      context "without a card specified" do
-        let(:card_number) { "4242424242424242" }
-
-        it "creates a generic card and subscription" do
-          runner = RSpecStripe::Runner.new({customer: "id", subscription: "test"})
-          runner.call!
-        end
-      end
-
       context "with a card specified" do
         let(:card_number) { "5555555555554444" }
 
         it "creates the specified card subscription" do
-          runner = RSpecStripe::Runner.new({customer: "id", subscription: "test", card: :mastercard})
+          runner = RSpecStripe::Runner.new({customer: "id", subscription: "test"})
           runner.call!
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-stripe
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Stephen Bussey