rspec-sorbet 1.8.1 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d35ae78f068312d7be093df0738b370c73b9a9e27e9949230a4fc0abc779c5b
-  data.tar.gz: 2b3d38f4de42ca8ec002160c646c1bf3906cda6066c1603fb7b6da00f30314e9
+  metadata.gz: 88e13e13b30f81692eee4f6e0733cb8382c177df738040fd973b800976940459
+  data.tar.gz: 9e655229ec0b953a8bd0839d9f28f2be66d9553d5c6854fbe83dcdd323586f7d
 SHA512:
-  metadata.gz: 74de415e920f3b98d82460ded292fb392219726e9abad758db444e3324784bbf8ea9d44efc728ef9ec4fd4f771246bf368de85ee956ad4e536b4727b897c30c5
-  data.tar.gz: 56544eab93fb2d158ecfa38111236517c50e70800ddfc694ae0c6b6a6ec0edb88dd3839a8f9987e8169485160db34933acca2ae93d5f540df0e53cbb66e09223
+  metadata.gz: 754248f96d753ca1069284780ff3cabb11700f3f224ab28a3336df5261ed9935371948cd4e40cb992177796a21c7fcb95d0a49d3474db6f33a1a0612f3c3f121
+  data.tar.gz: ad16625d96aa2acd2c3d4fba8b7b8f5bb11988ae6a0fb2075b78b7dd53db7106abba8b3a91a063adb8d4201e412735e39ed4b93db01c7c591bd6aa7cc5e32d26

data/.github/workflows/ci.yml

@@ -1,5 +1,7 @@
 ---
 name: Continuous Integration
+env:
+  SLACK_CHANNEL_ID: C0317P7C9C2
 on:
   push:
     branches-ignore:
@@ -38,9 +40,9 @@ jobs:
         || github.ref == 'refs/heads/stable')
       uses: pullreminders/slack-action@a5a262c896a1cc80dcbae59ba95513e2dfb21439
       env:
-        SLACK_BOT_TOKEN: "${{ secrets.SLACK_BOT_TOKEN }}"
+        SLACK_BOT_TOKEN: "${{ secrets.BELLROY_SLACK_TOKEN }}"
       with:
-        args: '{\"channel\":\"C33574SJJ\",\"text\":\"* ${{ github.repository }} BUILD
+        args: '{\"channel\":\"${{ env.SLACK_CHANNEL_ID }}\",\"text\":\"* ${{ github.repository }} BUILD
           FAILURE*\", \"attachments\": [{ \"fallback\": \"Failure summary\", \"color\":
           \"#ff0000\", \"fields\": [{\"title\": \"Branch\", \"value\":\"${{ steps.extract_branch.outputs.branch
           }}\"}, {\"title\": \"Who broke it\", \"value\":\"${{ github.actor }}\"},

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+1.9.0
+
+* Allow specification of a custom validation handler (thanks [@bmalinconico](https://github.com/bmalinconico))
+
+1.8.3
+
+* Make sorbet a development dependency
+
+1.8.2
+
+* Reduce gem size by excluding RBIs from gem build
+
 1.8.1
 
 * [BUGFIX] Fix processing T.let type mismatch messages when there are digits in module name

data/README.md

@@ -34,3 +34,16 @@ RSpec::Sorbet.allow_doubles!
 ### `eq` matcher usage with `T::Struct`'s
 
 Using the [`eq` matcher](https://www.rubydoc.info/github/rspec/rspec-expectations/RSpec%2FMatchers:eq) to compare [`T::Struct`'s](https://sorbet.org/docs/tstruct) might not behave as you'd expect whereby two separate instances of the same struct class with identical attributes are not `==` out of the box. The standalone [sorbet-struct-comparable](https://github.com/tricycle/sorbet-struct-comparable) gem may be of interest if you are looking for a simple attribute based comparison that will help make the `eq` matcher behave as you expect.
+
+### Specifying a custom validation handler
+
+You can customise the handler of Sorbet validation errors if you so desire.
+
+
+```ruby
+def handler(signature, opts)
+  raise MyCustomException, "The options were #{opts}"
+end
+
+T::Configuration.call_validation_error_handler = handler
+```

data/lib/rspec/sorbet/doubles.rb

@@ -11,6 +11,8 @@ module RSpec
           inline_type_error_handler(error)
         end
 
+        @existing_handler = T::Configuration.instance_variable_get(:@call_validation_error_handler)
+
         T::Configuration.call_validation_error_handler = proc do |signature, opts|
           call_validation_error_handler(signature, opts)
         end
@@ -23,6 +25,13 @@ module RSpec
       INLINE_DOUBLE_REGEX =
         /T.(?:let|cast): Expected type (?:T.(?<t_method>any|nilable|class_of)\()?(?<expected_types>[a-zA-Z0-9:: ,]*)(\))?, got (?:type .* with value )?#<(?<double_type>Instance|Class|Object)?Double([\(]|[ ])(?<doubled_type>[a-zA-Z0-9:: ,]*)(\))?/.freeze
 
+
+      def handle_call_validation_error(signature, opts)
+        raise TypeError, opts[:pretty_message] unless @existing_handler 
+
+        @existing_handler.call(signature, opts)
+      end
+
       def inline_type_error_handler(error)
         case error
         when TypeError
@@ -75,7 +84,7 @@ module RSpec
         message.match?(TYPED_ARRAY_MESSAGE)
       end
 
-      def call_validation_error_handler(_signature, opts)
+      def call_validation_error_handler(signature, opts)
         should_raise = true
 
         message = opts.fetch(:pretty_message, opts.fetch(:message, ''))
@@ -108,7 +117,7 @@ module RSpec
           end
         end
 
-        raise TypeError, opts[:pretty_message] if should_raise
+        handle_call_validation_error(signature, opts) if should_raise
       end
     end
   end

data/lib/rspec/sorbet/version.rb

@@ -3,6 +3,6 @@
 
 module RSpec
   module Sorbet
-    VERSION = '1.8.1'
+    VERSION = '1.9.0'
   end
 end

data/rspec-sorbet.gemspec

@@ -16,17 +16,17 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^spec/}) && !f.match(%r{^spec/support/factories/})
+    f.match(%r{^(sorbet|spec)/}) && !f.match(%r{^spec/support/factories/})
   end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'sorbet'
   spec.add_dependency 'sorbet-runtime'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake', '>= 13.0'
   spec.add_development_dependency 'rspec', '>= 3.0'
+  spec.add_development_dependency 'sorbet'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-sorbet
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.9.0
 platform: ruby
 authors:
 - Samuel Giles
@@ -11,7 +11,7 @@ cert_chain: []
 date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: sorbet
+  name: sorbet-runtime
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,13 +25,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sorbet-runtime
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,47 +53,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: sorbet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 description:
 email:
 - samuel.giles@bellroy.com
@@ -124,59 +124,6 @@ files:
 - rspec-sorbet.gemspec
 - run_ci.sh
 - shell.nix
-- sorbet/config
-- sorbet/rbi/gems/ast@2.4.2.rbi
-- sorbet/rbi/gems/byebug@11.1.3.rbi
-- sorbet/rbi/gems/coderay@1.1.3.rbi
-- sorbet/rbi/gems/diff-lcs@1.4.4.rbi
-- sorbet/rbi/gems/docile@1.4.0.rbi
-- sorbet/rbi/gems/em-websocket@0.5.2.rbi
-- sorbet/rbi/gems/eventmachine@1.2.7.rbi
-- sorbet/rbi/gems/ffaker@2.20.0.rbi
-- sorbet/rbi/gems/ffi@1.15.4.rbi
-- sorbet/rbi/gems/formatador@0.3.0.rbi
-- sorbet/rbi/gems/guard-compat@1.2.1.rbi
-- sorbet/rbi/gems/guard-livereload@2.5.2.rbi
-- sorbet/rbi/gems/guard-rspec@4.7.3.rbi
-- sorbet/rbi/gems/guard@2.18.0.rbi
-- sorbet/rbi/gems/http_parser.rb@0.6.0.rbi
-- sorbet/rbi/gems/listen@3.7.0.rbi
-- sorbet/rbi/gems/lumberjack@1.2.8.rbi
-- sorbet/rbi/gems/method_source@1.0.0.rbi
-- sorbet/rbi/gems/multi_json@1.15.0.rbi
-- sorbet/rbi/gems/nenv@0.3.0.rbi
-- sorbet/rbi/gems/notiffany@0.1.3.rbi
-- sorbet/rbi/gems/parallel@1.21.0.rbi
-- sorbet/rbi/gems/parser@3.0.2.0.rbi
-- sorbet/rbi/gems/pry-byebug@3.8.0.rbi
-- sorbet/rbi/gems/pry@0.14.1.rbi
-- sorbet/rbi/gems/rainbow@3.0.0.rbi
-- sorbet/rbi/gems/rake@13.0.6.rbi
-- sorbet/rbi/gems/rb-fsevent@0.11.0.rbi
-- sorbet/rbi/gems/rb-inotify@0.10.1.rbi
-- sorbet/rbi/gems/rbi@0.0.6.rbi
-- sorbet/rbi/gems/regexp_parser@2.1.1.rbi
-- sorbet/rbi/gems/rexml@3.2.5.rbi
-- sorbet/rbi/gems/rspec-core@3.10.1.rbi
-- sorbet/rbi/gems/rspec-expectations@3.10.1.rbi
-- sorbet/rbi/gems/rspec-mocks@3.10.2.rbi
-- sorbet/rbi/gems/rspec-support@3.10.2.rbi
-- sorbet/rbi/gems/rspec@3.10.0.rbi
-- sorbet/rbi/gems/rubocop-ast@1.12.0.rbi
-- sorbet/rbi/gems/rubocop-rspec@2.5.0.rbi
-- sorbet/rbi/gems/rubocop@1.22.1.rbi
-- sorbet/rbi/gems/ruby-progressbar@1.11.0.rbi
-- sorbet/rbi/gems/shellany@0.0.1.rbi
-- sorbet/rbi/gems/simplecov-html@0.12.3.rbi
-- sorbet/rbi/gems/simplecov@0.21.2.rbi
-- sorbet/rbi/gems/simplecov_json_formatter@0.1.3.rbi
-- sorbet/rbi/gems/spoom@1.1.5.rbi
-- sorbet/rbi/gems/stackprof@0.2.17.rbi
-- sorbet/rbi/gems/tapioca@0.5.2.rbi
-- sorbet/rbi/gems/thor@1.1.0.rbi
-- sorbet/rbi/gems/unicode-display_width@2.1.0.rbi
-- sorbet/rbi/gems/unparser@0.6.0.rbi
-- sorbet/tapioca/require.rb
 homepage: https://github.com/tricycle/rspec-sorbet
 licenses:
 - MIT

data/sorbet/config

@@ -1,4 +0,0 @@
---dir
-.
---ignore
-vendor

data/sorbet/rbi/gems/ast@2.4.2.rbi

@@ -1,54 +0,0 @@
-# DO NOT EDIT MANUALLY
-# This is an autogenerated file for types exported from the `ast` gem.
-# Please instead update this file by running `bin/tapioca gem ast`.
-
-# typed: true
-
-module AST; end
-
-class AST::Node
-  def initialize(type, children = T.unsafe(nil), properties = T.unsafe(nil)); end
-
-  def +(array); end
-  def <<(element); end
-  def ==(other); end
-  def append(element); end
-  def children; end
-  def clone; end
-  def concat(array); end
-  def deconstruct; end
-  def dup; end
-  def eql?(other); end
-  def hash; end
-  def inspect(indent = T.unsafe(nil)); end
-  def to_a; end
-  def to_ast; end
-  def to_s(indent = T.unsafe(nil)); end
-  def to_sexp(indent = T.unsafe(nil)); end
-  def to_sexp_array; end
-  def type; end
-  def updated(type = T.unsafe(nil), children = T.unsafe(nil), properties = T.unsafe(nil)); end
-
-  protected
-
-  def assign_properties(properties); end
-  def fancy_type; end
-
-  private
-
-  def original_dup; end
-end
-
-class AST::Processor
-  include ::AST::Processor::Mixin
-end
-
-module AST::Processor::Mixin
-  def handler_missing(node); end
-  def process(node); end
-  def process_all(nodes); end
-end
-
-module AST::Sexp
-  def s(type, *children); end
-end