rspec-sidekiq_pro 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0209fc3fe2a82f7cd7355cd0514da771926c8557b68fd4ea23680d0b5cc95e6
-  data.tar.gz: bea903392cd28942099eb2b70e6ee0111df93842c569d7a5ccba113e4e9fdb4f
+  metadata.gz: 2cd253da9eb5bb4e1bbb68a9bf9c2453f200e2743120b1730f82bc9c51c346ab
+  data.tar.gz: 63e909c970b1f4d29d1334f14b721a9c12478ca02cfef5d829d5046cea1ba733
 SHA512:
-  metadata.gz: fddfe519ba229d75f3c6bcd1f1a68eade0e7c23babb04ebe377484a3704857bb47feb12d6f9de213cdf0fe9a037b874bfb78692c5a69359f5cf270bb0a28f020
-  data.tar.gz: f1177195cf806d86619f027255619fdd5b47f370aba696a4d3931cccf8498197f758895c7fb7cee1a10320fe5cea94d48cc7e044a7250d9a767bcfd5252c0d2a
+  metadata.gz: ec44fdba876447f815815d3f9bf510876aca1be41fe0324102fff0828285d3a9b214825c9c79966b342e42e4d109c2487052d33aa1cd99c0fff69c34253a5dc0
+  data.tar.gz: c2692d557e4d997d3c17b895b7db57ca841b729bb643bbd2e1b8dfe3af410a80f959aee8db786e81d3787d282ec2f5a04a3f9dc5ac401bacf29fee08b3352d6a

data/README.md

@@ -1,8 +1,9 @@
-# Rspec for Sidekiq Pro
+# RSpec for Sidekiq Pro
 
 [![Gem Version](https://badge.fury.io/rb/rspec-sidekiq_pro.svg)](https://rubygems.org/gems/rspec-sidekiq_pro)
 [![CI Status](https://github.com/inkstak/rspec-sidekiq_pro/actions/workflows/ci.yml/badge.svg)](https://github.com/inkstak/rspec-sidekiq_pro/actions/workflows/ci.yml)
-[![Maintainability](https://api.codeclimate.com/v1/badges/9bb8b75ea8c66b1a9c94/maintainability)](https://codeclimate.com/github/inkstak/rspec-sidekiq_pro/maintainability)
+[![Ruby Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://github.com/testdouble/standard)
+[![Maintainability](https://api.codeclimate.com/v1/badges/3de8ad4b1787cdb9ca20/maintainability)](https://codeclimate.com/github/inkstak/rspec-sidekiq_pro/maintainability)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/3de8ad4b1787cdb9ca20/test_coverage)](https://codeclimate.com/github/inkstak/rspec-sidekiq_pro/test_coverage)
 
 ### Installation
@@ -191,9 +192,10 @@ end
 ```bash
 bundle exec rspec
 bundle exec rubocop
+bundle exec standardrb
 ```
 
-Both can be run with:
+All of them can be run with:
 
 ```bash
 bundle exec rake

data/lib/rspec/sidekiq_pro/batches.rb

@@ -86,15 +86,15 @@ module Sidekiq
       if Sidekiq::Testing.disabled?
         super
       else
-        @bid  = bid || SecureRandom.urlsafe_base64(10)
+        @bid = bid || SecureRandom.urlsafe_base64(10)
         props = RSpec::SidekiqPro::Batches::Props.fetch(bid, {})
 
-        @created_at  = props.fetch("created_at", Time.now.utc).to_f
+        @created_at = props.fetch("created_at", Time.now.utc).to_f
         @description = props["description"]
-        @parent_bid  = props["parent"]
-        @callbacks   = props.fetch("callbacks", {})
-        @jids        = props.fetch("jids", [])
-        @mutable     = props.empty?
+        @parent_bid = props["parent"]
+        @callbacks = props.fetch("callbacks", {})
+        @jids = props.fetch("jids", [])
+        @mutable = props.empty?
       end
     end
 
@@ -179,8 +179,8 @@ module Sidekiq
         callback.each do |target, options|
           klass_name, method = target.to_s.split("#")
           klass = klass_name.constantize
-          meth  = method || "on_#{event}"
-          inst  = klass.new
+          meth = method || "on_#{event}"
+          inst = klass.new
           inst.jid = SecureRandom.hex(12) if inst.respond_to?(:jid)
           inst.send(meth, status, options)
         end
@@ -192,11 +192,11 @@ module Sidekiq
         if Sidekiq::Testing.disabled?
           super
         else
-          @bid      = bid
-          @props    = RSpec::SidekiqPro::Batches::Props.fetch(bid, {})
-          @pending  = 0
+          @bid = bid
+          @props = RSpec::SidekiqPro::Batches::Props.fetch(bid, {})
+          @pending = 0
           @failures = 0
-          @total    = @props.fetch("jids", []).size
+          @total = @props.fetch("jids", []).size
         end
       end
     end

data/lib/rspec/sidekiq_pro/matchers/job_matcher.rb

@@ -20,7 +20,6 @@ module RSpec
           if block
             raise ArgumentError, "setting block to `with` is not supported for this matcher" if supports_value_expectations?
             raise ArgumentError, "setting arguments and block together in `with` is not supported" if expected_arguments.any?
-
             @expected_arguments = block
           else
             @expected_arguments = normalize_arguments(expected_arguments)
@@ -41,7 +40,7 @@ module RSpec
           raise "setting expecations with both `at` and `in` is not supported" if @expected_interval
 
           @expected_timestamp = timestamp
-          @expected_schedule  = timestamp.to_i
+          @expected_schedule = timestamp.to_i
           self
         end
 
@@ -85,7 +84,7 @@ module RSpec
         end
 
         def matches?(jobs)
-          @actual_jobs  = jobs
+          @actual_jobs = jobs
           filtered_jobs = filter_jobs(actual_jobs)
 
           if expected_count
@@ -96,7 +95,7 @@ module RSpec
         end
 
         def does_not_match?(jobs)
-          @actual_jobs  = jobs
+          @actual_jobs = jobs
           filtered_jobs = filter_jobs(actual_jobs)
 
           if expected_count
@@ -135,45 +134,66 @@ module RSpec
         end
 
         def failure_message_diff
-          diff = []
-          diff << "  exactly:   #{expected_count} time(s)"       if expected_count
-          diff << "  arguments: #{expected_arguments}"           if expected_arguments
-          diff << "  in:        #{expected_interval_output}"     if expected_interval
-          diff << "  at:        #{expected_timestamp}"           if expected_timestamp
-          diff << "  batch:     #{output_batch(expected_batch)}" if expected_batch
-          diff << "  batch:     no batch"                        if expected_without_batch
-          diff << "" if diff.any?
+          message = []
+          message += expectations_in_failure_message
+          message << "" if message.any?
+          message << actual_jobs_size_in_failure_message
+
+          if expected_arguments || expected_schedule || expected_without_batch || expected_batch
+            message[-1] = "#{message[-1]}:"
+            message += actual_jobs_details_in_failure_message
+          end
+
+          message.join("\n")
+        end
 
+        def actual_jobs_size_in_failure_message
           if actual_jobs.empty?
-            diff << "no #{worker_class} found"
-          elsif !expected_arguments && !expected_schedule && !expected_without_batch && !expected_batch
-            diff << "found #{actual_jobs.size} #{worker_class}"
+            "no #{worker_class} found"
           else
-            diff << "found #{actual_jobs.size} #{worker_class}:"
-
-            actual_jobs.each do |job|
-              job_message = []
-              job_message << "arguments: #{job["args"]}"                if expected_arguments
-              job_message << "at:        #{output_schedule(job["at"])}" if expected_schedule && job["at"]
-              job_message << "at:        no schedule"                   if expected_schedule && !job["at"]
-              job_message << "batch:     #{output_batch(job["bid"])}"   if (expected_without_batch || expected_batch) && job["bid"]
-              job_message << "batch:     no batch"                      if (expected_without_batch || expected_batch) && !job["bid"]
-
-              diff += job_message.map.with_index do |line, index|
-                if actual_jobs.size == 1
-                  "  #{line}"
-                elsif index.zero?
-                  "  - #{line}"
-                else
-                  "    #{line}"
-                end
+            "found #{actual_jobs.size} #{worker_class}"
+          end
+        end
+
+        # rubocop:disable Layout/ExtraSpacing
+        # It becomes unreadable when not allowing alignement
+        def expectations_in_failure_message
+          message = []
+          message << "  exactly:   #{expected_count} time(s)"       if expected_count
+          message << "  arguments: #{expected_arguments}"           if expected_arguments
+          message << "  in:        #{expected_interval_output}"     if expected_interval
+          message << "  at:        #{expected_timestamp}"           if expected_timestamp
+          message << "  batch:     #{output_batch(expected_batch)}" if expected_batch
+          message << "  batch:     no batch"                        if expected_without_batch
+          message
+        end
+
+        def job_details_in_failure_message(job)
+          message = []
+          message << "  arguments: #{job["args"]}"                if expected_arguments
+          message << "  at:        #{output_schedule(job["at"])}" if expected_schedule && job["at"]
+          message << "  at:        no schedule"                   if expected_schedule && !job["at"]
+          message << "  batch:     #{output_batch(job["bid"])}"   if (expected_without_batch || expected_batch) && job["bid"]
+          message << "  batch:     no batch"                      if (expected_without_batch || expected_batch) && !job["bid"]
+          message
+        end
+
+        def actual_jobs_details_in_failure_message
+          actual_jobs.flat_map do |job|
+            job_details_in_failure_message(job).map.with_index do |line, index|
+              if actual_jobs.size > 1
+                indent = "    "
+                indent = "  - " if index.zero?
+                line = "#{indent}#{line[2..]}"
               end
+
+              line
             end
           end
-
-          diff.join("\n")
         end
 
+        # rubocop:enable Layout/ExtraSpacing
+
         def expected_interval_output
           "#{expected_interval.inspect} (#{output_schedule(expected_schedule)})"
         end
@@ -184,9 +204,12 @@ module RSpec
 
         def output_batch(value)
           case value
-          when :__undef__     then "to be present"
-          when String         then "<Sidekiq::Batch bid: #{value.inspect}>"
-          when Sidekiq::Batch then "<Sidekiq::Batch bid: #{value.bid.inspect}>"
+          when :__undef__
+            "to be present"
+          when String
+            "<Sidekiq::Batch bid: #{value.inspect}>"
+          when Sidekiq::Batch
+            "<Sidekiq::Batch bid: #{value.bid.inspect}>"
           else
             if value.respond_to?(:description)
               value.description
@@ -213,10 +236,8 @@ module RSpec
             !bid.nil?
           when String
             expected_batch == bid
-
           when ::Sidekiq::Batch
             expected_batch.bid == bid
-
           else
             return unless bid
 

data/lib/rspec/sidekiq_pro/version.rb

@@ -2,6 +2,6 @@
 
 module RSpec
   module SidekiqPro
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-sidekiq_pro
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Savater Sebastien
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-22 00:00:00.000000000 Z
+date: 2022-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -48,30 +48,56 @@ dependencies:
   name: sidekiq
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.5'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.5'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: sidekiq-pro
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.5'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.5'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8'
+- !ruby/object:Gem::Dependency
+  name: zeitwerk
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
 description:
 email: github.60k5k@simplelogin.co
 executables: []
@@ -106,7 +132,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: A collection of tools and matchers for Sidekiq Pro