rspec-sidekiq 4.1.0 → 4.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4f0ece401056914cf478dc4657d19aad569156ebf40ee29ee85c36fc430cfc3
-  data.tar.gz: 858c2c49ae54497a5201eab4cb3d9179fbe21a1684b11663719dfd17dd198cb2
+  metadata.gz: 545725855a34595908bcd584dfcee30045ad1519fbd8295bf5fbf6aed7fdd254
+  data.tar.gz: 26905978185b4e101e0f3d40b2318c0c47143d92a4a762286e5951be92942824
 SHA512:
-  metadata.gz: 831dfa10d07623e001f2253072b6d8e5311a0d887661421ba3eb914fce8f5020b73e5c7bda02264ebf4be6b6f23c2b02f8082a149d7ff5836895525ae61d697c
-  data.tar.gz: fda99d4e3bd9b43fb55ed60e96f77fd0ca54156bc6dcc42df3f1d2fb9323fff9fc63f5495a595766e937d0214fff10736ef18b9b468fccf4b97b91b2aae5e296
+  metadata.gz: 2f9c854985b82b12fdcd32fa0a3ec68185e1ad22ebc554f3f1e7a4b0d29d1c399706e31eef4155de6805fe61628c670a91634386eb05cf9de6762693369f3276
+  data.tar.gz: a0033e0cd3b6a6e03f5042dd04931393e87806adca9f7e78cd3bf034c2018cf89da309826e78e7a067e5a5950e86ff3aef79a2e55bb6ede116a37392000123fa

data/CHANGES.md

@@ -1,3 +1,11 @@
+Unreleased
+---
+
+4.2.0
+---
+* Add warning about `have_enqueued_sidekiq_job` with no arguments (default will
+  change in next major release) (#216, #217)
+
 4.1.0
 ---
 * Add Composable support to `enqueue_sidekiq_job` and

data/lib/rspec/sidekiq/configuration.rb

@@ -1,4 +1,5 @@
 require "rubygems"
+require "set"
 
 module RSpec
   module Sidekiq
@@ -14,11 +15,20 @@ module RSpec
         # Functional settings defaults
         @clear_all_enqueued_jobs = true
         @warn_when_jobs_not_processed_by_sidekiq = true
+        @silence_warnings = Set.new
       end
 
       def sidekiq_gte_7?
         Gem::Version.new(::Sidekiq::VERSION) >= Gem::Version.new("7.0.0")
       end
+
+      def silence_warning(symbol)
+        @silence_warnings << symbol
+      end
+
+      def warn_for?(symbol)
+        !@silence_warnings.include?(symbol)
+      end
     end
   end
 end

data/lib/rspec/sidekiq/matchers/have_enqueued_sidekiq_job.rb

@@ -7,8 +7,18 @@ module RSpec
 
       # @api private
       class HaveEnqueuedSidekiqJob < Base
+        DEPRECATION = [
+          "[WARNING] `have_enqueued_sidekiq_job()` without arguments default behavior will change in next major release.",
+          "Use `have_enqueued_sidekiq_job(no_args)` to maintain legacy behavior.",
+          "More available here: https://github.com/wspurgin/rspec-sidekiq/wiki/have_enqueued_sidekiq_job-without-argument-default-behavior"
+        ].join(" ").freeze
+
         def initialize(expected_arguments)
           super()
+
+          if expected_arguments == [] && RSpec::Sidekiq.configuration.warn_for?(:have_enqueued_sidekiq_job_default)
+            Kernel.warn(DEPRECATION, uplevel: 3)
+          end
           @expected_arguments = normalize_arguments(expected_arguments)
         end
 
@@ -16,7 +26,6 @@ module RSpec
           @klass = job_class
 
           @actual_jobs = EnqueuedJobs.new(klass)
-
           actual_jobs.includes?(expected_arguments, expected_options)
         end
       end

data/lib/rspec/sidekiq/matchers.rb

@@ -1,4 +1,5 @@
 require "rspec/core"
+require "rspec/matchers"
 require "rspec/mocks/argument_list_matcher"
 require "rspec/mocks/argument_matchers"
 

data/lib/rspec/sidekiq/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module Sidekiq
-    VERSION = "4.1.0"
+    VERSION = "4.2.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-sidekiq
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.2.0
 platform: ruby
 authors:
 - Aidan Coyle
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-27 00:00:00.000000000 Z
+date: 2024-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core