rspec-rails 7.0.1 → 7.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5f52b2377b281190553090f208b2d03f030aefb03395fb46afd8af1c63df3a1
-  data.tar.gz: 1a7c088f8ee631d5f9756277724554ccc30247719849a1dd0b6d03bfd8279e11
+  metadata.gz: 725cbfd52d9f763648a595bba0a46d7c0905548e04b988f7c451a0b23ec5e283
+  data.tar.gz: ae2f038303eca35e63674c059e4ebe3b3788c47e52bd397ed67c5b857b8f2e19
 SHA512:
-  metadata.gz: 5dbf49c52a590a8ce6d91ced03bfc78ebeb4737b8cfcc11932e8959b38c0428eca4414da31a82172ca965db65fed36e490e8c85e761f1fed0f2ef555b9b75210
-  data.tar.gz: c47326924297943c4d0704f3da54f8ef13a849a73d3a023405cf290347698c0b486a8c692a8774cc022bbf92a80c424197bca1d44a1cd46c1a613cb0ffca3e79
+  metadata.gz: 3949cffce869076c1b3d84806c76ce5c609b8ae7cc5cd906b44ed09d8df3be4c7d7603c4a2d0430d2337fe7d828b8879025bf32fcacecbb2da010f2108949479
+  data.tar.gz: 0a9c1d5d4968a49d52d6d68078761241431a28c8e2f023d3228536839c7a550d637996b050fbc771f475cc2b3951f0846be429a31fba9d124138f3d8b67d66e3

data/Changelog.md

@@ -1,5 +1,25 @@
 ### Development
-[Full Changelog](https://github.com/rspec/rspec-rails/compare/v7.0.1...7-0-maintenance)
+[Full Changelog](https://github.com/rspec/rspec-rails/compare/v7.1.0...7-1-maintenance)
+
+### 7.1.0 / 2024-11-09
+[Full Changelog](https://github.com/rspec/rspec-rails/compare/v7.0.2...v7.1.0)
+
+Enhancements:
+
+* Improve implicit description for ActionCable matchers `have_broadcasted_to` /
+  `have_broadcast`. (Simon Fish, #2795)
+* Comment out `infer_spec_type_from_file_location!` in newly generated
+  `rails_helper.rb` files. (Jon Rowe, #2804)
+* Allow turning off active job / mailer argument validation.
+  (Oli Peate, #2808)
+
+### 7.0.2 / 2024-11-09
+[Full Changelog](https://github.com/rspec/rspec-rails/compare/v7.0.1...v7.0.2)
+
+Bug Fixes:
+
+* Fix issue with `have_enqueued_mail` when jobs were incorrectly matched due
+  to refactoring in #2780. (David Runger, #2793)
 
 ### 7.0.1 / 2024-09-03
 [Full Changelog](https://github.com/rspec/rspec-rails/compare/v7.0.0...v7.0.1)
@@ -19,7 +39,7 @@ Enhancements:
 * Change default driver for system specs on Rails 7.2 to match its default.
   (Steve Polito, #2746)
 * Verify ActiveJob arguments by comparing to the method signature. (Oli Peate, #2745)
-* Add suggestion to rails_helper.rb to skip when not in test most. (Glauco Custódio, #2751)
+* Add suggestion to rails_helper.rb to skip when not in test mode. (Glauco Custódio, #2751)
 * Add `at_priority` qualifier to `have_enqueued_job` set of matchers. (mbajur, #2759)
 * Add spec directories to `rails stats` on Rails main / 8.0.0. (Petrik de Heus, #2781)
 

data/README.md

@@ -10,7 +10,7 @@ expressed in plain English.
 
 According to [RSpec Rails new versioning strategy][] use:
 * **[`rspec-rails` 7.x][]** for Rails 7.x.
-* **[`rspec-rails` 6.x][]** for Rails 6.1.
+* **[`rspec-rails` 6.x][]** for Rails 6.1, 7.0 or 7.1.
 * **[`rspec-rails` 5.x][]** for Rails 5.2 or 6.x.
 * **[`rspec-rails` 4.x][]** for Rails from 5.x or 6.x.
 * **[`rspec-rails` 3.x][]** for Rails earlier than 5.0.
@@ -32,7 +32,7 @@ According to [RSpec Rails new versioning strategy][] use:
 
 ## Installation
 
-**IMPORTANT** This README / branch refers to the 7.0.x stable release series, only bugfixes from this series will
+**IMPORTANT** This README / branch refers to the 7.1.x stable release series, only bugfixes from this series will
 be added here. See the [`main` branch on Github](https://github.com/rspec/rspec-rails/tree/main) if you want or
 require the latest unstable features.
 

data/lib/generators/rspec/install/templates/spec/rails_helper.rb

@@ -67,20 +67,22 @@ RSpec.configure do |config|
   # config.use_transactional_fixtures = true
 
 <% end -%>
-  # RSpec Rails can automatically mix in different behaviours to your tests
-  # based on their file location, for example enabling you to call `get` and
-  # `post` in specs under `spec/controllers`.
+  # RSpec Rails uses metadata to mix in different behaviours to your tests,
+  # for example enabling you to call `get` and `post` in request specs. e.g.:
   #
-  # You can disable this behaviour by removing the line below, and instead
-  # explicitly tag your specs with their type, e.g.:
-  #
-  #     RSpec.describe UsersController, type: :controller do
+  #     RSpec.describe UsersController, type: :request do
   #       # ...
   #     end
   #
   # The different available types are documented in the features, such as in
   # https://rspec.info/features/7-0/rspec-rails
-  config.infer_spec_type_from_file_location!
+  #
+  # You can also this infer these behaviours automatically by location, e.g.
+  # /spec/models would pull in the same behaviour as `type: :model` but this
+  # behaviour is considered legacy and will be removed in a future version.
+  #
+  # To enable this behaviour uncomment the line below.
+  # config.infer_spec_type_from_file_location!
 
   # Filter lines from Rails gems in backtraces.
   config.filter_rails_from_backtrace!

data/lib/rspec/rails/matchers/action_cable/have_broadcasted_to.rb

@@ -51,6 +51,10 @@ module RSpec
             exactly(:thrice)
           end
 
+          def description
+            "have broadcasted #{base_description}"
+          end
+
           def failure_message
             "expected to broadcast #{base_message}".tap do |msg|
               if @unmatching_msgs.any?
@@ -140,18 +144,21 @@ module RSpec
               end
           end
 
-          def base_message
+          def base_description
             "#{message_expectation_modifier} #{@expected_number} messages to #{stream}".tap do |msg|
               msg << " with #{data_description(@data)}" unless @data.nil?
-              msg << ", but broadcast #{@matching_msgs_count}"
             end
           end
 
+          def base_message
+            "#{base_description}, but broadcast #{@matching_msgs_count}"
+          end
+
           def data_description(data)
             if data.is_a?(RSpec::Matchers::Composable)
               data.description
             else
-              data
+              data.inspect
             end
           end
 

data/lib/rspec/rails/matchers/action_cable.rb

@@ -3,6 +3,8 @@ require "rspec/rails/matchers/action_cable/have_broadcasted_to"
 module RSpec
   module Rails
     module Matchers
+      extend RSpec::Matchers::DSL
+
       # Namespace for various implementations of ActionCable features
       #
       # @api private
@@ -50,7 +52,10 @@ module RSpec
 
         ActionCable::HaveBroadcastedTo.new(target, channel: described_class)
       end
-      alias_method :broadcast_to, :have_broadcasted_to
+
+      alias_matcher :broadcast_to, :have_broadcasted_to do |desc|
+        desc.gsub("have broadcasted", "broadcast")
+      end
 
     private
 

data/lib/rspec/rails/matchers/active_job.rb

@@ -178,6 +178,8 @@ module RSpec
           end
 
           def detect_args_signature_mismatch(jobs)
+            return if skip_signature_verification?
+
             jobs.each do |job|
               args = deserialize_arguments(job)
 
@@ -189,6 +191,11 @@ module RSpec
             nil
           end
 
+          def skip_signature_verification?
+            !RSpec::Mocks.configuration.verify_partial_doubles? ||
+              RSpec::Mocks.configuration.temporarily_suppress_partial_double_verification
+          end
+
           def check_args_signature_mismatch(job_class, job_method, args)
             signature = Support::MethodSignature.new(job_class.public_instance_method(job_method))
             verifier = Support::StrictSignatureVerifier.new(signature, args)

data/lib/rspec/rails/matchers/have_enqueued_mail.rb

@@ -72,7 +72,7 @@ module RSpec
           @mailer_class ? @mailer_class.name : 'ActionMailer::Base'
         end
 
-        def job_match?(job)
+        def job_matches?(job)
           legacy_mail?(job) || parameterized_mail?(job) || unified_mail?(job)
         end
 
@@ -93,6 +93,7 @@ module RSpec
 
         def detect_args_signature_mismatch(jobs)
           return if @method_name.nil?
+          return if skip_signature_verification?
 
           mailer_class = mailer_class_name.constantize
 
@@ -123,7 +124,7 @@ module RSpec
 
         def unmatching_mail_jobs
           @unmatching_jobs.select do |job|
-            job_match?(job)
+            job_matches?(job)
           end
         end
 

data/lib/rspec/rails/version.rb

@@ -3,7 +3,7 @@ module RSpec
     # Version information for RSpec Rails.
     module Version
       # Current version of RSpec Rails, in semantic versioning format.
-      STRING = '7.0.1'
+      STRING = '7.1.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-rails
 version: !ruby/object:Gem::Version
-  version: 7.0.1
+  version: 7.1.0
 platform: ruby
 authors:
 - David Chelimsky
@@ -44,7 +44,7 @@ cert_chain:
   ZsVDj6a7lH3cNqtWXZxrb2wO38qV5AkYj8SQK7Hj3/Yui9myUX3crr+PdetazSqQ
   F3MdtaDehhjC
   -----END CERTIFICATE-----
-date: 2024-09-03 00:00:00.000000000 Z
+date: 2024-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -296,7 +296,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rspec/rspec-rails/issues
-  changelog_uri: https://github.com/rspec/rspec-rails/blob/v7.0.1/Changelog.md
+  changelog_uri: https://github.com/rspec/rspec-rails/blob/v7.1.0/Changelog.md
   documentation_uri: https://rspec.info/documentation/
   mailing_list_uri: https://groups.google.com/forum/#!forum/rspec
   source_code_uri: https://github.com/rspec/rspec-rails
@@ -316,7 +316,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: RSpec for Rails