rspec-rails 3.0.0.beta1 → 3.0.0.beta2

data/spec/generators/rspec/observer/observer_generator_spec.rb

@@ -14,8 +14,8 @@ describe Rspec::Generators::ObserverGenerator do
   end
 
   describe 'the spec' do
-    it { should exist }
-    it { should contain(/require 'spec_helper'/) }
-    it { should contain(/describe PostsObserver/) }
+    it { is_expected.to exist }
+    it { is_expected.to contain(/require 'spec_helper'/) }
+    it { is_expected.to contain(/describe PostsObserver/) }
   end
 end

data/spec/generators/rspec/scaffold/scaffold_generator_spec.rb

@@ -12,14 +12,14 @@ describe Rspec::Generators::ScaffoldGenerator do
 
     describe 'with no options' do
       before { run_generator %w(posts) }
-      it { should contain(/require 'spec_helper'/) }
-      it { should contain(/describe PostsController/) }
-      it { should contain(%({ "these" => "params" })) }
+      it { is_expected.to contain(/require 'spec_helper'/) }
+      it { is_expected.to contain(/describe PostsController/) }
+      it { is_expected.to contain(%({ "these" => "params" })) }
     end
 
     describe 'with --no-controller_specs' do
       before { run_generator %w(posts --no-controller_specs) }
-      it { should_not exist }
+      it { is_expected.not_to exist }
     end
   end
 
@@ -27,13 +27,13 @@ describe Rspec::Generators::ScaffoldGenerator do
     subject { file('spec/controllers/posts_controller_spec.rb') }
     before { run_generator %w(posts title:string) }
 
-    it { should contain(%({ "title" => "MyString" })) }
+    it { is_expected.to contain(%({ "title" => "MyString" })) }
   end
 
   describe 'namespaced controller spec' do
     subject { file('spec/controllers/admin/posts_controller_spec.rb') }
     before  { run_generator %w(admin/posts) }
-    it { should contain(/describe Admin::PostsController/)}
+    it { is_expected.to contain(/describe Admin::PostsController/)}
   end
 
   describe 'view specs' do
@@ -41,34 +41,34 @@ describe Rspec::Generators::ScaffoldGenerator do
       before { run_generator %w(posts) }
       describe 'edit' do
         subject { file("spec/views/posts/edit.html.erb_spec.rb") }
-        it { should exist }
-        it { should contain(/require 'spec_helper'/) }
-        it { should contain(/describe "(.*)\/edit"/) }
-        it { should contain(/it "renders the edit (.*) form"/) }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/require 'spec_helper'/) }
+        it { is_expected.to contain(/describe "(.*)\/edit"/) }
+        it { is_expected.to contain(/it "renders the edit (.*) form"/) }
       end
 
       describe 'index' do
         subject { file("spec/views/posts/index.html.erb_spec.rb") }
-        it { should exist }
-        it { should contain(/require 'spec_helper'/) }
-        it { should contain(/describe "(.*)\/index"/) }
-        it { should contain(/it "renders a list of (.*)"/) }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/require 'spec_helper'/) }
+        it { is_expected.to contain(/describe "(.*)\/index"/) }
+        it { is_expected.to contain(/it "renders a list of (.*)"/) }
       end
 
       describe 'new' do
         subject { file("spec/views/posts/new.html.erb_spec.rb") }
-        it { should exist }
-        it { should contain(/require 'spec_helper'/) }
-        it { should contain(/describe "(.*)\/new"/) }
-        it { should contain(/it "renders new (.*) form"/) }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/require 'spec_helper'/) }
+        it { is_expected.to contain(/describe "(.*)\/new"/) }
+        it { is_expected.to contain(/it "renders new (.*) form"/) }
       end
 
       describe 'show' do
         subject { file("spec/views/posts/show.html.erb_spec.rb") }
-        it { should exist }
-        it { should contain(/require 'spec_helper'/) }
-        it { should contain(/describe "(.*)\/show"/) }
-        it { should contain(/it "renders attributes in <p>"/) }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/require 'spec_helper'/) }
+        it { is_expected.to contain(/describe "(.*)\/show"/) }
+        it { is_expected.to contain(/it "renders attributes in <p>"/) }
       end
     end
 
@@ -76,22 +76,22 @@ describe Rspec::Generators::ScaffoldGenerator do
       before { run_generator %w(posts --no-template-engine) }
       describe 'edit' do
         subject { file("spec/views/posts/edit.html._spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
 
       describe 'index' do
         subject { file("spec/views/posts/index.html._spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
 
       describe 'new' do
         subject { file("spec/views/posts/new.html._spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
 
       describe 'show' do
         subject { file("spec/views/posts/show.html._spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
     end
 
@@ -100,22 +100,22 @@ describe Rspec::Generators::ScaffoldGenerator do
 
       describe 'edit' do
         subject { file("spec/views/posts/edit.html.erb_spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
 
       describe 'index' do
         subject { file("spec/views/posts/index.html.erb_spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
 
       describe 'new' do
         subject { file("spec/views/posts/new.html.erb_spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
 
       describe 'show' do
         subject { file("spec/views/posts/show.html.erb_spec.rb") }
-        it { should_not exist }
+        it { is_expected.not_to exist }
       end
     end
   end
@@ -125,14 +125,14 @@ describe Rspec::Generators::ScaffoldGenerator do
 
     describe 'with default options' do
       before { run_generator %w(posts) }
-      it { should contain(/require "spec_helper"/) }
-      it { should contain(/describe PostsController/) }
-      it { should contain(/describe "routing"/) }
+      it { is_expected.to contain(/require "spec_helper"/) }
+      it { is_expected.to contain(/describe PostsController/) }
+      it { is_expected.to contain(/describe "routing"/) }
     end
 
     describe 'with --no-routing-specs' do
       before { run_generator %w(posts --no-routing_specs) }
-      it { should_not exist }
+      it { is_expected.not_to exist }
     end
   end
 end

data/spec/generators/rspec/view/view_generator_spec.rb

@@ -13,8 +13,8 @@ describe Rspec::Generators::ViewGenerator do
     it 'generates a spec for the supplied action' do
       run_generator %w(posts index)
       file('spec/views/posts/index.html.erb_spec.rb').tap do |f|
-        f.should contain(/require 'spec_helper'/)
-        f.should contain(/describe "posts\/index"/)
+        expect(f).to contain(/require 'spec_helper'/)
+        expect(f).to contain(/describe "posts\/index"/)
       end
     end
 
@@ -22,8 +22,8 @@ describe Rspec::Generators::ViewGenerator do
       it 'generates a spec for the supplied action' do
         run_generator %w(admin/posts index)
         file('spec/views/admin/posts/index.html.erb_spec.rb').tap do |f|
-          f.should contain(/require 'spec_helper'/)
-          f.should contain(/describe "admin\/posts\/index"/)
+          expect(f).to contain(/require 'spec_helper'/)
+          expect(f).to contain(/describe "admin\/posts\/index"/)
         end
       end
     end
@@ -33,8 +33,8 @@ describe Rspec::Generators::ViewGenerator do
     it 'generates a spec for the supplied action' do
       run_generator %w(posts index --template_engine haml)
       file('spec/views/posts/index.html.haml_spec.rb').tap do |f|
-        f.should contain(/require 'spec_helper'/)
-        f.should contain(/describe "posts\/index"/)
+        expect(f).to contain(/require 'spec_helper'/)
+        expect(f).to contain(/describe "posts\/index"/)
       end
     end
   end

data/spec/rspec/rails/assertion_adapter_spec.rb

@@ -13,16 +13,16 @@ describe RSpec::Rails::MinitestAssertionAdapter do
       end
     else
       it "exposes #{m} to host examples" do
-        methods.should include(m)
+        expect(methods).to include(m)
       end
     end
   end
 
   it "does not expose internal methods of Minitest" do
-    methods.should_not include("_assertions")
+    expect(methods).not_to include("_assertions")
   end
 
   it "does not expose Minitest's message method" do
-    methods.should_not include("message")
+    expect(methods).not_to include("message")
   end
 end

data/spec/rspec/rails/configuration_spec.rb

@@ -11,7 +11,7 @@ describe "configuration" do
 
   describe "#render_views?" do
     it "is false by default" do
-      RSpec.configuration.render_views?.should be_falsey
+      expect(RSpec.configuration.render_views?).to be_falsey
     end
   end
 
@@ -20,7 +20,7 @@ describe "configuration" do
       RSpec.configuration.render_views = false
       RSpec.configuration.render_views
 
-      RSpec.configuration.render_views?.should be_truthy
+      expect(RSpec.configuration.render_views?).to be_truthy
     end
   end
 end

data/spec/rspec/rails/deprecations_spec.rb

@@ -10,7 +10,7 @@ describe "rspec-rails-2 deprecations" do
       end
 
       it "is deprecated" do
-        RSpec.should_receive(:deprecate)
+        expect(RSpec).to receive(:deprecate)
         group.integrate_views
       end
     end

data/spec/rspec/rails/example/controller_example_group_spec.rb

@@ -1,12 +1,13 @@
 require "spec_helper"
 
 class ::ApplicationController
+  def self.abstract?; false; end
 end
 
 module RSpec::Rails
   describe ControllerExampleGroup do
-    it { should be_included_in_files_in('./spec/controllers/') }
-    it { should be_included_in_files_in('.\\spec\\controllers\\') }
+    it { is_expected.to be_included_in_files_in('./spec/controllers/') }
+    it { is_expected.to be_included_in_files_in('.\\spec\\controllers\\') }
 
     let(:group) do
       RSpec::Core::ExampleGroup.describe do
@@ -15,19 +16,19 @@ module RSpec::Rails
     end
 
     it "includes routing matchers" do
-      group.included_modules.should include(RSpec::Rails::Matchers::RoutingMatchers)
+      expect(group.included_modules).to include(RSpec::Rails::Matchers::RoutingMatchers)
     end
 
     it "adds :type => :controller to the metadata" do
-      group.metadata[:type].should eq(:controller)
+      expect(group.metadata[:type]).to eq(:controller)
     end
 
     context "with implicit subject" do
       it "uses the controller as the subject" do
         controller = double('controller')
         example = group.new
-        example.stub(:controller => controller)
-        example.subject.should == controller
+        allow(example).to receive_messages(:controller => controller)
+        expect(example.subject).to eq(controller)
       end
     end
 
@@ -35,7 +36,7 @@ module RSpec::Rails
       it "uses the specified subject instead of the controller" do
         group.subject { 'explicit' }
         example = group.new
-        example.subject.should == 'explicit'
+        expect(example.subject).to eq('explicit')
       end
     end
 
@@ -48,10 +49,10 @@ module RSpec::Rails
 
       it "delegates named route helpers to the underlying controller" do
         controller = double('controller')
-        controller.stub(:foos_url).and_return('http://test.host/foos')
+        allow(controller).to receive(:foos_url).and_return('http://test.host/foos')
 
         example = group.new
-        example.stub(:controller => controller)
+        allow(example).to receive_messages(:controller => controller)
 
         # As in the routing example spec, this is pretty invasive, but not sure
         # how to do it any other way as the correct operation relies on before
@@ -60,7 +61,7 @@ module RSpec::Rails
         routes.draw { resources :foos }
         example.instance_variable_set(:@orig_routes, routes)
 
-        example.foos_url.should eq('http://test.host/foos')
+        expect(example.foos_url).to eq('http://test.host/foos')
       end
     end
 
@@ -77,23 +78,81 @@ module RSpec::Rails
 
     describe "with inferred anonymous controller" do
       before do
-        group.stub(:controller_class).and_return(Class.new)
+        allow(group).to receive(:controller_class).and_return(Class.new)
       end
 
-      it "infers the anonymous controller class when infer_base_class_for_anonymous_controllers is true" do
-        RSpec.configuration.stub(:infer_base_class_for_anonymous_controllers?).and_return(true)
-        group.controller { }
+      it "defaults to inferring anonymous controller class" do
+        expect(RSpec.configuration.infer_base_class_for_anonymous_controllers).to be_truthy
+      end
+
+      context "when infer_base_class_for_anonymous_controllers is true" do
+        before do
+          allow(RSpec.configuration).to receive(:infer_base_class_for_anonymous_controllers?).and_return(true)
+        end
+
+        it "infers the anonymous controller class" do
+          group.controller { }
+
+          controller_class = group.metadata[:example_group][:described_class]
+          expect(controller_class.superclass).to eq(group.controller_class)
+        end
+
+        it "infers the anonymous controller class when no ApplicationController is present" do
+          hide_const '::ApplicationController'
+          group.controller { }
+
+          controller_class = group.metadata[:example_group][:described_class]
+          expect(controller_class.superclass).to eq(group.controller_class)
+        end
+      end
+
+      context "when infer_base_class_for_anonymous_controllers is false" do
+        before do
+          allow(RSpec.configuration).to receive(:infer_base_class_for_anonymous_controllers?).and_return(false)
+        end
 
-        controller_class = group.metadata[:example_group][:described_class]
-        controller_class.superclass.should eq(group.controller_class)
+        it "sets the anonymous controller class to ApplicationController" do
+          group.controller { }
+
+          controller_class = group.metadata[:example_group][:described_class]
+          expect(controller_class.superclass).to eq(ApplicationController)
+        end
+
+        it "sets the anonymous controller class to ActiveController::Base when no ApplicationController is present" do
+          hide_const '::ApplicationController'
+          group.controller { }
+
+          controller_class = group.metadata[:example_group][:described_class]
+          expect(controller_class.superclass).to eq(ActionController::Base)
+        end
       end
+    end
+
+    describe "controller name" do
+      let(:controller_class) { group.metadata[:example_group][:described_class] }
 
-      it "sets the anonymous controller class to ApplicationController when infer_base_class_for_anonymous_controllers is false" do
-        RSpec.configuration.stub(:infer_base_class_for_anonymous_controllers?).and_return(false)
+      it "sets the name as AnonymousController if it's anonymous" do
         group.controller { }
+        expect(controller_class.name).to eq "AnonymousController"
+      end
+
+      it "sets the name according to defined controller if it is not anonymous" do
+        stub_const "FoosController", Class.new(::ApplicationController)
+        group.controller(FoosController) { }
+        expect(controller_class.name).to eq "FoosController"
+      end
+
+      it "sets name as AnonymousController if defined as ApplicationController" do
+        group.controller(ApplicationController) { }
+        expect(controller_class.name).to eq "AnonymousController"
+      end
+
+      it "sets name as AnonymousController the controller is abstract" do
+        abstract_controller = Class.new(::ApplicationController)
+        def abstract_controller.abstract?; true; end
 
-        controller_class = group.metadata[:example_group][:described_class]
-        controller_class.superclass.should eq(ApplicationController)
+        group.controller(abstract_controller) { }
+        expect(controller_class.name).to eq "AnonymousController"
       end
     end
   end

data/spec/rspec/rails/example/feature_example_group_spec.rb

@@ -2,8 +2,8 @@ require "spec_helper"
 
 module RSpec::Rails
   describe FeatureExampleGroup do
-    it { should be_included_in_files_in('./spec/features/') }
-    it { should be_included_in_files_in('.\\spec\\features\\') }
+    it { is_expected.to be_included_in_files_in('./spec/features/') }
+    it { is_expected.to be_included_in_files_in('.\\spec\\features\\') }
 
     it "adds :type => :feature to the metadata" do
       group = RSpec::Core::ExampleGroup.describe do

data/spec/rspec/rails/example/helper_example_group_spec.rb

@@ -5,32 +5,32 @@ module RSpec::Rails
     module ::FoosHelper; end
     subject { HelperExampleGroup }
 
-    it { should be_included_in_files_in('./spec/helpers/') }
-    it { should be_included_in_files_in('.\\spec\\helpers\\') }
+    it { is_expected.to be_included_in_files_in('./spec/helpers/') }
+    it { is_expected.to be_included_in_files_in('.\\spec\\helpers\\') }
 
     it "provides a controller_path based on the helper module's name" do
       example = double
       example.stub_chain(:example_group, :described_class) { FoosHelper }
 
       helper_spec = Object.new.extend HelperExampleGroup
-      helper_spec.__send__(:_controller_path, example).should == "foos"
+      expect(helper_spec.__send__(:_controller_path, example)).to eq("foos")
     end
 
     it "adds :type => :helper to the metadata" do
       group = RSpec::Core::ExampleGroup.describe do
         include HelperExampleGroup
       end
-      group.metadata[:type].should eq(:helper)
+      expect(group.metadata[:type]).to eq(:helper)
     end
 
     describe "#helper" do
       it "returns the instance of AV::Base provided by AV::TC::Behavior" do
         helper_spec = Object.new.extend HelperExampleGroup
-        helper_spec.should_receive(:view_assigns)
+        expect(helper_spec).to receive(:view_assigns)
         av_tc_b_view = double('_view')
-        av_tc_b_view.should_receive(:assign)
-        helper_spec.stub(:_view) { av_tc_b_view }
-        helper_spec.helper.should eq(av_tc_b_view)
+        expect(av_tc_b_view).to receive(:assign)
+        allow(helper_spec).to receive(:_view) { av_tc_b_view }
+        expect(helper_spec.helper).to eq(av_tc_b_view)
       end
 
       before do
@@ -48,7 +48,7 @@ module RSpec::Rails
             ActionView::Base.new
           end
         end
-        group.new.helper.should be_kind_of(ApplicationHelper)
+        expect(group.new.helper).to be_kind_of(ApplicationHelper)
       end
     end
   end
@@ -57,9 +57,9 @@ module RSpec::Rails
     describe "determine_default_helper_class" do
       it "returns the helper module passed to describe" do
         helper_spec = Object.new.extend HelperExampleGroup::ClassMethods
-        helper_spec.stub(:described_class) { FoosHelper }
-        helper_spec.determine_default_helper_class("ignore this").
-          should eq(FoosHelper)
+        allow(helper_spec).to receive(:described_class) { FoosHelper }
+        expect(helper_spec.determine_default_helper_class("ignore this")).
+          to eq(FoosHelper)
       end
     end
   end