rspec-rails 2.6.1 → 2.7.0.rc1

data/spec/generators/rspec/install/install_generator_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+require 'generators/rspec/install/install_generator'
+
+describe Rspec::Generators::InstallGenerator do
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  it "generates .rspec" do
+    run_generator
+    file('.rspec').should exist
+  end
+
+  it "generates spec/spec_helper.rb" do
+    run_generator
+    File.read( file('spec/spec_helper.rb') ).should =~ /^require 'rspec\/autorun'$/m
+  end
+end

data/spec/generators/rspec/integration/integration_generator_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/integration/integration_generator'
+
+describe Rspec::Generators::IntegrationGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  describe 'are not generated' do
+    before do
+      run_generator %w(posts --no-request-specs)
+    end
+    describe 'index.html.erb' do
+      subject { file('spec/requests/posts_spec.rb') }
+      it { should_not exist }
+    end
+  end
+
+  describe 'are generated' do
+    describe 'without webrat matchers by default' do
+      before do
+        run_generator %w(posts)
+      end
+      subject { file('spec/requests/posts_spec.rb') }
+      it { should exist }
+      it { should contain /require 'spec_helper'/ }
+      it { should contain /describe "GET \/posts"/ }
+      it { should contain /get posts_index_path/ }
+    end
+    describe 'with webrat matchers' do
+      before do
+        run_generator %w(posts --webrat)
+      end
+      subject { file('spec/requests/posts_spec.rb') }
+      it { should exist }
+      it { should contain /require 'spec_helper'/ }
+      it { should contain /describe "GET \/posts"/ }
+      it { should contain /visit posts_index_path/ }
+    end
+  end
+end

data/spec/generators/rspec/mailer/mailer_generator_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/mailer/mailer_generator'
+
+describe Rspec::Generators::MailerGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  describe 'mailer spec' do
+    subject { file('spec/mailers/posts_spec.rb') }
+    describe 'a spec is created for each action' do
+      before do
+        run_generator %w(posts index show)
+      end
+      it { should exist }
+      it { should contain /require "spec_helper"/ }
+      it { should contain /describe "index" do/ }
+      it { should contain /describe "show" do/ }
+    end
+    describe 'creates placeholder when no actions specified' do
+      before do
+        run_generator %w(posts)
+      end
+      it { should exist }
+      it { should contain /require "spec_helper"/ }
+      it { should contain /pending "add some examples to \(or delete\)/ }
+    end
+  end
+
+  describe 'a fixture is generated for each action' do
+    before do
+      run_generator %w(posts index show)
+    end
+    describe 'index' do
+      subject { file('spec/fixtures/posts/index') }
+      it { should exist }
+      it { should contain /Posts#index/ }
+    end
+    describe 'show' do
+      subject { file('spec/fixtures/posts/show') }
+      it { should exist }
+      it { should contain /Posts#show/ }
+    end
+  end
+end

data/spec/generators/rspec/model/model_generator_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/model/model_generator'
+
+describe Rspec::Generators::ModelGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  it 'should run both the model and fixture tasks' do
+    gen = generator %w(posts)
+    gen.should_receive :create_model_spec
+    gen.should_receive :create_fixture_file
+    capture(:stdout) { gen.invoke_all }
+  end
+
+  describe 'the generated files' do
+    describe 'with fixtures' do
+      before do
+        run_generator %w(posts --fixture)
+      end
+
+      describe 'the spec' do
+        subject { file('spec/models/posts_spec.rb') }
+
+        it { should exist }
+        it { should contain /require 'spec_helper'/ }
+        it { should contain /describe Posts/ }
+      end
+
+      describe 'the fixtures' do
+        subject { file('spec/fixtures/posts.yml') }
+
+        it { should contain Regexp.new '# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html' }
+      end
+    end
+
+    describe 'without fixtures' do
+      before do
+        run_generator %w(posts)
+      end
+
+      describe 'the fixtures' do
+        subject { file('spec/fixtures/posts.yml') }
+
+        it { should_not exist }
+      end
+    end
+  end
+end

data/spec/generators/rspec/observer/observer_generator_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/observer/observer_generator'
+
+describe Rspec::Generators::ObserverGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  subject { file('spec/models/posts_observer_spec.rb') }
+  before do
+    prepare_destination
+    run_generator %w(posts)
+  end
+
+  describe 'the spec' do
+    it { should exist }
+    it { should contain /require 'spec_helper'/ }
+    it { should contain /describe PostsObserver/ }
+  end
+end

data/spec/generators/rspec/scaffold/scaffold_generator_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/scaffold/scaffold_generator'
+
+describe Rspec::Generators::ScaffoldGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  describe 'controller specs' do
+    subject { file('spec/controllers/posts_controller_spec.rb') }
+    describe 'generated by default' do
+      before do
+        run_generator %w(posts)
+      end
+
+      describe 'the spec' do
+        it { should exist }
+        it { should contain /require 'spec_helper'/ }
+        it { should contain /describe PostsController/ }
+      end
+    end
+    describe 'skipped with a flag' do
+      before do
+        run_generator %w(posts --no-controller_specs)
+      end
+      it { should_not exist }
+    end
+  end
+
+  describe 'view specs' do
+    describe 'generated by default' do
+      before do
+        run_generator %w(posts)
+      end
+      describe 'edit' do
+        subject { file("spec/views/posts/edit.html.erb_spec.rb") }
+        it { should exist }
+        it { should contain /require 'spec_helper'/ }
+        it { should contain /describe "(.*)\/edit.html.erb"/ }
+        it { should contain /it "renders the edit (.*) form"/ }
+      end
+      describe 'index' do
+        subject { file("spec/views/posts/index.html.erb_spec.rb") }
+        it { should exist }
+        it { should contain /require 'spec_helper'/ }
+        it { should contain /describe "(.*)\/index.html.erb"/ }
+        it { should contain /it "renders a list of (.*)"/ }
+      end
+      describe 'new' do
+        subject { file("spec/views/posts/new.html.erb_spec.rb") }
+        it { should exist }
+        it { should contain /require 'spec_helper'/ }
+        it { should contain /describe "(.*)\/new.html.erb"/ }
+        it { should contain /it "renders new (.*) form"/ }
+      end
+      describe 'show' do
+        subject { file("spec/views/posts/show.html.erb_spec.rb") }
+        it { should exist }
+        it { should contain /require 'spec_helper'/ }
+        it { should contain /describe "(.*)\/show.html.erb"/ }
+        it { should contain /it "renders attributes in <p>"/ }
+      end
+    end
+
+    describe 'skipped with a flag' do
+      before do
+        run_generator %w(posts --no-view-specs)
+      end
+      describe 'edit' do
+        subject { file("spec/views/posts/edit.html.erb_spec.rb") }
+        it { should_not exist }
+      end
+      describe 'index' do
+        subject { file("spec/views/posts/index.html.erb_spec.rb") }
+        it { should_not exist }
+      end
+      describe 'new' do
+        subject { file("spec/views/posts/new.html.erb_spec.rb") }
+        it { should_not exist }
+      end
+      describe 'show' do
+        subject { file("spec/views/posts/show.html.erb_spec.rb") }
+        it { should_not exist }
+      end
+    end
+  end
+
+  describe 'routing specs' do
+    subject { file('spec/routing/posts_routing_spec.rb') }
+    describe 'generated by default' do
+      before do
+        run_generator %w(posts)
+      end
+
+      describe 'the spec' do
+        it { should exist }
+        it { should contain /require "spec_helper"/ }
+        it { should contain /describe PostsController/ }
+        it { should contain /describe "routing"/ }
+      end
+    end
+    describe 'skipped with a flag' do
+      before do
+        run_generator %w(posts --no-routing_specs)
+      end
+      it { should_not exist }
+    end
+  end
+
+end

data/spec/generators/rspec/view/view_generator_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/view/view_generator'
+
+describe Rspec::Generators::ViewGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  describe 'with default template engine' do
+    it 'generates a spec for the supplied action' do
+      run_generator %w(posts index)
+      file('spec/views/posts/index.html.erb_spec.rb').tap do |f|
+        f.should contain /require 'spec_helper'/
+        f.should contain /describe "posts\/index.html.erb"/
+      end
+    end
+
+    describe 'with a nested resource' do
+      it 'generates a spec for the supplied action' do
+        run_generator %w(admin/posts index)
+        file('spec/views/admin/posts/index.html.erb_spec.rb').tap do |f|
+          f.should contain /require 'spec_helper'/
+          f.should contain /describe "admin\/posts\/index.html.erb"/
+        end
+      end
+    end
+  end
+
+  describe 'haml' do
+    it 'generates a spec for the supplied action' do
+      run_generator %w(posts index --template_engine haml)
+      file('spec/views/posts/index.html.haml_spec.rb').tap do |f|
+        f.should contain /require 'spec_helper'/
+        f.should contain /describe "posts\/index.html.haml"/
+      end
+    end
+  end
+end

data/spec/rspec/rails/example/controller_example_group_spec.rb

@@ -1,5 +1,8 @@
 require "spec_helper"
 
+class ::ApplicationController
+end
+
 module RSpec::Rails
   describe ControllerExampleGroup do
     it { should be_included_in_files_in('./spec/controllers/') }
@@ -28,15 +31,15 @@ module RSpec::Rails
       end
     end
 
-    describe "with explicit subject" do
-      it "should use the specified subject instead of the controller" do
+    context "with explicit subject" do
+      it "uses the specified subject instead of the controller" do
         group.subject { 'explicit' }
         example = group.new
         example.subject.should == 'explicit'
       end
     end
 
-    describe "with anonymous controller" do
+    describe "#controller" do
       before do
         group.class_eval do
           controller(Class.new) { }
@@ -60,5 +63,38 @@ module RSpec::Rails
         example.foos_url.should eq('http://test.host/foos')
       end
     end
+
+    describe "#bypass_rescue" do
+      it "overrides the rescue_with_handler method on the controller to raise submitted error" do
+        example = group.new
+        example.instance_variable_set("@controller", Class.new { def rescue_with_handler(e); end }.new)
+        example.bypass_rescue
+        expect do
+          example.controller.rescue_with_handler(RuntimeError.new("foo"))
+        end.to raise_error("foo")
+      end
+    end
+
+    describe "with inferred anonymous controller" do
+      before do
+        group.stub(:controller_class).and_return(Class.new)
+      end
+
+      it "infers the anonymous controller class when infer_base_class_for_anonymous_controllers is true" do
+        RSpec.configuration.stub(:infer_base_class_for_anonymous_controllers?).and_return(true)
+        group.controller { }
+
+        controller_class = group.metadata[:example_group][:describes]
+        controller_class.superclass.should eq(group.controller_class)
+      end
+
+      it "sets the anonymous controller class to ApplicationController when infer_base_class_for_anonymous_controllers is false" do
+        RSpec.configuration.stub(:infer_base_class_for_anonymous_controllers?).and_return(false)
+        group.controller { }
+
+        controller_class = group.metadata[:example_group][:describes]
+        controller_class.superclass.should eq(ApplicationController)
+      end
+    end
   end
 end

data/spec/rspec/rails/matchers/relation_match_array_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+
+describe "ActiveSupport::Relation =~ matcher" do
+  let!(:models) { Array.new(3) { MockableModel.create } }
+
+  it "verifies that the scope returns the records on the right hand side, regardless of order" do
+    MockableModel.scoped.should =~ models.reverse
+  end
+
+  it "fails if the scope encompasses more records than on the right hand side" do
+    another_model = MockableModel.create
+
+    MockableModel.scoped.should_not =~ models.reverse
+  end
+
+  it "fails if the scope encompasses fewer records than on the right hand side" do
+    MockableModel.limit(models.length - 1).should_not =~ models.reverse
+  end
+end

data/spec/rspec/rails/matchers/route_to_spec.rb

@@ -5,22 +5,44 @@ describe "route_to" do
   include RSpec::Rails::Matchers::RoutingMatchers::RouteHelpers
 
   it "delegates to assert_recognizes" do
-    self.should_receive(:assert_recognizes).with({ "these" => "options" }, { :method=> :get, :path=>"path" })
+    self.should_receive(:assert_recognizes).with({ "these" => "options" }, { :method=> :get, :path=>"path" }, {})
     {:get => "path"}.should route_to("these" => "options")
   end
 
   context "with shortcut syntax" do
 
     it "routes with extra options" do
-      self.should_receive(:assert_recognizes).with({ :controller => "controller", :action => "action", :extra => "options"}, { :method=> :get, :path=>"path" })
+      self.should_receive(:assert_recognizes).with({ :controller => "controller", :action => "action", :extra => "options"}, { :method=> :get, :path=>"path" }, {})
       get("path").should route_to("controller#action", :extra => "options")
     end
 
     it "routes without extra options" do
-      self.should_receive(:assert_recognizes).with({ :controller => "controller", :action => "action"}, { :method=> :get, :path=>"path" })
+      self.should_receive(:assert_recognizes).with(
+        {:controller => "controller", :action => "action"}, 
+        {:method=> :get, :path=>"path" },
+        {}
+      )
       get("path").should route_to("controller#action")
     end
 
+    it "routes with one query parameter" do
+      self.should_receive(:assert_recognizes).with(
+        {:controller => "controller", :action => "action", :queryitem => "queryvalue"},
+        {:method=> :get, :path=>"path" },
+        {'queryitem' => 'queryvalue' }
+      )
+      get("path?queryitem=queryvalue").should route_to("controller#action", :queryitem => 'queryvalue')
+    end
+
+    it "routes with multiple query parameters" do
+      self.should_receive(:assert_recognizes).with(
+        {:controller => "controller", :action => "action", :queryitem => "queryvalue", :qi2 => 'qv2'},
+        {:method=> :get, :path=>"path"},
+        {'queryitem' => 'queryvalue', 'qi2' => 'qv2'}
+      )
+      get("path?queryitem=queryvalue&qi2=qv2").should route_to("controller#action", :queryitem => 'queryvalue', :qi2 => 'qv2')
+    end
+
   end
 
   context "with should" do