rspec-rails 2.14.0.rc1 → 2.14.0

data/spec/generators/rspec/view/view_generator_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/view/view_generator'
+
+describe Rspec::Generators::ViewGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before { prepare_destination }
+
+  describe 'with default template engine' do
+    it 'generates a spec for the supplied action' do
+      run_generator %w(posts index)
+      file('spec/views/posts/index.html.erb_spec.rb').tap do |f|
+        f.should contain(/require 'spec_helper'/)
+        f.should contain(/describe "posts\/index"/)
+      end
+    end
+
+    describe 'with a nested resource' do
+      it 'generates a spec for the supplied action' do
+        run_generator %w(admin/posts index)
+        file('spec/views/admin/posts/index.html.erb_spec.rb').tap do |f|
+          f.should contain(/require 'spec_helper'/)
+          f.should contain(/describe "admin\/posts\/index"/)
+        end
+      end
+    end
+  end
+
+  describe 'with a specified template engine' do
+    it 'generates a spec for the supplied action' do
+      run_generator %w(posts index --template_engine haml)
+      file('spec/views/posts/index.html.haml_spec.rb').tap do |f|
+        f.should contain(/require 'spec_helper'/)
+        f.should contain(/describe "posts\/index"/)
+      end
+    end
+  end
+end

data/spec/rspec/rails/assertion_adapter_spec.rb

@@ -0,0 +1,28 @@
+require "spec_helper"
+
+describe RSpec::Rails::TestUnitAssertionAdapter do
+  include RSpec::Rails::TestUnitAssertionAdapter
+
+  Test::Unit::Assertions.public_instance_methods.select{|m| m.to_s =~ /^(assert|flunk)/}.each do |m|
+    if m.to_s == "assert_equal"
+      it "exposes #{m} to host examples" do
+        assert_equal 3,3
+        expect do
+          assert_equal 3,4
+        end.to raise_error(ActiveSupport::TestCase::Assertion)
+      end
+    else
+      it "exposes #{m} to host examples" do
+        methods.should include(m)
+      end
+    end
+  end
+
+  it "does not expose internal methods of MiniTest" do
+    methods.should_not include("_assertions")
+  end
+
+  it "does not expose MiniTest's message method" do
+    methods.should_not include("message")
+  end
+end

data/spec/rspec/rails/assertion_delegator_spec.rb

@@ -0,0 +1,43 @@
+require "spec_helper"
+
+describe RSpec::Rails::AssertionDelegator do
+  it "provides a module that delegates assertion methods to an isolated class" do
+    klass = Class.new {
+      include RSpec::Rails::AssertionDelegator.new(Test::Unit::Assertions)
+    }
+
+    expect(klass.new).to respond_to(:assert)
+  end
+
+  it "delegates back to the including instance for methods the assertion module requires" do
+    assertions = Module.new {
+      def has_thing?(thing)
+        self.things.include?(thing)
+      end
+    }
+
+    klass = Class.new {
+      include RSpec::Rails::AssertionDelegator.new(assertions)
+
+      def things
+        [:a]
+      end
+    }
+
+    expect(klass.new).to have_thing(:a)
+    expect(klass.new).not_to have_thing(:b)
+  end
+
+  it "does not delegate method_missing" do
+    assertions = Module.new {
+      def method_missing(method, *args)
+      end
+    }
+
+    klass = Class.new {
+      include RSpec::Rails::AssertionDelegator.new(assertions)
+    }
+
+    expect { klass.new.abc123 }.to raise_error(NoMethodError)
+  end
+end

data/spec/rspec/rails/configuration_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+describe "configuration" do
+  before do
+    @orig_render_views = RSpec.configuration.render_views?
+  end
+
+  after do
+    RSpec.configuration.render_views = @orig_render_views
+  end
+
+  describe "#render_views?" do
+    it "is false by default" do
+      RSpec.configuration.render_views?.should be_false
+    end
+  end
+
+  describe "#render_views" do
+    it "sets render_views? to return true" do
+      RSpec.configuration.render_views = false
+      RSpec.configuration.render_views
+
+      RSpec.configuration.render_views?.should be_true
+    end
+  end
+end

data/spec/rspec/rails/deprecations_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe "rspec-rails-2 deprecations" do
+  context "controller specs" do
+    describe "::integrate_views" do
+      let(:group) do
+        RSpec::Core::ExampleGroup.describe do
+          include RSpec::Rails::ControllerExampleGroup
+        end
+      end
+
+      it "is deprecated" do
+        RSpec.should_receive(:deprecate)
+        group.integrate_views
+      end
+    end
+  end
+end

data/spec/rspec/rails/example/controller_example_group_spec.rb

@@ -0,0 +1,100 @@
+require "spec_helper"
+
+class ::ApplicationController
+end
+
+module RSpec::Rails
+  describe ControllerExampleGroup do
+    it { should be_included_in_files_in('./spec/controllers/') }
+    it { should be_included_in_files_in('.\\spec\\controllers\\') }
+
+    let(:group) do
+      RSpec::Core::ExampleGroup.describe do
+        include ControllerExampleGroup
+      end
+    end
+
+    it "includes routing matchers" do
+      group.included_modules.should include(RSpec::Rails::Matchers::RoutingMatchers)
+    end
+
+    it "adds :type => :controller to the metadata" do
+      group.metadata[:type].should eq(:controller)
+    end
+
+    context "with implicit subject" do
+      it "uses the controller as the subject" do
+        controller = double('controller')
+        example = group.new
+        example.stub(:controller => controller)
+        example.subject.should == controller
+      end
+    end
+
+    context "with explicit subject" do
+      it "uses the specified subject instead of the controller" do
+        group.subject { 'explicit' }
+        example = group.new
+        example.subject.should == 'explicit'
+      end
+    end
+
+    describe "#controller" do
+      before do
+        group.class_eval do
+          controller(Class.new) { }
+        end
+      end
+
+      it "delegates named route helpers to the underlying controller" do
+        controller = double('controller')
+        controller.stub(:foos_url).and_return('http://test.host/foos')
+
+        example = group.new
+        example.stub(:controller => controller)
+
+        # As in the routing example spec, this is pretty invasive, but not sure
+        # how to do it any other way as the correct operation relies on before
+        # hooks
+        routes = ActionDispatch::Routing::RouteSet.new
+        routes.draw { resources :foos }
+        example.instance_variable_set(:@orig_routes, routes)
+
+        example.foos_url.should eq('http://test.host/foos')
+      end
+    end
+
+    describe "#bypass_rescue" do
+      it "overrides the rescue_with_handler method on the controller to raise submitted error" do
+        example = group.new
+        example.instance_variable_set("@controller", Class.new { def rescue_with_handler(e); end }.new)
+        example.bypass_rescue
+        expect do
+          example.controller.rescue_with_handler(RuntimeError.new("foo"))
+        end.to raise_error("foo")
+      end
+    end
+
+    describe "with inferred anonymous controller" do
+      before do
+        group.stub(:controller_class).and_return(Class.new)
+      end
+
+      it "infers the anonymous controller class when infer_base_class_for_anonymous_controllers is true" do
+        RSpec.configuration.stub(:infer_base_class_for_anonymous_controllers?).and_return(true)
+        group.controller { }
+
+        controller_class = group.metadata[:example_group][:described_class]
+        controller_class.superclass.should eq(group.controller_class)
+      end
+
+      it "sets the anonymous controller class to ApplicationController when infer_base_class_for_anonymous_controllers is false" do
+        RSpec.configuration.stub(:infer_base_class_for_anonymous_controllers?).and_return(false)
+        group.controller { }
+
+        controller_class = group.metadata[:example_group][:described_class]
+        controller_class.superclass.should eq(ApplicationController)
+      end
+    end
+  end
+end

data/spec/rspec/rails/example/feature_example_group_spec.rb

@@ -0,0 +1,56 @@
+require "spec_helper"
+
+module RSpec::Rails
+  describe FeatureExampleGroup do
+    it { should be_included_in_files_in('./spec/features/') }
+    it { should be_included_in_files_in('.\\spec\\features\\') }
+
+    it "adds :type => :feature to the metadata" do
+      group = RSpec::Core::ExampleGroup.describe do
+        include FeatureExampleGroup
+      end
+
+      expect(group.metadata[:type]).to eq(:feature)
+    end
+
+    it "includes Rails route helpers" do
+      Rails.application.routes.draw do
+        get "/foo", :as => :foo, :to => "foo#bar"
+      end
+
+      group = RSpec::Core::ExampleGroup.describe do
+        include FeatureExampleGroup
+      end
+
+      expect(group.new.foo_path).to eq("/foo")
+      expect(group.new.foo_url).to eq("http://www.example.com/foo")
+    end
+
+    describe "#visit" do
+      it "raises an error informing about missing Capybara" do
+        group = RSpec::Core::ExampleGroup.describe do
+          include FeatureExampleGroup
+        end
+
+        expect {
+          group.new.visit('/foobar')
+        }.to raise_error(/Capybara not loaded/)
+      end
+
+      it "is resistant to load order errors" do
+        capybara = Module.new do
+          def visit(url)
+            "success: #{url}"
+          end
+        end
+
+        group = RSpec::Core::ExampleGroup.describe do
+          include capybara
+          include FeatureExampleGroup
+        end
+
+        expect(group.new.visit("/foo")).to eq("success: /foo")
+      end
+    end
+  end
+end

data/spec/rspec/rails/example/helper_example_group_spec.rb

@@ -0,0 +1,64 @@
+require "spec_helper"
+
+module RSpec::Rails
+  describe HelperExampleGroup do
+    module ::FoosHelper; end
+    subject { HelperExampleGroup }
+
+    it { should be_included_in_files_in('./spec/helpers/') }
+    it { should be_included_in_files_in('.\\spec\\helpers\\') }
+
+    it "provides a controller_path based on the helper module's name" do
+      helper_spec = Object.new.extend HelperExampleGroup
+      helper_spec.stub_chain(:example, :example_group, :described_class).and_return(FoosHelper)
+      helper_spec.__send__(:_controller_path).should == "foos"
+    end
+
+    it "adds :type => :helper to the metadata" do
+      group = RSpec::Core::ExampleGroup.describe do
+        include HelperExampleGroup
+      end
+      group.metadata[:type].should eq(:helper)
+    end
+
+    describe "#helper" do
+      it "returns the instance of AV::Base provided by AV::TC::Behavior" do
+        helper_spec = Object.new.extend HelperExampleGroup
+        helper_spec.should_receive(:view_assigns)
+        av_tc_b_view = double('_view')
+        av_tc_b_view.should_receive(:assign)
+        helper_spec.stub(:_view) { av_tc_b_view }
+        helper_spec.helper.should eq(av_tc_b_view)
+      end
+
+      before do
+        Object.const_set(:ApplicationHelper, Module.new)
+      end
+
+      after do
+        Object.__send__(:remove_const, :ApplicationHelper)
+      end
+
+      it "includes ApplicationHelper" do
+        group = RSpec::Core::ExampleGroup.describe do
+          include HelperExampleGroup
+          def _view
+            ActionView::Base.new
+          end
+        end
+        group.new.helper.should be_kind_of(ApplicationHelper)
+      end
+    end
+  end
+
+  describe HelperExampleGroup::ClassMethods do
+    describe "determine_default_helper_class" do
+      it "returns the helper module passed to describe" do
+        helper_spec = Object.new.extend HelperExampleGroup::ClassMethods
+        helper_spec.stub(:described_class) { FoosHelper }
+        helper_spec.determine_default_helper_class("ignore this").
+          should eq(FoosHelper)
+      end
+    end
+  end
+end

data/spec/rspec/rails/example/mailer_example_group_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+module RSpec::Rails
+  describe MailerExampleGroup do
+    module ::Rails; end
+    before do
+      Rails.stub_chain(:application, :routes, :url_helpers).and_return(Rails)
+      Rails.stub_chain(:configuration, :action_mailer, :default_url_options).and_return({})
+    end
+
+    it { should be_included_in_files_in('./spec/mailers/') }
+    it { should be_included_in_files_in('.\\spec\\mailers\\') }
+
+    it "adds :type => :mailer to the metadata" do
+      group = RSpec::Core::ExampleGroup.describe do
+        include MailerExampleGroup
+      end
+      group.metadata[:type].should eq(:mailer)
+    end
+  end
+end

data/spec/rspec/rails/example/model_example_group_spec.rb

@@ -0,0 +1,15 @@
+require "spec_helper"
+
+module RSpec::Rails
+  describe ModelExampleGroup do
+    it { should be_included_in_files_in('./spec/models/') }
+    it { should be_included_in_files_in('.\\spec\\models\\') }
+
+    it "adds :type => :model to the metadata" do
+      group = RSpec::Core::ExampleGroup.describe do
+        include ModelExampleGroup
+      end
+      group.metadata[:type].should eq(:model)
+    end
+  end
+end

data/spec/rspec/rails/example/request_example_group_spec.rb

@@ -0,0 +1,17 @@
+require "spec_helper"
+
+module RSpec::Rails
+  describe RequestExampleGroup do
+    it { should be_included_in_files_in('./spec/requests/') }
+    it { should be_included_in_files_in('./spec/integration/') }
+    it { should be_included_in_files_in('.\\spec\\requests\\') }
+    it { should be_included_in_files_in('.\\spec\\integration\\') }
+
+    it "adds :type => :request to the metadata" do
+      group = RSpec::Core::ExampleGroup.describe do
+        include RequestExampleGroup
+      end
+      group.metadata[:type].should eq(:request)
+    end
+  end
+end

data/spec/rspec/rails/example/routing_example_group_spec.rb

@@ -0,0 +1,32 @@
+require "spec_helper"
+
+module RSpec::Rails
+  describe RoutingExampleGroup do
+    it { should be_included_in_files_in('./spec/routing/') }
+    it { should be_included_in_files_in('.\\spec\\routing\\') }
+
+    it "adds :type => :routing to the metadata" do
+      group = RSpec::Core::ExampleGroup.describe do
+        include RoutingExampleGroup
+      end
+      group.metadata[:type].should eq(:routing)
+    end
+
+    describe "named routes" do
+      it "delegates them to the route_set" do
+        group = RSpec::Core::ExampleGroup.describe do
+          include RoutingExampleGroup
+        end
+
+        example = group.new
+
+        # Yes, this is quite invasive
+        url_helpers = double('url_helpers', :foo_path => "foo")
+        routes = double('routes', :url_helpers => url_helpers)
+        example.stub(:routes => routes)
+
+        example.foo_path.should == "foo"
+      end
+    end
+  end
+end