rspec-rails 2.0.0.beta.8 → 2.0.0.beta.9.1

data/README.markdown

@@ -1,17 +1,11 @@
-RSpec-2 for Rails-3
+# rspec-rails-2
 
-### Backwards compatibility
+## RSpec-2 for Rails-3
 
-None. This is a rewrite of the rspec-rails extension designed to work
-with rails-3.x and rspec-2.x. It will not work with older versions of
-either rspec or rails.
+rspec-rails-2 brings rspec-2 to rails-3 with lightweight extensions to both
+libraries.
 
-### Current state
-
-Currently in alpha - some things work, some not so much - see Known Issues,
-below
-
-Install:
+## Install
 
     gem install rspec-rails --pre
 
@@ -23,7 +17,7 @@ This installs the following gems:
 * rspec-mocks
 * rspec-rails
 
-Configure:
+## Configure:
 
 Add this line to the Gemfile:
 
@@ -39,16 +33,36 @@ the "rake spec" task.
 Note that things are in flux, so some generators generate code that
 doesn't work all that well yet.
 
-### What works (and what doesn't)
+## Living on edge
+
+If you prefer to exploit bundler's support for pointing a gem at a github repo,
+be sure to do so for all five of the relevant rspec gems:
+
+    gem "rspec-rails",        :git => "git://github.com/rspec/rspec-rails.git"
+    gem "rspec",              :git => "git://github.com/rspec/rspec.git"
+    gem "rspec-core",         :git => "git://github.com/rspec/rspec-core.git"
+    gem "rspec-expectations", :git => "git://github.com/rspec/rspec-expectations.git"
+    gem "rspec-mocks",        :git => "git://github.com/rspec/rspec-mocks.git"
+
+Keep in mind that each of these repos is under active development, which means
+that its very likely that you'll pull from these repos and they won't play nice
+together. If playing nice is important to you, stick to the published gems.
+
+## Backwards compatibility
+
+This is a complete rewrite of the rspec-rails extension designed to work with
+rails-3.x and rspec-2.x. It will not work with older versions of either rspec
+or rails.  Many of the APIs from rspec-rails-1 have been carried forward,
+however, so upgrading an app from rspec-1/rails-2, while not pain-free, should
+not send you to the doctor with a migraine.
 
-Currently supported:
+## Synopsis
 
 * each example runs in its own transaction
-  * configurable in Rspec.configure
-    * see generated spec/spec_helper.rb
+  * configurable in RSpec.configure
+    * see generated spec/spec\_helper.rb
 * model specs in spec/models
 * controller specs in spec/controllers
-  * no view isolation yet
 * view specs in spec/views
 * mailer specs in spec/mailers
 * observer specs in spec/models
@@ -56,20 +70,23 @@ Currently supported:
   * these wrap rails integration tests
 * rails assertions
 * assertion-wrapping matchers
-  * redirect_to
-  * render_template
-    * template must exist (unlike rspec-rails-1.x)
+  * redirect\_to
+  * render\_template
+* helper specs
 * webrat matchers
 * generators
   * run "script/rails g" to see the list of available generators
 
-### Known issues
+## Known issues
 
-* no helper specs
-* no routing specs
-* only works with ActiveRecord
+See http://github.com/rspec/rspec-rails/issues
 
-## Controller Specs
+# Request Specs
+
+Request specs live in spec/requests, and mix in behavior
+from Rails' integration tests.
+
+# Controller Specs
 
 Controller specs live in spec/controllers, and mix in
 ActionController::TestCase::Behavior. See the documentation
@@ -78,12 +95,22 @@ available from Rails.
 
 You can use RSpec expectations/matchers or Test::Unit assertions.
 
+## rendering views
+By default, controller specs do not render views (as of beta.9).
+This supports specifying controllers without concern for whether
+the views they render work correctly or even exist. If you prefer
+to render the views (a la Rails' functional tests), you can use the
+`render_views` declaration in each example group:
+
+    describe SomeController do
+      render_views
+      ...
+
+## Matchers
 In addition to what Rails offers, controller specs provide all
 of rspec-core's matchers and the rspec-rails' specific matchers
 as well.
 
-## Matchers
-
 ### render_template
 Delegates to Rails' assert_template:
 
@@ -94,3 +121,31 @@ Delegates to assert_redirect
 
     response.should redirect_to(widgets_path)
 
+# View specs
+
+View specs live in spec/views, and mix in ActionView::TestCase::Behavior.
+
+    describe "events/show.html.erb" do
+      it "displays the event location" do
+        assign(:event, stub_model(Event,
+          :location => "Chicago"
+        )
+        render
+        rendered.should contain("Chicago")
+      end
+    end
+
+# Helper specs
+
+Helper specs live in spec/helpers, and mix in ActionView::TestCase::Behavior.
+
+    describe EventsHelper do
+      describe "#link_to_event" do
+        it "displays the title, and formatted date" do
+          event = Event.new("Ruby Kaigi", Date.new(2010, 8, 27))
+          # helper is an instance of ActionView::Base configured with the
+          # EventsHelper and all of Rails' built-in helpers
+          helper.link_to_event.should =~ /Ruby Kaigi, 27 Aug, 2010/
+        end
+      end
+    end

data/Rakefile

@@ -1,7 +1,7 @@
 require 'rake'
 require 'yaml'
 
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__),'lib'))
+$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
 
 require 'rake/rdoctask'
 require 'rspec/rails/version'
@@ -9,7 +9,7 @@ require 'rspec'
 require 'rspec/core/rake_task'
 require 'cucumber/rake/task'
 
-Rspec::Core::RakeTask.new(:spec)
+RSpec::Core::RakeTask.new(:spec)
 Cucumber::Rake::Task.new(:cucumber) do |t|
   t.cucumber_opts = %w{--format progress}
 end
@@ -18,14 +18,14 @@ begin
   require 'jeweler'
   Jeweler::Tasks.new do |gem|
     gem.name = "rspec-rails"
-    gem.version = Rspec::Rails::Version::STRING
-    gem.summary = "rspec-rails-#{Rspec::Rails::Version::STRING}"
-    gem.description = "Rspec-2 for Rails-3"
+    gem.version = RSpec::Rails::Version::STRING
+    gem.summary = "rspec-rails-#{RSpec::Rails::Version::STRING}"
+    gem.description = "RSpec-2 for Rails-3"
     gem.email = "dchelimsky@gmail.com;chad.humphries@gmail.com"
     gem.homepage = "http://github.com/rspec/rspec-rails"
     gem.authors = ["David Chelimsky", "Chad Humphries"]
     gem.rubyforge_project = "rspec"
-    gem.add_dependency "rspec", gem.version
+    gem.add_dependency "rspec", "2.0.0.beta.9" # gem.version
     gem.add_dependency "webrat", ">= 0.7.0"
     gem.post_install_message = <<-EOM
 #{"*"*50}
@@ -49,7 +49,7 @@ end
 namespace :gem do
   desc "push to gemcutter"
   task :push => :build do
-    system "gem push pkg/rspec-rails-#{Rspec::Rails::Version::STRING}.gem"
+    system "gem push pkg/rspec-rails-#{RSpec::Rails::Version::STRING}.gem"
   end
 end
 

data/Upgrade.markdown

@@ -0,0 +1,12 @@
+# Upgrade to rspec-rails-2
+
+## What's changed
+
+### View specs
+
+Rails changed the way it renders partials, so to set an expectation that a partial
+gets rendered:
+
+    view.should_receive(:_render_partial).
+      with(hash_including(:partial => "widget/row"))
+

data/VERSION

@@ -1 +1 @@
-2.0.0.beta.8
+2.0.0.beta.9.1

data/autotest/discover.rb

@@ -0,0 +1 @@
+Autotest.add_discovery { "rspec2" }

data/cucumber.yml

@@ -0,0 +1,3 @@
+default: --require features --format progress --tags ~@wip
+pretty:  --require features --format pretty   --tags ~@wip
+wip:     --require features --tags @wip

data/example_app_template.rb

@@ -1,5 +1,5 @@
-$LOAD_PATH.unshift(File.expand_path('../../../lib', __FILE__))
+$LOAD_PATH.unshift(File.expand_path('../lib', __FILE__))
 require 'rspec/rails/version'
 
-gem 'rspec-rails', :path => File.expand_path('../../../', __FILE__)
+gem 'rspec-rails', :path => File.expand_path('../', __FILE__)
 

data/features/controller_specs/do_not_render_views.feature

@@ -0,0 +1,61 @@
+Feature: do not render views
+
+  By default, controller specs do not render views. This
+  allows you specify which view template an action should
+  try to render regardless of whether that template exists
+  or compiles cleanly.
+
+  Scenario: expect template that exists and is rendered by controller (passes)
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """
+      require "spec_helper.rb"
+
+      describe WidgetsController do
+        describe "index" do
+          it "renders the index template" do
+            get :index
+            response.should render_template("index")
+          end
+          it "renders the widgets/index template" do
+            get :index
+            response.should render_template("widgets/index")
+          end
+        end
+      end
+      """
+    When I run "rspec ./spec"
+    Then I should see "2 examples, 0 failures"
+
+  Scenario: expect template that exists but is not rendered by controller (fails)
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """
+      require "spec_helper.rb"
+
+      describe WidgetsController do
+        describe "index" do
+          it "renders the 'new' template" do
+            get :index
+            response.should render_template("new")
+          end
+        end
+      end
+      """
+    When I run "rspec ./spec"
+    Then I should see "1 example, 1 failure"
+
+  Scenario: expect template that does not exist and is not rendered by controller (fails)
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """
+      require "spec_helper.rb"
+
+      describe WidgetsController do
+        describe "index" do
+          it "renders a template that does not exist" do
+            get :index
+            response.should render_template("does_not_exist")
+          end
+        end
+      end
+      """
+    When I run "rspec ./spec"
+    Then I should see "1 example, 1 failure"

data/features/controller_specs/readers.feature

@@ -0,0 +1,18 @@
+Feature: controller spec readers
+
+  Controller specs expose a number of different
+  attribute readers.
+
+  Scenario: access controller
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """
+      require "spec_helper.rb"
+
+      describe WidgetsController do
+        it "is available before an action" do
+          controller.should be_an_instance_of(WidgetsController)
+        end
+      end
+      """
+    When I run "rspec ./spec"
+    Then I should see "1 example, 0 failures"

data/features/controller_specs/render_views.feature

@@ -0,0 +1,53 @@
+Feature: render views
+
+  You can tell a controller example group to render views
+  with the render_views declaration.
+
+  Scenario: expect template that exists and is rendered by controller (passes)
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """
+      require "spec_helper.rb"
+
+      describe WidgetsController do
+        render_views
+
+        describe "index" do
+          it "renders the index template" do
+            get :index
+            response.should render_template("index")
+          end
+
+          it "renders the widgets/index template" do
+            get :index
+            response.should render_template("widgets/index")
+          end
+        end
+      end
+      """
+    When I run "rspec ./spec"
+    Then I should see "2 examples, 0 failures"
+
+  Scenario: expect template that does not exist and is rendered by controller (passes)
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """
+      require "spec_helper.rb"
+
+      describe WidgetsController do
+        render_views
+
+        before do
+          def controller.index
+            render "other"
+          end
+        end
+
+        describe "index" do
+          it "renders the other template" do
+            get :index
+            response.should render_template("other")
+          end
+        end
+      end
+      """
+    When I run "rspec ./spec"
+    Then I should see "1 example, 1 failure"

data/features/model_specs/errors_on.feature

@@ -0,0 +1,32 @@
+Feature: errors_on
+
+  Scenario: with one validation error
+    Given a file named "spec/models/widget_spec.rb" with:
+      """
+      require "spec_helper"
+
+      class ValidatingWidget < ActiveRecord::Base
+        set_table_name :widgets
+        validates_presence_of :name
+      end
+
+      describe ValidatingWidget do
+        it "fails validation with no name (using error_on)" do
+          ValidatingWidget.new.should have(1).error_on(:name)
+        end
+
+        it "fails validation with no name (using errors_on)" do
+          ValidatingWidget.new.should have(1).errors_on(:name)
+        end
+
+        it "passes validation with a name (using 0)" do
+          ValidatingWidget.new(:name => "liquid nitrogen").should have(0).errors_on(:name)
+        end
+
+        it "passes validation with a name (using :no)" do
+          ValidatingWidget.new(:name => "liquid nitrogen").should have(:no).errors_on(:name)
+        end
+      end
+      """
+    When I run "rspec spec/models/widget_spec.rb"
+    Then I should see "4 examples, 0 failures"

data/features/model_specs/transactional_examples.feature

@@ -28,7 +28,7 @@ Feature: transactional examples
       """
       require "spec_helper"
 
-      Rspec.configure do |c|
+      RSpec.configure do |c|
         c.use_transactional_examples = true
       end
 
@@ -55,7 +55,7 @@ Feature: transactional examples
       """
       require "spec_helper"
 
-      Rspec.configure do |c|
+      RSpec.configure do |c|
         c.use_transactional_examples = false
       end
 

data/features/view_specs/view_spec.feature

@@ -2,7 +2,7 @@ Feature: view spec
 
   View specs live in spec/views and render view templates in isolation.
 
-  Scenario: passing spec
+  Scenario: passing spec that renders the described view file
     Given a file named "spec/views/widgets/index.html.erb_spec.rb" with:
       """
       require "spec_helper"
@@ -51,3 +51,104 @@ Feature: view spec
     When I run "rspec spec/views"
     Then I should see "1 example, 0 failures"
 
+  Scenario: passing spec with explicit template rendering
+    Given a file named "spec/views/widgets/widget.html.erb_spec.rb" with:
+      """
+      require "spec_helper"
+
+      describe "rendering the widget template" do
+        it "displays the widget" do
+          assign(:widget, stub_model(Widget, :name => "slicer"))
+
+          render :template => "widgets/widget.html.erb"
+
+          response.should contain("slicer")
+        end
+      end
+      """
+    And a file named "app/views/widgets/widget.html.erb" with:
+      """
+      <h2><%= @widget.name %></h2>
+      """
+    When I run "rspec spec/views"
+    Then I should see "1 example, 0 failures"
+
+  Scenario: passing spec with rendering of locals in a partial
+    Given a file named "spec/views/widgets/_widget.html.erb_spec.rb" with:
+      """
+      require "spec_helper"
+
+      describe "rendering locals in a partial" do
+        it "displays the widget" do
+          widget = stub_model(Widget, :name => "slicer")
+
+          render :partial => "widgets/widget.html.erb", :locals => {:widget => widget}
+
+          response.should contain("slicer")
+        end
+      end
+      """
+    And a file named "app/views/widgets/_widget.html.erb" with:
+      """
+      <h3><%= widget.name %></h3>
+      """
+    When I run "rspec spec/views"
+    Then I should see "1 example, 0 failures"
+
+  Scenario: passing spec with rendering of locals in an implicit partial
+    Given a file named "spec/views/widgets/_widget.html.erb_spec.rb" with:
+      """
+      require "spec_helper"
+
+      describe "rendering locals in a partial" do
+        it "displays the widget" do
+          widget = stub_model(Widget, :name => "slicer")
+
+          render "widgets/widget", :widget => widget
+
+          response.should contain("slicer")
+        end
+      end
+      """
+    And a file named "app/views/widgets/_widget.html.erb" with:
+      """
+      <h3><%= widget.name %></h3>
+      """
+    When I run "rspec spec/views"
+    Then I should see "1 example, 0 failures"
+
+  Scenario: passing spec with rendering of text
+    Given a file named "spec/views/widgets/direct.html.erb_spec.rb" with:
+      """
+      require "spec_helper"
+
+      describe "rendering text directly" do
+        it "displays the given text" do
+
+          render :text => "This is directly rendered"
+
+          response.should contain("directly rendered")
+        end
+      end
+      """
+    When I run "rspec spec/views"
+    Then I should see "1 example, 0 failures"
+
+  Scenario: passing spec with rendering of Prototype helper update
+    Given a file named "spec/views/widgets/prototype_update.html.erb_spec.rb" with:
+      """
+      require "spec_helper"
+
+      describe "render a Prototype helper update" do
+        it "hides the status indicator" do
+
+          render :update do |page|
+            page.hide 'status-indicator'
+          end
+
+          response.should contain("Element.hide(\"status-indicator\")")
+        end
+      end
+      """
+    When I run "rspec spec/views"
+    Then I should see "1 example, 0 failures"