rspec-process-mocks 0.0.1 → 0.0.2

data/features/message_expectations/expect_message.feature

@@ -81,6 +81,90 @@ Feature: expect a message
     And the output should contain "expected: 1 time"
     And the output should contain "received: 0 times"
 
+  Scenario: expect a message, and it is called twice
+    Given a file named "spec/account_spec.rb" with:
+      """
+      RSpec.configuration.mock_framework = :rspec
+      $: << File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '..', 'lib'))
+      require 'rspec/process_mocks'
+      require "account"
+
+      describe Account do
+        context "when closed" do
+          it "logs an account closed message in a child process" do
+
+            logger = double("logger")
+            account = Account.new
+            account.logger = logger
+
+            logger.should_receive_in_child_process(:account_closed)
+
+            account.close
+
+            sleep 0.1
+          end
+        end
+      end
+      """
+    And a file named "lib/account.rb" with:
+      """
+      class Account
+        attr_accessor :logger
+
+        def close
+          Process.fork do
+            logger.account_closed
+            logger.account_closed
+          end
+        end
+      end
+      """
+    When I run `rspec spec/account_spec.rb`
+    Then the output should contain "1 example, 1 failure"
+    And the output should contain "expected: 1 time"
+    And the output should contain "received: 2 times"
+
+  Scenario: expect a message at least once, and it is called twice
+    Given a file named "spec/account_spec.rb" with:
+      """
+      RSpec.configuration.mock_framework = :rspec
+      $: << File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '..', 'lib'))
+      require 'rspec/process_mocks'
+      require "account"
+
+      describe Account do
+        context "when closed" do
+          it "logs an account closed message in a child process" do
+
+            logger = double("logger")
+            account = Account.new
+            account.logger = logger
+
+            logger.should_receive_in_child_process(:account_closed).at_least(1).times
+
+            account.close
+
+            sleep 0.1
+          end
+        end
+      end
+      """
+    And a file named "lib/account.rb" with:
+      """
+      class Account
+        attr_accessor :logger
+
+        def close
+          Process.fork do
+            logger.account_closed
+            logger.account_closed
+          end
+        end
+      end
+      """
+    When I run `rspec spec/account_spec.rb`
+    Then the output should contain "1 example, 0 failure"
+
   @wip
   Scenario: expect a message with an argument
     Given a file named "spec/account_spec.rb" with:

data/lib/rspec/process_mocks/message_expectation.rb

@@ -6,60 +6,67 @@ module RSpec
       def initialize(*args)
         super
 
-        # The tempfile is used for interprocess communication
-        @tempfile = Tempfile.new("should-receive-#{@expected_from.object_id}-#{@sym}")
+        # The temp files are used for interprocess communication.
+        # This one stores the calls that are exact matches.
+        @actual_tempfile = Tempfile.new("should-receive-#{@expected_from.object_id}-#{@sym}")
+        # This one stores the similar calls.
+        @similar_tempfile = Tempfile.new("should-receive-similar-#{@expected_from.object_id}-#{@sym}")
       end
-      def verify_messages_received
-        # Maybe we should add a sleep loop here if @tempfile is empty. This may
-        # prevent a user of this library from having to add a sleep in the spec.
-        # Maybe this:
-        #     @tempfile.rewind
-        #     lines = @tempfile.readlines
-        #     timeout = Configure.verify_timeout
-        #     while lines.empty? && timeout > 0
-        #       sleep 0.1
-        #       timeout -= 0.1
-        #       @tempfile.rewind
-        #       lines = @tempfile.readlines
-        #     end
 
-        @tempfile.rewind
-        lines = @tempfile.readlines
-#puts "lines in verify_messages_received: #{lines.inspect}"
-        return true if lines.size == 1 #&& # Called exactly once.
-#          lines[0] == "[]\n" # Called with no arguments.
 
-        generate_error
-      rescue RSpec::Mocks::MockExpectationError => error
-        error.backtrace.insert(0, @expected_from)
-        Kernel::raise error
+      # This method is executed in the _child_ process when the stubbed method
+      # is called exact arguments
+      # Overwritten from rspec.
+      def invoke(*args, &block)
+        msg = args.inspect
+        @actual_tempfile.puts msg
+        @actual_tempfile.flush
       end
 
-      # This is a hack to get it to work. But it means we can only ever expect
-      # exactly 1 message.
-      def matches_exact_count?
-        lines.size == 1
+      # This method is executed in the _child_ process when the stubbed method
+      # is called with similar argument.
+      # Overwritten from rspec.
+      def advise(*args)
+        @similar_tempfile.puts msg
+        @similar_tempfile.flush
+        similar_messages
       end
 
-      # This method is executed in the _child_ process when the stubbed method
-      # is called.
-      def invoke(*args, &block)
+      # This overwrites the rspec implementation because we need to record
+      # similar messages in a temp file not instance variables.
+      def similar_messages
+        @similar_tempfile.rewind
+        @similar_tempfile.readlines
+      end
 
-        msg = args.inspect
-        @tempfile.puts msg
-        @tempfile.flush
-#        puts "##{@sym} called on #{@expected_from.class}-#{@expected_from.object_id}; args: #{args.inspect}"
-#        yield block, *args if defined?(block)
+      # Reads back the actual/exact-match arguments written to the temp file.
+      # This is not a method in rspec.
+      def actual_messages
+        @actual_tempfile.rewind
+        @actual_tempfile.readlines
       end
 
-      # This is a hack to get it to work. But it means we don't get info about
-      # "similar" methods in the failure output. Similar messages are those with
-      # a matching method name, but not matching arguments.
-      # Note: this is only a rough definition of "similar" methods. "Similar"
-      # methods are not part of RSpec's external API, so their definition is not
-      # strictly documented.
-      def similar_messages
-        []
+      # The following methods used to use instance variables. But we can't do
+      # that because those aren't shared between processes. These methods
+      # overwrite rspec's behavior and instead keep the state in temp files.
+      def actual_received_count
+        actual_messages.size
+      end
+      def generate_error
+        if similar_messages.empty?
+          @error_generator.raise_expectation_error(@sym, @expected_received_count, actual_received_count, *@args_expectation.args)
+        else
+          @error_generator.raise_similar_message_args_error(self, *similar_messages)
+        end
+      end
+      def matches_at_least_count?
+        @at_least && actual_received_count >= @expected_received_count
+      end
+      def matches_at_most_count?
+        @at_most && actual_received_count <= @expected_received_count
+      end
+      def matches_exact_count?
+        @expected_received_count == actual_received_count
       end
     end
   end

data/lib/rspec/process_mocks/version.rb

@@ -1,7 +1,7 @@
 module RSpec # :nodoc:
   module ProcessMocks # :nodoc:
     module Version # :nodoc:
-      STRING = '0.0.1'
+      STRING = '0.0.2'
     end
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: rspec-process-mocks
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - Paul Cortens
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-28 00:00:00 -07:00
+date: 2011-06-08 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -64,6 +64,6 @@ rubyforge_project:
 rubygems_version: 1.5.0
 signing_key: 
 specification_version: 3
-summary: rspec-process-mocks-0.0.1
+summary: rspec-process-mocks-0.0.2
 test_files: []