rspec-otel 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2db5ebf1aa940bae5b290f6d6683e1f1bea754fc83e8eaf9997bb3971235244
-  data.tar.gz: 5c7b7ca60e93ca6ccf82479cfe3374c5420ab5be80484787c4cdc74ed67548cb
+  metadata.gz: b966349d533ad57a8ee5fc1fd79b7ed99922beb6aad8fc1fb59e97d8062cdf5e
+  data.tar.gz: e167fba956f24f180846574e5b87214f906b0d35377d7b92230df99aa6244dc2
 SHA512:
-  metadata.gz: f99a6e31d6acc0fc5dc26453690a7b66a6ed8352cc4790b26fccdad93dfa1692adaaa9f3f4fd5798c8d1e9084a8c509ebf1800936a3b4a1354ca3ddc6e9b701e
-  data.tar.gz: 12a5346b1eb3b3247d9d5d62e46aa1c4e3c13f891a0abdd72a2f2931e054f86bcc6d9634959faf65329689933af438075de259682b7357995bb596dfd8b5a008
+  metadata.gz: 5f19d4e4b8c94818c8d11e373380fc527c8e61f875e24189c3fa401a38d49f1647eb4f5e4862dea702de3397fd2ec81ee6deca4612056678c8de9faa90208eae
+  data.tar.gz: a3320a67e728db92483d66a7cad492abbc7785cb7088417ab8e9e23b1648db348b0b32e869b308d6369a0cb7c267c613a17e7f0f810d11ab5138a4cbb6072b98

data/lib/rspec_otel/matchers/emit_span.rb

@@ -8,19 +8,24 @@ module RspecOtel
       def initialize(name = nil)
         @name = name
         @filters = []
+        @before_spans = []
+        @closest_span = nil
 
-        add_name_filter
+        @filters << name_filter
       end
 
-      def matches?(block)
-        before_spans = []
+      def matches?(block) # rubocop:disable Metrics/MethodLength
         if block.respond_to?(:call)
-          before_spans = RspecOtel.exporter.finished_spans
+          @before_spans = RspecOtel.exporter.finished_spans
           block.call
         end
 
-        (RspecOtel.exporter.finished_spans - before_spans).each do |span|
-          return true if @filters.all? { |f| f.call(span) }
+        closest_count = 0
+        (RspecOtel.exporter.finished_spans - @before_spans).each do |span|
+          count = @filters.count { |f| f.call(span) }
+          @closest_span = span if count > closest_count
+          closest_count = count
+          return true if count == @filters.count
         end
 
         false
@@ -110,7 +115,17 @@ module RspecOtel
       end
 
       def failure_message
-        "expected span #{failure_match_description} #{printable_name} to have been emitted, but it couldn't be found"
+        closest = closest_span
+        expect_content = "expected span #{failure_match_description} #{printable_name} to have been emitted"
+
+        case closest
+        when nil
+          "#{expect_content}, but there were no spans emitted at all"
+        when OpenTelemetry::SDK::Trace::SpanData
+          "#{expect_content}, but it couldn't be found. Found a close matching span named `#{closest.name}`"
+        else
+          raise "I don't know what to do with a #{closest.class} span"
+        end
       end
 
       def failure_message_when_negated
@@ -123,6 +138,12 @@ module RspecOtel
 
       private
 
+      def closest_span
+        return @closest_span unless @closest_span.nil?
+
+        (RspecOtel.exporter.finished_spans - @before_spans).first
+      end
+
       def failure_match_description
         case name
         when String
@@ -141,8 +162,8 @@ module RspecOtel
         end
       end
 
-      def add_name_filter
-        @filters << lambda do |span|
+      def name_filter
+        lambda do |span|
           case name
           when String
             span.name == name
@@ -154,9 +175,13 @@ module RspecOtel
 
       def exception_attributes(exception)
         attributes = {}
-        unless exception.nil?
+        return attributes if exception.nil?
+
+        if exception.is_a?(Exception)
           attributes['exception.type'] = exception.class.to_s
           attributes['exception.message'] = exception.message
+        else
+          attributes['exception.type'] = exception.to_s
         end
 
         attributes

data/lib/rspec_otel/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RspecOtel
-  VERSION = '0.0.5'
+  VERSION = '0.0.7'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rspec-otel
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Damien MATHIEU
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-23 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-api
@@ -85,7 +84,6 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -100,8 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: RSpec matchers for the OpenTelemetry framework
 test_files: []