rspec-multiprocess_runner 1.3.1 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4d3eb03320ff5e8dba79f4bf21fe0cbda05915fcd22beb68fa20e866a12253b
-  data.tar.gz: 0a3cbb76435ae9773b829c38b3ada6e0e0782267699db8c7a1762d641a3c71cc
+  metadata.gz: 1a7a20eae3cf50ce32007e5ad3911ef435a08ef700af8834f2dd7c850bab9498
+  data.tar.gz: 7f667747464c2264153c7231233e2231b6a688b78b8090aa985bd8a8392e8484
 SHA512:
-  metadata.gz: 3984c8a5243872c5a9043579774dbfa0670c6380d4c326f67d80cf0206bfaa41bd6ac1cff07d81dee5af97a9e132009773481ab26f1766976b5102f1bbc03ede
-  data.tar.gz: 53c4f6b1720f79ad03d2e35201ff0fa7ec3c9b3867919851dffe13f9b2988454524834ce77e3d3386b599a565ac7feb98d602b451c7835ebc18e853c1b2feae8
+  metadata.gz: 7c9509227d2289e66e5a51c706f9cd9507e775d95589e98f59f45957dffd1dde142c85280a321e5b8997441efaee3e9b2c6f22c6fbb4591f7deca36dbc8eaccf
+  data.tar.gz: 201eeafffde0a53bb5d398da3e5e966b698af74b48ccde3d74f591830e844c530ea7ae68f381866d7831b0effecae317f19dbcdf89a1c29845f335efe12ae4db

data/CHANGELOG.md

@@ -1,3 +1,27 @@
+# 1.4.3
+
+* New 1.4.2 logging is less aggressive and should only show errors now
+* Adds a docker container for releasing
+
+# 1.4.2
+
+* Add better logging for errors that occur outside of tests
+* Add docker tests for all current ruby versions and more ruby versions to test in
+* Fix some minor bugs that caused incorrect error codes (still failure codes)
+* Fixed the error code spec file
+
+# 1.4.1
+
+* Fix file coordinator helpers failing due to unknown method on command line args
+
+# 1.4.0
+
+* Fix issue catching spec files failing outside of tests (it will now die loudly instead of passing silently).
+
+# 1.3.3
+
+* File output bug fix
+
 # 1.3.1
 
 * Or use an environment variable for summary file.

data/Gemfile.lock

@@ -1,36 +1,36 @@
 PATH
   remote: .
   specs:
-    rspec-multiprocess_runner (1.3.0)
+    rspec-multiprocess_runner (1.4.3.pre)
       rspec (>= 3.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    byebug (11.0.1)
+    byebug (11.1.3)
     coderay (1.1.2)
     diff-lcs (1.3)
-    method_source (0.9.2)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.7.0)
+    method_source (1.0.0)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
       byebug (~> 11.0)
-      pry (~> 0.10)
-    rake (10.5.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.5)
+      pry (~> 0.13.0)
+    rake (13.0.1)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.2)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.3)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
     stub_env (1.0.4)
       rspec (>= 2.0, < 4.0)
 
@@ -40,9 +40,9 @@ PLATFORMS
 DEPENDENCIES
   bundler (>= 1.10)
   pry-byebug
-  rake (~> 10.0)
+  rake (>= 12.3.3)
   rspec-multiprocess_runner!
   stub_env
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/lib/rspec/multiprocess_runner/coordinator.rb

@@ -41,7 +41,7 @@ module RSpec::MultiprocessRunner
     def exit_code
       exit_code = 0
       exit_code |= 1 if any_example_failed?
-      exit_code |= 2 if !failed_workers.empty?
+      exit_code |= 2 if failed_workers.any? || error_messages.any?
       exit_code |= 4 if work_left_to_do? || @file_coordinator.missing_files.any?
       exit_code
     end
@@ -52,10 +52,10 @@ module RSpec::MultiprocessRunner
         end_workers_in_parallel(@workers.dup, :kill_now)
       else
         @shutting_down = true
-        print "Shutting down #{pluralize(@workers.size, "worker")} …" if options.print_summary
+        print "Shutting down #{pluralize(@workers.size, "worker")} …" if options[:print_summary]
         # end_workers_in_parallel modifies @workers, so dup before sending in
         end_workers_in_parallel(@workers.dup, :shutdown_now)
-        if options.print_summary
+        if options[:print_summary]
           puts " done"
           print_summary
         end
@@ -203,25 +203,30 @@ module RSpec::MultiprocessRunner
       end
     end
 
+    def summary_file
+      File.new(options.summary_filename, 'w') if (options.summary_filename)
+    end
+
     def print_summary
       elapsed = Time.now - @start_time
       by_status_and_time = combine_example_results.each_with_object(Hash.new { |h, k| h[k] = [] }) do |result, idx|
         idx[result.status] << result
       end
 
-      outputs = [STDOUT]
-      outputs << File.new(options.summary_filename, 'w') if (options.summary_filename)
+      outputs = [$stdout, summary_file].compact
       outputs.each do |output|
         print_skipped_files_details(output)
         print_pending_example_details(output, by_status_and_time["pending"])
         print_failed_example_details(output, by_status_and_time["failed"])
         print_missing_files(output)
-        log_failed_files(by_status_and_time["failed"].map(&:filename).uniq  + @file_coordinator.missing_files.to_a) if options.log_failing_files
+        log_failed_files(output, by_status_and_time["failed"].map(&:filename).uniq  + @file_coordinator.missing_files.to_a) if options.log_failing_files
         print_failed_process_details(output)
+        print_error_messages(output)
         output.puts
         print_elapsed_time(output, elapsed)
         output.puts failed? ? "FAILURE" : "SUCCESS"
         print_example_counts(output, by_status_and_time)
+        output.close unless output == $stdout
       end
     end
 
@@ -229,6 +234,10 @@ module RSpec::MultiprocessRunner
       @file_coordinator.results.select { |r| r.run_status == "example_complete" }.sort_by { |r| r.time_finished }
     end
 
+    def error_messages
+      @file_coordinator.results.select { |r| r.run_status == "error_running" }.sort_by { |r| r.time_finished }
+    end
+
     def any_example_failed?
       @file_coordinator.results.detect { |r| r.status == "failed" }
     end
@@ -263,7 +272,7 @@ module RSpec::MultiprocessRunner
       end
     end
 
-    def log_failed_files(failed_files)
+    def log_failed_files(output, failed_files)
       return if failed_files.nil?
       output.puts
       output.puts "Writing failures to file: #{options.log_failing_files}"
@@ -286,6 +295,7 @@ module RSpec::MultiprocessRunner
       pending_count = by_status_and_time["pending"] ? by_status_and_time["pending"].size : 0
       missing_count = @file_coordinator.missing_files.size
       process_failure_count = failed_workers.size
+      error_count = error_messages.size
       skipped_count = @file_coordinator.remaining_files.size
 
       # Copied from RSpec
@@ -293,6 +303,7 @@ module RSpec::MultiprocessRunner
       summary << ", " << pluralize(failure_count, "failure")
       summary << ", #{pending_count} pending" if pending_count > 0
       summary << ", " << pluralize(process_failure_count, "failed proc") if process_failure_count > 0
+      summary << ", " << pluralize(error_count, "error") if error_count > 0
       summary << ", " << pluralize(skipped_count, "skipped file") if skipped_count > 0
       summary << ", " << pluralize(missing_count, "missing file") if missing_count > 0
       output.puts summary
@@ -307,6 +318,17 @@ module RSpec::MultiprocessRunner
       end
     end
 
+    def print_error_messages(output)
+      return if error_messages.nil?
+      output.puts
+      output.puts "Errors:"
+      error_messages.each_with_index do |error, i|
+        output.puts
+        output.puts "  #{i.next}) #{error.filename}"
+        output.print error.message
+      end
+    end
+
     def print_missing_files(output)
       return if @file_coordinator.missing_files.empty?
       output.puts

data/lib/rspec/multiprocess_runner/file_coordinator.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 require 'rspec/multiprocess_runner'
 require 'socket'
+require 'json'
 require 'set'
 
 module RSpec::MultiprocessRunner
@@ -14,7 +15,7 @@ module RSpec::MultiprocessRunner
     COMMAND_FINISHED = "finished"
     COMMAND_START = "start"
 
-    def initialize(files, options={})
+    def initialize(files, options=RSpec::MultiprocessRunner::CommandLineOptions.new)
       @spec_files = []
       @results = Set.new
       @threads = []
@@ -69,7 +70,8 @@ module RSpec::MultiprocessRunner
         else
           return nil # Malformed response, assume done, cease function
         end
-      rescue
+      rescue StandardError => e
+        puts("Got exception #{e} in get_file")
         return nil # If Error, assume done, cease function
       end
     end
@@ -122,7 +124,7 @@ module RSpec::MultiprocessRunner
         break unless raw_response
         command, results, node = JSON.parse(raw_response)
         if command == COMMAND_START
-          if results == options.start_string
+          if results == options.run_identifier
             socket.puts COMMAND_START
           else
             socket.puts COMMAND_FINISHED
@@ -143,7 +145,7 @@ module RSpec::MultiprocessRunner
 
     def start?
       begin
-        @node_socket.puts [COMMAND_START, options.start_string].to_json
+        @node_socket.puts [COMMAND_START, options.run_identifier].to_json
         response = @node_socket.gets
         response = response.chomp if response
         raise BadStartStringError if response == COMMAND_FINISHED

data/lib/rspec/multiprocess_runner/reporting_formatter.rb

@@ -59,6 +59,17 @@ module RSpec::MultiprocessRunner
       )
     end
 
+    def message(struct)
+      # this is just for reporting errors not otherwise reported
+      return unless RSpec.world.non_example_failure
+
+      message = struct.message
+      # skip these as they always come after an error is seems
+      return if message =~ /^No examples found./
+
+      worker.report_error(message)
+    end
+
     private
 
     def capture_output

data/lib/rspec/multiprocess_runner/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module MultiprocessRunner
-    VERSION = "1.3.1"
+    VERSION = "1.4.3"
   end
 end

data/lib/rspec/multiprocess_runner/worker.rb

@@ -29,6 +29,7 @@ module RSpec::MultiprocessRunner
 
     STATUS_EXAMPLE_COMPLETE = "example_complete"
     STATUS_RUN_COMPLETE = "run_complete"
+    ERROR_RUNNING = "error_running"
 
     def initialize(environment_number, options)
       @environment_number = environment_number
@@ -196,6 +197,10 @@ module RSpec::MultiprocessRunner
         end
         $stdout.puts "#{environment_number} (#{pid}): #{message_hash["description"]} (#{location})#{suffix}"
         @current_example_started_at = Time.now
+      when ERROR_RUNNING
+        example_results << Result.new(message_hash)
+        $stdout.puts "Error in file: #{message_hash["filename"]}"
+        $stdout.print message_hash["message"]
       else
         $stderr.puts "Received unsupported status #{message_hash["status"].inspect} in worker #{pid}"
       end
@@ -219,7 +224,15 @@ module RSpec::MultiprocessRunner
         description: description,
         line_number: line_number,
         details: details,
-        filename: @current_file
+        filename: @current_file,
+      )
+    end
+
+    def report_error(message)
+      send_message_to_coordinator(
+        status: ERROR_RUNNING,
+        message: message,
+        filename: @current_file,
       )
     end
 
@@ -263,9 +276,9 @@ module RSpec::MultiprocessRunner
     def act_on_message_from_coordinator(message_hash)
       return handle_closed_coordinator_socket unless message_hash # EOF
       case message_hash["command"]
-      when "quit"
+      when COMMAND_QUIT
         exit
-      when "run_file"
+      when COMMAND_RUN_FILE
         execute_spec(message_hash["filename"])
       else
         $stderr.puts "Received unsupported command #{message_hash["command"].inspect} in worker #{pid}"
@@ -281,7 +294,9 @@ module RSpec::MultiprocessRunner
       RSpec.world.example_groups.clear
 
       ReportingFormatter.worker = self
-      RSpec::Core::Runner.run(@rspec_arguments + [spec_file])
+      error_stream = StringIO.new
+      output_stream = StringIO.new
+      RSpec::Core::Runner.run(@rspec_arguments + [spec_file], error_stream, output_stream)
       send_message_to_coordinator(status: STATUS_RUN_COMPLETE, filename: spec_file)
     ensure
       @current_file = nil
@@ -322,7 +337,7 @@ module RSpec::MultiprocessRunner
 
   # @private
   class Result
-    attr_reader :run_status, :status, :description, :details, :filename, :time_finished
+    attr_reader :description, :details, :filename, :message, :run_status, :status, :time_finished
 
     def initialize(complete_message, time = Time.now)
       @hash = complete_message
@@ -331,6 +346,7 @@ module RSpec::MultiprocessRunner
       @description = complete_message["description"]
       @details = complete_message["details"]
       @filename = complete_message["filename"]
+      @message = complete_message["message"]
       @time_finished = time
     end
 

data/rspec-multiprocess_runner.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", ">= 1.10"
   spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "byebug", "<11" if RUBY_VERSION.to_f < 2.4
+  spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "stub_env"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-multiprocess_runner
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.3
 platform: ruby
 authors:
 - Rhett Sutphin
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-03 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -59,16 +59,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: stub_env
   requirement: !ruby/object:Gem::Requirement
@@ -131,7 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A runner for RSpec 3 that uses multiple processes to execute specs in parallel