rspec-multiprocess_runner 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 203c3b7bd50cc7c856265414ea8bcf734f09c8f8
-  data.tar.gz: d92e105f0f5aecff2723fc65ccc46db29bd16f4c
+  metadata.gz: 4d891049e0122f0b95c00eab92191c798e68d533
+  data.tar.gz: 7ddbae3e691ed2ab6d2121e7a362ea61a279e680
 SHA512:
-  metadata.gz: 1b678c0f53864275c7e7244d9b9c09c60524217dc9ae639062a66267574c2ae6d6c38c5f8bfc7ee9bad965e4aa6fbe4934533ba81bf66515a815e9d5a0c9fdf8
-  data.tar.gz: bf55bb27e8253464dd181f8f2289b6079d90bc292ea1f54d2bb13da4cd69750b93728f649b625b87a034134f74117834d8d06e164295f9394e78c621e6a118ba
+  metadata.gz: e8fe6572977652575bb0d8073222f65a0cd0b1c696b2ee2ce51bd9e2d6133d4c749610c094956f7f1c27e0b3942a3297858563f2c86d30d6c412f3f196f358b4
+  data.tar.gz: def29fc93cb9a4e822bf08c7f16a923d701b2b74959625db36933001abce6000e3fd8f6e3930f1d5b4dd0bf8b57e8e99a9af5dd9716abf11566b1dfc4d789ccb

data/CHANGELOG.md

@@ -1,5 +1,12 @@
+# 0.3.0
+
+* Require a filename for the `--log-failing-files` option (#9)
+* Exit status for `multirspec` is only 0 on success and is always non-zero when
+  there is any sort of failure (#8)
+
 # 0.2.3
 
+* Add `--log-failing-files` option (#7)
 
 # 0.2.2
 

data/exe/multirspec

@@ -30,9 +30,4 @@ end
 
 success = coordinator.run
 
-status = if options.log_failing_files
-  0
-else
-  success ? 0 : 1
-end
-exit(status)
+exit(success ? 0 : 1)

data/lib/rspec/multiprocess_runner/command_line_options.rb

@@ -13,7 +13,7 @@ module RSpec::MultiprocessRunner
       self.file_timeout_seconds = nil
       self.example_timeout_seconds = 15
       self.pattern = "**/*_spec.rb"
-      self.log_failing_files = false
+      self.log_failing_files = nil
       self.rspec_options = []
     end
 
@@ -88,8 +88,8 @@ module RSpec::MultiprocessRunner
           self.pattern = pattern
         end
 
-        parser.on("--log-failing-files", "Write failing spec files to multiprocess.failures") do |bool|
-          self.log_failing_files = bool
+        parser.on("--log-failing-files FILENAME", "Filename to log failing files to") do |filename|
+          self.log_failing_files = filename
         end
 
         parser.on_tail("-h", "--help", "Prints this help") do

data/lib/rspec/multiprocess_runner/coordinator.rb

@@ -175,7 +175,6 @@ module RSpec::MultiprocessRunner
       by_status_and_time = combine_example_results.each_with_object({}) do |result, idx|
         (idx[result.status] ||= []) << result
       end
-      count_examples(by_status_and_time)
 
       print_skipped_files_details
       print_pending_example_details(by_status_and_time["pending"])
@@ -196,13 +195,6 @@ module RSpec::MultiprocessRunner
       (@workers + @stopped_workers).detect { |w| w.example_results.detect { |r| r.status == "failed" } }
     end
 
-    def count_examples(example_results)
-      @metadata = {}
-      @metadata[:example_count] = example_results.map { |status, results| results.size }.inject(0) { |sum, ct| sum + ct }
-      @metadata[:failure_count] = example_results["failed"] ? example_results["failed"].size : 0
-      @metadata[:pending_count] = example_results["pending"] ? example_results["pending"].size : 0
-    end
-
     def print_skipped_files_details
       return if @spec_files.empty?
       puts
@@ -235,7 +227,6 @@ module RSpec::MultiprocessRunner
 
     def log_failed_files(failed_example_results)
       return if failed_example_results.nil?
-      return if failed_example_results.size > @metadata[:example_count] / 10.0
 
       failing_files = Hash.new { |h, k| h[k] = 0 }
       failed_example_results.each do |failure|
@@ -243,8 +234,8 @@ module RSpec::MultiprocessRunner
       end
 
       puts
-      puts "Writing failures to file: multiprocess.failures"
-      File.open("multiprocess.failures", "w+") do |io|
+      puts "Writing failures to file: #{@log_failing_files}"
+      File.open(@log_failing_files, "w+") do |io|
         failing_files.each do |(k, _)|
           io << k
           io << "\n"
@@ -258,13 +249,16 @@ module RSpec::MultiprocessRunner
     end
 
     def print_example_counts(by_status_and_time)
+      example_count = by_status_and_time.map { |status, results| results.size }.inject(0) { |sum, ct| sum + ct }
+      failure_count = by_status_and_time["failed"] ? by_status_and_time["failed"].size : 0
+      pending_count = by_status_and_time["pending"] ? by_status_and_time["pending"].size : 0
       process_failure_count = failed_workers.size
       skipped_count = @spec_files.size
 
       # Copied from RSpec
-      summary = pluralize(@metadata[:example_count], "example")
-      summary << ", " << pluralize(@metadata[:failure_count], "failure")
-      summary << ", #{@metadata[:pending_count]} pending" if @metadata[:pending_count] > 0
+      summary = pluralize(example_count, "example")
+      summary << ", " << pluralize(failure_count, "failure")
+      summary << ", #{pending_count} pending" if pending_count > 0
       summary << ", " << pluralize(process_failure_count, "failed proc") if process_failure_count > 0
       summary << ", " << pluralize(skipped_count, "skipped file") if skipped_count > 0
       puts summary

data/lib/rspec/multiprocess_runner/rake_task.rb

@@ -52,6 +52,8 @@ module RSpec::MultiprocessRunner
     # rspec binary from the loaded rspec-core gem.
     attr_accessor :multirspec_path
 
+    # Filename to which to append a list of the files containing specs that
+    # failed.
     attr_accessor :log_failing_files
 
     # Command line options to pass to the RSpec workers. Defaults to `nil`.
@@ -110,7 +112,7 @@ module RSpec::MultiprocessRunner
         cmd_parts << '--pattern' << pattern
       end
       if log_failing_files
-        cmd_parts << '--log-failing-files'
+        cmd_parts << '--log-failing-files' << log_failing_files
       end
       if files_or_directories
         cmd_parts.concat(files_or_directories)

data/lib/rspec/multiprocess_runner/version.rb

@@ -1,5 +1,5 @@
 module RSpec
   module MultiprocessRunner
-    VERSION = "0.2.3"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rspec-multiprocess_runner
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Rhett Sutphin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-01-12 00:00:00.000000000 Z
+date: 2016-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core