rspec-mergify 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 379b00755c80dfcba26213f7747fd42f2739c39f2cc450e36123e1703b9312f4
-  data.tar.gz: 979aaf645e9f2ad882dd00f900a5168be6f5c3ff041360e79698860e7be3790d
+  metadata.gz: 968b0ced5510f59941eb189080af9e540dc8cd2799757bb16f0dbe746204471e
+  data.tar.gz: 307dff0317e1abf576472b0428a1e3f0f8d7f1b1b9257c84ecfd81f0fac9152c
 SHA512:
-  metadata.gz: dc0c1dae123ed41a0ca6290ed79d4bcd82ec79989f8d8cf3e232e3e505592bd791d3387435d99721f5c42218839990e609d4d595ba4317e544e3b65255ed14c8
-  data.tar.gz: 1827d2eefe6a13d8efb9b6e10cc99da36e6e64b842cfee830cc872d687caabb72881b61cdffb496d74e6e8cf91ccfaf44f7bee866f31858fafc8998e23488016
+  metadata.gz: 23673868ac2acd11145346748cea2e5c1cae71cb6c55371ad1440a2f9bdf3436ddf0ebaaef9ae2bfd7a56e5d435b67c3f449b3161201becbd3a7b864dea8d2ad
+  data.tar.gz: 2d676dd9fc25b6383db1013e42513d5f70208a6796f4fe4fa5544493d123736871b6d7617c9590c7f8fc8fd2fa4ffb99cf1b683c9cf6df0d124c6a8a27822c05

data/lib/mergify/rspec/ci_insights.rb

@@ -145,7 +145,6 @@ module Mergify
       # rubocop:disable Metrics/MethodLength
       def load_flaky_detector
         return unless @token && @repo_name
-        return unless Utils.env_truthy?('_MERGIFY_TEST_NEW_FLAKY_DETECTION')
 
         require_relative 'flaky_detection'
         mode = @base_branch_name ? 'new' : 'unhealthy'
@@ -155,6 +154,10 @@ module Mergify
           full_repository_name: @repo_name,
           mode: mode
         )
+      rescue FlakyDetectionDisabledError
+        # The repository has not opted into flaky detection, or has no baseline
+        # yet. Both are expected; skip without surfacing an error.
+        nil
       rescue StandardError => e
         @flaky_detector_error_message = "Could not load flaky detector: #{e.message}"
       end

data/lib/mergify/rspec/flaky_detection.rb

@@ -8,6 +8,12 @@ require_relative 'utils'
 
 module Mergify
   module RSpec
+    # Signals that flaky detection must not run for this session, and that this
+    # is expected rather than a failure: the repository has not opted in (the
+    # server responds with 404) or there is no baseline of recorded tests yet.
+    # Callers skip silently instead of surfacing an error banner.
+    class FlakyDetectionDisabledError < StandardError; end
+
     # Manages intelligent test rerunning with budget constraints for flaky detection.
     # rubocop:disable Metrics/ClassLength
     class FlakyDetector
@@ -193,7 +199,7 @@ module Mergify
 
       private
 
-      # rubocop:disable Metrics/AbcSize
+      # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
       def fetch_context
         owner, repo = Utils.split_full_repo_name(@full_repository_name)
         uri = URI("#{@url}/v1/ci/#{owner}/repositories/#{repo}/flaky-detection-context")
@@ -207,9 +213,18 @@ module Mergify
         request['Authorization'] = "Bearer #{@token}"
 
         response = http.request(request)
-        parse_context(response.body)
+        case response.code.to_i
+        when 200
+          parse_context(response.body)
+        when 404
+          # A 404 means the repository has not opted into flaky detection; this
+          # is the expected default, not an error.
+          raise FlakyDetectionDisabledError
+        else
+          raise "Mergify API returned HTTP #{response.code}"
+        end
       end
-      # rubocop:enable Metrics/AbcSize
+      # rubocop:enable Metrics/AbcSize,Metrics/MethodLength
 
       # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
       def parse_context(body)
@@ -231,7 +246,9 @@ module Mergify
       def validate!
         return unless @mode == 'new' && @context[:existing_test_names].empty?
 
-        raise 'Cannot use "new" mode without existing test names in the context'
+        # Without a baseline, `new` mode would treat every test as new and rerun
+        # the whole suite. Skip instead of surfacing an error.
+        raise FlakyDetectionDisabledError
       end
 
       def remaining_budget

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rspec-mergify
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Mergify